From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7809DA0547; Wed, 12 Oct 2022 10:08:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C50F42ED2; Wed, 12 Oct 2022 10:08:15 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id B715A42ECF for ; Wed, 12 Oct 2022 10:08:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665562093; x=1697098093; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1QvQaWRzyMxq2tHamc/bUVux/5pOwWdEB6TCA4/Kgzs=; b=fVZwQtwOrVPXAqq5WMYL8bxEwowvJsqJd1hFXtqfP+vZFGE5N2NLDDEh U6K83UyDH5qVW55ljHZ8vtwu9UlNAYmDgQdbQc6rohHPhNGe+qk5qelbf vDJvtHxsBTZ+zKFZ7YUNGVBhWs9qYt3ep6Gxec6BGUHX8SurWmsSdoSWK RoWPFHbbqOtpH4HzD5gbyZeCyCvMM5W2mKbpSL3x2dSP9IRn3NVZhVTnv 2FAhxqBp7Xud5ax1uvM3dLch39h6VtMuAwADUKDEeUNEu04xNasMhg2jZ CdwtMivEeFs/TDuLu4U7PTngceFULEcEGeWR34BHXm/yrC4n3NujJtoMu w==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="368899498" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="368899498" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 01:08:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="769120749" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="769120749" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 12 Oct 2022 01:08:12 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 01:08:11 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 01:08:11 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 01:08:11 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 01:08:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDIR3zlFbbzeu0oCVe/cmZm6RH9ugGZ+yla56wqhKuV0gWPT6B+lOSsMiUdJuHRvNH9AdjAAHgq60lPntIm656QikHtg1C/sScx1/MQIs5I8UpQOB8lEBpc5MQ/7rT7+vPohRjF46rxLcz/rBh1IPXyJ1qydcUfS/hvGk7Zvkj2atub1mgKGMsvnue/pMCHKPR1Nm2xmBlw8DktRYiz5TIKVSEidCtnJO+YreO5U5dE1YZM+NsTiLsBnhf5DaAxnnJ2HolSo2Gy3dvvYFo4bKdPtRU2uB0dhijDnElBUm/ahgtP4M8JUJ+f/FuZ9xmtpm3ziPXshXkhh21zk3CY7Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XNKN+UqcjEq9BiQ5KMBus4Rg10Tw1p0qoZjamb9VmH8=; b=jCWx71Ew/7csyLXg+co19MtnWwZ52BLgSLxB/YEyJHuQI7rm1eSMke3ToGQyAUCaYqVJgOBsSrrxb/tALYulx3ZWuiqPTiXIT5AMH1CkHBlU6JcEiurDI7RGrr5pS4Kfk5E34O17CvdMJPlC6jG5aSeUzq1GMQO1JbpSA7KLEyY3UPh/Hf+HTkg0XWbTY4u6j+mmu61ss8IPVYqSfN5hjINkwbZ44UEbGOluenKvYT2LWPTTR6yMqcTwNTidwY9xyKziGL8O5DFu6VK69fEpY81/b9dXNH3UO0xv7Ujlm3StK0QzXphOgW0sfKMMpHbvR2wRocMEXl2T5p6RQc8wVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by MW4PR11MB6840.namprd11.prod.outlook.com (2603:10b6:303:222::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 08:08:09 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5709.022; Wed, 12 Oct 2022 08:08:09 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 4/8] vdpa/ifc: write queue count to MQ register Thread-Topic: [PATCH v3 4/8] vdpa/ifc: write queue count to MQ register Thread-Index: AQHYyZPrij2rvX6S0kiwNzU07SIWkq4KbzeQ Date: Wed, 12 Oct 2022 08:08:09 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-5-git-send-email-andy.pei@intel.com> In-Reply-To: <1663308990-621-5-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|MW4PR11MB6840:EE_ x-ms-office365-filtering-correlation-id: af3d2b04-a235-427f-3d95-08daac28e696 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DAheZUgE+/xWUCdIrNF5BCWsW941BcfbXPZ+SV9v31ZsoaUwNW3smIqo3Bi75TSFXFRvfH3vHREykZsqpOmAAeeFqaYLbJDt0YSZjQNn+dgHl3Q3n7vtZUUDzOImlFtTx1pqCRyQ+xo4mGEKTC/EXHy+c/Itan/eXkSGw9qJS9z4nDSRIw5rZ4jrm1aOeVL/4ErPCHKAeDuFcOqajkpsfB3asvGGG6OemLlry5I9gm5KwzkcHESgXIZVPQFKJRvM34BBwCKu8cbZAaGCU5BJDVwsBMzlc6pIVROj4D0bYrWeOmTqPC2vqFbWxqLKfyPkr2NFtSfMGSVG+cFmbfq9pFxjzz671keh7dzhw8SoYLvt2Au/8cQS/0aWml+CKjKXjRJpbu6Y9HeIWWhzh+ypmc+H+6V5oyxBnwEBP3Sz99Rw1jkETiYALD9y0kL2tuJzUtJlMC470qt3dmV3tWIciKwXHDyakRud7dUqIbJyfqshrtZ1YLcxh2a4L1+JlZFNTifFuajtSBsdIEH9fqa6RFWXeZhuK+0yPchYLOV93wqkxCk7V9djmd1wL+av7mXT4yE6I4eg9IkVWPBYOljdj+/hqwcCmEOyAElD1+Nb/PM/vNHsXH9ka5VylmXciHfWthFNEzh+5RF1mqfh8ugReX3IeIMbw8bpnGd5bPdlC+OS2EdAp3NHOILpn5sVfmXoRFxaE3PX/4gLGrJJsz2xe/MqtYVblKeYWY/ZjqoPpZo+qnBHpylSdZtjys1cVR1X5vWpndUleTZzU1Z8gI9YHg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199015)(2906002)(38070700005)(26005)(9686003)(8936002)(54906003)(478600001)(110136005)(71200400001)(186003)(55016003)(7696005)(64756008)(66556008)(66476007)(86362001)(316002)(76116006)(53546011)(52536014)(33656002)(66946007)(4326008)(5660300002)(66446008)(8676002)(41300700001)(6506007)(82960400001)(83380400001)(122000001)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zpbdP5vcLfPgto7jy7jARF2emzPwQccantV1VZ87xHiW4izN1sg+sd4MKGCG?= =?us-ascii?Q?fpKNUIhfoclWlIcWj+UTsYiZgDW/CWsw2o4+lz+BYj57SctSijPcq5s4xIMc?= =?us-ascii?Q?O6byED1BHuTVdfk1rXsphANTqfPxoqz4XRhMCYskJVQamlyby6oKwxS2GBsv?= =?us-ascii?Q?b8WcTfEWAC4V0otvpfLzOEIWej4zVeDepSJzfE5hJFD6oWEcC/Zr3Bc6mbuB?= =?us-ascii?Q?/4y2VsnWnkZpKIZlVD0P3weSNTDiZHcw/5DV98I7awVX6VTbjnGMude3qQPH?= =?us-ascii?Q?vhYMaDpGHiIYcbvc4K6AfCJxg/62EImvcJw2MbRmmv9TT2TXWWvVOv50MNOr?= =?us-ascii?Q?rTCZD8n4J7O5pbBwbvPqWlOMYIzoNKf2ydmy+2X46/RG0vHZy5hiLbVN5kA7?= =?us-ascii?Q?M8Vla8FXfkkmCfz+F0N69rzM+DXy6IvnwO5vKeNTWkWLog4tPGzoL53niWKu?= =?us-ascii?Q?v83zv8W65Z/GX40GjSGL4AfhiboGTVsnuaynuoawp9oSiidxp85j1gD0J4Ap?= =?us-ascii?Q?L3Hl+vHOu4qP094+FhNmAyIZNkE4vA4jYEcL0t219RpqlXHWIk7x6ERyfqwG?= =?us-ascii?Q?sEZvHk+u2Ut5XDfIvV/fggEHuq7PbDXhqTTrYoGB44NiOAD1fx01XepZhog7?= =?us-ascii?Q?P6v8RFR+c10kUB+6Y/xCog/tS3AzgmOedytUKVzXiu5t93sXmxULnAVzFmel?= =?us-ascii?Q?6j2Eq4iT4VDmBlSPpt6M5r7id98u4a2XqSi35S7fmQUgPkXnRoKJfWx0BKah?= =?us-ascii?Q?NxOnaDC7MY7Y9oiA1yFJ/Tmc5PE3PfTL8D+ntG/JQrPJOAxaYoQRDWsUDDwH?= =?us-ascii?Q?sAliHFVKQco4PoU2y4oWspAYLsxM7YT+ukjI6m+J9lUvzehPkhBPp6KYXp1g?= =?us-ascii?Q?0hDFYnzxVbaMfFXWWjiXURx3e1FVFxGVdQb2iWRZwa3s6WTuendKqXsiL8J7?= =?us-ascii?Q?myj+DIEGneYb24QqV1E2WN2FDYTIVRQsV1WPGx4xVYzddbTuySUu6OXYYyhW?= =?us-ascii?Q?Q+owXuZvij8dYCQvY4lsM712dqRkkz118tPyhEBz/oQCiGJxfuDFj/UJwuiG?= =?us-ascii?Q?i5V1+QvZslnVhRFuLrhXeVqqIKT93Lbx0DiD15pEgmUR+2FiC8JNrzOOujmI?= =?us-ascii?Q?GxGZ0chYc6QuGQTjgfLzbQep81DkBWm3+WPFcOXRF8YjZCCICixJezdjGvRp?= =?us-ascii?Q?tYeIzBgwjCevwbGfyUDzFsHkvvqDSvbOWuS6QSJSpJhukewCuJ1g56w1Oz8u?= =?us-ascii?Q?m6ksND+JPJwky5CN9FJPL+wBrK0+FcKiW8DoksK4fjbkIfmq08B/OACuxThE?= =?us-ascii?Q?oPCd79FaqR4MqKVUYUWxhRNqf7gGFrCMRDrUyN1XWxcmeWFeBeAnzF1syOjE?= =?us-ascii?Q?iAegvq61RcRGCICJFzpLdjg4kmecQ6t1MTwLi5XFHv57aEJySPiYHJSAemQm?= =?us-ascii?Q?Y4g2uP/4oOnqvz0UoRaxaAyJ45Y666LHi0kmc8W8z03uSsleaRHi8BB/y8hI?= =?us-ascii?Q?q1fP2Iaaam6qW7qYLI2zOqg4EhQYLwjpRTuaQluoAOK3vGg+Yt146QWFyMHd?= =?us-ascii?Q?HNX69Saymju4hlVj1Kr+g8boUVmRKbvOaQYh2UTU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af3d2b04-a235-427f-3d95-08daac28e696 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 08:08:09.3309 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IhBRj29ejUKb3cnW+I6kJxDd3lZbbxFBVxBVTjbB71D6JJLKF8YpzG+ykMgv2MWJzokM2IAwJIxBDAqh8LPdKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6840 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:16 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v3 4/8] vdpa/ifc: write queue count to MQ register >=20 > Write queue count to IFCVF_MQ_OFFSET register > to enable multi queue feature. Multi-queue >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > drivers/vdpa/ifc/base/ifcvf.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.= c > index 34c8226..7efb408 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -198,6 +198,35 @@ > IFCVF_WRITE_REG32(val >> 32, hi); > } >=20 > +STATIC void > +ifcvf_enable_multiqueue(struct ifcvf_hw *hw) Maybe ifcvf_enable_mq? > +{ > + u8 *mq_cfg; > + int qid; Qid should be the same type as nr_vring, so u8 > + int nr_queue_pair =3D 0; > + > + for (qid =3D 0; qid < hw->nr_vring; qid++) { > + if (!hw->vring[qid].enable) > + continue; > + nr_queue_pair++; > + } > + > + if (nr_queue_pair =3D=3D 0) { > + WARNINGOUT("no enabled vring\n"); > + return; > + } > + > + if (hw->device_type =3D=3D IFCVF_NET) > + nr_queue_pair =3D (nr_queue_pair + 1) / 2; Why +1? > + > + mq_cfg =3D hw->mq_cfg; > + if (mq_cfg) { > + *(u32 *)mq_cfg =3D nr_queue_pair; > + RTE_LOG(INFO, PMD, "%d queue pairs are enabled\n", > + nr_queue_pair); > + } As blk does not have queue pair, the log should be different for net/blk. The variable nr_queue_pair should be nr_queue as it's the number of queues. When device type is net, you can make *(u32 *)mq_cfg equal to nr_queue / 2 Thanks, Chenbo > +} > + > STATIC int > ifcvf_hw_enable(struct ifcvf_hw *hw) > { > @@ -215,6 +244,7 @@ > return -1; > } >=20 > + ifcvf_enable_multiqueue(hw); > for (i =3D 0; i < hw->nr_vring; i++) { > IFCVF_WRITE_REG16(i, &cfg->queue_select); > io_write64_twopart(hw->vring[i].desc, &cfg->queue_desc_lo, > -- > 1.8.3.1