From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F30AA0548; Wed, 12 Oct 2022 05:01:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27A4440691; Wed, 12 Oct 2022 05:01:50 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 3D5334067C for ; Wed, 12 Oct 2022 05:01:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665543708; x=1697079708; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=s5iQc4ETvESStw5W/tjljizHOx+T3crNRjjxhk74T7U=; b=l1hWjC3+5AvIUaryam9KzyNY+I0QxVM9xISgsaaIMw2qzGF/fkf87wk0 tZhxVJ/l/JAQ6uG4tueuSawOeLUXqfD0RJj9Y9DcxR72Qfu1w5VAHgb49 e/rwvSPSdNB6tcJeIh35pzZELy1ffSwF9oTqCz42dEW9YLbDBrD/bywfd I+8m0NpktCTOlxpfS+XtyOIBFJyIZ82Y2INV/lSUNVoFc/ULHcejzgisi 1jO56HYlTBbydKb9Onp36Ra3kXukfVK+NH5wARBjsbAc5GDFoi4WLfgPk jpSr0kIFVxmPLJqRZ5Xevlbh2fTan8NU63LYceYfw4qdgEnw78wM6y+qs g==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="390989040" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="390989040" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 20:01:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="955584253" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="955584253" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 11 Oct 2022 20:01:47 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 20:01:46 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 20:01:46 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 20:01:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OB/ecMjz9hNzNek4dr5DlMbMJIybNW5R6z3CwQYIUFxcTe2//qjmn5ZQ1ejSvKDIbM7zKjNjbI+JCzy+/Bo6tzwt0yOt9+vesdAANWcwIJSKwUP2Z3nnSQJ2NucreDSeQnS/q03rW6e/nskqEcsO/nxPQxIilg6UCTjWgIie0iTjPebZ0nj87OtOL2MwFU5pt9Hc3HSGK7upwQpP/amND6IF2y1Khv6YPzxDrnpBgHfYeMuScLlmI5BoJFpuAX+5tQ34upJgsaHdrZtCscXm3ggcw3BqFNIBJ+pzVLVvSPY2TOWqLeo/xsUVX74Ba0s59lByLPgkfrTpwd7rq4tj4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c33E8auAaRwZikXRCdL/BNxcToUAGvzc4+xGdnnHMlo=; b=WEPV5QrsepCWOuYsHaN1WprVRdJ5/7oQwhrmk6TS1ltFRDbbwPAHweIfBgrhdM3Dk8OSeE/ms5Y1knXZg+bCWapwV63+ex1vI+a9JNtMghY8yFGcvwXgz2PlqfddXPZLlUvlHFXvp5/c4lY2+RIvTJLlzRhRaT/Knk1sq1+nqSpsUp3JvSSjP3A/uoSXQtTHSdXdQi+/EocCIQdfMUgtMC/c2v+uDbYlf9BjqJi/2qOW1/CubfT/056QX+4fZP7yo5utVKrwRz6LNlgKSiwlX175ZVmENfcCJRU+fy9WBO2Wtc36hM4+o/u1zgbJDFkbYk4kdpE6v+aZC/3epkgeBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SA2PR11MB5161.namprd11.prod.outlook.com (2603:10b6:806:fa::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 03:01:40 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022 03:01:40 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 2/8] vdpa/ifc: add multi-queue support Thread-Topic: [PATCH v3 2/8] vdpa/ifc: add multi-queue support Thread-Index: AQHYyZPjhD/OuJdngE+p46Dob/WD3q4KOoTg Date: Wed, 12 Oct 2022 03:01:39 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-3-git-send-email-andy.pei@intel.com> In-Reply-To: <1663308990-621-3-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|SA2PR11MB5161:EE_ x-ms-office365-filtering-correlation-id: 24a44fe1-bc53-429c-e239-08daabfe15a8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LWZPBzTiEcPxZH3+mffPhBeZIvMa7S+o7dQR6bcGLBLEsysLnEGaInPbpYr921vWu96J6Af5CTZ5cZRLDxP2c6WNdMifS2o/LX/fLSYzqAKUHrBQeoQG5W+i0pduMDjmMqOUg9KUEwxnNKW6ndogUDRyqidWYBZkUW+OrSbS3/xjrmbXsYXhuAr/S0tWWDD3kRqfp2i/NTcqXF+jPzjjONcMJ6Ix145ZayF1SIynJCIBLVXqNObqWH4r8rH7freUTZT1nFKLoVOQSbYPfUNjyVSc0XtDwh+ymhx1x52zbbO6BUkAgexiKuELWTDtynoo9o4YHvVfNMi2QCyOvgj5wnJ9A3Y8hPxCoWprHnkZciGhAtkGs8/XlypRr9f4VEjyrH3RD16TElKRV480fyH+UIYFZ06fMQPL0wLXBYGfljBQxUhAYTRVIS3HGUDd/1fgblHamMBWhh3o46t3xwRSXpMJR6PbVyHMZ+pxxzPy0oIkUXlRot41x+xHOjVutRhtER834oWfWydFDjfgwMgecNKbWzFvpFClIK/T8mb+QgjbswtYNQ8QbcqvcrAFZuUeDYgc+gi0vPEelCbxcsg7eoPULHPw1PLMBAQX+Ca1FpZXgvUTC8FjIPltQFujpVG3hAqjTjpZmc/pREkj+yP/rzb62RVFOF/KhzrgIOpQoKeXwL2NNOXf7G0x/BVSAb7pcNfqfXYJxMA7VeRXJzwBwSGy3Gi6ZJoTOu0uo5vb1n4dRH6wgVjc1Np2/UI2frbJnNGVqz92njr62B2H7clxzA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(376002)(346002)(396003)(366004)(39860400002)(451199015)(38100700002)(82960400001)(38070700005)(53546011)(33656002)(86362001)(55016003)(7696005)(41300700001)(6506007)(4326008)(8676002)(26005)(8936002)(52536014)(9686003)(66446008)(64756008)(478600001)(54906003)(110136005)(71200400001)(66476007)(66556008)(66946007)(76116006)(316002)(122000001)(5660300002)(186003)(2906002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UsMoY0FUgGNEv7q5j8K3JTJFLOGxlDwooINDT1W2hYUShpdF18WLGUEeIqDu?= =?us-ascii?Q?kRl0cGRkkefDkmIq7mTe562nMkA4mlERymDoFQqovYhhznuQs9P3fhS7FAR8?= =?us-ascii?Q?yQ80gM0OMhM0im02OFmm0/EguhgxP/kFJ88UzJPehapwHtA462QBGBg2M7y3?= =?us-ascii?Q?nYETzkicQV8Phr+m+/NJIxn50zR49tUspYoYhRR/jgy28JYvuqW+XRw0unD1?= =?us-ascii?Q?VKeOnUf+TrGgkj04itH7SVYJg0RSCcCJ5OiSuga3M5QdjvzccC66xfyQMngJ?= =?us-ascii?Q?wbSNkAW7h5N+l1B+6iYlYWjGeLOme7WVGf+QA7F1D6YdIyNvd/Cmk30EAXdH?= =?us-ascii?Q?G/cOFD+tiJBn23/SyyEyR7zuKr6sh8VmyvsOZizWudv6tgAgQy9T+py8sB7E?= =?us-ascii?Q?ZZm4nqPiOR06DB6+ny18pkOPAP9V0LYF6y9iZX81HRAe5r6yL3/+JWjQpJvR?= =?us-ascii?Q?YLjzrWLEmR5NDaZDV5ixkJjOObSrriPVth6lsfYvRZF4LIIJgj3oBOPZXaGo?= =?us-ascii?Q?SljrHJ2mJuP/XEjAHVFHKZk6gKL0ymsr2TkaDJeWkGqMTmq9JLAQfCQbFJkV?= =?us-ascii?Q?mt/JLubnOM7yj2DJABp+9LAalU0zrRKyhIr9eWHaoLKZSH6vUhFoVb/+zEgz?= =?us-ascii?Q?oNVSUr9l9pl9dNu9FeU2YYMlULhv6W6aknfiQwzCUXGY1sIa/NnwUcB48Rjo?= =?us-ascii?Q?70up0ITe85HGAZO/Hx1ACsDftac+K6fpk5gZYzsoJNMBvpAx5OFT+9gbxWk3?= =?us-ascii?Q?+ZNL7zf8Qo/Bk/0fQhS4uRi+cz4tihgSJ9HJHPmr4OFNHreI8vF5U+v0hxY4?= =?us-ascii?Q?c5AY0dMXa4AY5KyPB9aRSlknvZ7gZufGaQfZH64/W80qPlwHAx6B1AWdIDlK?= =?us-ascii?Q?eAtCgqsQSg5fmeTojWkD2dudei6tvxTRK900zvZaeriKQmv/yXb1GrdHu2f3?= =?us-ascii?Q?X9FlNCOxRj16BO6JfvWLJNJQlitzhQt4g4lBviCBEPuU37mjxSr7SzNTrNt4?= =?us-ascii?Q?D2f8SYU6rdGQW3Qx50i0Z7dwDrWpWoSYUou0XDpv0KQ6l9i72CXSaj6gojhg?= =?us-ascii?Q?X5qssmKsIgjj++BeEN9j439bkt3xo6SsPtIf2+Q02X6891cMwjyB5tIQRigW?= =?us-ascii?Q?ws3e4WqJiZO9CSqR28zx/i7Rn7VVPqM1MeZ714SZDm+O2uoVHz5n44zpszXj?= =?us-ascii?Q?5MGfofZGJvGBA2Q3I7+V9c1oZJu5Juvvn5EUC1/P+Xqd4kJpqJNdTS9sa8SI?= =?us-ascii?Q?9DahoCevgnZDKBFayplOCvNpaG6U4Aswnlw/niVUU/bIsXokcoZ0nrv+izyh?= =?us-ascii?Q?tO/W3yKH1YjuZh2fAI9pYLWP6WMk1WJ8984FXsFRbFNZNUFYaNBPjh8oeWVF?= =?us-ascii?Q?AbYNOaarpiW5Fi2sbEGoSZWHVxW4Cq1HIP1NZeANAWyE0zRlX/tZr/DzMZvp?= =?us-ascii?Q?VGutg6yWvUJTZbfl+CwKQ0xE3Q7vXA8Nab6G+sbRM4Y3zejAum7bMEjzRaXy?= =?us-ascii?Q?yDo0VdzxULS44bVX0lrsZyu+J+Jh9Oe+RXU2TIz/rKykUcz0Rng7h9Rko/ek?= =?us-ascii?Q?m6erSAsvg+gh9/RCxWBJbysscq7aLhXK2YZFV7V+?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24a44fe1-bc53-429c-e239-08daabfe15a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 03:01:39.9622 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GrS+2h/lpeMAh3NdNiUEN0/EICGBh/441MpDWSLr2QD33pnB/pQErlYYRws91rmEqd1fwavNCuak1lvnMIX+lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5161 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:16 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v3 2/8] vdpa/ifc: add multi-queue support >=20 > Enable VHOST_USER_PROTOCOL_F_MQ feature. > Expose IFCVF_MQ_OFFSET register to enable multi queue. Multi-queue >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > drivers/vdpa/ifc/base/ifcvf.c | 5 +++++ > drivers/vdpa/ifc/base/ifcvf.h | 2 ++ > drivers/vdpa/ifc/ifcvf_vdpa.c | 1 + > 3 files changed, 8 insertions(+) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.= c > index f1e1474..34c8226 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -90,6 +90,11 @@ > if (!hw->lm_cfg) > WARNINGOUT("HW support live migration not support!\n"); >=20 > + if (hw->mem_resource[4].addr) > + hw->mq_cfg =3D hw->mem_resource[4].addr + IFCVF_MQ_OFFSET; > + else > + hw->mq_cfg =3D NULL; > + It will be better to add comments about the explanation that you sent befor= e. Thanks, Chenbo > if (hw->common_cfg =3D=3D NULL || hw->notify_base =3D=3D NULL || > hw->isr =3D=3D NULL || hw->dev_cfg =3D=3D NULL) { > DEBUGOUT("capability incomplete\n"); > diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.= h > index ef7697a..d16d9ab 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.h > +++ b/drivers/vdpa/ifc/base/ifcvf.h > @@ -50,6 +50,7 @@ >=20 > #define IFCVF_LM_CFG_SIZE 0x40 > #define IFCVF_LM_RING_STATE_OFFSET 0x20 > +#define IFCVF_MQ_OFFSET 0x28 >=20 > #define IFCVF_LM_LOGGING_CTRL 0x0 >=20 > @@ -149,6 +150,7 @@ struct ifcvf_hw { > u16 *notify_base; > u16 *notify_addr[IFCVF_MAX_QUEUES * 2]; > u8 *lm_cfg; > + u8 *mq_cfg; > struct vring_info vring[IFCVF_MAX_QUEUES * 2]; > u8 nr_vring; > int device_type; > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index 07cc63d..3e5ffba 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1248,6 +1248,7 @@ struct rte_vdpa_dev_info { > 1ULL << VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD | \ > 1ULL << VHOST_USER_PROTOCOL_F_HOST_NOTIFIER | \ > 1ULL << VHOST_USER_PROTOCOL_F_LOG_SHMFD | \ > + 1ULL << VHOST_USER_PROTOCOL_F_MQ | \ > 1ULL << VHOST_USER_PROTOCOL_F_STATUS) >=20 > #define VDPA_BLK_PROTOCOL_FEATURES \ > -- > 1.8.3.1