From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD693A0A03; Thu, 20 Oct 2022 05:21:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E08642C28; Thu, 20 Oct 2022 05:21:37 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 6475A40694 for ; Thu, 20 Oct 2022 05:21:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666236096; x=1697772096; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3JE94VJNDl2PCjMeSdTm94mIRLEuPtRCsLgYnLKfSDA=; b=cCPxrXwnB+F77Xon8XxdnU4uIu7Eyj9td369dGwETTGHDRQJ8tf1IcfI xmNSXpwiFF7+bayXH9MAk2IbN5/yiRJwbVTUXHXXlwjj6h8RI2yYq2n0y X4oPzVMXwVoCbMeXsTXiDteTC7kXY5WZFM6FvLiFis6rvIeXRkyQ0ZN0d VFOZD+C/3Rkvi7D6qiQkgHtayKd6dYahLfP8RPB/RMrAb1dbTdTzEM/H9 2AjdLhFmIgurAYtCeAtha6I/zvwGgwQ9+XP/uby0go0N0cmIjSorw8SAg fZnLQKKTuk/hUZA9g3uXmqOMIrNTEvlkZhFB3TTCbHDuzXdPPrBPDkEqb w==; X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="370803761" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="370803761" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 20:21:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="662784753" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="662784753" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 19 Oct 2022 20:21:35 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 20:21:35 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 20:21:34 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 20:21:34 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 20:21:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iQHZOWhIm9E2Q8p5mbLRAa586G+bOgMjb+Xmce05AyEivxEXAiREnTQt7FItLz6VuMcVsHPJbd1HEkHvFfHrqvFPArKovR7tpyD44IdncLgh1DG+cq/qSG6mwNRlu9bkRnwYTEwRhpF4/0/HJHao3lC8lMiyf0B+usLcRyg9449k0qTApappMaxUS3+RerVB3gtWlCU5lTB0jbV7u60ngYqoyCNo0DZVBpDiN9Y1aiYweSxyYbJmsHWfrzAC60259yKxCvaPQWQ1nlzx5cKcvzdQ1vi3r3G8IN3wOoiibo4waWzOz9PhHfwALWS/nYiPM4xqejkFH9fvCd1Gb4GHPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kQJ0ctk3PIp7GuQhVnqP0ViDeVSb4r099VbmzgdM8zs=; b=kMJhmURT4FvyRbj3702QuScUDBcEhuAWeZL//ZbJOIKMCgcg0tJJRaaVzKYIKqWkwS9SzrAOMwu62+ZKjHZeRbn2yb1WTw0b53XMqQTWfS0oFymyDinXpsESfSJVpIDIeY+jjbiKaDsb1ikblHyUoRTCl8gK1bKNrM9wSyOQ+17rfpdOG5QzkoUctJZWJEYE/GPTGzkDBs4TeUMwtOeMwsHpOD4Lwcwvomx9yx++g4LCGB2Cwp2gfeoAfyp6KPgol7LxrFY/H4eydyj0eBR/bYR/QwdwuuZK2vvRcU+fg2V/Qz+AHyyammUQ0qRb7GI6pbGXk90YaCrRCswsz9fHNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH7PR11MB7122.namprd11.prod.outlook.com (2603:10b6:510:20d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Thu, 20 Oct 2022 03:21:33 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022 03:21:32 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v9 09/12] vdpa/ifc: improve internal list logic Thread-Topic: [PATCH v9 09/12] vdpa/ifc: improve internal list logic Thread-Index: AQHY453qreqt9cgOrkq/zH7bdDE4Kq4WnsvQ Date: Thu, 20 Oct 2022 03:21:32 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666168884-104665-1-git-send-email-andy.pei@intel.com> <1666168884-104665-10-git-send-email-andy.pei@intel.com> In-Reply-To: <1666168884-104665-10-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH7PR11MB7122:EE_ x-ms-office365-filtering-correlation-id: 314d9bae-4ce4-4e92-6ba3-08dab24a3000 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MPMh9GTBVfWA9JOx4yXI4mW5Q5b29tOGe3akzg97mzuiFF4/2++z2DT3tZRxnc7oZfJX+snmGdJRJzb0zzvP4l66ZfpUPiqPnwzlP2GooWvQ9ksxeCk1TGmcuPp6zn58viuiUdDsxYFflDbXor8sEfrYnpGvodlRIgM0GkX16vd93jO600xerJNAKofYcYmH6/h355F3EXjgGRrEhsJ2h4pRtxF/0SWqLIW15bv5tTZSguUpnSpmY/O8x10PjgM0jcB+t/neKFZ0775oBy6GCc2PVT8CK0h/QhlCA7eOdnw57CVn+fzdE6sV80vPV6EjNN84XVj+fD4mGOcz1TM/MkhpcQOVEGnWbROcq+1sftiNJGj9wMx3/mwmfcvasOSScFWlDw8t8oVMVPImxhc1wHMkqWZAZpdS7Yt4sXozXbyheRldjh22NdLRmxUpNKxLLCwpm35p1H5OoMa34S3tUd/4YP5si9URoWrsg54hkAK9BYFn+N66qM8sl6gTBk/l03rl0LESp41bx9GNpx7BZVhZSqHl5Utum307roY4Gs8AAuAYFLOY4XBuqSsiJ+oe+T0/LCU9ZQzGT8colyP3NG/ZrapvuNlNJXhTJe/GbrLWfOu9fZHLNQmWVdck2PjOhW0QvKaH2heSkSJOkM88hrmhrMILVAA876N+DGsrhE6EUzyyt/eavALcct2ZbD550gY9AuM7aX0KYIP6trpcIsVgLGD05mtbQWdNMYNAgav2UMKq6TVg5zLJvto4l4RtloAyKPbonch1IfWuFA0FLA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199015)(33656002)(82960400001)(2906002)(38100700002)(122000001)(71200400001)(86362001)(186003)(83380400001)(38070700005)(26005)(5660300002)(4326008)(316002)(7696005)(110136005)(6506007)(53546011)(66476007)(478600001)(9686003)(66446008)(66946007)(54906003)(66556008)(76116006)(8936002)(55016003)(52536014)(41300700001)(64756008)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sN+SYWT4FAMythoSOpb1olqpwfFQAH6eaZSzBv+Hp16eH2qPZcAKRqCKUSHt?= =?us-ascii?Q?IrXkrP267swvc8I4wtUqrNIo5UQGGXzwWXIj+/4X4URTTB2dqTGO1rMQMQJo?= =?us-ascii?Q?QG6yuQn3sql3P5ZuhM+DxgwZr78jBmp6opBNSaQcIcEDZB7iZ7lM48TCGtNl?= =?us-ascii?Q?aveQjApZ05To3S/oC6ceo0XyXYCkfnk4IgOI7RWp60R0Riv18fPAsyvRHeTg?= =?us-ascii?Q?ARnEbphGF00ECRR5Cqby/ymp4rBOspEPMzOXlKaCIbWMjIaqUYF5eKomjqkG?= =?us-ascii?Q?doFtdO0OZdNDMAOmBhZKn8Jsy2lVPLkvBsqJiD5KMgJsbuk4B7loPU+5TMAg?= =?us-ascii?Q?A0KaQ5TpUnsxDnAxue2M1aX/E6iJgUUuZbCXM4P16wC2YvHiqXxa6TIGNpkP?= =?us-ascii?Q?yKUgcsfCJoiNzWakMXzP4JFLty7sfwg+0/U77XubZcLt4dNy3eMp0KGP38B1?= =?us-ascii?Q?e4OfpZJ6FgykQmpRyLCFxnDSXlPeTGihrWu++yAgifH8kmNttV1lT08//bHB?= =?us-ascii?Q?wV4pnsoNV7ZrGLPkF9qklK8kn5dUedX4w6P1/FA3SqdcNegbMqyDTKxTKsRy?= =?us-ascii?Q?NJRj515CbJ7BbipA624mW1VziE0tR7cDYh//+XTVVQPGRTvIhVzYOZsQqqKH?= =?us-ascii?Q?xjvolzIqjoACqP5O3Rb17EQVdon3F/znWmp9ApDigkER01h1sIpw+NwOePxt?= =?us-ascii?Q?NIZBh1UKEFkGrKVip7zk0evzmkZTTzZGYIoDtoJVsFFdKReFwUXTE2jQ6DJh?= =?us-ascii?Q?5q6rRCQubRih987U+YMovC84sSRUxdxifwp1vwfhZhnFxJiZVUR6elXWuncp?= =?us-ascii?Q?N+2o3wuY92hWR6SCextN1Tmm/l6ujlTFupDfnWEU6rVGOND7gS34NlLkXz3/?= =?us-ascii?Q?xN1ytDh2skV/6jHh8EHf1NW47uSTmOmdjjqfNcq9k5VFmRrsVclhf1tF3sJb?= =?us-ascii?Q?ej6lmO4qJv4f548A6cZLiuWqEmMwjYdej3eYSCaqV8H7IwaKZfiBbibaWOf1?= =?us-ascii?Q?t5QKOTeaJCkl+wMmhVhO41voGwYZcm6KHZDoEIE1cZgTUXRv/2zeVeUEuKK8?= =?us-ascii?Q?sP88so4jWofAX60w8TTymvm0mMDbdbcMeCwEVWmS2sMgzL0SN94VE/F/qUoD?= =?us-ascii?Q?fxcG6nafl0Srfb8C4U/ZITyTWKpyWu0lHRSEuOPJVSNVsFFI+T9CPsdq3EXs?= =?us-ascii?Q?siylhxbNKzSPuCRuMZcZttUle+llEqwOZdtqkzniaYAs/iRjs5hZpwu9jFAZ?= =?us-ascii?Q?vugLCkSPYoN5pvPpdMvXRVgpQXwMW3Bg+h21jlxHpsmUMmXWdetBnkXs5H+g?= =?us-ascii?Q?zaACA41xEra+n1ARQEzgCyau6dPzzH1rmnVpin5/jy8rhWTfO9w2y9YT+GSq?= =?us-ascii?Q?PmXK6zEH0M8r0x3La7aAU4CIltme958vtOyAH44iofKCoSbuyejrNPQohfS+?= =?us-ascii?Q?zGrgsBMnkmr8frNI2rNMToZeD7YdMsWHicJbG3Z5sxGk24J1+3GB6Rr0PX7a?= =?us-ascii?Q?wLyHWE5y0TWosFEOlcQ6RF54YdF9UZYk2g0MPkTPiSaL7LCz/Wc0CFCmy8/P?= =?us-ascii?Q?TPnQHJV8cveiYfPi5r1LdoTVfHdoEkqhfm4IOus/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 314d9bae-4ce4-4e92-6ba3-08dab24a3000 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 03:21:32.8848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: djHYAhqVSqjH6i1auvcHjX+BZpzQQm/oKKvQT6Q9N6ZXlNcAVcKejLwG8OdsZzvi3RIY9IsMVc2NEv5J4+1Pgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7122 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, October 19, 2022 4:41 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v9 09/12] vdpa/ifc: improve internal list logic >=20 > Insert internal list element to internal list before > register vdpa device, in order to call vdpa ops during > vdpa device registration. >=20 > Signed-off-by: Andy Pei > Reviewed-by: Maxime Coquelin > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index c16e263..8dfd493 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1737,17 +1737,20 @@ struct rte_vdpa_dev_info dev_info[] =3D { > } > internal->sw_lm =3D sw_fallback_lm; >=20 > + pthread_mutex_lock(&internal_list_lock); > + TAILQ_INSERT_TAIL(&internal_list, list, next); > + pthread_mutex_unlock(&internal_list_lock); > + > internal->vdev =3D rte_vdpa_register_device(&pci_dev->device, > dev_info[internal->hw.device_type].ops); > if (internal->vdev =3D=3D NULL) { > DRV_LOG(ERR, "failed to register device %s", pci_dev->name); > + pthread_mutex_lock(&internal_list_lock); > + TAILQ_REMOVE(&internal_list, list, next); > + pthread_mutex_unlock(&internal_list_lock); > goto error; > } >=20 > - pthread_mutex_lock(&internal_list_lock); > - TAILQ_INSERT_TAIL(&internal_list, list, next); > - pthread_mutex_unlock(&internal_list_lock); > - > rte_atomic32_set(&internal->started, 1); > update_datapath(internal); >=20 > -- > 1.8.3.1 Reviewed-by: Chenbo Xia