From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: "Pei, Andy" <andy.pei@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] vhost: add some log for vhost message VHOST_USER_SET_VRING_BASE
Date: Fri, 14 Jan 2022 07:39:32 +0000 [thread overview]
Message-ID: <SN6PR11MB3504BEE3BD02FE462AE368149C549@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1642144737-201099-1-git-send-email-andy.pei@intel.com>
> -----Original Message-----
> From: Pei, Andy <andy.pei@intel.com>
> Sent: Friday, January 14, 2022 3:19 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>
> Subject: [PATCH] vhost: add some log for vhost message
> VHOST_USER_SET_VRING_BASE
I suggest the title be:
vhost: add log for VHOST_USER_SET_VRING_BASE
>
> Usually the last avail index and last used index is 0, but for target
> device of live migration, the last avail index and last used index is
> not 0. So I think some log is helpful.
Can simplify to:
This patch adds log for vring related info in handling of vhost message
VHOST_USER_SET_VRING_BASE, which will be useful in live migration case.
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> lib/vhost/vhost_user.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index a781346..3cb13fb 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -973,6 +973,11 @@
> vq->last_avail_idx = msg->payload.state.num;
> }
>
> + VHOST_LOG_CONFIG(INFO,
> + "vring base idx:%d last_used_idx:%u last_avail_idx:%u.\n",
vring idx:%u
Thanks,
Chenbo
> + msg->payload.state.index, vq->last_used_idx,
> + vq->last_avail_idx);
> +
> return RTE_VHOST_MSG_RESULT_OK;
> }
>
> --
> 1.8.3.1
next prev parent reply other threads:[~2022-01-14 7:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 7:18 Andy Pei
2022-01-14 7:39 ` Xia, Chenbo [this message]
2022-01-14 7:59 ` Pei, Andy
2022-01-14 7:57 ` [PATCH v2] vhost: add log for VHOST_USER_SET_VRING_BASE Andy Pei
2022-01-17 2:29 ` Xia, Chenbo
2022-01-27 5:32 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3504BEE3BD02FE462AE368149C549@SN6PR11MB3504.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=andy.pei@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).