* [PATCH] vhost: use colon in version.map
@ 2022-02-15 5:55 Peng Yu
2022-03-03 11:32 ` Xia, Chenbo
0 siblings, 1 reply; 3+ messages in thread
From: Peng Yu @ 2022-02-15 5:55 UTC (permalink / raw)
To: dev; +Cc: Peng Yu, Ray Kinsella, Maxime Coquelin, Chenbo Xia
The punctuation after the `global` keyword should be colon, not
semicolon. The default gcc linker accepts both colon and semicolon, but
the gold linker will report syntax error if we use semicolon after the
`global` keyword.
Signed-off-by: Peng Yu <penyu@amazon.com>
---
lib/vhost/version.map | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vhost/version.map b/lib/vhost/version.map
index 1202ba9c1a..0a66c5840c 100644
--- a/lib/vhost/version.map
+++ b/lib/vhost/version.map
@@ -90,7 +90,7 @@ EXPERIMENTAL {
};
INTERNAL {
- global;
+ global:
rte_vdpa_register_device;
rte_vdpa_relay_vring_used;
--
2.16.6
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] vhost: use colon in version.map
2022-02-15 5:55 [PATCH] vhost: use colon in version.map Peng Yu
@ 2022-03-03 11:32 ` Xia, Chenbo
2022-03-04 13:57 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Xia, Chenbo @ 2022-03-03 11:32 UTC (permalink / raw)
To: Peng Yu, dev; +Cc: Ray Kinsella, Maxime Coquelin
> -----Original Message-----
> From: Peng Yu <penyu@amazon.com>
> Sent: Tuesday, February 15, 2022 1:56 PM
> To: dev@dpdk.org
> Cc: Peng Yu <penyu@amazon.com>; Ray Kinsella <mdr@ashroe.eu>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Subject: [PATCH] vhost: use colon in version.map
>
> The punctuation after the `global` keyword should be colon, not
> semicolon. The default gcc linker accepts both colon and semicolon, but
> the gold linker will report syntax error if we use semicolon after the
> `global` keyword.
>
> Signed-off-by: Peng Yu <penyu@amazon.com>
> ---
> lib/vhost/version.map | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/version.map b/lib/vhost/version.map
> index 1202ba9c1a..0a66c5840c 100644
> --- a/lib/vhost/version.map
> +++ b/lib/vhost/version.map
> @@ -90,7 +90,7 @@ EXPERIMENTAL {
> };
>
> INTERNAL {
> - global;
> + global:
>
> rte_vdpa_register_device;
> rte_vdpa_relay_vring_used;
> --
> 2.16.6
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vhost: use colon in version.map
2022-03-03 11:32 ` Xia, Chenbo
@ 2022-03-04 13:57 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2022-03-04 13:57 UTC (permalink / raw)
To: Xia, Chenbo, Peng Yu, dev; +Cc: Ray Kinsella, Maxime Coquelin
On 3/3/2022 11:32 AM, Xia, Chenbo wrote:
>> -----Original Message-----
>> From: Peng Yu <penyu@amazon.com>
>> Sent: Tuesday, February 15, 2022 1:56 PM
>> To: dev@dpdk.org
>> Cc: Peng Yu <penyu@amazon.com>; Ray Kinsella <mdr@ashroe.eu>; Maxime Coquelin
>> <maxime.coquelin@redhat.com>; Xia, Chenbo <chenbo.xia@intel.com>
>> Subject: [PATCH] vhost: use colon in version.map
>>
>> The punctuation after the `global` keyword should be colon, not
>> semicolon. The default gcc linker accepts both colon and semicolon, but
>> the gold linker will report syntax error if we use semicolon after the
>> `global` keyword.
>>
>> Signed-off-by: Peng Yu <penyu@amazon.com>
>
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-04 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15 5:55 [PATCH] vhost: use colon in version.map Peng Yu
2022-03-03 11:32 ` Xia, Chenbo
2022-03-04 13:57 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).