From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD85DA057B; Wed, 19 Oct 2022 11:13:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F26340E03; Wed, 19 Oct 2022 11:13:11 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id E8D6140A8B for ; Wed, 19 Oct 2022 11:13:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666170789; x=1697706789; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+lzPdzgZdyRoxgbS7DtANBEs2J2xVTd4r3NWOnf2bHs=; b=mzm65I9rpzJEjrannD6WW3FywE9We3cIrqc9JzVcyDTakfq2EipkC8H8 pdRrW5Im+E00nraVG/HZP8dQhTtwDbGcYn2yerO/yvu46uPHvdAEYy2Ab Y8dPQUklsFg0JC8zurmPfHSkF9zpqG6YjfD8TOP9hpjkGV26u2KHI6nRj gq7kH28YnVa0EH3BuugoNjyCp5Smojw38w8UCuGKMMcMBLEGBkcwK2QbT gPgkBDCwJE0ztywOpDAxDsQm5neF8mDWlUhQFbJ7D3w6tms05TR7vL1sM ZqOUmnSbXLYZ9fvb04GGM6YLJz/jPEP6hX5sD7RfNgLNg0wBtZigltLtv g==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="289672032" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="289672032" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:13:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="660252613" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="660252613" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 19 Oct 2022 02:13:07 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 02:13:07 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 02:13:07 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 02:13:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lv92xMedA3feA3p2w5t4CZnn9/P5Sil1zTg0fl9A4IBUTZDD+qDsSbgqmXFVG8fYp90iMsyeZ4I/TxqzesxJCw2AUXUfhJtGGajoaGwXUoQaMvQ0hFXoazwP/PXQ3ENNb7yfGVdWAwHrod91kEOGHe5w5//exMZO0vpzXpz48uAAbk4ZUYaTQb9EsYA1SfsdHrDS9lpa9zEhCnvVtn6KeOwzzQaFUR6q6Quw+K1p0h1P8vIFphLrBKDdV8w7aRj9z5SB5bjtOC34GTLn10NidJ+rfqo7wEvPf+FoYAzjHYOghehVRiHQicVWfmKvNDr8LQKWFdX4cm2JtrKJ2SAdYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wWyRwyl3gc/0RSLVGtXrnvoBaVBsE1A1NOstsHYtc7o=; b=azk3/lQ0EFoCjV13uyGnf969Pk3nSzQxriloTy1hdL/4PNVVUgr3C5z952q1e/SbLj+WkSyRrDO9xojjwzdWofGij22W5+S1rk601kd0wzY/mV0oLHhVdMYUCREyJ+RMIX0qZu2ev5ioCXaiZuV0Z4CIy2qKqrYxSFc/U0TUx6H/mO3vl0yG2L+8G0WZPBg/d8TakI0N0xH+FlAIWwInGaDSYoVYUY8lLmUg3KK8eQgg4IS9T7pAYtmb+dFPxUCRTq2pIzV4yY27p4OCBx0foZt1keaNpnuZPxU8Jz/zx5zyQ2xe9ggxSGbQ9IQxqZRRccg8t3LSheW+oo11p9jxDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH0PR11MB5808.namprd11.prod.outlook.com (2603:10b6:510:129::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct 2022 09:13:04 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 09:13:04 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v8 09/12] vdpa/ifc: change some driver logic Thread-Topic: [PATCH v8 09/12] vdpa/ifc: change some driver logic Thread-Index: AQHY4vFUoN2VFq90JkCzaP4QXcJTjq4Vb76g Date: Wed, 19 Oct 2022 09:13:04 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666094871-25721-1-git-send-email-andy.pei@intel.com> <1666094871-25721-10-git-send-email-andy.pei@intel.com> In-Reply-To: <1666094871-25721-10-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH0PR11MB5808:EE_ x-ms-office365-filtering-correlation-id: c1ef9642-539a-4bc0-dee9-08dab1b22142 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: x1nYEzT8MDJZM84jdGqj/LXFtcCwgFGMetXTv09sTRCdo0p4z3SRijnJHbfHD5IZPi/qpS9OaY805P/I/qPbX3+mN8KarfXwvd0di+tjegUI2u0X/1CsoatQF6cPeIZZ8NEGkTSveOkhe8wznRjaBtKSCnWP5eX9FzqC4rbkpQNsMnBEYZ6kAqlVtiJY1sbGrRAAyHtFMo5HP3yVnlIPKxl372aIOUGkrrPjUjnXg9zvWFPi/kaUh5hufqunrMGSu5Ldz+GQiPUoZ1m12YNu44+AhaKwlFyzkpp1B8PsjpGLdABCKmiGRJM5Cl6haj522M3oT2z4SX2v0UCzXDQYJM5AmdGU9tSk/rTro57/GH7QRhZm1FNuSgJzCMO/iiUyvnroO/hsy4Gdj75A/89WYpNhVXHIatx7AFRjBMXRao4vcdehLXT7rrPUHeTGfwgiBHLtLcWHJAQ9ppbosKtfKccB5Ztm7DY4E5isbBvUnp9ueuje0PgkC2vxXkMyj0bpBefA+olzIFEZRhgIPdbF2AX7zGzNh1f5ysQNgZHKaGBB0hSxBtNaVvDLs3+nrndRGA1N+8p4qaPqf6k9c2f5baVZP081iaCIcVEJGE0MdiWFbQQZ91RNppc9WkqhsCjWkyYoPMiC+cqyYBO9MF6Tm9vSggogsmUyGovCZcRKDiXsvwDK6Hq2qiMOBXRNRPem4x/PS6WrU59H+pFmuETInAb0eqojlKRp0NccKkVysiw9jbCVOfoAecrj8c9eK20cvA0ZezwA/2y1cB9LwreSjg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(136003)(39860400002)(366004)(396003)(451199015)(110136005)(54906003)(9686003)(316002)(478600001)(66946007)(64756008)(4326008)(66556008)(66476007)(8676002)(66446008)(71200400001)(76116006)(26005)(41300700001)(7696005)(52536014)(53546011)(5660300002)(8936002)(33656002)(186003)(2906002)(83380400001)(6506007)(55016003)(38070700005)(82960400001)(38100700002)(86362001)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3RmGOe0aHb1LkFzoVKI7UQxVzte4Wdew8dtDI9l3rwCobEaj/VvCkp1M7MDc?= =?us-ascii?Q?GnROvzD+21WvE2+cq4JqjiEFlOoArOVQ7WphFsgGOZTMJ1F16wwStKmmji30?= =?us-ascii?Q?W26h902lRMKyyHF4QhRffg9p//m8AaDAHjpt1co7oS5Yy477F67APMGAidkD?= =?us-ascii?Q?OtyMzpm6RAJEVwtIJlTokBwEhDzSjRGw6PZKVSuUwPXV5mBulo8BPO8rWw9a?= =?us-ascii?Q?EUhLWn0gDEaeqXl/LwdypQX+YmTtTYwoV4kNNRuiFWTo/sg8GqsLY2GP/FF6?= =?us-ascii?Q?O3UemVuwiSQD8jhFnVNdhErdE8ISWvDjI4MWKBbp8n4YQzm8UkU/4PWeU1bG?= =?us-ascii?Q?BDXLelD76rqevA+YX71E8cRE2/zkb9gY4kMff2zKbdv2zj/ffSWGT9M6RNuG?= =?us-ascii?Q?GQYVYCBI+Ne1G7zR99YZreyxWCGJanm6KQxvx1wCR192l1PuQaR1fIs/Ar65?= =?us-ascii?Q?uCpAv+7ZEQYP9ZSTvrHjsifQ7OC+djth3lWmoJjq2npMPlu2TRdEqDncGshf?= =?us-ascii?Q?A4d2UfKCv2tEA9TYYhyMsOYBThqSuKAgjIPuyyw4wW76ys50ahLYsgor5ku1?= =?us-ascii?Q?a8wUwhc53Ax/mMBHAyctfJBJX1LBhMcK8ywlVdnoNxttjJTVBgjR3Yj3aQiC?= =?us-ascii?Q?qC5jQqv/hqEku8hEOyQCsdbMLTTrwkOlceCSqnojaRJJ04ARvcMP9udUMKI3?= =?us-ascii?Q?8BLPZsH8erh1Ta2OiG2iOBGrIohguYJFosf24L79JPczoD1fgJzMtdLzqaK0?= =?us-ascii?Q?86lNCeZYQdEsCAP/tPumppVXPX+8VUy5xf+A4p/PTKuc3edcyzh2nG7baJca?= =?us-ascii?Q?ITAzlrebgD/Q2nrfEz6fT2QNt9GAQsg2xKcg5kGCepC0Jn5aidlmOlzIrKYp?= =?us-ascii?Q?TP/PuyR3y+0ZNQUjXFYbAIAi709Nt02UD/RN6oa1GG7Ukj4P4RwVTRb6RKVS?= =?us-ascii?Q?c0wODthljkT0Kp78wjZ31tXlddHEwzuAOVCtMPmZDwBptBIsC2biJzXVmTIK?= =?us-ascii?Q?GI4bTz5Lu8qBML2Tg8IVsV+Aiy4jpYwfkjmhSq29l3Q3hsP2p71mGD5uCkjr?= =?us-ascii?Q?LtjSyWFcErk2+WV+JrdyalBgsXFb8b92cYZOkVCaO6yFgoQzHdg+W4a8FLef?= =?us-ascii?Q?i7lMuPpm7fhdKDB7CoX2/vYjThTxWQ7mBbgb+McZ9HxjxUOCDe9DSMF8Sovp?= =?us-ascii?Q?TYp+voEoLHEkPsXj7Lq7b3u5J9EMHjzeWbsXBspupaIsFI4JpXJc39oegRer?= =?us-ascii?Q?hPqQcN6KMBhy/jR87L80vJ0/U5RiUf0zC5o3wywZJ1pOowfu5uaOTuHMsmqr?= =?us-ascii?Q?hFoE9S4L2SG4OSvMxi5AfD9GpTCRDRSSPTizWvFNs6cQohBIzmzyceBkqwjU?= =?us-ascii?Q?hxF1MR7MPEX17S9tAa2YHxIzmtLBtwnXH74JO5Ghw66h6Pk/fXhKoIl5Oa2G?= =?us-ascii?Q?W5sOI78LjBvWgcK+hFzHWJ68kDOy1W/B5wKnWxZ0mwqO9nFM+gVvQtiSulDa?= =?us-ascii?Q?TyXH4yFJkG0izUxnK9zHFA/EHni8SnQJo44gKBATmT6yUJW/GhLveQPydH1p?= =?us-ascii?Q?po+8K1yjpwTkk66YCJ4FNzLze0MC0Vu7c4k3r+dH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1ef9642-539a-4bc0-dee9-08dab1b22142 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 09:13:04.6515 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 02F2euCIzpI0J1ib1nt/LlRVmFyhY0zHgZtlf6fVgVz2AMe7iaIpTMyjAivty4qcMT6dX0qyzscYgMuCeQ6b9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5808 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Tuesday, October 18, 2022 8:08 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v8 09/12] vdpa/ifc: change some driver logic >=20 > Insert internal list element to internal list before > register vdpa device, in order to call vdpa ops during > vdpa device registration. Patch seems good but title may be too general.. Maybe: improve internal list logic ? Thanks, Chenbo >=20 > Signed-off-by: Andy Pei > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index c16e263..8dfd493 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1737,17 +1737,20 @@ struct rte_vdpa_dev_info dev_info[] =3D { > } > internal->sw_lm =3D sw_fallback_lm; >=20 > + pthread_mutex_lock(&internal_list_lock); > + TAILQ_INSERT_TAIL(&internal_list, list, next); > + pthread_mutex_unlock(&internal_list_lock); > + > internal->vdev =3D rte_vdpa_register_device(&pci_dev->device, > dev_info[internal->hw.device_type].ops); > if (internal->vdev =3D=3D NULL) { > DRV_LOG(ERR, "failed to register device %s", pci_dev->name); > + pthread_mutex_lock(&internal_list_lock); > + TAILQ_REMOVE(&internal_list, list, next); > + pthread_mutex_unlock(&internal_list_lock); > goto error; > } >=20 > - pthread_mutex_lock(&internal_list_lock); > - TAILQ_INSERT_TAIL(&internal_list, list, next); > - pthread_mutex_unlock(&internal_list_lock); > - > rte_atomic32_set(&internal->started, 1); > update_datapath(internal); >=20 > -- > 1.8.3.1