From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFF57A0557; Fri, 10 Jun 2022 05:53:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC6E440689; Fri, 10 Jun 2022 05:53:35 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id F258040221 for ; Fri, 10 Jun 2022 05:53:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654833214; x=1686369214; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=P3hpqTEKx8bopl+p5fiwR0jCWZPhpEg+6Jjnw5dd1N0=; b=YcK1qQz8Ezg6CpbGKT9oj5elb2GLywtIFU1bYyqNZBPZVfkj9c6J/7iD pLhyEGNAeRfI2SCufxzZpbE0kvKKAgvPJ6EnU+Qelbfots0Wv6GhdkE0C sLYTLdTgvMCUq7phghk3pY8HCP/RMjHgUGSlqFzo3IT/wbILlF+mJi4D5 VmGNeaZB0IOI5VX18Y3NH3i99R1mKxjKebpNBzJyLq804+uTBflB5qIJs xJbGOrElsVsj/yWSwSPdx3s0m2WPEt6pyHfXl9pEKqly9qQY32h7y/baJ pmnl9PVFu85qU0ZsacUJSWF3mnIoDCJsE0JwcpnmfEfw2cZW9u8EPP5Rk Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="276275427" X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="276275427" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 20:50:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="724756535" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2022 20:50:37 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 9 Jun 2022 20:50:37 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 9 Jun 2022 20:50:36 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 9 Jun 2022 20:50:36 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 9 Jun 2022 20:50:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n49OjAbIp4K1wP0lAg5Wp7iB1t06sIJc41rRNzV4OE/dLpRT7/qMuudTOuGBS55xveChZ3z2g8IHipGn47EYvelf8cBpQptuq4ojeq1kzdYgPJjVWLc1V7TsylE2hADzwrPaC0Yiw+AGhrwpeSb0VuTmzJdfho7LfcrBgA7PgzpegsP5HYkjGuyPvfK88oNlMpCOCZlXClLm/lja1O/ZDCVNV7LYW2NgL4GXNZNISuEml5723ZJ69CJOW7+FueRj+UfG98x9rxpWWNQmkNAZPk9+gsqfTFOSdIaiEP4zbXryU1tgwim5BHOg5BUElOQJlZXmqnNeG6c+08b/6vnTjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iiKTgIFC8qIj1bdA+MrsF3TWzuXiJWhVFy6KzfiUwXo=; b=lnltkEPV0LuvmnyAp0A4sEcvbKAOfnQXZ0ge4uQJLOwwlH0O5v5h12Uu6LHnNUQSgTnko+dSnGo3SKF03wieS62Mulkde6ZD50AB7jmlN5YuphL9HSrms13HWkDk715hobAcrgnL9cKwFvOvzC8M229n4iRo8K2/4E39ZcvwHiyrWFAy4ymiPQ45HejBQYn1GWV/7J3e7xixMyza/PXZlR2g/VZiC6Ce04+zEikZk4edzsuuSAvPStuU2lkwvPrnTcM7d4GxO5pDWAk/FkS0xsayU6+dKNjWvhIZZnJrdCQfz/t7A/QWJnRfcQtzzM2MFUXt7L45uwTjhy1MvN9SQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by MWHPR11MB2016.namprd11.prod.outlook.com (2603:10b6:300:26::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Fri, 10 Jun 2022 03:50:31 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::d4ff:ac50:621a:60e7]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::d4ff:ac50:621a:60e7%7]) with mapi id 15.20.5314.019; Fri, 10 Jun 2022 03:50:31 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "jasowang@redhat.com" , "david.marchand@redhat.com" , "Matz, Olivier" , "Ma, WenwuX" , "Zhang, Yuying" , "Singh, Aman Deep" , "Jiang, Cheng1" Subject: RE: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path Thread-Topic: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path Thread-Index: AQHYezZTW5vJMGYo1UypFmW2qXY6eK1IA/PQ Date: Fri, 10 Jun 2022 03:50:31 +0000 Message-ID: References: <20220608124946.102623-1-maxime.coquelin@redhat.com> <20220608124946.102623-7-maxime.coquelin@redhat.com> In-Reply-To: <20220608124946.102623-7-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0affd40a-8351-4665-cb8a-08da4a945da6 x-ms-traffictypediagnostic: MWHPR11MB2016:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p3WVBmSMQrehjg+pOWurzbpkD/JZaZ2YqCwgsHGJwCSJ+yyCbLcBb8CF/0gXLFWsNGxwst+vz2jqZ+haABobL2eFcMa5GURmXaLawKfVfZZCH4y1giaTvHDgXn+XwF9/4Tt/+CfntJSfTvL7vS6M8lNT4im3SIzHEjAkTkVD5eQcsG8SeC4nzyZ86kVnSXY3gLIa0eCpseTC5TmyND6xmQmoeeNZ0KYHu1X0bBmeVHo4Ak17whHq/EPb32SE7RxYqcln9Fnpw09EKq3xUM7PSBL/wK2zWnYB14kbq3PSKui3q9eDbCzorD90i5leJwyjHDQzzg6ouEM8xBaf+ncMV72XS5rteiLN/UuxPzhgsWsKF16hx0laq1McLeSUxQSRQn1tUXaN7YeRoWGnQxe+AVeRYmBRGPtcA6AQ7ZOIFnAkGVswrGP+MHLlZQBQqnURPnah14Be/vEdjV6lGXMLJ8NWnwb3Z6CEbP+NXSSf1QF3vybHGUUU4wkahWUaYs/jKLE/zu1wAhz2wlb37YDWtD+26ByI7WuYSOHgaieyzlmlC2MWqT7XOb8PRzlbWGHZr24lVxIz+WiBqTy5nMxtgnxteNBicygFXgyOkQ1Zsi6S2S4oy2nCbfiWTAgHGck9rNsoaUGpWlrXob14XUmDLF623oDgG61ScwX8eZeapVC0EppvVn1NSyA92zWV6xdNHj3Q3str6Bj06rVLjmncjNej2BO7VK2b41GoZLyFfgY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(122000001)(26005)(2906002)(38070700005)(316002)(110136005)(6636002)(86362001)(921005)(9686003)(55016003)(5660300002)(71200400001)(186003)(82960400001)(52536014)(76116006)(33656002)(38100700002)(8936002)(66946007)(7696005)(83380400001)(508600001)(53546011)(66446008)(66476007)(64756008)(66556008)(8676002)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PSNpy1kM+0Sm9z9nabtH9r3kraTmJ7lxtRJgUPxEkSJwQLCbGzvf6vrd/fXr?= =?us-ascii?Q?Fp587wCoRc4WoprFv4Tl9cV6ufArtAdDExDPZffX7GvqlvaFHTR1tZqFOfgH?= =?us-ascii?Q?PrFdIKwHaD3EmYOJVdq3LJZyGXMMtS8cpmRNo0JSOfONIWkHzTdBi8athyUf?= =?us-ascii?Q?knC8+mY9HDbfLqaZqB5bxi4fNAxe6FMohr7DB9a7cjLf7QH8JsI3ZGT79YYk?= =?us-ascii?Q?FoeP+IDDEAUPVhJHU7zqpO0WZO9rE7QwxyliecpJKviiT3p/gOQ0TGZQY5FK?= =?us-ascii?Q?pnuTxgy3xWUkeYLMQRi+n2YBfcaou16fdOlnJMRsLT9FbSNGmJoN+eURTL3d?= =?us-ascii?Q?bE6mwTTKtyPQEx4+Bp635RU9ExMtwilfFP8mQ/2zA7v8kNANtyb2i8MEL2O2?= =?us-ascii?Q?jZ2WopZYd9caQTTFGCkMRF68Ou8oNelRA/y9TJGbJkINHfAA/zAzZf0RAuVG?= =?us-ascii?Q?OIMWte1wwyj/dSx8N0joD8aNebt+YjtSwz6+f+l92uAEXWGdPCLjK6c3ASbp?= =?us-ascii?Q?8rRuIVbMyKcgI5RhAGdy2ETudmrX0AX29WcDB8goRvZ9wkCbiB7lc7ANGBgu?= =?us-ascii?Q?8Vfqdk7o3Dw2tKlPbskNVh0WkjdsCHE5qKhpevJ5AumrWrLKHBecxQkkDqiU?= =?us-ascii?Q?HMy6z0lkehmbpJaz7SmNwLv2A8Z4xzwgBYHiD/E/deRPRV6hyzkDn4PSKGIM?= =?us-ascii?Q?PsAypSCx6esGQWP6TuIfXog9csOccSDyfDCcZuEXd4ynF9hz4OwNZKCjm8EE?= =?us-ascii?Q?TdN84ozwpVkY8E1SOazaMsfZZKHDudppqauvVBY5rKE+AXeh6oy2c1dyCjqr?= =?us-ascii?Q?TVVXkIHRSgzOSfGycf1FichF3E8iFBr4/VG1o6UrJNRRfK7sxr1W0vvaXVyJ?= =?us-ascii?Q?MNJs/VpmMdGMDwWkhkW3gVIhqVyAZ3mSbr4s+C0GsFVixdY8BGuEFvKNoVb0?= =?us-ascii?Q?iiAMdOPtvLUb+SugMKodFSij6zS8qeYfhBwUYcjsK2MgFcJCac82chVUP770?= =?us-ascii?Q?7pR4qt62FYQjPgFQd3dBSa3wUCa9UpdFFVeqfTPFILTbI+0S3Vsu+VlXRqiq?= =?us-ascii?Q?QMhyJbMzyt+rIG6FChkMnTZ80DDFGVB27hy48H1LaBiZSxy3scFGazo07UpE?= =?us-ascii?Q?ZNp+sLulTVtAAAlMhkObOHZfuf5x2RGOW5PJSHU7tih1StAQoDqog8pHnvzg?= =?us-ascii?Q?3vyMsf/b+y7eKMWKXynH7ATfdDBwleBuiRCDWvYj3VY3qXIqSshcSegQ/Z89?= =?us-ascii?Q?P3If4lqdM12aa0b4jTkOvjSqtrBQbwV5FPMW1STxJIKgvTyBfdI+RjsSraJ0?= =?us-ascii?Q?A2OQTyfAQY9FJmoHPzCipMMxEdZdTcAMCedGa07s99341N8XS7jdyShJzz8w?= =?us-ascii?Q?Y+eUtUwOzRmDiLS0BVBw7PAaOmTy7e5RsLfCoBqT7IqM6ZtvuXnhV6jMBoL5?= =?us-ascii?Q?cyEG+ZMoGki7p/Mxs1OTz/cd6S9QbNe82wP0Aeg4nDHAFDslMtLEVH7LWUrJ?= =?us-ascii?Q?baZOvDOswpZ0KI57KkbsKsywlBtTsKU9OMR8lYULmzHhYjV2Wxu9ohoKS1BR?= =?us-ascii?Q?Sq1lZ3QoZbMqk+SQX56PFqpU4s18ArFgCl5vFCBPwdb5D5+4qu9NZRfqYJ6J?= =?us-ascii?Q?1E0h/deBUTRce/yNYp6x1C6UIibUwS9dZGyLU4EunIxN2I7BnBhN6dvaiiVW?= =?us-ascii?Q?g9i3qibMEUHDdc3vU6TbL/wahXutSsZLGXPX6zu9xQUafaq4GVre6jIJFysI?= =?us-ascii?Q?WImiF0216A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0affd40a-8351-4665-cb8a-08da4a945da6 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2022 03:50:31.2861 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G+8uaR6lpRXV1woHi1N6yra+49nsUvMyru0/7Md7lFICfqDFW9bpEC7zaSLWHV26zL7voeVTFAIk2cIUtZY3UA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2016 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org +Cheng > -----Original Message----- > From: Maxime Coquelin > Sent: Wednesday, June 8, 2022 8:50 PM > To: dev@dpdk.org; jasowang@redhat.com; Xia, Chenbo = ; > david.marchand@redhat.com; Matz, Olivier ; Ma, > WenwuX ; Zhang, Yuying ; > Singh, Aman Deep > Cc: Maxime Coquelin > Subject: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path >=20 > Virtio specification supports guest checksum offloading > for L4, which is enabled with VIRTIO_NET_F_GUEST_CSUM > feature negotiation. However, the Vhost PMD does not > advertise Tx checksum offload capabilities. >=20 > Advertising these offload capabilities at the ethdev level > is not enough, because we could still end-up with the > application enabling these offloads while the guest not > negotiating it. >=20 > This patch advertises the Tx checksum offload capabilities, > and introduces a compatibility layer to cover the case > VIRTIO_NET_F_GUEST_CSUM has not been negotiated but the > application does configure the Tx checksum offloads. This > function performs the L4 Tx checksum in SW for UDP and TCP. > Compared to Rx SW checksum, the Tx SW checksum function > needs to compute the pseudo-header checksum, as we cannot > know whether it was done before. >=20 > This patch does not advertise SCTP checksum offloading > capability for now, but it could be handled later if the > need arises. >=20 > Reported-by: Jason Wang > Signed-off-by: Maxime Coquelin > --- > drivers/net/vhost/rte_eth_vhost.c | 62 +++++++++++++++++++++++++++++++ > 1 file changed, 62 insertions(+) >=20 > diff --git a/drivers/net/vhost/rte_eth_vhost.c > b/drivers/net/vhost/rte_eth_vhost.c > index 42f0d52ebc..d75d256040 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -92,6 +92,7 @@ struct pmd_internal { > rte_atomic32_t started; > bool vlan_strip; > bool rx_sw_csum; > + bool tx_sw_csum; > }; >=20 > struct internal_list { > @@ -283,8 +284,10 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev= ) > { > struct pmd_internal *internal =3D eth_dev->data->dev_private; > const struct rte_eth_rxmode *rxmode =3D ð_dev->data- > >dev_conf.rxmode; > + const struct rte_eth_txmode *txmode =3D ð_dev->data- > >dev_conf.txmode; >=20 > internal->rx_sw_csum =3D false; > + internal->tx_sw_csum =3D false; >=20 > /* SW checksum is not compatible with legacy mode */ > if (!(internal->flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS)) > @@ -297,6 +300,56 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev= ) > internal->rx_sw_csum =3D true; > } > } > + > + if (!(internal->features & (1ULL << VIRTIO_NET_F_GUEST_CSUM))) { > + if (txmode->offloads & > + (RTE_ETH_TX_OFFLOAD_UDP_CKSUM | > RTE_ETH_TX_OFFLOAD_TCP_CKSUM)) { > + VHOST_LOG(NOTICE, "Tx csum will be done in SW, may > impact performance."); > + internal->tx_sw_csum =3D true; > + } > + } > +} > + > +static void > +vhost_dev_tx_sw_csum(struct rte_mbuf *mbuf) > +{ > + uint32_t hdr_len; > + uint16_t csum =3D 0, csum_offset; > + > + switch (mbuf->ol_flags & RTE_MBUF_F_TX_L4_MASK) { > + case RTE_MBUF_F_TX_L4_NO_CKSUM: > + return; > + case RTE_MBUF_F_TX_TCP_CKSUM: > + csum_offset =3D offsetof(struct rte_tcp_hdr, cksum); > + break; > + case RTE_MBUF_F_TX_UDP_CKSUM: > + csum_offset =3D offsetof(struct rte_udp_hdr, dgram_cksum); > + break; > + default: > + /* Unsupported packet type. */ > + return; > + } > + > + hdr_len =3D mbuf->l2_len + mbuf->l3_len; > + csum_offset +=3D hdr_len; > + > + /* Prepare the pseudo-header checksum */ > + if (rte_net_intel_cksum_prepare(mbuf) < 0) > + return; > + > + if (rte_raw_cksum_mbuf(mbuf, hdr_len, rte_pktmbuf_pkt_len(mbuf) - > hdr_len, &csum) < 0) > + return; > + > + csum =3D ~csum; > + /* See RFC768 */ > + if (unlikely((mbuf->packet_type & RTE_PTYPE_L4_UDP) && csum =3D=3D 0)) > + csum =3D 0xffff; > + > + if (rte_pktmbuf_data_len(mbuf) >=3D csum_offset + 1) > + *rte_pktmbuf_mtod_offset(mbuf, uint16_t *, csum_offset) =3D csum; > + > + mbuf->ol_flags &=3D ~RTE_MBUF_F_TX_L4_MASK; > + mbuf->ol_flags |=3D RTE_MBUF_F_TX_L4_NO_CKSUM; > } >=20 > static void > @@ -423,6 +476,10 @@ eth_vhost_tx(void *q, struct rte_mbuf **bufs, > uint16_t nb_bufs) > } > } >=20 > + if (r->internal->tx_sw_csum) > + vhost_dev_tx_sw_csum(m); > + > + > bufs[nb_send] =3D m; > ++nb_send; > } > @@ -1267,6 +1324,11 @@ eth_dev_info(struct rte_eth_dev *dev, >=20 > dev_info->tx_offload_capa =3D RTE_ETH_TX_OFFLOAD_MULTI_SEGS | > RTE_ETH_TX_OFFLOAD_VLAN_INSERT; > + if (internal->flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS) { > + dev_info->tx_offload_capa |=3D RTE_ETH_TX_OFFLOAD_UDP_CKSUM | > + RTE_ETH_TX_OFFLOAD_TCP_CKSUM; > + } > + > dev_info->rx_offload_capa =3D RTE_ETH_RX_OFFLOAD_VLAN_STRIP; > if (internal->flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS) { > dev_info->rx_offload_capa |=3D RTE_ETH_RX_OFFLOAD_UDP_CKSUM | > -- > 2.35.3