From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24E8C41E28; Fri, 10 Mar 2023 04:16:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0843E40685; Fri, 10 Mar 2023 04:16:48 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 71D5A40150; Fri, 10 Mar 2023 04:16:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678418206; x=1709954206; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ySJTpkyOKn7z+vrrobrvztaRHfcTUCwer/mUAlBulGI=; b=OerHRWacJDOemWThR6W7cgjTLw1mVFhS5gGaE5sBnfoyyhu+dvZnGisU gZQUBBer4blWzfJR2VkHSKtDfiI+9Sv0/K4Bo7zHIPBDZQZyc5tp52MWp 62vfYPIxj6Q9CaoNA4mmR1m6TeinUqM1STeX0cczvOPINzsnKCkXd8jOf ft0rEoOBvwxmd75waseh/5xrkW5jpINY2PFfHLYZ4jq/fGwWZqG5nK5dC nMdp6CXKzRT0f0X6hUstxSESzu5c3z/pB5qU8HD6aeRIU2/ukgHBrGxdh jObnJh9BPpzkXgE13HBMVT5sCC3DXujycez3zblZ2V2/FyEOENJ0yIEfa w==; X-IronPort-AV: E=McAfee;i="6500,9779,10644"; a="338189469" X-IronPort-AV: E=Sophos;i="5.98,248,1673942400"; d="scan'208";a="338189469" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2023 19:16:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10644"; a="851751818" X-IronPort-AV: E=Sophos;i="5.98,248,1673942400"; d="scan'208";a="851751818" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 09 Mar 2023 19:16:45 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 9 Mar 2023 19:16:45 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 9 Mar 2023 19:16:44 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 9 Mar 2023 19:16:44 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 9 Mar 2023 19:16:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jllgnyayWcqFqeLtAEx0sn9PTXvoHYdWINsmaA36O9NFKz8wqL3WAF0wRQRGh+gyke3dT3kx2HdJlCDPB/whQFS6+atBg+8ueUReGnpLSOZVp+++jGPW0Eq4B3VvHBGChZ1g7jrbLSxPJLZJpAbc9adViKCobDFQ0ug+H18+618AqF/ysaytrnTQxDjQ06knnDU2blv9ogoTXeO51FUs1MItb/qIr/mo+dQE4Iz8VtoWY1Ae3weWefguVMDCBjZNdCoAjUt6a5LK7L9A7srt2XjssXWyWSnb+MZ0a2s9FvAp3yEoQemXdmtYcizXr9tYIzgJqy+GJQWBd0DvvAfaNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ySla2+AORNPxsehHsyYEt7zX1gD6nzdOBTEXhul8wXY=; b=MI0XTEpLIwvkNAUCe64nDynt4ddZPOBfd5O/r+BXDh5iC0FgN5NAxz76HQrr0WgUFKyt1rHb+6+TLC/+mY7PUZeIUMVTbIE/Fj6FiVR1xLCyunlO99s153vu4jkQ5e0ph4FDEA3VQonpCAQXgTxpw4cIObJoCVREjrogTOd+MBvwZVrHo220OeG9t6SblBz05Ukn61/j2PakaridhGFmT16Cbi2UfHI4wrrrT6Pb2IG+TZL2ugeQezmBfUpGQa6R/2+REIfeEr+M/wWbGZCWyJ4Z1HeYSTbFzbdgyrUq3OiwhxT3tU57AR4Mt6xLCnMDcpcPfJ7HEt3N4Vv5qwzvEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by MN0PR11MB5987.namprd11.prod.outlook.com (2603:10b6:208:372::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 03:16:42 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::930b:6671:e4f0:4ebc]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::930b:6671:e4f0:4ebc%3]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 03:16:42 +0000 From: "Xia, Chenbo" To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Maxime Coquelin , Junjie Chen , "Jianfeng Tan" , "Jiang, Cheng1" Subject: RE: [PATCH 1/3] net/vhost: add missing newline in logs Thread-Topic: [PATCH 1/3] net/vhost: add missing newline in logs Thread-Index: AQHZUoQCnRnKqqa25UWMlN3a+7Pog67zWGVA Date: Fri, 10 Mar 2023 03:16:41 +0000 Message-ID: References: <20230309123752.2237828-1-david.marchand@redhat.com> <20230309123752.2237828-2-david.marchand@redhat.com> In-Reply-To: <20230309123752.2237828-2-david.marchand@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|MN0PR11MB5987:EE_ x-ms-office365-filtering-correlation-id: 962b4864-2c79-4f53-1308-08db2115dedf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TT3634G5cXYG3OR5Mn8MnAGo9HSauOhOyIxbtJY3sEGDmU8K4By3gEv9UmRjuZUi2ZC0/ZDONAUGxaGz+58oy2VSjHXfs3api6SoaJE4QrtY0qcdHUt138/Yi4WsYHVa1B1TVchVduLlKjHUGtfpTn5y9abS5S7xBWrWrtRzhIWT41FcyDqobTcjqMleDRf0i3qNftLgsnh5Rrp1R0aNEjrZmrs4GT3r39ba8Lhbj7jPe1ylozN0f/q8DFNkZz+4viS4SEu/NtNdOde8eZM9Uyfx1d5JqzWuXECdu2Me75IwWZo8nC4mtzyiWZyMSxoY6v/f0sCK4ae8PgJPpR2+/q3G+hrHO0GhOTYNlQloP1JFGw70fS8IIPm50SotA3CWP1ZrVMRs2I/UzNG3VxlYxcp3J7plcHBSbemQF92zYTGkrtftI0GQnYdQ6cVjfHbcmCZmTFOOi5jWcjX2zVq6T0AEgVnypyCpkZ09pFKmCu4aBfrbp+mLNlChZdX2jsDYrsHECzTgwt/eWUT9elTKGPYqtNZpDNpf0EIGv8w4b4FS4GL2Z2eY/36kY1Kca2/XlPR3R/v6Nvw97d2V6L2cE/dQJtEtzF/9QSrwy9qEozcKlD1aNkFyZeo8w2m6A1gPVEQGuz4UU0DUJuOIKp0a3JcDcffl4GLYDbDRWf5lzxb+b5ZCi33K5/vpOkF/2rLlDbwuLRfeXr6kTOO0ZVkGLw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(39860400002)(346002)(396003)(376002)(366004)(451199018)(66446008)(66476007)(64756008)(66556008)(76116006)(66946007)(8676002)(4326008)(9686003)(53546011)(6506007)(107886003)(122000001)(186003)(26005)(83380400001)(316002)(54906003)(110136005)(478600001)(86362001)(33656002)(2906002)(55016003)(71200400001)(38100700002)(38070700005)(82960400001)(7696005)(41300700001)(5660300002)(52536014)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cK5jhbNyhjWhVgoD7YUero2UNLoX5o7S92orj2fql4IeV7zm4VrYU9p0OQo7?= =?us-ascii?Q?mMnsGbl6KAubw4VJl/b1zRjMbJ8ug/jzFB+dZSAnYU7FlV2AkGAnLZB2/niG?= =?us-ascii?Q?Sb+tFZr9JIhLQ1CHRP7NIdGzlZEo7JKWkRocR2+9p4ZztRD3cOVuO8AbmgZ5?= =?us-ascii?Q?MaqQGgb7PJT8dvJCGDEJFXkoHdpy/QzvY4ne3eiNN2mRlBw3BWtrhjJbIF3N?= =?us-ascii?Q?4756nmZFhEiMMvUXpXbvHD/s/9kyJ2pUFPwAX2E/fZkGCZhzPMhPEjEN9d+1?= =?us-ascii?Q?t58y2zMLqwe30bhbXOdyoyy34DgMDTbrtTbZqPycvSQ99cLJMpqkX5rxRUr3?= =?us-ascii?Q?M+p1wrsqiT46X/2GtLueCng/kkgzTFmI7+MDuDu/6mkNshg4c/KYEQ3HeUIm?= =?us-ascii?Q?9Lm1qIZcYI/AGDdx6I87LQ9XgZ2M/dvPGp5tRuEwqy6pHD3N+8kNtyogv+Bd?= =?us-ascii?Q?7gtCMYd54DnJwgJn06P4AKji3nF5Hres786sQnIBJrKarkCczhTu4o38LqLM?= =?us-ascii?Q?Q/FA0e8z5PwjyjxG97pyRx4whDbfdWb6QZnc4TzOhvLm8Gr53dg+NuduBFD1?= =?us-ascii?Q?/Ruimn4EHEdQvGGIondOqI0oruW/lcx9qbhks1WN7xO54bk6WEVy2tsL7Ysj?= =?us-ascii?Q?0X4jrh9aVCFiJ9MtKOKAxuPXjsmo6WkBLVdquMjDtwJhL1c4iPZWX4PpvkO0?= =?us-ascii?Q?sw0lNwhhI4lA6t+ZJwnaTdjmTZINXkh3kqwVsy/oJG6NfxnUh3+PRdheHMdz?= =?us-ascii?Q?BmoZvN4THw18hcqaixTAEevARBd7esItLLfPPG2G4WgEO4/RgwzQVXOEVXYc?= =?us-ascii?Q?+JE91Ntub6xAa9xvaXmIFN2n7/ArcJcDcDM0sM54dDIzXr0vCjkgy8AmOndn?= =?us-ascii?Q?ohfXpt66kB+QipiVEc6G0uJl5+vMSkgF2STnssyxlFkJyVxbragLn3PXFtnU?= =?us-ascii?Q?vTS9IIlzZEMv8FEOEClL9WnrexHkHQjIrEaOJHqrrbZdguyW7AMY/XDnqK22?= =?us-ascii?Q?Uli0mDgeed5AkHbmN/lioB5CyOSgajPXmK2s2AfmEAC39MpTk6kblpso2Ssb?= =?us-ascii?Q?YoCxvTmeulJDEEo/BIk0UTYv4Pi62xBvvR3zeHw2y7QcMqbdJoW8PJMAY2dB?= =?us-ascii?Q?IdSo6y5QRmh32NMF+j27pIpG4W0IbVX1LcuuGs7xpHtFabYnHOxFHIhsjh1n?= =?us-ascii?Q?7TYTcjG57Qqzu2LIo8H+Z743XRCsSXGlIB5sF2AD5PqS+HiC71vc6jxBYnih?= =?us-ascii?Q?JmEpeujq4vmWePKmX0x4iKWKPwy5oXgTMKQpG1vSn1i6lMBhaIQjujfDke1K?= =?us-ascii?Q?3k/wLiRfU9XpOzODvct9mbEKPNiAhLaZU53tv4ViYChl93n2s+hwUEPVmdTo?= =?us-ascii?Q?2gGVwCFoey3KYO/Avjw+HipBb+LPJmXTj37O03z0bWrOC8IiV+j2xY7XNFZd?= =?us-ascii?Q?oBB/V0iCSU12lTq86+Su1f6oEFD1JrAGhi9SlMlcx6cG0cpDvD32xdEDXHTR?= =?us-ascii?Q?kYrYTeE/FScttOPmQYIJTE7JqVn5cGTRzpPOWr2PBY37qb+duTZKP03NQKfv?= =?us-ascii?Q?s5jG53JtzRox+q/LS/ygFk7B1YIaxjWyDGj72nTa?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 962b4864-2c79-4f53-1308-08db2115dedf X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2023 03:16:41.9935 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IqyUCRph/Sgz5h+Ki7XCRQW+jiQuF0HYzeX4GNLB/2M0SHg2zpnjDKAAyhgMOtRvFgPS6xNJsIUNGUSCUf49dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5987 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Thursday, March 9, 2023 8:38 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Maxime Coquelin ; Xia, > Chenbo ; Junjie Chen ; > Jianfeng Tan ; Jiang, Cheng1 > > Subject: [PATCH 1/3] net/vhost: add missing newline in logs >=20 > Fixes: 3f8ff12821e4 ("vhost: support interrupt mode") > Fixes: 8f1750f42e2d ("net/vhost: perform SW checksum in Rx path") > Fixes: 8ba1723783b2 ("net/vhost: perform SW checksum in Tx path") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > drivers/net/vhost/rte_eth_vhost.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/vhost/rte_eth_vhost.c > b/drivers/net/vhost/rte_eth_vhost.c > index 9c609b45a3..198bf4d1f4 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -297,7 +297,7 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev) > if (internal->features & (1ULL << VIRTIO_NET_F_CSUM)) { > if (!(rxmode->offloads & > (RTE_ETH_RX_OFFLOAD_UDP_CKSUM | > RTE_ETH_RX_OFFLOAD_TCP_CKSUM))) { > - VHOST_LOG(NOTICE, "Rx csum will be done in SW, may > impact performance."); > + VHOST_LOG(NOTICE, "Rx csum will be done in SW, may > impact performance.\n"); > internal->rx_sw_csum =3D true; > } > } > @@ -305,7 +305,7 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev) > if (!(internal->features & (1ULL << VIRTIO_NET_F_GUEST_CSUM))) { > if (txmode->offloads & > (RTE_ETH_TX_OFFLOAD_UDP_CKSUM | > RTE_ETH_TX_OFFLOAD_TCP_CKSUM)) { > - VHOST_LOG(NOTICE, "Tx csum will be done in SW, may > impact performance."); > + VHOST_LOG(NOTICE, "Tx csum will be done in SW, may > impact performance.\n"); > internal->tx_sw_csum =3D true; > } > } > @@ -646,7 +646,7 @@ eth_rxq_intr_disable(struct rte_eth_dev *dev, uint16_= t > qid) >=20 > ret =3D rte_vhost_get_vhost_vring(vq->vid, (qid << 1) + 1, &vring); > if (ret < 0) { > - VHOST_LOG(ERR, "Failed to get rxq%d's vring", qid); > + VHOST_LOG(ERR, "Failed to get rxq%d's vring\n", qid); > return ret; > } > VHOST_LOG(INFO, "Disable interrupt for rxq%d\n", qid); > @@ -851,7 +851,7 @@ new_device(int vid) > if (dev_conf->intr_conf.rxq) { > if (eth_vhost_install_intr(eth_dev) < 0) { > VHOST_LOG(INFO, > - "Failed to install interrupt handler."); > + "Failed to install interrupt handler.\n"); > return -1; > } > } > @@ -1191,7 +1191,7 @@ eth_dev_start(struct rte_eth_dev *eth_dev) > if (dev_conf->intr_conf.rxq) { > if (eth_vhost_install_intr(eth_dev) < 0) { > VHOST_LOG(INFO, > - "Failed to install interrupt handler."); > + "Failed to install interrupt handler.\n"); > return -1; > } > } > -- > 2.39.2 Reviewed-by: Chenbo Xia =20