From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A696AA00C2; Mon, 26 Sep 2022 09:15:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E0D3400D7; Mon, 26 Sep 2022 09:15:25 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 5799E400D5 for ; Mon, 26 Sep 2022 09:15:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664176523; x=1695712523; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9M80SE7Y/oDBaPr+xWeUsIiqTed6udP0oSOKSRpIPEI=; b=CYibiJY3p4rXX1iMI+JcmFWr+Sl2FGMLBpkLnpOQoX+la92EK+zJogiu TdFD2waKgLKBVAW6owMXRTlFfPq4E5AOz1mmcntgWfTbk+neRZME227Dl N4k0ZL5VcMZZ19LZVMMJJL0VFz78qVRqH1m/8Y0kCzGs4HXSJTR3Wf+E+ pz6HbGm0FoNdxEzS8DFoFu3v4+ywwRSi+oufD+E1QgXLDut/QSsMSWkP6 gcTETJ9LLIIulvP0E01aTdjKujWji3h3vy5OHhsvkg1a36tHxAx4Pc076 abWXNKzRhVKA8KuTlztJfHRoWsLH0AshpwskIjI9jQTeE1HHDfDNjKjx6 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10481"; a="280684356" X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="280684356" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2022 00:15:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10481"; a="598627476" X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="598627476" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 26 Sep 2022 00:15:21 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 00:15:21 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 00:15:18 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 26 Sep 2022 00:15:18 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 26 Sep 2022 00:15:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DdqA43PYiWeC2/BIOGasPPaNPmfIW+HIZuvid5R/FMPnPly3mPlXAk2at6YjvmlPBnj4gelq0vGEil++QvYUQ92tcTTKQt06tI9tOObH+vTnogXK6Oz3OuKYpT9wSeVyK/FDG4buyTgTafaEupeIsEli1RqiNOYfIlrPg6G4xnQrXkyyf+R2/9S+yCtv6FwSP0UNLm88ohC+0TTI3Q0S7evko2CJL4ZE1Zv63C1s23zCs+KUyWt/854aPuQYa9kMTdHw8IveCyZ25FK0nhUGO1suixaEfLNlPDjmhhCziN+TPRaizsZJZXDCAmWI7OBwy3N5QSW4b3WfccZZxqbI9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TEsXKcsqYcxld+qGi7kjJDH/5MiqzUcSTy5sxfQ4R7Q=; b=oX2oSp7aBk2sheSpEwhkhoSNMwiInbhUnFCnGo/hsZ6TuJNNOr+P5G6SfrtlMg75o6sVSUKGYWjd8ooicLcR/dbJzUMzRRO7y+tsgeNwVPj+c74Phhx/aDSdwY7cQk9ohaCXeGAjT9NPDm7LJGKgzND0zZclxasaZGEPwMfqdYSHp4sowvuFblKgzYziuuBBn7GcLEOzBuXB7Po63bODNN0z5/A9vYm0seuO0Jzrbz+9mnf4FtL4j4qkQip59QTa+SLs7eZF4g17Dy8vXnOVrUNXLcWkpTSTCPPoi6ack98+Zc3lOkGhATi964Hmrd3jYJedC38vNpD9cgIF9R9bdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by DM4PR11MB5424.namprd11.prod.outlook.com (2603:10b6:5:39c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Mon, 26 Sep 2022 07:15:16 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::408e:79cb:b715:b8ac]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::408e:79cb:b715:b8ac%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 07:15:16 +0000 From: "Xia, Chenbo" To: Alexander Chernavin , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" Subject: RE: [PATCH] net/virtio: fix crash when dev is configured twice Thread-Topic: [PATCH] net/virtio: fix crash when dev is configured twice Thread-Index: AQHYvRc9AB9Cr5XINk2mYJCwsQhpSa3xdM8Q Date: Mon, 26 Sep 2022 07:15:16 +0000 Message-ID: References: <20220831085344.47995-1-achernavin@netgate.com> In-Reply-To: <20220831085344.47995-1-achernavin@netgate.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|DM4PR11MB5424:EE_ x-ms-office365-filtering-correlation-id: 5944f32c-ccdb-4dba-ab54-08da9f8edcc8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aTtP2II0JPd2X8DgvVVdTO0wEleYkOdjHksSY75R3bk65JDZnuWZ9noU5jnMotfEBBLKibJJMzuhOglOl//pezop9Vitxee2Jd8ZadAp5uaqVmYKJQEd+Dn4HRo9BMOsqjZQzEPsnB89M7nJQNoOBhmZ7dttHMvQLpHfDYIdMLWiAbtvq0BvQqdaMnYhX3qNWQcKFazYyVuNlfLLO90zUcBnGJmaCScgPITe/plA0Bs3SiQCGxvKUCl+SkpWwBScbZjfi95Q527I3bWd2PbCMGvIm9nWh90O/voVZmLFcDi9+1sU9J0N1fkTEkEX48GuAJw3mScMVAH2C2DwCDp7Cscl1TaV2SVRtjpllR88hpZHlswv8uSQ2NEMQgwwruwdh7WQXdljy6VwW2qfjMy1SkURgE3uaAqp8khSZ9NS8OZgCnCYsR6RPRJvH47OAFV7gJqEsAdD0tSRUB0PoWSnsFnPfo9hthwBkspq6StN1hmwZ13E5jT4/6bqtcx7uJg7BsqABc+eC2KoRkK/S/GxAvoqZS/vvjeagiILMFrP/IFINaOhZZmZPuaXFDjvCEkBvGq+3LrwD7YGW26cMUUzlfuxC/6H56BBhWpsR/MeEiTqsPhikE9G9VV0uxVsH71rDelinO+awmzPbj33pNl5QcWjK8LPFJ6NBYwAk+EfqJqU/wAPKHC7pZ2dBjj5XZuKINIg8uC1DRb3R+jeVIbHj0dsLfokUFbCUsu2NrlwCFiH3CvrjebH9vXju6f59hLADGQULHfQlT5ghFgH8If+sQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(376002)(346002)(136003)(39860400002)(451199015)(6506007)(26005)(53546011)(7696005)(9686003)(186003)(122000001)(83380400001)(71200400001)(2906002)(52536014)(5660300002)(8936002)(55016003)(110136005)(478600001)(64756008)(66476007)(66556008)(66946007)(76116006)(8676002)(41300700001)(66446008)(4326008)(316002)(38070700005)(86362001)(38100700002)(33656002)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?izfaIGourjKIIkoGQVAFYCbGNORGu5bvY6neEijELkRyXaaHF7TTtlK+7K9p?= =?us-ascii?Q?+JZPv58SbJ161bnrBSGM2y2OZ8SbjRwmy48iGTgu60S5yhrM9PZkIfdaFmQl?= =?us-ascii?Q?DltawEUD/Eq/uj05X2VtTvieYIGGLaWPH/jAZmQpNsnaZQyLIoupiTxhGvXn?= =?us-ascii?Q?BzyQ3nIpR11zXnNKkTECFlgQdsFM0aoo+AmOuwCsrDdZe13tVN8BEAYnJEOj?= =?us-ascii?Q?pHkpZglb39+pWsWoDQByDBXuT5k2gfMq30ZFLF3W93MfhhZVtTZZrlRcPYlo?= =?us-ascii?Q?QfOXlA2SLFPk14N1x0zTXROARGS8hkKJ4nEkzEapEauXHbIL1s2baXdAJQFW?= =?us-ascii?Q?EVxTlSD3VvZ2LAanrbwl2t3Nl6Hoi2uDtO0IibPJp2931RAIK5MGFnVDtvW4?= =?us-ascii?Q?cFqxSEenXcQ+nPE/15ussKFmnwL9TiLgiiKTqDw2fjlaN0QhizRJ1+13ggRF?= =?us-ascii?Q?pH+iv8RbWB0NozK6pWbAX1ynXiPJ33GL+s+9OY27Nfn9crslVxbn2eZY/KFP?= =?us-ascii?Q?qu6EJWZdrA6SShXnhqCxwOCgX9LbzdAY4HuhhqeEtx1RGWmcl88v33ncnGis?= =?us-ascii?Q?4gWJV80say622qHqZwki9lzTOsIlJose1fdE9YDGuBgu5hiJj2b4xBF4WGDT?= =?us-ascii?Q?0ijECdpcC3EIrlR6HcW41rRm1SMtjXEEWZ4NJKeZRF0U0LTaeQtuz6TFyWlZ?= =?us-ascii?Q?Pb49NBZz1T+XF6dxHvd4MkbAoG5oUHD5U6J8WuLaYLNgqT959RlzeK9jFKxQ?= =?us-ascii?Q?NNsf+cirktMiJv34qXfwhZ155AbTLQyGL1ks+pbS5b1802uOiu1l22g7XPyS?= =?us-ascii?Q?xE+vaAPDBvnTTy6OglaxS+dApEz3gXkQXPAdEeh2ypCd5/t0tMpHYZvPWTH1?= =?us-ascii?Q?oEz8gOU/Jp669PiFKcjZSKtxi8UlMwKGnbhisrazHo11HnkzU6FTaEzJGIjk?= =?us-ascii?Q?UtSfdBfPDciIq4498pV1/688GeqJkt8CPOB98HYOrIa61kGCH6xFWo2JXT2a?= =?us-ascii?Q?JFSdwXCVIeZaWy5V1JTxVqjnB7qMANaJ/LAXH9Y8WFlGQm0V7NBARQFnH0a6?= =?us-ascii?Q?WtSHTx2y6Cox80Juja/LxtE7j1hpZFTINbW939MkG5bzDh6xaHu0r7fDyJWm?= =?us-ascii?Q?y55fOUX+v9TOhHShSwIUvKN9TmnVvBGwV3jhbjj3uKlXILen5cw6xFFGF817?= =?us-ascii?Q?T707xfEH8EYPovIQFQxGZlkyZcLkjHfwfFEwM/wCkTK79jUQPKc86S7gp99W?= =?us-ascii?Q?71MPIqep+cB5+gjnszVw8CHSHqGxhfB03+5xlwutR8NrCXqwpSpwhZafT+OJ?= =?us-ascii?Q?f6SpC/1xiRgMR3tTbDF2KcqSQ7uk79BTtUfZmGTrvaW8CEQGNQb6hOXqmlG1?= =?us-ascii?Q?DGafeCrW5i3HzaYX9hUTzF+bd1zvCzSpAJywUGGxOaxokvHZ0S2e2+uBUta/?= =?us-ascii?Q?ZZdRjaNK150y9VmXntrc3s21FwTitgPN4AwYNaNOrVEN8a3IEbArPm2cdVyb?= =?us-ascii?Q?oP4amodQTNbgJsgJMaSQibfg2ExAzze2MlHTQz8FzcaLssqphBYKTpVI+i2S?= =?us-ascii?Q?uRe1q+r8kT9jaVEW+K/9m2i9TmdcT7BMj5Q/zxOx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5944f32c-ccdb-4dba-ab54-08da9f8edcc8 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 07:15:16.4188 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RPL5g0lnpISa1Ggfc1BHIsvmYpT7sHYFoulKA7j4R2o3L/3W59YPU+FIDRAo8Gyc9QhtyJupE0AAO2aINBol5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5424 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Alexander Chernavin > Sent: Wednesday, August 31, 2022 4:54 PM > To: maxime.coquelin@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Alexander Chernavin > Subject: [PATCH] net/virtio: fix crash when dev is configured twice >=20 > When first attempt to configure a device with RX interrupt enabled fails > for some reason (e.g. because "Multiple intr vector not supported"), > second attempt to configure the device with RX interrupt disabled and > feature set unchanged will succeed but will leave virtio queues not > allocated. Accessing the queues will cause a segfault. >=20 > First attempt: > - virtio_dev_configure() > - virtio_init_device() is called to reinit the device because > "dev->data->dev_conf.intr_conf.rxq" is "1" > - virtio_configure_intr() fails and returns an error > - virtio_free_queues() frees previously allocated virtio queues > - virtio_init_device() fails and returns an error > - virtio_dev_configure() fails and returns an error >=20 > Second attempt: > - virtio_dev_configure() > - This time virtio_init_device() is not called, virtio queues > are not allocated >=20 > With this fix, reinit the device during configuration if virtio queues > are not allocated. Good catch. This is a fix, we should backport it, let's add fix and cc-stab= le Tag. Thanks, Chenbo=20 >=20 > Signed-off-by: Alexander Chernavin > --- > drivers/net/virtio/virtio_ethdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index d180162abd..38bfe050b5 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -2616,6 +2616,13 @@ virtio_dev_configure(struct rte_eth_dev *dev) > return ret; > } >=20 > + /* if queues are not allocated, reinit the device */ > + if (hw->vqs =3D=3D NULL) { > + ret =3D virtio_init_device(dev, hw->req_guest_features); > + if (ret < 0) > + return ret; > + } > + > if ((rxmode->mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) && > !virtio_with_feature(hw, VIRTIO_NET_F_RSS)) { > PMD_DRV_LOG(ERR, "RSS support requested but not supported by > the device"); > -- > 2.25.1