From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: "Ding, Xuan" <xuan.ding@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>
Subject: RE: [PATCH v2] doc: update async enqueue API usage
Date: Thu, 23 Jun 2022 03:09:25 +0000 [thread overview]
Message-ID: <SN6PR11MB3504E04299B782C03BF8BCD09CB59@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220621072131.14756-1-xuan.ding@intel.com>
> -----Original Message-----
> From: Ding, Xuan <xuan.ding@intel.com>
> Sent: Tuesday, June 21, 2022 3:22 PM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Ding, Xuan
> <xuan.ding@intel.com>
> Subject: [PATCH v2] doc: update async enqueue API usage
>
> From: Xuan Ding <xuan.ding@intel.com>
>
> This patch updates the correct usage for async enqueue APIs.
> The rte_vhost_poll_enqueue_completed() needs to be
> called in time to notify the guest of completed packets and
> avoid packet loss.
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> v2:
> * refine doc and commit log
> ---
> doc/guides/prog_guide/vhost_lib.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/guides/prog_guide/vhost_lib.rst
> b/doc/guides/prog_guide/vhost_lib.rst
> index cd3f6caa9a..628db3fc38 100644
> --- a/doc/guides/prog_guide/vhost_lib.rst
> +++ b/doc/guides/prog_guide/vhost_lib.rst
> @@ -480,6 +480,14 @@ the same vring with their own DMA virtual channels.
> Besides, the number
> of DMA devices is limited. For the purpose of scaling, it's necessary to
> support sharing DMA channels among vrings.
>
> +* Async enqueue API usage
> +
> + In async enqueue path, rte_vhost_poll_enqueue_completed() needs to be
> + called in time to notify the guest of DMA copy completed packets.
> + Moreover, calling rte_vhost_submit_enqueue_burst() all the time but
> + not poll completed will cause the DMA ring to be full, which will
> + result in packet loss eventually.
> +
> Recommended IOVA mode in async datapath
> ---------------------------------------
>
> --
> 2.17.1
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
next prev parent reply other threads:[~2022-06-23 3:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 9:34 [PATCH] " xuan.ding
2022-06-20 1:43 ` Hu, Jiayu
2022-06-20 2:08 ` Ding, Xuan
2022-06-20 2:10 ` Hu, Jiayu
2022-06-21 7:21 ` [PATCH v2] " xuan.ding
2022-06-21 13:22 ` Xia, Chenbo
2022-06-22 1:13 ` Ding, Xuan
2022-06-23 3:09 ` Xia, Chenbo [this message]
2022-07-01 13:54 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3504E04299B782C03BF8BCD09CB59@SN6PR11MB3504.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=xuan.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).