From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E806CA0556; Mon, 17 Oct 2022 08:23:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C81F940143; Mon, 17 Oct 2022 08:23:55 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 80D69400D7 for ; Mon, 17 Oct 2022 08:23:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665987834; x=1697523834; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oHIySEdaRdHpZTh+4s29eRvPaEQrIH3uYIp8KdC+fD4=; b=IGf8w2bJltfYScG5SS/s6xLyoBFtas5odIDosUyxha/O6zDAMsmAVz4/ GVKF5NIqU+2sbH5D1APR89c5T2aPI3cU+0brgR83X7NPNRNLoBZEQKy/Y fMBBAu5KfrDW64F5NR+bIqKJiGfaRg+vThONXpZ8mQPi9/4WPyFApi8D8 dZaE8WQAno22kY2WedK/yqS1BwjoHonjBiaUQqk7NneTsQVm8rvfHE0uM 87WCh8MSwWcrluhjDQEyp6GwixIIVB7qHVcFEH6I/JPhVVjqlOAfI/X1l uEH2Mi+yQAZ0CjaLjE9LVePMKQB7y7oFs2IiK5/j/0vesR6UTNQoMpZh/ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="367742033" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="367742033" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2022 23:23:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="717380539" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="717380539" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 16 Oct 2022 23:23:53 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:23:52 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:23:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 16 Oct 2022 23:23:52 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 16 Oct 2022 23:23:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oB7M2VqPq8ZXnCznNY3bpD+qBS974VKgYsr4TtNnEIZhiZOLoBVUGip2yKeFbfKSfgrermcvFkBgr/DOS+jqtrrGVt5BXhlQngP94czvPe3V3oQx3eLsJc3ylWIhumIrL9lIGSEYFvqDZuqwGq3J6dMzAEcxW1sX9bQZI4JbgrCl4jdmbVHwp6RkaoJBqOdn85Fjb9HgQPNZAPM9PzO5QhCcr2+2hBVWfeIDxD1RDXd8ZBdTZzUvgHq06wXRC2Ox76i/VDBf1ZTC6pKwRh0KeS/RloEVBOklSokkSt4kXpToSXOA9iVi2f+sk4fgqnjYqcEReTYy1E53Gns4smr7Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=INBge9oQ17dTGQxVSfxfbTLdK9YMZxzZbjjzi6/XZOY=; b=E2Jr7LpBMb8abKFjLptfpDU/Pz5+hy/auI6U2lXjXgt2mzj1PZu0NiyfegEMz7/tNRamFz3ITLYxJsrKXQeqGBVyC7QvnQEwQPU1kEzZlRWxdbvsQDHKK0NqwrgeH8Ap4Etn4UQOs8cqsME2d1numbC3broouCTRLFAmkWPiDI0pNCrb2Lv7r+SwCAnhSpGa6J+HA4jHmrQfAmIGbSmPk+xgm31iciX3vvwAPf8i/A+ehRJzARQdZkKasTtjj+i/D2++nIVTp2hJDH9O8aG24ksUrYh77iu/++AJcCEhUGoHrHwb/5gwkVz9XqH617/5HP7sp0ELOtU/iF7SrmJ+LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH0PR11MB4935.namprd11.prod.outlook.com (2603:10b6:510:35::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct 2022 06:23:51 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5723.030; Mon, 17 Oct 2022 06:23:51 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v4 4/8] vdpa/ifc: write queue count to MQ register Thread-Topic: [PATCH v4 4/8] vdpa/ifc: write queue count to MQ register Thread-Index: AQHY3uCExfMAa3qzwEuGYGiHN+KLNq4SJB3w Date: Mon, 17 Oct 2022 06:23:50 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1665650674-291949-1-git-send-email-andy.pei@intel.com> <1665650674-291949-5-git-send-email-andy.pei@intel.com> In-Reply-To: <1665650674-291949-5-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH0PR11MB4935:EE_ x-ms-office365-filtering-correlation-id: 8152811e-79ee-4eb2-e2a8-08dab0082864 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 59p4XY/jEV+G5uO70w67Dkua/FSfgCljRw3je70IaT6UzjIm8uvOf/UiqmmqfE9/b1Ump5UNk9M2MQlZ5L439hGRM1KKY8vHd8Jw7ut2ahdtgaInsuG/tqp+S0leNqAB2A+8ViJhqqYNXIxxCFBR7u2fc8S0NUdQq5pW4HWK4URgyr3Y9FIBjpF177kyZ8QlQ7r0la/8Zw1i4kFp9WNkxgLrK7KicYcUap5N4+BiRM0NBVqON6vDLptoMZ0UsjKY3IageRCT1rOODK1Xz/pef0y7nwGOGU0Jf+YEj3+TOqWEmnkLBVEbEbqqE6SAAl1xfs8IJbwJ9VPFbB8w5mpb5PbuNgAMkJ8Ud5gxuywlQLklRT2KnyltNDMXgwEBfSHO7iKbsLXXR9hOnSCm57lhBATQSVSj1/uuJ1ZmIzaJOtYJcBhbhV3v2NEF1gYWxCxEYyktqT/EGXz9sPkoFlM3Sr2/7f130bhwLN8AlkUDZVv72f+Rm3rotpPthaPfAGCmcr03bMDPcpq8npKq+GBX8x/U0+6JnVkNz+5pRZ22iuxSXDsC2j1E4bQtMdZrdYKgO1/W7oS/aAegZW3hPLbb9uI5phgwiGGYyRyTSkD3L4DVAzMXMh/eNQ0zRP9492KyBycIQsVOKRM2/mG7zt8alQocDINv2yYg6RsQfV4vlkB6bNzL5bDNaFpD8Kwu2TXLImUDq5BDjdtnnGFoxQq4ClP9dJE3J1SN4nluwOplGhjWmLIy1TJz+umkewzeO9g3uJaBIQaKpL7LTl/VihpYLg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(39860400002)(136003)(366004)(376002)(451199015)(33656002)(86362001)(38070700005)(122000001)(38100700002)(82960400001)(186003)(55016003)(2906002)(5660300002)(6506007)(7696005)(26005)(53546011)(9686003)(478600001)(83380400001)(316002)(71200400001)(110136005)(54906003)(76116006)(66446008)(64756008)(66946007)(66556008)(8676002)(4326008)(66476007)(41300700001)(52536014)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b0Mle0yBonkRjHZ0YCJEygiiRP8mtnJTn6xU7LPplDRlAH1WDkZsFibJbTcw?= =?us-ascii?Q?wYN+soLa8O8aQ+fXtRzOKf5D5oznWfHgavrEFiawXfyq9vJg1Pao/yrRzLE4?= =?us-ascii?Q?BpLX3LdUTccwuAmCRlxuh/EwApHx7LWSQNTI3H6O0JPbGanS6Eib0zAgT9BF?= =?us-ascii?Q?MN0oTJ3usliHcwAhmoP+sCQnnnQ11gsCUi+/tCU7LZcUnp2Ja9srGgteREp8?= =?us-ascii?Q?PIg+lz3p790GeSI7Vlypmc1RpJpd+6dSYGhjdPemKwKE+PVeFw7xgQzYCHta?= =?us-ascii?Q?GvB8wxWJxKmf1JGPzJdqDpkXXLDM1yd0wnEtpY+HJO7JNsGdIW47M0PQbCSW?= =?us-ascii?Q?0s7v3LvNH7dPEGBgGzzIwc3bbaiT4ojCdp44SZSi1rJmqeulAIcT0f2yANTd?= =?us-ascii?Q?blsivHKamKi1lmkUh5ZPWl2GvTkh8jelQ21QtNUaBJ/TPttzHKuNJCfXWapj?= =?us-ascii?Q?Qq8P6D4C6jLlZYB7cMkZZCnRE2x5AVDwWjOWuybsR3LxTCTMUq3l9GKDP/j3?= =?us-ascii?Q?tdzb6AxhOf24lH+qfZzHXyzHrK6vzDP8/v1kodHJMVrHec0S87GR7sE0Mqm/?= =?us-ascii?Q?axKsqKNyVoa8i4ctaJknYbRYpWv99aJuC8scDZfMXekyfR3g94YoLC7CAWcQ?= =?us-ascii?Q?8Yp9rOLEdTajsFHoLUAwiWtq76Gplpk11oMXwsHEgS8r8ANepwZnvQ/N6UAh?= =?us-ascii?Q?Lg0YgxLM+b48yaJouNDMyGKBUnh7V2doHHSNLc55QvLQb5hYIdDjxyTMY6zo?= =?us-ascii?Q?3nGsid9nVdjbHB49KHMyfEVBcySRI10g7qQe8yTRpDg2XDgDf7FIkbyY8fV9?= =?us-ascii?Q?LszSPoff7MpALCZT6E8cxF88NjFbaUTRyFc69IL7zHunCcSuhNjSTfcAOyD2?= =?us-ascii?Q?1mVvPy0sI2i6GrwV8r9U/jvV5CLN9l1btzxx58HBE5sjyf+BycIm1dIEIhs7?= =?us-ascii?Q?qKfeJJj9eM+HcidvJ20+wo+86nOCMTgIFN6p4LsFlGVFfhxslPIR3DgbgMhG?= =?us-ascii?Q?Yqtdj8W2QnQrq5hI8u8HO37HrT9qltgcDdpS8GN0l67cSuFK0tM0AQidr/PI?= =?us-ascii?Q?B2Hoy25JD306KuqWfCe/jqlG2KeSCDIF7vZYV2t60NyS2h9qWSmPDMqyBv/V?= =?us-ascii?Q?RDAI7V7O3lMnnQZPGWFXSuZ9DtQXw+zCxAG+dNoLSuOdQWQH7Z6HRhkKAMvT?= =?us-ascii?Q?1zgn59RjkA9Q4RTAJvsgSZEU7QgDrpd+uscEZM8nDi5Pa6DOnYWPvdLCbrQP?= =?us-ascii?Q?eaOoMbpWttncOrl12j5EEfauv29RKNKKXbzhYeqMWcFOFSGzeP2BovVpOQHg?= =?us-ascii?Q?uqYEEimFnKHKOq9peJZv1/7nvJb0galU3/mmXE3CwioLfBthZ/8bcX8fng4T?= =?us-ascii?Q?olW5NuwXJZaaJW2dRVD6Q4PBLYGLK0gUWt/4L89DLu4JAjuMUprRrJsWPXhA?= =?us-ascii?Q?QVebhIwbebm+qtdYfJF9GY75Jgc/rwevL4pkJIQT5L0tAlftfz+/SnXjAiuB?= =?us-ascii?Q?99iLqyR/kB4dBjeCoEill3VIRAlSsGjJufhYUUbgXEPC1CHtVJ4tDVbkFDEb?= =?us-ascii?Q?J5TAIRtZ/tI+XUXhXFR2KSJ0k1XWZYcFrirhyJy5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8152811e-79ee-4eb2-e2a8-08dab0082864 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 06:23:50.9804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gFyRhJLtzUZu/QFzDscHQr+YMzvY5Slfx2rC+PZTPsQG1NMRdLzLM1CcwzTzomG3EdDBBc6c3soHBBVFefBnEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4935 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Thursday, October 13, 2022 4:45 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v4 4/8] vdpa/ifc: write queue count to MQ register >=20 > Write queue count to IFCVF_MQ_OFFSET register > to enable multi-queue feature. >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > drivers/vdpa/ifc/base/ifcvf.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.= c > index 81c68c0..60c7017 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -202,6 +202,37 @@ > IFCVF_WRITE_REG32(val >> 32, hi); > } >=20 > +STATIC void > +ifcvf_enable_mq(struct ifcvf_hw *hw) > +{ > + u8 *mq_cfg; > + u8 qid; > + int nr_queue =3D 0; > + > + for (qid =3D 0; qid < hw->nr_vring; qid++) { > + if (!hw->vring[qid].enable) > + continue; > + nr_queue++; > + } > + > + if (nr_queue =3D=3D 0) { > + WARNINGOUT("no enabled vring\n"); > + return; > + } > + > + mq_cfg =3D hw->mq_cfg; > + if (mq_cfg) { > + if (hw->device_type =3D=3D IFCVF_BLK) { > + *(u32 *)mq_cfg =3D nr_queue; > + RTE_LOG(INFO, PMD, "%d queue are enabled\n", nr_queue); queue -> queues With this fixed: Reviewed-by: Chenbo Xia > + } else { > + *(u32 *)mq_cfg =3D nr_queue / 2; > + RTE_LOG(INFO, PMD, "%d queue pairs are enabled\n", > + nr_queue / 2); > + } > + } > +} > + > STATIC int > ifcvf_hw_enable(struct ifcvf_hw *hw) > { > @@ -219,6 +250,7 @@ > return -1; > } >=20 > + ifcvf_enable_mq(hw); > for (i =3D 0; i < hw->nr_vring; i++) { > IFCVF_WRITE_REG16(i, &cfg->queue_select); > io_write64_twopart(hw->vring[i].desc, &cfg->queue_desc_lo, > -- > 1.8.3.1