From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39FE9A0556; Mon, 17 Oct 2022 08:35:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27B16406A2; Mon, 17 Oct 2022 08:35:49 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 43E47400D7 for ; Mon, 17 Oct 2022 08:35:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665988548; x=1697524548; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=nSqBJ4VLEb5mfBkcSyeIs1JjIvg0+A9T9+Cb5yQMvS0=; b=j/gwJuq0IPqhCG6rySgzpW/t8zjM13kREsUHx3b+A21r5zg9zlWUOCU/ gV2Wid/TTe5s/82WwWiGw5214K76iiXXSIqUhTEid5QrvItK2v/qBUBmb SLPLPhjrvKc1shm2vo3eNi/m5mU/Z3nnLZWcJkovZHLKawv8G6ObkGhm8 dLLkkJVL5JF3t++AEyYTKFa3v7CuvYcmnELrcPT/aPuLfj9jRIvIEIAC8 cpuuk8X8od6RB9GvjLBIyIOkn5On1iDike+2qPjxKySEawdN7VYAM820R kJLr3clOGwaJDIkPqNSvS43lFoAk7IAGfITGHFG1SEBAUHUAPNLMaKllQ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="303335321" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="303335321" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2022 23:35:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="770655428" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="770655428" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 16 Oct 2022 23:35:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:35:17 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:35:17 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 16 Oct 2022 23:35:17 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 16 Oct 2022 23:35:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XN+vY4zBzNw+GstKZ3rrHf9SqY6Fn7lWAd7SPsq9hT9bc2nHsGY2ofIvCd1ZHs85+KnC8Feb9SmDBvRTffdL/OH95GjlogNnW3XL92WPn2Nmof5tl8b7bTdVsD/BIZeeut9WDc61QEE4aJAKuI+0Ib/Ijrv46v6a2WaN3G7ctBqj9a+0U9v2cux9Q5ByXC260QPd3mOGo7zuu190iHpB6IpfFM+fSU0D28nufDuDa1IY72BO1gUcVlIJNPJAbe8s1uJAn6H9IqAPx+dop1qLHCVEQ1sTbmM3QxIQNRKqddtzXTtUGKArKmhQUa1J2/QAYdUtYXrHo0LCFHOdmSe7Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l6KcUANqya6eiBRCjFXN/FJBxzNowTnUQhHQLk4klDk=; b=PhPBJv0+mk7Xkz079kEWy6m7CiFRrRVAERKmjz7lmHgk3zbaVR3W0hJ0JAY1XOalpINSd4914U/lqL3kATe74lIidYCuMIcojDDvVtXuCP+PCrYxxdelwewx2AtzoDYIYAwFgKR6BDiUfKnhFXx+Tj8luscjwNpm2hnINgc7QPJelQGi7zFCFXRbcU5de03fX+M8LEExOUXVT7N6xB2EHGFApOf6ss+MwTsAPIuUpGIjke+XbntNAKc9HNY40DW1a48siIe5NbZvH8PqjNxki3jdtrehPZlMucJnoMkEcws5bScD7ESljNuG08zBGU/ni9R7OR0iAOxIrrZ2n7bNZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by CO1PR11MB4913.namprd11.prod.outlook.com (2603:10b6:303:9f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct 2022 06:35:15 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5723.030; Mon, 17 Oct 2022 06:35:15 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v4 8/8] vhost: improve vDPA blk device configure condition Thread-Topic: [PATCH v4 8/8] vhost: improve vDPA blk device configure condition Thread-Index: AQHY3uCKDdt93ksdE0iFWtrcIu1sAq4SJ0Tg Date: Mon, 17 Oct 2022 06:35:14 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1665650674-291949-1-git-send-email-andy.pei@intel.com> <1665650674-291949-9-git-send-email-andy.pei@intel.com> In-Reply-To: <1665650674-291949-9-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|CO1PR11MB4913:EE_ x-ms-office365-filtering-correlation-id: fc61ff60-09e1-47a5-14ae-08dab009c015 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eAvNRfIJg8SoqU8ssNqY++THZMXSdI6gjYueIoHZVwwX6Fk8EltRIDblYLeMZxVqnSmt4WN1tBEJt5VvRzBEyMhV9/BOujq2rEllXnS49m9liZ9BoPBz5fz5iu+gJB7RnO+z+2jQtUW+OJvKIvtKHuakfCWDqmaGQ+X8Niq7pWFmMP8UcLPz7iXXlMw88zIhexaLCkrlEgBQBx46KWpaZui9xgjBDJyJ8KiJ1V6qgjlje0dJBOOr6CFemMqleE3bPu7BQqmUDue+tIySF5BdiOm24f8VSKM3bOfGF/tb/nMa0UG9m7n/p/FwZA6JcnLXbd6lqMN05K2H8VNglJwbSo6Odfoqbx+5tQLkUL41xxWTv29ObgrMDt0rS5aVvlpv86GVYX+X+OFRvorcdQxsaRVEKzQcf+Mpw3/NzEeNuHIKX1O48yZ0UhJktYwvX2wq7wI/yHng/i0tbdk4mvslv0Z1bW6VQTOPexdpuNyieszeJyVlsuk30UGazvPIV6A69IoDWtQ71xxSzE2GhF34dLKnO36BHRUpzMcXQVpCyNQvdy2tkcJUOfHALPyGlElb8XgUlAqtP5ncxCNpTReyY/ZTl/HRXvCYXrVKQSDjXYnCM/dHwZekTDOC9bmo8p16WsdmSBWL7GIyqqXaUwXmXRJGiBUljvc+J2rz+vbndJkmDOMcuqZhJe/OFC+PjR6s3VsFchvM+rnPJEhKNHkiBUrRBDzwYGg58fkVBdL0iMLNbmCvZJ6pVSmmgFVoOTyhDpS8CxMkoY/wZbGKKlb9vg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(396003)(39860400002)(376002)(136003)(366004)(451199015)(38100700002)(8936002)(52536014)(5660300002)(82960400001)(122000001)(83380400001)(33656002)(86362001)(38070700005)(26005)(9686003)(110136005)(54906003)(186003)(55016003)(478600001)(71200400001)(316002)(4326008)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(41300700001)(8676002)(53546011)(7696005)(6506007)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AYYHyTfz0aTo73EK2vI0WZtpG0yZrA8IqRyrOh/o4Y3LCe6Gu3wc8NF3Lgiy?= =?us-ascii?Q?FJ12fcZnjhfjjnnaZEihenrnVSaRYTL3eIR/s7dfYpC21s1YZnk5O7zvge1C?= =?us-ascii?Q?YsFB60KeUOsNDLg6VcgQtIMIE+C/oRDWe5hXS1ef4CtXaSvgTBK49u2sFjZF?= =?us-ascii?Q?mtJTlfad4PgN0aowmzFPupdh44os7L0hrq/bvgOHjrQ074lLM0JprGPyWmmQ?= =?us-ascii?Q?+s8gfF5Y/GSfQy2IzF2IqBOrwckZotwYnelrICwvgRCCOM0J14UJXXmEULEJ?= =?us-ascii?Q?ZwgNfNV/vlCNBINxhtEB7nAAzVBNBY0jTcELsx1iTRWZ68GW9OsGExJqu4pE?= =?us-ascii?Q?fyWNKFWvGq+SoC9sDEUzLeDKZJNW8zM7zMvtKHk7tqZDCeY2/W48gmW6W1Dv?= =?us-ascii?Q?yMCIV0P1QLAuIj/ZU50XSbopzw6FWv9iAbQDwlyRRaTzoAYZBlVU49EJE2pj?= =?us-ascii?Q?N6ro2B6xAvOm0kad39acCF1ILi8Q8ore3c4ILHh0wu3lujreVyhgr1b0DnFr?= =?us-ascii?Q?sczbas+f2Y7BEtWRdPnXiz3s+Ko8mY7eYL13c9wNOj/MZLoLEH4d+jKN1sRs?= =?us-ascii?Q?m82nu9iRAd9uadISR7+aRabxuY1N9iPiEXliT9CAPegLFZYq333GFq+dk3n7?= =?us-ascii?Q?dScWQhO9yP0rLTo48mdULKwfj7iGWdBJfhxKdM7tE0pqgb5EUyGlTW9UcZEx?= =?us-ascii?Q?dnKLmc2+UR68WgEPcm78yuT0XN0zjFIKTtE8jOA8Jjgj0fo7HrZtaodcvrGW?= =?us-ascii?Q?IpiF10uk8wkx+Yunnwo082ll+vDrMIdRHJWVmoxoUwNXgaezNKvAv7PAclXi?= =?us-ascii?Q?hvFh50pJU7BckHv33OUySVA2sxR1G7x3ocX8LOoShc8uBS2Bkf7oZuPKM7Vg?= =?us-ascii?Q?EOogbLTceeR5wRiWWsKbwDxatgXpga9zMrW0KvQQqJ7qOHzERUz+BlgPzGLs?= =?us-ascii?Q?lc+5CMUD12ek/ZYO2PIfZ77KKYrmX0Xqar28dNkZ2l8f6ZTLrLN7HuI/MgcL?= =?us-ascii?Q?xWM7+BqBElLCBr/2gDd7YVwM+X+6y2Op3tEIjia8A56Vog6t3qqvxvHJjJ3t?= =?us-ascii?Q?9tFUXdUIDjRVtp2ghCnAFWJiktMMGeYJKMohKuZVIlsAbYLDKMI6SCfXttUa?= =?us-ascii?Q?EOxDWEQG60phCCSbDxpXOSR83jgQm5hAqt6bkl6Kqoz1O/JOPxP/+ZgyOIoz?= =?us-ascii?Q?vUEtp67YAbY6DKky8TM5+ph9D6vEXRY+NcnU7f/ZxZWptroyl7wIcUKqUPBc?= =?us-ascii?Q?X9ln6gpaFofUJyHJiuKTSOJ2BlkgPoRW9zTqYz78bcq02+hlKztnX/0sw3fg?= =?us-ascii?Q?CT+No/9Qha+9ZXowqJMvOY2/SZdL+u4IRJ/xbLb8BagmRm1rnV/TC+JjD+Nh?= =?us-ascii?Q?a/qUfV99SGikp29i92whSAyIUFU8HSbWy3mcihoT3JS48fhqnF1sgdWjdqdB?= =?us-ascii?Q?waj4YDIMhqHfMFicpEXeRPWywqtkwdCkwzJ/k4yfm8pp3mIxTex1y18lUDE9?= =?us-ascii?Q?YNccXvX6P3n/n4bz8UU4ffxCjeD8ma3udjhvEfPoFCZxLIfHhhCkpna5l69T?= =?us-ascii?Q?WTtDN8KFore4TsJM13NKMsePe5eVY/c1nai9SLkR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc61ff60-09e1-47a5-14ae-08dab009c015 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 06:35:14.9679 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wQSAUOBm+rfJbEC4YBw47ZfkaBZB7igZOJ4dHdQ/DK0mH0aEtPHcylSGF/qTC0SLQg6W1IXO/RMzoj3DC1aK3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4913 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Thursday, October 13, 2022 4:45 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v4 8/8] vhost: improve vDPA blk device configure conditio= n >=20 > To support multi-queue, configure device > after call fd of all queues are set. >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > lib/vhost/vhost_user.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index 0509025..3ede83f 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -2965,6 +2965,7 @@ static int is_vring_iotlb(struct virtio_net *dev, > uint32_t vdpa_type =3D -1; > uint32_t request; > uint32_t i; > + uint16_t blk_call_fd; >=20 > dev =3D get_device(vid); > if (dev =3D=3D NULL) > @@ -3191,9 +3192,15 @@ static int is_vring_iotlb(struct virtio_net *dev, > if (!vdpa_dev) > goto out; >=20 > - if (vdpa_type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK > - && request !=3D VHOST_USER_SET_VRING_CALL) > - goto out; > + if (vdpa_type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK) { > + if (request =3D=3D VHOST_USER_SET_VRING_CALL) { > + blk_call_fd =3D ctx.msg.payload.u64 & > VHOST_USER_VRING_IDX_MASK; > + if (blk_call_fd !=3D dev->nr_vring - 1) > + goto out; > + } else { > + goto out; > + } > + } >=20 > if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) { > if (vdpa_dev->ops->dev_conf(dev->vid)) > -- > 1.8.3.1 Reviewed-by: Chenbo Xia