From: "Sebastian, Selwin" <Selwin.Sebastian@amd.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v3] drivers: add a HW quirk for register definitions
Date: Mon, 20 Jan 2020 07:14:16 +0000 [thread overview]
Message-ID: <SN6PR12MB2704854DE0F30D3BF17CAB5F8D320@SN6PR12MB2704.namprd12.prod.outlook.com> (raw)
In-Reply-To: <ab8e8feb-aeb2-246f-2c51-c23a6b5a16ce@intel.com>
[AMD Official Use Only - Internal Distribution Only]
Thank you David, Ferruh,
I pushed v4 of the patch with changes.
Thanks and Regards
Selwin Sebastian
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com>
Sent: Tuesday, January 14, 2020 6:48 PM
To: David Marchand <david.marchand@redhat.com>; Sebastian, Selwin <Selwin.Sebastian@amd.com>
Cc: dev <dev@dpdk.org>; Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] drivers: add a HW quirk for register definitions
[CAUTION: External Email]
On 1/14/2020 12:35 PM, David Marchand wrote:
> On Tue, Jan 14, 2020 at 12:58 PM Selwin Sebastian
> <Selwin.Sebastian@amd.com> wrote:
>>
>> V1000/R1000 processors are using the same PCI ids for the network
>> device as SNOWYOWL processor but has altered register definitions for
>> determining the window settings for the indirect PCS access.
>> Add support to check for this hardware and if found use the new
>> register values.
>>
>> Added a new routine rte_pci_search_device to pci driver to search for
>> a device.
>
> You can already iterate on a bus devices.
>
> struct rte_bus *pci_bus = rte_bus_find_by_name("pci"); return pci_bus
> != NULL && pci_bus->find_device(NULL, callback, args) != NULL;
>
> See:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> dpdk.org%2Fdpdk%2Ftree%2Fdrivers%2Fbus%2Fpci%2Fpci_params.c%23n38&
> data=02%7C01%7CSelwin.Sebastian%40amd.com%7C35db24f051c546e2d13b08d798
> f438b5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637146047002796925
> &sdata=6wBRIab3588iwCsgBV7JJ%2FjcXU5no1mKQtHxbFxJJlc%3D&reserv
> ed=0
>
Nice, this looks better approach.
prev parent reply other threads:[~2020-01-20 7:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 17:30 Selwin Sebastian
2020-01-14 12:30 ` Ferruh Yigit
2020-01-14 12:35 ` David Marchand
2020-01-14 13:18 ` Ferruh Yigit
2020-01-20 7:14 ` Sebastian, Selwin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR12MB2704854DE0F30D3BF17CAB5F8D320@SN6PR12MB2704.namprd12.prod.outlook.com \
--to=selwin.sebastian@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).