Re: [dpdk-dev] [PATCH v2] net/axgbe: add support for Scattered Rx

["Sebastian, Selwin" <Selwin.Sebastian@amd.com>]

[AMD Official Use Only - Internal Distribution Only]


Thanks and Regards
Selwin Sebastian
 
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com> 
Sent: Wednesday, March 4, 2020 10:44 PM
To: Sebastian, Selwin <Selwin.Sebastian@amd.com>; dev@dpdk.org
Cc: Kumar, Ravi1 <Ravi1.Kumar@amd.com>
Subject: Re: [PATCH v2] net/axgbe: add support for Scattered Rx

[CAUTION: External Email]

On 3/4/2020 1:44 PM, ssebasti@amd.com wrote:
> From: Selwin Sebastian <selwin.sebastian@amd.com>
>
> Enable scattered rx support and add jumbo packet receive capability
>
> Signed-off-by: Selwin Sebastian <selwin.sebastian@amd.com>

<...>

> @@ -249,6 +249,10 @@ axgbe_dev_start(struct rte_eth_dev *dev)  {
>       struct axgbe_port *pdata = dev->data->dev_private;
>       int ret;
> +     struct rte_eth_dev_data *dev_data = dev->data;
> +     uint16_t max_pkt_len = dev_data->dev_conf.rxmode.max_rx_pkt_len;
> +
> +     dev->dev_ops = &axgbe_eth_dev_ops;

Is this assignment required, isn't it already set in init (eth_axgbe_dev_init)?


Yes. Removed this line. 
<...>

> diff --git a/drivers/net/axgbe/axgbe_rxtx.c 
> b/drivers/net/axgbe/axgbe_rxtx.c index 96055c25b..57e2bbb34 100644
> --- a/drivers/net/axgbe/axgbe_rxtx.c
> +++ b/drivers/net/axgbe/axgbe_rxtx.c
> @@ -307,6 +307,152 @@ axgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
>       return nb_rx;
>  }
>
> +

monor nit, there is additional empty line here.
Fixed it.