From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7DE042601; Thu, 21 Sep 2023 05:00:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79F1D4026D; Thu, 21 Sep 2023 05:00:08 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 4C57F4014F for ; Thu, 21 Sep 2023 05:00:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695265206; x=1726801206; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=EgAPoVABCDxQc6iFOf/xFC9fdbXHcVio0kG/OmRg8G4=; b=Lfug8buN7Ifv5gu+RA2kcOZJXUHFI15I9Wgky2sXZ17CZKp1aMa3C3qc ZFaclrbn1of4sdvpJZjdLPamxZWRAZjDtuKHTYoBvLRd+0tuPyT9o/WC9 RHVm6W3b59Y0IOEwhVvKpzq6YdsAr+Bd/qez0GGiK9OL5POKB1TB6/pth kwfUHjtvY2zVCDNcJKSINX8E3HxLvkmXFtudjMKkfz0ZUOASaR4Ujyy6/ HTTe1Va+Ibo0RfEp/f7nv2DXrK3l1d+kersiXcocVEPtDrsBv3nCqytUu MULgqscqpak7q9MNMiXu5C+gQ+T64pKs0WIrnb0VZaStxmEAsl4yHDuAF A==; X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="411355127" X-IronPort-AV: E=Sophos;i="6.03,164,1694761200"; d="scan'208";a="411355127" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 20:00:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="920556473" X-IronPort-AV: E=Sophos;i="6.03,164,1694761200"; d="scan'208";a="920556473" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Sep 2023 20:00:04 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 20 Sep 2023 20:00:04 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 20 Sep 2023 20:00:04 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 20 Sep 2023 20:00:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LYsT6QkBCWO0UIrngvBSSkIpvDv+BYJecpwjj8UMmMXM3nYh0i03/TTzaMFKc2rlxUI2951rwyuzvdFjp0aIUOSH0vzjOQ/NHBxH380suz9xUyVHZEfeSbBqwNVALLCmfh613kE4bNZoyOn/XIRxttXxzpgIcnuAYOZYb1Gfs1AeF9JdQT/YmYfjLfH8mLHf0oedJXjiOBTKSPiQ3F4oChxPNjcROvEek3glOeJsA5Le9LNcoKkfChXbXoqokpWMlgp9pZULbTZ2PaESL5LgPbs7GPhvXCv8aL2tsTWP20d1drP7qGy5tr8k6nhZwH7OB65scC5dLEp5iMXC4W+ubw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oh8+xP8UNveASls7BN4/ikU5uu9edF+LK02tR+EWioI=; b=XBS3lwipqwbbGg6R9K7pE0MyCNEGk5I9gc6tussyqtJvjkh97ZwJcaReixDdz7nnylHVDlwaqhG92fEIN6fJLlVBowsFSG6EAJuBhD5In2s0j9a8qEJALFJ+xPLfIpoLL6ThR48a6q67TGaAzPK0ZZuxo9TIIlJLOxc6bzgQgxu2ScG2FLgkhWr8IAC4L4xX7+wh4E7Xfn2NSmwBkHqRIEp1JETUv3aFClp1k+wD9wOzvZP2ghlWzL67nhZbQhWbL2cIGYETJ0Uz5iLFQKH1X8VUadWcbXxRRPTZ3Gj/XKjF8uMDzsf263ntoK1lEzjgv413EmQ7Qb0rJ66PaWuV5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7019.namprd11.prod.outlook.com (2603:10b6:806:2ae::22) by IA1PR11MB7176.namprd11.prod.outlook.com (2603:10b6:208:418::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Thu, 21 Sep 2023 03:00:01 +0000 Received: from SN7PR11MB7019.namprd11.prod.outlook.com ([fe80::7f2e:e0a:ddb2:753d]) by SN7PR11MB7019.namprd11.prod.outlook.com ([fe80::7f2e:e0a:ddb2:753d%7]) with mapi id 15.20.6792.026; Thu, 21 Sep 2023 03:00:01 +0000 From: "Jiang, Cheng1" To: Amit Prakash Shukla CC: "dev@dpdk.org" , "jerinj@marvell.com" Subject: RE: [PATCH 1/2] app/dma-perf: skip support in dma-perf application Thread-Topic: [PATCH 1/2] app/dma-perf: skip support in dma-perf application Thread-Index: AQHZyTADK4tjkPjZhEa3fBATLDZZGLAk2+qg Date: Thu, 21 Sep 2023 03:00:01 +0000 Message-ID: References: <20230807130621.2023043-1-amitprakashs@marvell.com> In-Reply-To: <20230807130621.2023043-1-amitprakashs@marvell.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7019:EE_|IA1PR11MB7176:EE_ x-ms-office365-filtering-correlation-id: 8edd9d43-4515-4235-1428-08dbba4ed8d2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2VcL6hfbtwbMZvU8N+73qDmNrCwcVIBG0NQ88WRI4VOO/bP/0DUxLnB0F+wzQLW5dtbu/frXlgqcnf1lLFWJw1H2QRuo+oeZwYOKAjP3srjyeDDrjBDXSlQCI+EWieds8IGApPcVKA1N34w/QC8pzqJ1HAnMHOq6DLQsyFaIyChg5lfGOiLknmJvQ4V3GjlUTXwb+LnRfLDmLvwoTes9CZiGbwJPowAjejV2nPFPAyYTLND7nd3Zi8bpSGvfh+BTuxMag7t5koEcYp85B0DZ93Xgk4J5UmduY5nRzaKEoCt4al6dhwkNw1yxCjke2khG7h480KAyrNvOli9s80qjb8ibCJrk3oYtpmU2NrnQuXCwwM3jgiI1X1NCBXx+cShEKYmVPY7cnv8B3Ljbi8xQnzWk7RPundIklJKNmEa8tZGKaU5tBP7a8mke0c0+0O5eNfkPrHcWAT7SLGUjn150UCAJLkDWV8IEA8jLcx3hcDv8jozQHvVS3fcPfMqbgxKATS9B4AGSs/5FN6LFn6VbHbaG4csC1gcPhbkhBCVOKdVy5DHFD37lyijE61Zt1iisuQv89cgAGK3IgdL6wcsSITWOnAfvFFNx59foFs1VNhNxDOgGk40Oy22S8BZCjRbn x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7019.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(39860400002)(136003)(366004)(396003)(1800799009)(186009)(451199024)(55016003)(9686003)(53546011)(82960400001)(2906002)(7696005)(6506007)(26005)(71200400001)(5660300002)(76116006)(8936002)(33656002)(4326008)(86362001)(52536014)(8676002)(316002)(6916009)(66556008)(41300700001)(54906003)(64756008)(66946007)(122000001)(66446008)(66476007)(38100700002)(83380400001)(478600001)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jGQkGoy/iOaKeioyaQrb5hoJaLp+JZ6Ljr6AYvyzkKxEUirlyGTytGYEtgLi?= =?us-ascii?Q?kyV6EfytqEP8btZtU+fPtaDIWyZMwbVKQhQ8msriIueGRdf4AwRGyobouuKr?= =?us-ascii?Q?svVP68xt1gbjRDpt2ezDFn1949twVVkfVHFNMCp5/Y+1wjBja2dZX3P2HLwu?= =?us-ascii?Q?KoR5tH9lW2bh5dq5Pli26aJH2NUrmvNXbmIOgXC8Z1WJbfOGhzuP2W0diXFy?= =?us-ascii?Q?9WnVBBv5YbREF6H1oBeNp5kccin+KuGD8ur7C1mmNUFZFLZ572koU/4g/zML?= =?us-ascii?Q?+1USI8GLevxWrtA+b5M36IGMLeo1QYKZ4A5Dc4KHDz194I9t8WkHc5FlLTuI?= =?us-ascii?Q?A5NBbr+Zh3xf5zkDgXGCFQd7MxXKNzieRZcrklpgzi1lXOlkoeBiQUUZJmu3?= =?us-ascii?Q?f9gl0LABz+1L2AQnQ1nQxOCXita1yz1EMnYaX+tDxOIXRT4ZEaotFlz7+UHS?= =?us-ascii?Q?gf2Zy4R2b1F2TQWQ43FrfPcDTYXFO6HXVRlJDgy7QaBlOh4z9bIBbs3mKT1C?= =?us-ascii?Q?nrzL1I5JhWs+y4PeUOGoX5f34vhuBIOVou9DJ16zdVDxlXiXBN6FgYcMj+Z6?= =?us-ascii?Q?hPmtEi0eRxmJO/B2HRqsTUug4Z+kGATJxxUuG/2/vQupD2lZ7CRTfQc7ATCd?= =?us-ascii?Q?b4t0yeX5kcsZlNSHE09eJ+UKWjSZBx510dtpNjztrQ0SGXiRnu5+UbPh2p0V?= =?us-ascii?Q?08PIp2TZqS/HVxM8hPPukl2sX1F6XlVCkB3YZlTI6VlYVb4wFPZCpzvxc1Yn?= =?us-ascii?Q?0gQOyWX3pZrFqfXHEr7CWiM8qvZ+8A/hH03pHkErD4lKbBA2hosqF0Bv5svB?= =?us-ascii?Q?nxmoxJR5X16hlqly1qJBxXW3nUYv5+A0yS8NiApnR+bZtHZm6cRFbOL5cBVp?= =?us-ascii?Q?t+a+P9wCJQPzMCqMPVqlxQF5VJgxAYpWNxrhKMU1TSMhDmcmJIKy2Eg1UDGU?= =?us-ascii?Q?mwWu+JO0QHqRMrBjGw00WmwbS1hY9wGZY7gpCkR6udS2P0VvmyAUi67LDzsx?= =?us-ascii?Q?MzPcpst7BeL1xZhTRvW2Q+d0iS+BJpBTeNTZXTNwcGNhia70IGgRSoeXWMsg?= =?us-ascii?Q?Uy8EZSPGs9XwWRQZHrplIxaWtUSFKTtGjbyRelf6oENZ0hugCeSWhp3rAR/s?= =?us-ascii?Q?w0eFz09/9yySEmyXTVSOfBfp7+nFjsx5FXtbA3sQx9ja7r3r9It22JgjCEFN?= =?us-ascii?Q?r63Qg5O0Q5Pf3w+NAN/NBALt5to0EJpLpn37kveeoeodOhK5QB2SA0KpCNWO?= =?us-ascii?Q?8zKIMH76UrjRH/twlLhGiGI4C7br0MEget+lS5HkEZ6GnnxZv2HEsL8BFgJz?= =?us-ascii?Q?KVxRHCYiRPsBCLPW8zu0+rmxn+pHL90/F9zGyCisoR/SjtyypwDSXCO5N51L?= =?us-ascii?Q?BplaFl/AN11s3yjdjEaT8c64uixepkxJzNnyS69+XeZnBelP7AyF4pRQkKCJ?= =?us-ascii?Q?8o3LEZhuZ5GzHAkkCPwKhK3YDlT93JX8r1vt4Xd6obeAy4p1/7tfHd4L0WIq?= =?us-ascii?Q?BC41SrdcB/+yLYQyv8n3PK8CUUprt1sXIxQIYJpyrBVr14rWv9svpc7CLvje?= =?us-ascii?Q?mqvVx6g+LqWVidv250SpMxGI2OqIWWxz63m0iCoq?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7019.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8edd9d43-4515-4235-1428-08dbba4ed8d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2023 03:00:01.0834 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yawZU8duuXx5o82JpgrUp+q8UfvIS3/pUBEw1TKkdi8xFlANZP78PrQVIQW1sjyFt/TStYyHp2wmZvhXWhpIaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7176 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Amit Prakash Shukla > Sent: Monday, August 7, 2023 9:06 PM > To: Jiang, Cheng1 > Cc: dev@dpdk.org; jerinj@marvell.com; Amit Prakash Shukla > > Subject: [PATCH 1/2] app/dma-perf: skip support in dma-perf application >=20 > Add support to skip running a dma-perf test-case. >=20 Sorry for the late reply. Generally I like your idea. But I might not be able to review in a timely m= anner, as I'm leaving Intel. If you're in a hurry, you might need to find someone else to help with the = review. Thanks for your work, Cheng > Signed-off-by: Amit Prakash Shukla > --- > app/test-dma-perf/config.ini | 2 ++ > app/test-dma-perf/main.c | 23 +++++++++++++++++++++++ > app/test-dma-perf/main.h | 1 + > 3 files changed, 26 insertions(+) >=20 > diff --git a/app/test-dma-perf/config.ini b/app/test-dma-perf/config.ini > index b550f4b23f..4d59234b2a 100644 > --- a/app/test-dma-perf/config.ini > +++ b/app/test-dma-perf/config.ini > @@ -36,6 +36,8 @@ > ; If you do not specify a result file, one will be generated with the sa= me > name as the configuration ; file, with the addition of "_result.csv" at = the end. >=20 > +; "skip" To skip a test-case set skip to 1. > + > [case1] > type=3DDMA_MEM_COPY > mem_size=3D10 > diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c index > e5bccc27da..61260fa072 100644 > --- a/app/test-dma-perf/main.c > +++ b/app/test-dma-perf/main.c > @@ -320,6 +320,7 @@ load_configs(const char *path) > const char *case_type; > const char *lcore_dma; > const char *mem_size_str, *buf_size_str, *ring_size_str, > *kick_batch_str; > + const char *skip; > int args_nr, nb_vp; > bool is_dma; >=20 > @@ -339,6 +340,13 @@ load_configs(const char *path) > for (i =3D 0; i < nb_sections; i++) { > snprintf(section_name, CFG_NAME_LEN, "case%d", i + 1); > test_case =3D &test_cases[i]; > + > + skip =3D rte_cfgfile_get_entry(cfgfile, section_name, "skip"); > + if (skip && (atoi(skip) =3D=3D 1)) { > + test_case->is_skip =3D true; > + continue; > + } > + > case_type =3D rte_cfgfile_get_entry(cfgfile, section_name, > "type"); > if (case_type =3D=3D NULL) { > printf("Error: No case type in case %d, the test will be > finished here.\n", @@ -523,6 +531,21 @@ main(int argc, char *argv[]) >=20 > printf("Running cases...\n"); > for (i =3D 0; i < case_nb; i++) { > + if (test_cases[i].is_skip) { > + printf("Test case %d configured to be skipped.\n\n", i > + 1); > + snprintf(output_str[0], MAX_OUTPUT_STR_LEN, > "Skip the test-case %d\n", > + i + 1); > + > + fd =3D fopen(rst_path_ptr, "a"); > + if (!fd) { > + printf("Open output CSV file error.\n"); > + return 0; > + } > + output_csv(true); > + fclose(fd); > + continue; > + } > + > if (!test_cases[i].is_valid) { > printf("Invalid test case %d.\n\n", i + 1); > snprintf(output_str[0], MAX_OUTPUT_STR_LEN, > "Invalid case %d\n", i + 1); diff --git a/app/test-dma-perf/main.h b/app/= test- > dma-perf/main.h index f65e264378..be89cb2b65 100644 > --- a/app/test-dma-perf/main.h > +++ b/app/test-dma-perf/main.h > @@ -41,6 +41,7 @@ struct lcore_dma_map_t { >=20 > struct test_configure { > bool is_valid; > + bool is_skip; > uint8_t test_type; > const char *test_type_str; > uint16_t src_numa_node; > -- > 2.25.1