From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 954BA423BC; Fri, 13 Jan 2023 04:17:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6745C410EF; Fri, 13 Jan 2023 04:17:05 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id B7564410D4 for ; Fri, 13 Jan 2023 04:17:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673579823; x=1705115823; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7r/m0Wp5qRG5BQ73hz3wQo9nPc60bJNvqhFoL1tXo1E=; b=dpA5xU4p/+u28ghinFnLoWHYBKKBRuCfc3CS0cqhumMQwnHmMeIMh8Kl FxGMaw5Vb9Ja1Wnztj9jWjLhfpAClBIOLbJc/H50mUqEOvOVx4rKXJyEi yYKy6/zBo8GR+DLFCx8Gqpv89HqX1WnTM84OyicD3ZXj5A8dh5j8HVnXz 37iYMMXLeKYWosVGCk+Hp/Q6Lm/30toqTcLdQ2mp8mAlVAMEl1TkiLnby vQYL4W7en34XVWiTfvmOg/Lnod+e8l9j3K1JyGFhatOKYadU+R1IwvEpN +MpYB4lATvoZwQG7rfVtXBMt9F3xWW+l1tXegL/tWNPXM63C4ZZuJHr9q Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="410137692" X-IronPort-AV: E=Sophos;i="5.97,212,1669104000"; d="scan'208";a="410137692" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 19:17:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="690359924" X-IronPort-AV: E=Sophos;i="5.97,212,1669104000"; d="scan'208";a="690359924" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 12 Jan 2023 19:17:02 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 12 Jan 2023 19:17:02 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 12 Jan 2023 19:17:02 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 12 Jan 2023 19:17:02 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 12 Jan 2023 19:17:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KGZnQbiGWfTXldxQIoE1TviIEIA496ARCiP4mhHTwYPi4VkRxJ44Kgaxd4zeU/OHbxM80LBSwSZCf9LYCVFNnH/biiCsw84ty9+3sx6Aen8cynir+6sOAL5bXfwvEZhPYqp7g15zWfm7VYNtYR3Hmf/lhzSM6HOzKDlDufwR+k2MGFmli5J3a1pz+LBGmv+FY6RBFcTt5pHd++m69FHHTWZhCfIFr123LjNACp4IxGa/24ui753WdagzHd2wf65j3gUIfwrjUqbvQ96ccZUfZDmwJ9FEkbY4N+4yExRd82BMgUJZGmZCOY1r2scUj2+bNDowDmLIPwtykFomswIqMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pbDRApX9iWkG+MTLdozicxcWDwlUIySqwhJnoP0tVpg=; b=E43pVac4gRdz5IXyWNaJmSboaaAw8VkUoVHLL1lfIybcuFNDss1ODtyVUVUw75jDzsntcpfnpxja1iYK8tbIIa3qBKbQ73/Sx8yKvP5rmp64zIqYg4Nz2hfsxSOaUhg4dHBQgMeqODwp/maf5ur51T0rO4GTLoZd3Z+MBp/kYJkFSYdMUsufLpT3YMm444J8jqhDacr0FNpHSAcidY4BHvHv6pF6kDDcMK4sHudv9klRFaR5x+9wvMLNA+yH9LEGo0+7omgO5NK2uhNVUo3j2XIm0OKlavD5y3MRciTFiTOLUwTqJp5jSziqc+jPU70ubI4QXTRX/9ZSCKphN5O8Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7019.namprd11.prod.outlook.com (2603:10b6:806:2ae::22) by SJ1PR11MB6179.namprd11.prod.outlook.com (2603:10b6:a03:45a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Fri, 13 Jan 2023 03:16:55 +0000 Received: from SN7PR11MB7019.namprd11.prod.outlook.com ([fe80::bacc:6241:115b:b26]) by SN7PR11MB7019.namprd11.prod.outlook.com ([fe80::bacc:6241:115b:b26%7]) with mapi id 15.20.5986.018; Fri, 13 Jan 2023 03:16:55 +0000 From: "Jiang, Cheng1" To: "Ma, WenwuX" , "dev@dpdk.org" , "Coquelin, Maxime" , "Xia, Chenbo" CC: "Ma, WenwuX" , "stable@dpdk.org" Subject: RE: [PATCH] vhost: fix net header settings in vhost datapath Thread-Topic: [PATCH] vhost: fix net header settings in vhost datapath Thread-Index: AQHZH+ZkuqZsaZWmmU2Raovl7oigwq6buOXw Date: Fri, 13 Jan 2023 03:16:54 +0000 Message-ID: References: <20230104023945.6669-1-wenwux.ma@intel.com> In-Reply-To: <20230104023945.6669-1-wenwux.ma@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7019:EE_|SJ1PR11MB6179:EE_ x-ms-office365-filtering-correlation-id: b81655f0-63f5-40a3-7a0e-08daf5149f6d x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 66NyfwQQDkUkjsVZ9gkwcN17Jo+a82MCgKAyUAvnjdCkLRsl1fzhEyoBqY3W7Hs0AN6knnYBNxtoJpd/D0lnSVP/VTMR/cjrfChgND4sr9BZoTD8N0EdYyj4zR7ygai19soxjLgo76xP6DXQaEi9d+YEPuTCImkhD38jpLks04iAeuU4VGXD1+B2TNrej6Rr0RhDBPNY17YE/yS/Tr4PrKvFG6RAk3ffEsgJquBL7k21YZpLGaOhRsERCUogm73eYiWyDcfWvbf5SXUIjBqYoqUlA5jpNi7gDNxsY0uHHMMr9jtUC4uCJCE6C8WX1YnxpZ7x3uk6yNbCpeAbJWtT6dUXMAHcKH9TwLLkLZFtzrq4qP3a1g0NfjnVoLwbNOudxsDYwjDba0Y9SzHlgqd89QV93qZLihDACbXgIcTvR845fLnRioe/NJ00i47E4HYzAYu8JoT6lMQ+p43dbqjYt9N2Dan6FfLTSJocoG8uqV5ZeitBHKy4YwCC1Pd5PQvZ3RGsxEslDB7M3uDKf612mfCIELTqHi8ZXmI+TAF3fNykUXuG2X0B1mJT+p2UbFyArzINHVE3Fxn3DMUoxDqEK/LWWNJW7FGi7kRR6JKmRn4X6xNmTl2zWSrVrZ+kxNWvFrl/93scSEoBSIJqwcmEYzorX06eJEf2qR3zgSQn3H663rXdrQpx2eg67jIwn++VYKyH1J01sNBuVHaFkGrrkQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7019.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(136003)(366004)(396003)(39860400002)(451199015)(55016003)(41300700001)(66556008)(54906003)(4326008)(66476007)(76116006)(316002)(66446008)(66946007)(8676002)(64756008)(86362001)(38070700005)(122000001)(52536014)(82960400001)(38100700002)(33656002)(5660300002)(110136005)(8936002)(83380400001)(6636002)(6506007)(71200400001)(53546011)(7696005)(2906002)(26005)(478600001)(186003)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OiPFjRVt2NZUe5EuGoB2cCAA6UIjxuxQ802l7iQ08rfifwL18HH/oL44g2wK?= =?us-ascii?Q?zGUwbIYxkNonAUOCZ2p3mY+B0VYLe/3qFPkjwcjU/12o5AcVxDYOXhg//9T0?= =?us-ascii?Q?REUysWvzYvtL4BaD6yhfeuDtlLqfR0KvKunWdgDkgaEhMHsDAu7cuhW7vvcO?= =?us-ascii?Q?IEoMRpJU398EmCoNOdrCdouKtjj2ZIcNvQek+Cdb8wFgcSSrczJXZCGAIdSk?= =?us-ascii?Q?W94mCRkmYWHcmuz8KA+MCx5OCmSorHYopnP6Lys46tfoxa2d+Bi/zoDdj15N?= =?us-ascii?Q?9n+KcNMod/uMAMbmcAZE0Id9POa9CFoRaS7ZtH9UdHlAwKwJ7wQxfCpbC43x?= =?us-ascii?Q?lKsfnA4dwXA6TFEAnc8I9yhOf4QOhppWYKaDVbTSGiUntLBYMhFByUmFLykN?= =?us-ascii?Q?KR525iMnsUy+NXmGKa08gRRBa4PMAUf8MaaZeyiZ0YQz8HT6f4gPQp2bjCJj?= =?us-ascii?Q?KUEdkrReBNCc/UkkfgVYLuRNT3dOVXEsCbGGiDZO2v5rzn3QfmyCZ6Z4CRMi?= =?us-ascii?Q?4iC0Mx+IGJSJLzzvsIDLx9GVMs/2KD1oh5b++BSK61EnxleTdCH6RAphB92B?= =?us-ascii?Q?Zj00PUOkMPp/eBWCSVgUCdQnP9n9qtvfAbrooUc1Bmlh0xuJc8YvXJaX41dD?= =?us-ascii?Q?F6xdhvt0bkMF1TKRFb9ym9zvx7dfdjHKOcolbin77Ut96+ELYeKnEUajVr1f?= =?us-ascii?Q?55ugm59XLGRegdhURN9PTuzweyI5pvHEm590bP1ILpdUvLyPpGz14dr/PmZa?= =?us-ascii?Q?e8VBSZcHibayUcFwnlsonbx+xswoPca/esbK5H3Ofv2wN4BGFvGr5Gf+OK2F?= =?us-ascii?Q?R8HpIK0BvhwQWLIA9gbZXNMHkC6iAcjdsx9yNTSWw2Gdvtdn718IlRePnEL3?= =?us-ascii?Q?DM8AvBIOoc1Mq8+P+0lnHgQPAmfDVNYNXVwZ6c0gjOlO8rtXqRk2c2Mg3zn/?= =?us-ascii?Q?j9BFEjpz0EAk3TYKRWeQpepVeA96mgm/kVFrZ2keQv0Jcl2MCPHaojA1vnby?= =?us-ascii?Q?D9safQhdOVRNjEhvl4ES24VJmLPUOydzxbydgoUrvxAnvIqBvGWHFXsA9mUR?= =?us-ascii?Q?noK6LkYzn/njjpw4Ui3d9i+LsoW/DUuHoi4PZvy66h9aPQi28N/0v3w3Jj6K?= =?us-ascii?Q?VeTcgqfkMn+V8LSsep67anKmLhs9Suf6Mygd92U9zFJEH27pzbqcniw2UPi1?= =?us-ascii?Q?bHnC3kbGVAetyYHGeKkNg19b5+HRsH06jxJsbOsbhX+bt3MFJcQhyKKB91cu?= =?us-ascii?Q?gZUp1+IOClbizaRhvpq/Ph1D0yNZvrPmJcbUzxKLgU/bJNI1J1S/BZJ4MgtS?= =?us-ascii?Q?mWtFGr8374OlyI7/qYoETxFaRLu3fbBcSVKGRkFn2fOWQIyWLKv7jCZ15QyB?= =?us-ascii?Q?1goPdBGs9Vc6U+YYat/FLsd/MaOtlj2A+Dd/5Avr2ybGIdp8Gys5rn7zRnAW?= =?us-ascii?Q?jMrOkPn06T/Sws09n6iM0of2gzVS8Apu8oUUTDVmx6+Z8UKMWvdjpBBs3Kv6?= =?us-ascii?Q?mFqoqY2xn2f/gxeiKFLBc5U65d7y8cfGFHY+7E2yzr1Ct6u9jIj/HSI8fWd0?= =?us-ascii?Q?Q3wRs7EGobEt4BVdedWHRk/eQRskpqHe6dWHgBpr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7019.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b81655f0-63f5-40a3-7a0e-08daf5149f6d X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2023 03:16:54.8624 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GuX4mpDKRxILBjBbZcmTEQQT6he0cfMN3I2JczkaxXPW8Sl/qM8udqEWPH5Enod2x2t8LHbq7iZkgMgCxgn4dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6179 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Wenwu, > -----Original Message----- > From: Wenwu Ma > Sent: Wednesday, January 4, 2023 10:40 AM > To: dev@dpdk.org > Cc: Ma, WenwuX ; stable@dpdk.org > Subject: [PATCH] vhost: fix net header settings in vhost datapath >=20 > In vhost sync batch enqueue, the "num_buffers" of virtio net header is no= t > be set, but it should be set to 1 if the mrg_rxbuf feature is turned on, = This > patch fix the issue. >=20 > Fixes: ef861692c398 ("vhost: add packed ring batch enqueue") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wenwu Ma > --- > lib/vhost/virtio_net.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index > cf796183a0..61d9052a57 100644 > --- a/lib/vhost/virtio_net.c > +++ b/lib/vhost/virtio_net.c > @@ -1493,6 +1493,12 @@ virtio_dev_rx_batch_packed_copy(struct > virtio_net *dev, > sizeof(struct virtio_net_hdr_mrg_rxbuf); > } >=20 > + if (rxvq_is_mergeable(dev)) { > + vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) { > + ASSIGN_UNLESS_EQUAL(hdrs[i]->num_buffers, 1); > + } > + } > + > vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) > virtio_enqueue_offload(pkts[i], &hdrs[i]->hdr); >=20 > -- > 2.25.1 Acked-by: Cheng Jiang Thanks, Cheng