From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D197424E6; Mon, 4 Sep 2023 04:17:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB8DC402AE; Mon, 4 Sep 2023 04:17:45 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 01A6F402A9; Mon, 4 Sep 2023 04:17:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693793864; x=1725329864; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LP3HJ56LhrtWB0A4dj4XNQEECUIxz1BSYEk1L6L6tKc=; b=HmyYtWvmbfvMF5AAxzzqP0G7IlA61w15eDlKiYW2ev2LtOFlNc2mF7sT MTQFzKTZj/0Zm9CKEQy+fQsNz4rXrbtgBXwxvsQ0H+XfbxfHZsFZyaSIb 31ibjsY80sw9yXyNq5a/nwwsJqK3yyZ6ztypn9psla6eWqXOPHZCaObAd lfehjId9Vlbtu7HWxeGcBdaWN4gfFS9kLMRYzGrgvC64FFI/SnLD3F/kW HhBe2KAcminPTVpLbiOfO2JkhZ5WGVuxw90M+Mil7iiavL7oIObF+MMpr fEBmZ6KSDioMruYAKdAgEqCf/LEKwe7Gdl1nULLiDqYKqMG98m76rFZ5P Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="379215498" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="379215498" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2023 19:17:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="775671337" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="775671337" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Sep 2023 19:17:42 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 3 Sep 2023 19:17:42 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 3 Sep 2023 19:17:41 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Sun, 3 Sep 2023 19:17:41 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Sun, 3 Sep 2023 19:17:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egbheH3ZE9o0ZIq4Y35hKR5i4WekFaHFm5tN+HQb33x02cC9absThxVWVVBuXmJKecaNtZB1F2hBc7Q/LohrMh4qfNniGOTVuWKlmcfAMnEpfEI8c+bjUVmkJx6h5xImRSnUl4yjs2KjuR/secDlKdqZUscXwOdFz7e5OLyMB4ciVs0RlqYWGCTto0xYBQ49zI89VXnf3jwTLcn97cz9X27XNGWIpDASSly+XWU/jJURUwnsFr+32zsnFeE4O9HpHdeVNxmilr5OuMPkUDy3sqRgs5r0Aezx7cHtrZbRPiy1Bf46gh9rulPhCkam/yX0qeHrd3vhnNuzVQuit35IfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LP3HJ56LhrtWB0A4dj4XNQEECUIxz1BSYEk1L6L6tKc=; b=Ct3BN3WdviFlkp+47hJcJbAxLR5XRaEDX0dhIzkFA6HexL9a8sW0L0o6MaIkwq9KPaaij2AHObJRz+nLyk2vS7GaRTN8CcF8ihydSFxaGe/+sossf8T6mesKPSI/hWOFTkHNy+Z+3cxMpal6hzJaeIGzzlFl4g3xk87S6psuRpvEY81C+mVWkqOI2xazkiaa21yq7rkBHVU9Dv3aiZrPTliH+kaBpzLLGepD2o6rEiQqZyOG3FJBz7S7tUtylflhkaIxjTKrpsj/3k5nHO4TrBhqHl0uFwTgv08Fk1ju4E8T+SSZmwJb/4RPlT7k/IntdiCDPDa0fq4Vz6Ry9MQttg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7491.namprd11.prod.outlook.com (2603:10b6:806:349::8) by DM4PR11MB5456.namprd11.prod.outlook.com (2603:10b6:5:39c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.30; Mon, 4 Sep 2023 02:17:39 +0000 Received: from SN7PR11MB7491.namprd11.prod.outlook.com ([fe80::c228:a4ea:733f:dfcc]) by SN7PR11MB7491.namprd11.prod.outlook.com ([fe80::c228:a4ea:733f:dfcc%3]) with mapi id 15.20.6745.030; Mon, 4 Sep 2023 02:17:39 +0000 From: "Lu, Wenzhuo" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Wu, Jingjing" , "stable@dpdk.org" Subject: RE: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop Thread-Topic: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop Thread-Index: AQHZ3AdzqSWpYvY4tkS2+j8UAOARSLAJ87BQ Date: Mon, 4 Sep 2023 02:17:39 +0000 Message-ID: References: <20230830155919.592390-1-bruce.richardson@intel.com> <20230831123337.871496-1-bruce.richardson@intel.com> <20230831123337.871496-3-bruce.richardson@intel.com> In-Reply-To: <20230831123337.871496-3-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7491:EE_|DM4PR11MB5456:EE_ x-ms-office365-filtering-correlation-id: fb57eb52-8e78-4d69-c348-08dbaced1ce9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8qTiNwMZg1AlK1ixD/5aV5uUb1j4+xo3fNmB+3F5sEq8OYvzyf8PNJ2w/r6EgLzES9FXW8xqOLyoFJc1tBO8Zh8RYajGo6aCJQQSaO+sVj2qL/a98T2tbqDrSecrZucB8yQoAmezT+jTfR1rYE7FTwpbqxuoBHd0GuUuSGRjyWx+nnBf8euXGv5eKEs5yGatw1qtjEJx7lmYtqRejpzl2jHKElQkETyJcyM3gCGKDHOlnKBquhgyMxBWL/6cOSH62zZhoQ9D5GeGT/BospHcKjf8E2Sy70cMO7F1LzBNTM2l+5RM1wWHmJaD1K8dcJTQKUr0hSO165V7vOj9Ku5qYR2fW3waXq/+XuPkhesY2+5mXNLmml27T8kvWUtEzQK+rpgM50O/2dWfrHxP7bgT/IU123aXn19WONa7XL6206o2crz/BIlkrFAipmNT+KuCdnyhTBEiphmSKTuUcRcKu2b91bgUbcouz8PxJisYFrckpcKMP1I7t5slHq4SpkeYYl88boXKudNqofxKKlY0U6EYkjEeFOfwMLVSzD2AEcKSA79VW5064V0zonEVRixUuDNTjun5mgOB5JIebX5bV4epaRKZlJc5oF1V3BgVBRrMsvCrsrjpe+qY91Lu0Juq x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(346002)(136003)(376002)(396003)(451199024)(1800799009)(186009)(4744005)(8936002)(41300700001)(450100002)(83380400001)(55016003)(478600001)(71200400001)(2906002)(76116006)(66946007)(5660300002)(8676002)(110136005)(52536014)(66476007)(66556008)(54906003)(64756008)(66446008)(316002)(4326008)(9686003)(53546011)(6506007)(7696005)(26005)(38070700005)(38100700002)(122000001)(33656002)(82960400001)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qFF579YLTbIo23YG56QMucxOt7VlHNliaI5ND9TxWoPatBLfr8p4DibwsQ/h?= =?us-ascii?Q?0PQx3qfV/e7SLSmlzIs7/Yjfetb19233UBIxzdn2+uA/0NStU5+bmUewfxSN?= =?us-ascii?Q?jD3cy1OQY3qNjwAnlZd9nMwiWqyt/VAI5fLqQoPQMTgRY7rfeJAlpRFNthvN?= =?us-ascii?Q?HslTndANIanGdZd8FBrTg8Ke9xa7SorRW0IJAw+3NS/ZzPeVmOjcVL+zUKPr?= =?us-ascii?Q?G8BopuuR3eN8Q1JghOwuRUXkwXSYEMweC+Ff2BHIu3JDhoM2bkr8hRJ076bb?= =?us-ascii?Q?JiZ7uQAgyMsZUxqw824mIZXOP242KJ9zAZ7eoOSQBy/Nq0+aKWk0fRCjF5y6?= =?us-ascii?Q?qZcf4l1tV1dmoTwo/RUqr6J+ihkmgLD2n2Vt8eRj5tIq8k+nCXCP/6EQK/Hw?= =?us-ascii?Q?tPvIKh4egbH23dxnZWab20RYOr99kKqd76C3l0En+QriaKI9p9lAY9Q47drx?= =?us-ascii?Q?D/gyd8i/nXs4kSXt09n+3yDKnemTtBsNbgon+uA70u6f9H1fMUZqSHjOJqtX?= =?us-ascii?Q?MZ9508Omnj2Pn1HpC+C+3qTdOlSFDKS4Xm5xFx4kb1NjYUjnEE0yMEyvslS+?= =?us-ascii?Q?qQxrd4zuo9OvA7zgsaTGYygB6PuOhT7p5Ua9KfaRAf4QYlrg5TALWXCv8Nwx?= =?us-ascii?Q?RK917326pJ2e0HckbBh+2K7eVRhKBy0xJhm5n5r+py55YeO+TXVB8LEgnbyI?= =?us-ascii?Q?pwSWwjDrSvhNydMI4F3i6ob+0GiuCFXHU+OZPOSxd0q2o3HHcj7JgQjyGzRj?= =?us-ascii?Q?Z2IuzkkD1MFpNphW/jrN5K2UuOr4JYncNZI0iXkBIdE5jqpU07gwMA7HdVVO?= =?us-ascii?Q?elbqg6pyE9dh9qYuJkQ0Qp9Apmy2SSepLxRWXc/91Djx7vXS463BW/A/PZY8?= =?us-ascii?Q?3NhCXBAWtI5JU7mUe7ibWflRo8ueGnSjP3IJlsSODX5Wo8QvNG1HC9yptVkR?= =?us-ascii?Q?FZfqjWzPr9/A5Z+U7W8T9URWHnEE04kRAim4jCalV+Oxpc4mUFSza+fCCZAr?= =?us-ascii?Q?7L5dM89/ZQcJc74B+u2RK5C2tPgapcqXqKocM6aVSbA0EW11l3gTQHtZGqW1?= =?us-ascii?Q?slbvJ97IF7ZC4tI+NtUTpNGqHxNUsgwQGypvl3fIDZ03F4oyWMTVz4ZCNu1o?= =?us-ascii?Q?pHY7L8PDhZiTj56zd482kcDs9CR7WkiiqkJLFZy/C+SReK83EZ3ev5U3FJni?= =?us-ascii?Q?7Qz6sp/QCzptCGw3QZggHvL86J+kLyBVghbvpvhs/rdDDfRBhrbv2XikBjMQ?= =?us-ascii?Q?qYqxx5JTXKihkArmQ5eIOb25GOODpkR0IaM8s3Z6rTMgPVPO5muIff+5xZmM?= =?us-ascii?Q?cEWWwazt1tOWdFf3lxkmtMBtWnAidKRJocxJbLz//dkfB0Ph9ovBWC/J7XFS?= =?us-ascii?Q?GQ21E4g2Z6LkHBxRUQngUpAjppZ1WgymU71iT4TUuIDzYiYLIhwgj91qkzTt?= =?us-ascii?Q?aLi4hZG+5E7E8nUZTU/j3nX3b9cwFi0waIoTRzCnrWLpV7dykF+uXWQze5b7?= =?us-ascii?Q?YmVVwlQQfYjKmnjl1+k9De8T8JItWsuEL8x0kwjKzTacZpI1KZWYyG0rHkzq?= =?us-ascii?Q?FYdEzsBDTwD9vWvj6fW5ONgHQh31BYmecNrQB3WG?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb57eb52-8e78-4d69-c348-08dbaced1ce9 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2023 02:17:39.4942 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EL1EliQK7mbWqAAx2F72ctpaZoZfmz49D6cZ8E2tSvc+NNuoytfiaL6y81DZ07zslBZ02oWXTmWSOp3rtBKb4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5456 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, August 31, 2023 8:34 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Lu, Wenzhuo > ; Wu, Jingjing ; > stable@dpdk.org > Subject: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop >=20 > When a queue is stopped all buffers are meant to released from it, and th= en a > new set of buffers reallocated on start. For the iavf code when using vec= tor Tx, > some buffers were left in the ring, and so those buffers were leaked. The > buffers were missed as the release code only handled one side of a > wrap-around case in the ring. >=20 > Fix the issue by doing a single iteration of the ring freeing all buffers= in it, > handling wraparound through a simple post-increment check. >=20 > Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx") > Fixes: 9ab9514c150e ("net/iavf: enable AVX512 for Tx") > Cc: wenzhuo.lu@intel.com > Cc: jingjing.wu@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Bruce Richardson Acked-by: Wenzhuo Lu