From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: mschmidt <mschmidt@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Rong, Leyi" <leyi.rong@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/iavf: fix VLAN offload with AVX512
Date: Wed, 29 Mar 2023 01:05:43 +0000 [thread overview]
Message-ID: <SN7PR11MB7491FE0077D2C88F6B029C7B8C899@SN7PR11MB7491.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230327100750.448859-1-mschmidt@redhat.com>
> -----Original Message-----
> From: Michal Schmidt <mschmidt@redhat.com>
> Sent: Monday, March 27, 2023 6:08 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Konstantin Ananyev
> <konstantin.v.ananyev@yandex.ru>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Rong, Leyi <leyi.rong@intel.com>; Lu,
> Wenzhuo <wenzhuo.lu@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/iavf: fix VLAN offload with AVX512
>
> It has been observed that mbufs of some received VLAN packets had the VLAN
> tag correctly set in vlan_tci, but ol_flags were missing the VLAN-indicating
> flags.
>
> _mm256_shuffle_epi8 operates as two independent 128-bit operations, not as
> a single 256-bit operation. To have the RTE_MBUF_F_RX_VLAN* flags reflected
> in the resulting vlan_flags for all 8 rx descriptors, the input l2tag2_flags_shuf
> must contain the required pattern in both 128-bit halves.
>
> This fix is for the AVX512 Rx path. The same bug in AVX2 was fixed by commit
> eb24917428a1 ("net/iavf: fix VLAN offload with AVX2").
>
> Fixes: 4b64ccb328c9 ("net/iavf: fix VLAN extraction in AVX512 path")
> Cc: stable@dpdk.org
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
next prev parent reply other threads:[~2023-03-29 1:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 10:07 Michal Schmidt
2023-03-29 1:05 ` Lu, Wenzhuo [this message]
2023-04-03 5:39 ` Zhang, Qi Z
2023-06-12 18:02 ` Thomas Monjalon
2023-06-13 0:38 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN7PR11MB7491FE0077D2C88F6B029C7B8C899@SN7PR11MB7491.namprd11.prod.outlook.com \
--to=wenzhuo.lu@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=leyi.rong@intel.com \
--cc=mschmidt@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).