* [PATCH] common/qat: enable gen4 c devices
@ 2023-08-11 12:38 Ciara Power
2023-08-11 13:40 ` David Marchand
2023-08-21 9:33 ` [PATCH v2] common/qat: enable QAT 2.0c devices Ciara Power
0 siblings, 2 replies; 9+ messages in thread
From: Ciara Power @ 2023-08-11 12:38 UTC (permalink / raw)
To: dev; +Cc: arkadiuszx.kusztal, Ciara Power, Kai Ji
This commit enables QAT 2.0c devices in the
Intel QuickAssist Technology PMD.
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
doc/guides/cryptodevs/qat.rst | 4 ++++
doc/guides/rel_notes/release_23_11.rst | 3 +++
drivers/common/qat/qat_device.c | 4 ++++
3 files changed, 11 insertions(+)
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index afdfb0bd22..fc5a212d00 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -457,6 +457,10 @@ to see the full table)
+-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
| Yes | No | No | 4 | 401xxx | IDZ/ N/A | qat_401xxx | 4xxx | 4942 | 2 | 4943 | 16 |
+-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
+ | Yes | Yes | Yes | 4 | 402xxx | linux/6.4+ | qat_402xxx | 4xxx | 4944 | 2 | 4945 | 16 |
+ +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
+ | Yes | No | No | 4 | 402xxx | IDZ/ N/A | qat_402xxx | 4xxx | 4944 | 2 | 4945 | 16 |
+ +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
* Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with IDZ driver version 4.9.0+
diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst
index 4411bb32c1..3bdd51a4a5 100644
--- a/doc/guides/rel_notes/release_23_11.rst
+++ b/doc/guides/rel_notes/release_23_11.rst
@@ -72,6 +72,9 @@ New Features
Also, make sure to start the actual text at the margin.
=======================================================
+* **Added support for QAT 2.0c devices to Intel QuickAssist Technology PMD.**
+
+ * QAT 2.0c (4944) devices are now enabled for QAT.
Removed Items
-------------
diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
index 2675f0d9d1..cbf1e6a988 100644
--- a/drivers/common/qat/qat_device.c
+++ b/drivers/common/qat/qat_device.c
@@ -50,6 +50,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
{
RTE_PCI_DEVICE(0x8086, 0x4943),
},
+ {
+ RTE_PCI_DEVICE(0x8086, 0x4945),
+ },
{.device_id = 0},
};
@@ -202,6 +205,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,
break;
case 0x4941:
case 0x4943:
+ case 0x4945:
qat_dev_gen = QAT_GEN4;
break;
default:
--
2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] common/qat: enable gen4 c devices
2023-08-11 12:38 [PATCH] common/qat: enable gen4 c devices Ciara Power
@ 2023-08-11 13:40 ` David Marchand
2023-08-21 9:37 ` Power, Ciara
2023-08-21 9:33 ` [PATCH v2] common/qat: enable QAT 2.0c devices Ciara Power
1 sibling, 1 reply; 9+ messages in thread
From: David Marchand @ 2023-08-11 13:40 UTC (permalink / raw)
To: Ciara Power; +Cc: dev, arkadiuszx.kusztal, Kai Ji
Hello Ciara,
On Fri, Aug 11, 2023 at 2:38 PM Ciara Power <ciara.power@intel.com> wrote:
>
> This commit enables QAT 2.0c devices in the
> Intel QuickAssist Technology PMD.
It is hard to make a link between the commit title "gen 4 c devices",
the table below "402xxx" and the release notes "QAT 2.0c".
Can you use a single designation of this new device?
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
> doc/guides/cryptodevs/qat.rst | 4 ++++
> doc/guides/rel_notes/release_23_11.rst | 3 +++
> drivers/common/qat/qat_device.c | 4 ++++
> 3 files changed, 11 insertions(+)
>
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index afdfb0bd22..fc5a212d00 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -457,6 +457,10 @@ to see the full table)
> +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
> | Yes | No | No | 4 | 401xxx | IDZ/ N/A | qat_401xxx | 4xxx | 4942 | 2 | 4943 | 16 |
> +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
> + | Yes | Yes | Yes | 4 | 402xxx | linux/6.4+ | qat_402xxx | 4xxx | 4944 | 2 | 4945 | 16 |
> + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
> + | Yes | No | No | 4 | 402xxx | IDZ/ N/A | qat_402xxx | 4xxx | 4944 | 2 | 4945 | 16 |
> + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
Is there such a kernel module named qat_402xxx upstream?
I can only find qat_4xxx.
>
> * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with IDZ driver version 4.9.0+
>
> diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst
> index 4411bb32c1..3bdd51a4a5 100644
> --- a/doc/guides/rel_notes/release_23_11.rst
> +++ b/doc/guides/rel_notes/release_23_11.rst
> @@ -72,6 +72,9 @@ New Features
> Also, make sure to start the actual text at the margin.
> =======================================================
>
> +* **Added support for QAT 2.0c devices to Intel QuickAssist Technology PMD.**
> +
> + * QAT 2.0c (4944) devices are now enabled for QAT.
Missing an empty line.
>
> Removed Items
> -------------
> diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
> index 2675f0d9d1..cbf1e6a988 100644
> --- a/drivers/common/qat/qat_device.c
> +++ b/drivers/common/qat/qat_device.c
> @@ -50,6 +50,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
> {
> RTE_PCI_DEVICE(0x8086, 0x4943),
> },
> + {
> + RTE_PCI_DEVICE(0x8086, 0x4945),
> + },
> {.device_id = 0},
> };
>
> @@ -202,6 +205,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,
> break;
> case 0x4941:
> case 0x4943:
> + case 0x4945:
> qat_dev_gen = QAT_GEN4;
> break;
> default:
> --
> 2.25.1
>
--
David Marchand
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH] common/qat: enable gen4 c devices
2023-08-11 13:40 ` David Marchand
@ 2023-08-21 9:37 ` Power, Ciara
2023-10-11 7:50 ` David Marchand
0 siblings, 1 reply; 9+ messages in thread
From: Power, Ciara @ 2023-08-21 9:37 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Kusztal, ArkadiuszX, Ji, Kai
Hi David,
> > +-----+-----+-----+-----+----------+---------------+---------------+------------+---
> -----+------+--------+--------+
> > | Yes | No | No | 4 | 401xxx | IDZ/ N/A | qat_401xxx | 4xxx |
> 4942 | 2 | 4943 | 16 |
> >
> > +-----+-----+-----+-----+----------+---------------+---------------+--
> > ----------+--------+------+--------+--------+
> > + | Yes | Yes | Yes | 4 | 402xxx | linux/6.4+ | qat_402xxx | 4xxx |
> 4944 | 2 | 4945 | 16 |
> > + +-----+-----+-----+-----+----------+---------------+---------------+------------+--
> ------+------+--------+--------+
> > + | Yes | No | No | 4 | 402xxx | IDZ/ N/A | qat_402xxx | 4xxx |
> 4944 | 2 | 4945 | 16 |
> > +
> > + +-----+-----+-----+-----+----------+---------------+---------------+
> > + ------------+--------+------+--------+--------+
>
> Is there such a kernel module named qat_402xxx upstream?
> I can only find qat_4xxx.
>
Good catch, you're right, there is no kernel module 402xxx.
These devices fall under the original 4xxx driver.
Will update here, and send a fix for the 401xxx entry later.
Have sent a v2 addressing the above comments:
https://patches.dpdk.org/project/dpdk/patch/20230821093349.3519591-1-ciara.power@intel.com/
Thanks,
Ciara
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] common/qat: enable gen4 c devices
2023-08-21 9:37 ` Power, Ciara
@ 2023-10-11 7:50 ` David Marchand
0 siblings, 0 replies; 9+ messages in thread
From: David Marchand @ 2023-10-11 7:50 UTC (permalink / raw)
To: Power, Ciara; +Cc: dev, Kusztal, ArkadiuszX, Ji, Kai
Hello Ciara,
On Mon, Aug 21, 2023 at 11:37 AM Power, Ciara <ciara.power@intel.com> wrote:
> > > +-----+-----+-----+-----+----------+---------------+---------------+------------+---
> > -----+------+--------+--------+
> > > | Yes | No | No | 4 | 401xxx | IDZ/ N/A | qat_401xxx | 4xxx |
> > 4942 | 2 | 4943 | 16 |
> > >
> > > +-----+-----+-----+-----+----------+---------------+---------------+--
> > > ----------+--------+------+--------+--------+
> > > + | Yes | Yes | Yes | 4 | 402xxx | linux/6.4+ | qat_402xxx | 4xxx |
> > 4944 | 2 | 4945 | 16 |
> > > + +-----+-----+-----+-----+----------+---------------+---------------+------------+--
> > ------+------+--------+--------+
> > > + | Yes | No | No | 4 | 402xxx | IDZ/ N/A | qat_402xxx | 4xxx |
> > 4944 | 2 | 4945 | 16 |
> > > +
> > > + +-----+-----+-----+-----+----------+---------------+---------------+
> > > + ------------+--------+------+--------+--------+
> >
> > Is there such a kernel module named qat_402xxx upstream?
> > I can only find qat_4xxx.
> >
> Good catch, you're right, there is no kernel module 402xxx.
> These devices fall under the original 4xxx driver.
> Will update here, and send a fix for the 401xxx entry later.
I noticed this patch for 402xxx pulled in the main branch.
Don't forget to send the fix on 401xxx entry please.
--
David Marchand
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] common/qat: enable QAT 2.0c devices
2023-08-11 12:38 [PATCH] common/qat: enable gen4 c devices Ciara Power
2023-08-11 13:40 ` David Marchand
@ 2023-08-21 9:33 ` Ciara Power
2023-09-18 14:31 ` Dooley, Brian
2023-09-19 5:49 ` [EXT] " Akhil Goyal
1 sibling, 2 replies; 9+ messages in thread
From: Ciara Power @ 2023-08-21 9:33 UTC (permalink / raw)
To: dev; +Cc: arkadiuszx.kusztal, david.marchand, Ciara Power, Kai Ji
This commit enables QAT 2.0c devices in the
Intel QuickAssist Technology PMD.
These are 4th Generation QAT, 402xx devices.
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
v2:
- Fixed kernel module.
- Modified commit to align naming of new QAT device.
---
doc/guides/cryptodevs/qat.rst | 4 ++++
doc/guides/rel_notes/release_23_11.rst | 4 ++++
drivers/common/qat/qat_device.c | 4 ++++
3 files changed, 12 insertions(+)
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index afdfb0bd22..730113da33 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -457,6 +457,10 @@ to see the full table)
+-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
| Yes | No | No | 4 | 401xxx | IDZ/ N/A | qat_401xxx | 4xxx | 4942 | 2 | 4943 | 16 |
+-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
+ | Yes | Yes | Yes | 4 | 402xx | linux/6.4+ | qat_4xxx | 4xxx | 4944 | 2 | 4945 | 16 |
+ +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
+ | Yes | No | No | 4 | 402xx | IDZ/ N/A | qat_4xxx | 4xxx | 4944 | 2 | 4945 | 16 |
+ +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
* Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with IDZ driver version 4.9.0+
diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst
index 4411bb32c1..72dfb3fbf0 100644
--- a/doc/guides/rel_notes/release_23_11.rst
+++ b/doc/guides/rel_notes/release_23_11.rst
@@ -72,6 +72,10 @@ New Features
Also, make sure to start the actual text at the margin.
=======================================================
+* **Added support for QAT 2.0c devices to Intel QuickAssist Technology PMD.**
+
+ * QAT 2.0c (4944) devices are now enabled for QAT.
+
Removed Items
-------------
diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
index 2675f0d9d1..cbf1e6a988 100644
--- a/drivers/common/qat/qat_device.c
+++ b/drivers/common/qat/qat_device.c
@@ -50,6 +50,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
{
RTE_PCI_DEVICE(0x8086, 0x4943),
},
+ {
+ RTE_PCI_DEVICE(0x8086, 0x4945),
+ },
{.device_id = 0},
};
@@ -202,6 +205,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,
break;
case 0x4941:
case 0x4943:
+ case 0x4945:
qat_dev_gen = QAT_GEN4;
break;
default:
--
2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH v2] common/qat: enable QAT 2.0c devices
2023-08-21 9:33 ` [PATCH v2] common/qat: enable QAT 2.0c devices Ciara Power
@ 2023-09-18 14:31 ` Dooley, Brian
2023-09-19 5:49 ` [EXT] " Akhil Goyal
1 sibling, 0 replies; 9+ messages in thread
From: Dooley, Brian @ 2023-09-18 14:31 UTC (permalink / raw)
To: Power, Ciara, dev
Cc: Kusztal, ArkadiuszX, david.marchand, Power, Ciara, Ji, Kai
Hi Ciara,
> -----Original Message-----
> From: Ciara Power <ciara.power@intel.com>
> Sent: Monday, August 21, 2023 10:34 AM
> To: dev@dpdk.org
> Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>;
> david.marchand@redhat.com; Power, Ciara <ciara.power@intel.com>; Ji, Kai
> <kai.ji@intel.com>
> Subject: [PATCH v2] common/qat: enable QAT 2.0c devices
>
> This commit enables QAT 2.0c devices in the Intel QuickAssist Technology
> PMD.
> These are 4th Generation QAT, 402xx devices.
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
>
> ---
> v2:
> - Fixed kernel module.
> - Modified commit to align naming of new QAT device.
> ---
> doc/guides/cryptodevs/qat.rst | 4 ++++
> doc/guides/rel_notes/release_23_11.rst | 4 ++++
> drivers/common/qat/qat_device.c | 4 ++++
> 3 files changed, 12 insertions(+)
>
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index afdfb0bd22..730113da33 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -457,6 +457,10 @@ to see the full table)
> +-----+-----+-----+-----+----------+---------------+---------------+------------+-------
> -+------+--------+--------+
> | Yes | No | No | 4 | 401xxx | IDZ/ N/A | qat_401xxx | 4xxx |
> 4942 | 2 | 4943 | 16 |
> +-----+-----+-----+-----+----------+---------------+---------------+------------+-------
> -+------+--------+--------+
> + | Yes | Yes | Yes | 4 | 402xx | linux/6.4+ | qat_4xxx | 4xxx | 4944
> | 2 | 4945 | 16 |
> + +-----+-----+-----+-----+----------+---------------+---------------+------------+------
> --+------+--------+--------+
> + | Yes | No | No | 4 | 402xx | IDZ/ N/A | qat_4xxx | 4xxx | 4944
> | 2 | 4945 | 16 |
> +
> + +-----+-----+-----+-----+----------+---------------+---------------+--
> + ----------+--------+------+--------+--------+
>
> * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with
> IDZ driver version 4.9.0+
>
> diff --git a/doc/guides/rel_notes/release_23_11.rst
> b/doc/guides/rel_notes/release_23_11.rst
> index 4411bb32c1..72dfb3fbf0 100644
> --- a/doc/guides/rel_notes/release_23_11.rst
> +++ b/doc/guides/rel_notes/release_23_11.rst
> @@ -72,6 +72,10 @@ New Features
> Also, make sure to start the actual text at the margin.
> =======================================================
>
> +* **Added support for QAT 2.0c devices to Intel QuickAssist Technology
> +PMD.**
> +
> + * QAT 2.0c (4944) devices are now enabled for QAT.
> +
>
> Removed Items
> -------------
> diff --git a/drivers/common/qat/qat_device.c
> b/drivers/common/qat/qat_device.c index 2675f0d9d1..cbf1e6a988 100644
> --- a/drivers/common/qat/qat_device.c
> +++ b/drivers/common/qat/qat_device.c
> @@ -50,6 +50,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
> {
> RTE_PCI_DEVICE(0x8086, 0x4943),
> },
> + {
> + RTE_PCI_DEVICE(0x8086, 0x4945),
> + },
> {.device_id = 0},
> };
>
> @@ -202,6 +205,7 @@ qat_pci_device_allocate(struct rte_pci_device
> *pci_dev,
> break;
> case 0x4941:
> case 0x4943:
> + case 0x4945:
> qat_dev_gen = QAT_GEN4;
> break;
> default:
> --
> 2.25.1
Acked-by: Brian Dooley <brian.dooley@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [EXT] [PATCH v2] common/qat: enable QAT 2.0c devices
2023-08-21 9:33 ` [PATCH v2] common/qat: enable QAT 2.0c devices Ciara Power
2023-09-18 14:31 ` Dooley, Brian
@ 2023-09-19 5:49 ` Akhil Goyal
2023-09-19 11:04 ` Power, Ciara
1 sibling, 1 reply; 9+ messages in thread
From: Akhil Goyal @ 2023-09-19 5:49 UTC (permalink / raw)
To: Ciara Power, dev; +Cc: arkadiuszx.kusztal, david.marchand, Kai Ji
> This commit enables QAT 2.0c devices in the
> Intel QuickAssist Technology PMD.
> These are 4th Generation QAT, 402xx devices.
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
>
> ---
> v2:
> - Fixed kernel module.
> - Modified commit to align naming of new QAT device.
> ---
> doc/guides/cryptodevs/qat.rst | 4 ++++
> doc/guides/rel_notes/release_23_11.rst | 4 ++++
> drivers/common/qat/qat_device.c | 4 ++++
> 3 files changed, 12 insertions(+)
>
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index afdfb0bd22..730113da33 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -457,6 +457,10 @@ to see the full table)
> +-----+-----+-----+-----+----------+---------------+---------------+------------+--------
> +------+--------+--------+
> | Yes | No | No | 4 | 401xxx | IDZ/ N/A | qat_401xxx | 4xxx | 4942
> | 2 | 4943 | 16 |
> +-----+-----+-----+-----+----------+---------------+---------------+------------+--------
> +------+--------+--------+
> + | Yes | Yes | Yes | 4 | 402xx | linux/6.4+ | qat_4xxx | 4xxx | 4944
> | 2 | 4945 | 16 |
> + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------
> +------+--------+--------+
> + | Yes | No | No | 4 | 402xx | IDZ/ N/A | qat_4xxx | 4xxx | 4944
> | 2 | 4945 | 16 |
> + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------
> +------+--------+--------+
>
> * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with
> IDZ driver version 4.9.0+
>
> diff --git a/doc/guides/rel_notes/release_23_11.rst
> b/doc/guides/rel_notes/release_23_11.rst
> index 4411bb32c1..72dfb3fbf0 100644
> --- a/doc/guides/rel_notes/release_23_11.rst
> +++ b/doc/guides/rel_notes/release_23_11.rst
> @@ -72,6 +72,10 @@ New Features
> Also, make sure to start the actual text at the margin.
> =======================================================
>
> +* **Added support for QAT 2.0c devices to Intel QuickAssist Technology
> PMD.**
> +
> + * QAT 2.0c (4944) devices are now enabled for QAT.
Is it 4944 or 4945? In the code below, the PCI device added is 4945
> +
>
> Removed Items
> -------------
> diff --git a/drivers/common/qat/qat_device.c
> b/drivers/common/qat/qat_device.c
> index 2675f0d9d1..cbf1e6a988 100644
> --- a/drivers/common/qat/qat_device.c
> +++ b/drivers/common/qat/qat_device.c
> @@ -50,6 +50,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
> {
> RTE_PCI_DEVICE(0x8086, 0x4943),
> },
> + {
> + RTE_PCI_DEVICE(0x8086, 0x4945),
> + },
> {.device_id = 0},
> };
>
> @@ -202,6 +205,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,
> break;
> case 0x4941:
> case 0x4943:
> + case 0x4945:
> qat_dev_gen = QAT_GEN4;
> break;
> default:
> --
> 2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [EXT] [PATCH v2] common/qat: enable QAT 2.0c devices
2023-09-19 5:49 ` [EXT] " Akhil Goyal
@ 2023-09-19 11:04 ` Power, Ciara
2023-09-19 12:38 ` Akhil Goyal
0 siblings, 1 reply; 9+ messages in thread
From: Power, Ciara @ 2023-09-19 11:04 UTC (permalink / raw)
To: Akhil Goyal, dev; +Cc: Kusztal, ArkadiuszX, david.marchand, Ji, Kai
Hi Akhil,
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, September 19, 2023 6:50 AM
> To: Power, Ciara <ciara.power@intel.com>; dev@dpdk.org
> Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>;
> david.marchand@redhat.com; Ji, Kai <kai.ji@intel.com>
> Subject: RE: [EXT] [PATCH v2] common/qat: enable QAT 2.0c devices
>
>
> > This commit enables QAT 2.0c devices in the Intel QuickAssist
> > Technology PMD.
> > These are 4th Generation QAT, 402xx devices.
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> >
> > ---
> > v2:
> > - Fixed kernel module.
> > - Modified commit to align naming of new QAT device.
> > ---
> > doc/guides/cryptodevs/qat.rst | 4 ++++
> > doc/guides/rel_notes/release_23_11.rst | 4 ++++
> > drivers/common/qat/qat_device.c | 4 ++++
> > 3 files changed, 12 insertions(+)
> >
> > diff --git a/doc/guides/cryptodevs/qat.rst
> > b/doc/guides/cryptodevs/qat.rst index afdfb0bd22..730113da33 100644
> > --- a/doc/guides/cryptodevs/qat.rst
> > +++ b/doc/guides/cryptodevs/qat.rst
> > @@ -457,6 +457,10 @@ to see the full table)
> >
> > +-----+-----+-----+-----+----------+---------------+---------------+--
> > ----------+--------
> > +------+--------+--------+
> > | Yes | No | No | 4 | 401xxx | IDZ/ N/A | qat_401xxx | 4xxx |
> 4942
> > | 2 | 4943 | 16 |
> >
> > +-----+-----+-----+-----+----------+---------------+---------------+--
> > ----------+--------
> > +------+--------+--------+
> > + | Yes | Yes | Yes | 4 | 402xx | linux/6.4+ | qat_4xxx | 4xxx | 4944
> > | 2 | 4945 | 16 |
> > +
> > + +-----+-----+-----+-----+----------+---------------+---------------+
> > + ------------+--------
> > +------+--------+--------+
> > + | Yes | No | No | 4 | 402xx | IDZ/ N/A | qat_4xxx | 4xxx |
> 4944
> > | 2 | 4945 | 16 |
> > +
> > + +-----+-----+-----+-----+----------+---------------+---------------+
> > + ------------+--------
> > +------+--------+--------+
> >
> > * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only
> > with IDZ driver version 4.9.0+
> >
> > diff --git a/doc/guides/rel_notes/release_23_11.rst
> > b/doc/guides/rel_notes/release_23_11.rst
> > index 4411bb32c1..72dfb3fbf0 100644
> > --- a/doc/guides/rel_notes/release_23_11.rst
> > +++ b/doc/guides/rel_notes/release_23_11.rst
> > @@ -72,6 +72,10 @@ New Features
> > Also, make sure to start the actual text at the margin.
> > =======================================================
> >
> > +* **Added support for QAT 2.0c devices to Intel QuickAssist
> > +Technology
> > PMD.**
> > +
> > + * QAT 2.0c (4944) devices are now enabled for QAT.
>
> Is it 4944 or 4945? In the code below, the PCI device added is 4945
The device PF ID is 4944, but the corresponding VF ID used in DPDK for the device is 4945.
Thanks,
Ciara
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [EXT] [PATCH v2] common/qat: enable QAT 2.0c devices
2023-09-19 11:04 ` Power, Ciara
@ 2023-09-19 12:38 ` Akhil Goyal
0 siblings, 0 replies; 9+ messages in thread
From: Akhil Goyal @ 2023-09-19 12:38 UTC (permalink / raw)
To: Power, Ciara, dev; +Cc: Kusztal, ArkadiuszX, david.marchand, Ji, Kai
> > Subject: RE: [EXT] [PATCH v2] common/qat: enable QAT 2.0c devices
> >
> >
> > > This commit enables QAT 2.0c devices in the Intel QuickAssist
> > > Technology PMD.
> > > These are 4th Generation QAT, 402xx devices.
> > >
> > > Signed-off-by: Ciara Power <ciara.power@intel.com>
> > >
> > > ---
> > Is it 4944 or 4945? In the code below, the PCI device added is 4945
>
> The device PF ID is 4944, but the corresponding VF ID used in DPDK for the
> device is 4945.
Applied to dpdk-next-crypto.
Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-10-11 7:51 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-11 12:38 [PATCH] common/qat: enable gen4 c devices Ciara Power
2023-08-11 13:40 ` David Marchand
2023-08-21 9:37 ` Power, Ciara
2023-10-11 7:50 ` David Marchand
2023-08-21 9:33 ` [PATCH v2] common/qat: enable QAT 2.0c devices Ciara Power
2023-09-18 14:31 ` Dooley, Brian
2023-09-19 5:49 ` [EXT] " Akhil Goyal
2023-09-19 11:04 ` Power, Ciara
2023-09-19 12:38 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).