From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE4B043900; Fri, 19 Jan 2024 16:42:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44E6C4029F; Fri, 19 Jan 2024 16:42:46 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id A0F8B40279 for ; Fri, 19 Jan 2024 16:42:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705678964; x=1737214964; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=6U8YaloW2tUSRD69/60vf2G8tgsEd0widLF/cGAyDHU=; b=EuY7hZg/bxT25SctEE4OK4qaWaS30obmvQntADZg+Ll1IPtcCcv5bc/b fZ80AtZ+h66QQm5jLERxcTtviskWk7NXMC3GwowKB9NiWFGko/E/XGSeE aKb8ybxaZg0TDjaaXRa6m2L46MPyuSyNioFtOcg2DlWL/3qm//RRuSbLN 8ox8M3IKTpevKvvjeVVmLbm5ednbybWr7J6qW1qWDQqgqBv5K6j7av2Ip 5Fm2BgP9RwTGszJoDSkaAmN7jP+2d1Sy/2G18B7qs0hjKP/YyybjNkElA S8Ve7nUWyo3/uC1fz/sxD1PjhQG4dXF2Iidd/r9ciYWluDTc2EZiFaylk w==; X-IronPort-AV: E=McAfee;i="6600,9927,10957"; a="391211602" X-IronPort-AV: E=Sophos;i="6.05,204,1701158400"; d="scan'208";a="391211602" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2024 07:42:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10957"; a="875392022" X-IronPort-AV: E=Sophos;i="6.05,204,1701158400"; d="scan'208";a="875392022" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Jan 2024 07:42:41 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 19 Jan 2024 07:42:40 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 19 Jan 2024 07:42:40 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Jan 2024 07:42:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MiWmIUxPDbUjcDgnOafEO1dwZpWvTmM1BBs5g5zMPEuYoAswjhVS2UM86MQjRMrLRx/eMXLF9OxJ8PDccZkmZM+mrVpqwr9PW9YJgLQ1qmd1b9xHhdnhQUYVqrDtYNf/xVa3hQhLGG7AUVi82mNPyH/DjIs5nHC8zmYZA3w055vwrLEoIigwQQ5grwO7xmfHKcWPmG6+a9OhNCQoTZhZMLW4BIlZBFhp4Sy19VynKfOGeY1Ze7rV7ozt/GzkmFqopSLzjgrE9/gnK5g8QLzTgg8bcunAUrM7loac/V8MEhr5X48qLWn6dsvOsPhkP+cF+XDCyO3nuz5ljPbmJ+kCow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PA4UAMiOodfuCn3QIYBGebxvycMseQ78cnGfWt8mCyQ=; b=RKTGY9ajCzwhCrqW5Cz+qQM7V4dpFA3QcdY8kDMOTWwHLJMHyNID3uLjUXPOsx+TM2x/GAtWCEFcEFuLkNj8a2FFZWuRwlLt7ad9VnHo3Ix73chnAulLZHgp07B4vuYt+4F4fR8ZHULz5zsImQvetAnN0upOyeBrEYN04Scok+c3GLbTbkFulQ4k2RdSGDQQk/zOUW5e+trwF8igKrMX/oYkiRd+H7URKpYKhH7YbDRMtsXTlAbmcXjkNTcSdvBrwmGnE+BIGrF+ARb6gIgemydiyZd6rfx0A506tu8UzW3g2HtYgExL3j9k7aoaZPF2uF8jMTMQroTzTBuoutn4aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by CO1PR11MB4882.namprd11.prod.outlook.com (2603:10b6:303:97::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.26; Fri, 19 Jan 2024 15:42:39 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::8a06:eadf:e98b:23ad]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::8a06:eadf:e98b:23ad%2]) with mapi id 15.20.7202.020; Fri, 19 Jan 2024 15:42:39 +0000 From: "Power, Ciara" To: sunshaowei01 <1819846787@qq.com>, "dev@dpdk.org" Subject: RE: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail Thread-Topic: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail Thread-Index: AQHaSsxOH+J8Q6Pf/EWdlMI0aaoP/bDhRnKA Date: Fri, 19 Jan 2024 15:42:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|CO1PR11MB4882:EE_ x-ms-office365-filtering-correlation-id: 5a08bd19-02c3-4071-44e9-08dc1905445d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: foZRZxoeCH33jSZH4kuMkHlW8jBwe26zE+B2zTL+MFTnh5dLCuStNCEkdXb37EeXwTRvhMw3xwBs8TFWUTY5rQqwmXgNFZKS1dj7CMaWRGxkawShKvk9oJxGl0q+ZxjlIQNGQXJ8tbAgO5XD/DcAUIuDYzrs/J4QDrlKbWIK4gEk/elrHZOUNgbpZNA9AWmWfoeNyWPYPv6G1/tg+UURP6+MXchI5q25Q12TYZRcl14SXLe/cHTJTAv3riHhc0KqT04ZmX4MvWG5ggpKSaAt60m7lsWu256H10DjoMgE2qlm2Bdw+PsXrLnFwGLnQzDe0ZLtlZVvVcJzIfUjcH8LayLXCEOUwGiFriwWw7dxICQ4qRqoqkQ66y4UThIDRbGrlnxlvcqwGA71PzxdsDnCSGpyRNk4xIb+45x66fXzkctg1shSQg3GJTC4o4Ih+sXR83wUJhOLKB2ckkVhns8lUx658mlWBJFcF02qmMqkIDE/CBJ2f+mSLG8+8sIKQnUd8doM7/Qut6pjoyn+Z+SqhAeiPxKl7BsdeTNubUKeKmkW4IumcH3f0XGrRciy6M6JJ6FkazziK5jfFyqn0+tOGH1ceqX/a0KjgsOUHDy/ztVbgb/VxvrbBpXbliINyDDE x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(39860400002)(366004)(376002)(136003)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(86362001)(2906002)(66446008)(316002)(66476007)(64756008)(110136005)(82960400001)(76116006)(66556008)(66946007)(6506007)(38070700009)(33656002)(7696005)(9686003)(41300700001)(53546011)(5660300002)(8936002)(52536014)(83380400001)(122000001)(38100700002)(26005)(8676002)(478600001)(55016003)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hal0IhGXJksp4SnDTsZPEUBVpWloq2wXYAWBHAVWozDc49qLt0WuOxsX0gR1?= =?us-ascii?Q?JUmny100ZNeLSrbu/ihOjVLBqALuabePUUYkBiYRDedvO7pa0BkMHG3OFAVF?= =?us-ascii?Q?+gTm2xTduAHd7tLutN53bDDJ+VNotK0tyfHUqP59+lp+X6FZyqx9lSlvwfBY?= =?us-ascii?Q?kGEfwaMtaXrHBGhXUZ5W+t8SaEDHgv1ozPup1fp8mqzz3sJDDnsQhm4neUAD?= =?us-ascii?Q?cIIL9J/lCLDnMainxWXc8cZYqpm+UKmPJVY6+cVy6XI//efL3Bo3qdyDW6YW?= =?us-ascii?Q?Dq7vmkTelDsyZIE+LCPTntGm4eTqJ2/1kWOeYY9Pliz0EfnPVQegwhdqBOLl?= =?us-ascii?Q?RBREh7WgZr13wc97yNfTzUIoU3y1ms+bhL3vDxW1J6epJxIiYVQYBFYmF/Z3?= =?us-ascii?Q?sm/I2W4BSQ+CuZN2fJVTUOgkdXD8NLdMx9+2BPUh8IKBNGbGr3LoL2C9SPic?= =?us-ascii?Q?QL3q0VWfWH1dYi1cPd+7ErSBQAwVllc1r8IVC1H7q0Wbo6yMVHiUUTcIiPGN?= =?us-ascii?Q?VhIXIsO5xU+sVL8ivVEhQ2qDE4DXqNoejVaPYFIRv1K6Ytfga9oDTk+rIBjQ?= =?us-ascii?Q?TKARDXK5UazzH9qyeluX/abl4EA5snQ77ARhJpUrYcieM4E8vjf76UESNezM?= =?us-ascii?Q?MOhd2YEmY0R6H832T5q0XmDaQprSuohLpoF2GEmomwcYSOOSe1IMw4EWmNTF?= =?us-ascii?Q?mGcmCQl6+DrDVhXU6GyZsU5vCGZrNwldNBilsf+DVJweVtokT3fQlFSrhAZd?= =?us-ascii?Q?iKLFs9sc+z5CAOVeKWT/Ta5oCFKsfDIF0x8LEQCRt6OwtR8511gLEBS0eHLI?= =?us-ascii?Q?6uklltmeYQWAOrS4BCNrJ1uvCmqFn5A8OJVMXrvXTUI8+4Zw03UY+tlQAE/M?= =?us-ascii?Q?9pgqTRTAH7ZyDvYM+BZ3Lvu2+g4Gfm0iwxblN3S4RRB4ywAALJrYp04hy5XO?= =?us-ascii?Q?Ak4vxlv7T83yKjX2/w0RbSubmsxlA2kcM0fdt3kB38YTniM2bBMrsKhwjofO?= =?us-ascii?Q?VjQNKyE0dMIAEonGHy8ND62Ej6NGZw9KnEC09Ta1iwJEQBtQCgjyQ23UubnX?= =?us-ascii?Q?JLOrVGmAxNTFHH2ZiCKfZMxXMrPubTl8YaiSMaS+z6TpvF8+HTgBQ/QY2l6S?= =?us-ascii?Q?aXka49aIxkoQkd3IWMWriZMKJIwCrmJknYM5ufjOzYdtbL3MG59E7OlbbYDT?= =?us-ascii?Q?6fgMIxLgmICRHECneKHIbFTmMRc2RmDqT5OZ+36sCzPeGESjAoi3eCHpO+Te?= =?us-ascii?Q?5WPMC+L6nsW6KowuDTCkYhiFWQFkvoHySMrJdtuoY02BPattD/Xt6y3Jw9TS?= =?us-ascii?Q?0OYYM8JC9Iypc8Q3aPOoHXzJDDBrq23TNEFlwcAn+G6QEvyGjiijh9RBIO/z?= =?us-ascii?Q?CkBPurIBuJPJXNTI9bpkIh5yjDTkv3sAQDRO2+YVyW/9YBdoGmMgZA4j8jO2?= =?us-ascii?Q?j3YTW+7G4R3YSz4SJLpxa4D1jFeKhXOz+PA7ueMB0UddP/6yvDJ43XMZC1bm?= =?us-ascii?Q?JZ95ywHfYkshMqTYOSunYdZnSW64rkW7+jAuAhzY4zH2Wp29CQkTDxpe2X+b?= =?us-ascii?Q?ut5fOK0Gx4fXMsscMf7DZIMGFyiQF0YbdADiWixW?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a08bd19-02c3-4071-44e9-08dc1905445d X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2024 15:42:39.2211 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2tfsyRsotwbabeJsfyUlajswaoRGQdOru8a3GdclO/MkOfpU+wB5xUvXmu6d7QFc8fyGQUYrvg0QANcfe5Ugog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4882 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: sunshaowei01 <1819846787@qq.com> > Sent: Friday, January 19, 2024 11:40 AM > To: dev@dpdk.org > Cc: Power, Ciara > Subject: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket= write > fail >=20 > Telemetry can only create 10 conns by default, each of which is processed= by a > thread. >=20 > When a thread fails to write using socket, the thread will end directly w= ithout > reducing the total number of conns. >=20 > This will result in the machine running for a long time, and if there are > 10 failures, the telemetry will be unavailable >=20 > Signed-off-by: sunshaowei01 <1819846787@qq.com> > --- > lib/telemetry/telemetry.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c index > 31e2391867..0b00c04090 100644 > --- a/lib/telemetry/telemetry.c > +++ b/lib/telemetry/telemetry.c > @@ -378,8 +378,8 @@ client_handler(void *sock_id) >=20 > "{\"version\":\"%s\",\"pid\":%d,\"max_output_len\":%d}", > telemetry_version, getpid(), MAX_OUTPUT_LEN); > if (write(s, info_str, strlen(info_str)) < 0) { > - close(s); > - return NULL; > + TMTY_LOG_LINE(ERR, "Socket write base info to client failed"); > + goto exit; > } >=20 > /* receive data is not null terminated */ @@ -404,6 +404,7 @@ > client_handler(void *sock_id) >=20 > bytes =3D read(s, buffer, sizeof(buffer) - 1); > } > +exit: > close(s); > rte_atomic_fetch_sub_explicit(&v2_clients, 1, > rte_memory_order_relaxed); > return NULL; > -- > 2.37.1 (Apple Git-137.1) Thanks for fixing this. Acked-by: Ciara Power