RE: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

["Power, Ciara" <ciara.power@intel.com>]

> -----Original Message-----
> From: Patrick Robb <probb@iol.unh.edu>
> Sent: Wednesday, March 6, 2024 2:59 PM
> To: Power, Ciara <ciara.power@intel.com>
> Cc: Akhil Goyal <gakhil@marvell.com>; Dooley, Brian <brian.dooley@intel.com>;
> Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Aaron Conole <aconole@redhat.com>;
> dev@dpdk.org; Sivaramakrishnan, VenkatX
> <venkatx.sivaramakrishnan@intel.com>; Wathsala Vithanage
> <wathsala.vithanage@arm.com>; thomas@monjalon.net; Marchand, David
> <david.marchand@redhat.com>
> Subject: Re: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec
> Multi-buffer version
> 
> On Wed, Mar 6, 2024 at 6:12 AM Power, Ciara <ciara.power@intel.com> wrote:
> >
> >
> > > And this is also failing
> > > http://mails.dpdk.org/archives/test-report/2024-
> > > March/601301.html
> > > These need to be fixed in CI infra.
> >
> > This function that throws the error is available in the recently tagged 1.4
> equivalent Arm repo, so I am unsure why it can't find it.
> > Could there be some old installed ipsec-mb version in the environment that is
> being picked up by DPDK?
> > Sometimes the meson configure step will pick up the correct ipsec-mb version,
> but then ninja step links to an older version that still exists and hadn't been
> uninstalled previously.
> > Not sure if that could be the case for the CI container though - Patrick maybe
> you can verify there are no 1.3 or less versions on system that could be being
> picked up:
> > I usually use something like:  find /usr -name libIPSec_MB.so\*
> We are building the arm ipsec environment from a base debian 12 image.
> 1. Install NASM
> 2. Install ipsec 1.4 from the new ARM tag.
> 3. run DPDK build
> 
> Thank you for providing the find command to check ipsec version.
> 
> root@f968452d8612:/# find /usr -name libIPSec_MB.so\*
> /usr/lib/libIPSec_MB.so
> /usr/lib/libIPSec_MB.so.1.4.0
> /usr/lib/libIPSec_MB.so.1
> 
> I assume my reading of the above is correct that only 1.4 is installed. Let me
> know if it's otherwise though. Thanks!

Thanks for checking that Patrick - looks fine to me, only 1.4 is there.

If the correct version is being installed and picked up, maybe there is something missing for that function definition in arm-ipsec-mb repo.
Wathsala, can you check that please?
For x86, we define the function in the header: lib/intel-ipsec-mb.h
And the implementation is in the C file: lib/x86_64/hmac_ipad_opad.c

Thanks,
Ciara


> 
> >
> >
> > Thanks for the help,
> > Ciara
> >