From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 373F0425DC; Mon, 18 Sep 2023 18:07:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C974D4025D; Mon, 18 Sep 2023 18:07:28 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 40DB34025C for ; Mon, 18 Sep 2023 18:07:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695053246; x=1726589246; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=pAVNd7VR6ND+n/qQuofTEANb7HtrS0GyYEFPubnDGZQ=; b=jJX7idLI5a0qn2nmUpa6EBFJ2zAg8R06A/8OC4hEXySLashm2HOMKdRb iV9OEsdSh6YPvub6xd6JQSN/ZLTVP/dAWlD6pc1ernnL2SyHo76GyZkoJ WTg2ft6SOSZOdlsYv1F3GhmTqGMxBHudAo/hynxuj2Xi9ap/s4zrQ7CuS OiRZ6TNWYGA+84J+2N4f/2RXWHfWee0mNWB8nc/H7Gs6o+JHF4nJqixr1 Y7/qACH/5uJQJuG0ai7XcYIHS/MrTTODF0VNqOy//A4v7Rp+7pzfEf65i RZ0K2D8mwdjU1oq2wREPtN2hpKDmKW70to38NvIvUn4ezE3RDBtGa047n g==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="466046217" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="466046217" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 09:02:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="836088043" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="836088043" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Sep 2023 09:02:03 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 18 Sep 2023 09:02:02 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 18 Sep 2023 09:02:02 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 18 Sep 2023 09:02:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EowY1VDRDC64NLULNF2ji4rEcwQ6QSzsw0k0AM3tJDoIcwiGbvK/Qg8rIUGqpetPEEQHpKdmQKR0s0p18okWYmEd5EkTBfRwVZ6e7CPK5CPIZ5JaiPVTQWuJMeAmIYzCUYIjs4WQm5ySffouwWLrE+t9tWvodlCPMSwqT4e7Ot3UQPShywgHLZ9/ZyEhW81t3MhW44PfosCSgFIA/IbvBWncq/BbAmXlgkhvgw+LF4KLF//DidvW1Nqs37TZYZHYH1UlX0LYBJ7zOWD+hR8dm66mNUQcx0WZeOajdOc2natemYZzDF2uua5JG7xG9v/WSwlbzyVI04WfL26wBYY0Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=53MApeQKlfYIJ3sk25lpCzia35xhyYdQa97rp/dUuSI=; b=I6HZ9AMGP65RqDSUHMqlFFfh6s5YdoURhIbLN3UJLzgUl8xsTXcDTdgkOEH6lVs6miqmh8ywh8QPUKI7oDuJ04x/MLljXOWh5g1EKp8Vl4aBTX3KDCdoKktYs30OK+274MTAQ8VP/WkrBuZ3XaVN16vxH1l6zsXANXlXLcdPdD3LXTEH6VRv0Qs85ga6rFW/+obnVahDrk17RFsW4OsELHgRDwqt8R846rKNPE0QX2wLa/rn2Say/tHTnYo4OFIoyt3waDtzWwHQkH9X0F2s2JMgcI36gKt4B4Fe2WSHXh6THbHsZrZD3B1gnvwttkWIeRmRiYPalGY3XJGVCwlJ3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by CH3PR11MB7275.namprd11.prod.outlook.com (2603:10b6:610:14c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.26; Mon, 18 Sep 2023 16:02:00 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::4986:f7d2:4c49:b31b]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::4986:f7d2:4c49:b31b%6]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 16:02:00 +0000 From: "Power, Ciara" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "gakhil@marvell.com" , "Ji, Kai" Subject: RE: [PATCH 2/3] common/qat: move command line params to the device struct Thread-Topic: [PATCH 2/3] common/qat: move command line params to the device struct Thread-Index: AQHZ6X2qXA1IMajjoEOTRwCPreB2m7AgvquQ Date: Mon, 18 Sep 2023 16:01:59 +0000 Message-ID: References: <20230917154258.3509805-1-arkadiuszx.kusztal@intel.com> <20230917154258.3509805-2-arkadiuszx.kusztal@intel.com> In-Reply-To: <20230917154258.3509805-2-arkadiuszx.kusztal@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|CH3PR11MB7275:EE_ x-ms-office365-filtering-correlation-id: c014d5c0-cbc9-46be-8f5b-08dbb8609771 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LwNDK2M504zMtPVuYo5uFIjptGp/RI9Z5WzEoRrnai8EGdpOayyx/758+xWzgBXfB3Q2Xizc+Yt/YxJfEuipK0XUtxAwW9Z7+IhD+X83ixxW7mrLYbAdjCVJu0zvOBpcFd7cOS0udO6QL7Vktyjt3DTHzR3mPL7VAyvouzaBUhRgoV8tqy6xJkudiIQDSwz2Kd11U32+8K3AIH+AZ/JYpr8xJ4KlPZmYnWssvQbd7GXuDAJstwsWk787ixM0b8SSk0pVO1oyYIzSwThs0grZOYkXbFFMU81ZWD5XjqYrYgt8P8Sm9kN2BRXHhtF/rZ+q9t8oiQIURShtBdDxe3extmnjlMRBaTTZDJG0O8x6DP4c9WN9+Xy6rzvGZdCU4v90Jr63cvvMqq6Az0tl+T/HzIUjHIMYqV5HqLzs08qL1cW0p0uyS9Ww5TaU0gPjLdBJnw1mXF0qk3Kx58BuB/gXLIq31tkksxILIQdTbvi/iWm4xc1S3BUIcLx7VX+oT+V7Gl7CsrE6L9fvSeGtI1SeNaH0JLfi/d4sbEHk0Lf/0beoqelypTe5rtPO/XAmkaMzvqhm+tUKDeaxbut2VrQRJAvtWl/rza81lhabkW8E6gHloZZXAS3W3xi7n+ggb6j6 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(376002)(396003)(136003)(366004)(186009)(1800799009)(451199024)(7696005)(6506007)(53546011)(71200400001)(9686003)(478600001)(83380400001)(26005)(107886003)(2906002)(66946007)(66446008)(66556008)(54906003)(76116006)(316002)(64756008)(66476007)(110136005)(8676002)(52536014)(5660300002)(4326008)(8936002)(41300700001)(33656002)(82960400001)(86362001)(55016003)(38070700005)(38100700002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6gtXrXYxMBTsCgbrNFDkuK2p+7ibaYBrIbC3H4/pQ+BK3N6rnQqQ1av0iiwe?= =?us-ascii?Q?yhpA/Si1FjNoAjbLaOJGJ4yLlragOb9pyJ/U3ToyTvKaYzZH8dgnYawTx1kx?= =?us-ascii?Q?Fuj86XdALikCD+6xN4whfsWUZgIKc4MCmvl8+6QKuz8FdHGlJ6znQUvpRqH+?= =?us-ascii?Q?QMBp+feCu/PW1IviuMe750FRWvchC0XNZDHJXMPwQVc6qdZ3TLcBH9Nm661Z?= =?us-ascii?Q?IJYvemCI2S2qAE7TYeIpQv/BIKyjU7Uyul0PQD/MemMytM7sJ5bj8uZ8T+hR?= =?us-ascii?Q?tLPEAzzUkbbJt8zrJxr0DMlinGHbjhuESdb0I8XxqjvibNqw1khanKFNQYZt?= =?us-ascii?Q?S+kU7vC1HKVe2jxYkFCSZXjAr+W6yJx/TjEgg9nW7xqlDB+WG6RCXucpKBxa?= =?us-ascii?Q?/Qfg0/oFyjsTEkji64SllIHQ8dhJCvK47X8GHT8ROQg1ZTP3atutLRXfi9q1?= =?us-ascii?Q?oiGPNl3iF3yKEelHLU+A0uhb1qhtiVfogEMXc+IBjD+aDmrI7tk81HIRDmjH?= =?us-ascii?Q?nw0cDxgxbnAH83ZpVBqCQTt2odOjpth7lLxQg0HTEBJ4hR+2AG5W0uiLuxU9?= =?us-ascii?Q?Dsl2hMbb9ObHIwuD//d6MitPdf0n9dXaAc2daVkOQdVsBhuQb1TXWW5zF7so?= =?us-ascii?Q?CwE3T9Nxl9Lg2oP04RSwA0HBERmwkEGLsKYeACQ+8WgS8QIc9HKuWnTWPYCO?= =?us-ascii?Q?JZRCPlOEka6FF0HFCiJ8RcImtGO6h+Qk57g6u37ymwY2udXc1jcPw5RfNznM?= =?us-ascii?Q?BFFQ++tH9eSHP965j9H22EBs8ZKdYt9VevKXqtEoYB8xPrcXGELe0VvkUpu0?= =?us-ascii?Q?CjvCD0wwSN7GgdcpiU+j1UgabBu3StM/YuLXHRm3/kdU6kZWlhT0omMZ7aRR?= =?us-ascii?Q?4pk04HiL043h+SMbS6uvpBkj3Onw2n5msXS+W37q0+xGK/BR6RV4Bf9KQa0a?= =?us-ascii?Q?/J4c3Wj8dFJigg6c9EIJtqUIBpxQt0FlXa7DEadXKynifmVMub+8JEvmyXbR?= =?us-ascii?Q?4gaYZCiEEryKGU64sDhVuzDkJwtDgcUzs7SXnxHsNluPyPS6JgWmOzxd2YX3?= =?us-ascii?Q?qDo2x6m4gp0YBcNM9+2SsiiG1dmvaS3sfRaEXxZNcJD1NA6O30nDMvBBOQCh?= =?us-ascii?Q?TaOHjy8zXNf/iVgWefhNgUGEVqgv06j11rhN2Ux8oz8tpVGqNmqT6mZrNC5w?= =?us-ascii?Q?FDmLWiUCeoUs5P5J1GXKz/crqlADO7ToFyG7s0OpYIv6dNiyPd0gLeyqkruS?= =?us-ascii?Q?c/WEeUXqrX16pGLXnZgWLPV3XdQtahOr0JphHpfwQwTTVt5mDcz7G1Jko+No?= =?us-ascii?Q?1dBg40tRe9gT6dZYW4q4RD4SEkUc7MAJu6PuL5JnGXL4KIKrKtJdGQ+Wck3C?= =?us-ascii?Q?FBVLh2rve7E0iM3/PmNfwmBfHaE1Un0J/wtVIRtU2DHlgsVeqb1kDIYIbgAZ?= =?us-ascii?Q?jlifPSg2UyxbWDlMaGh/BRD8LuQkZI51Khj6UiqPqGNiQPRhQ7nILM9CipG4?= =?us-ascii?Q?4QRZaq9atjyHDu2Bq7XLQZGRZOitRwg7l9imej9ap18gRN6/RGjSXoHjMX8j?= =?us-ascii?Q?1HtNPk2H2pkKpbPA+f2wkTD3TWlxmj4ELzBLPeyZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c014d5c0-cbc9-46be-8f5b-08dbb8609771 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2023 16:02:00.0164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HCivZvZMk6RofsEvHqWyidMUDSZ+53iYyH/y7AnobIMyNU0BS+enJ3sqN/J2Nnwye15n2BtjHF+dpkIKJgNc8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7275 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Arek, > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Sunday, September 17, 2023 4:43 PM > To: dev@dpdk.org > Cc: gakhil@marvell.com; Ji, Kai ; Power, Ciara > ; Kusztal, ArkadiuszX > > Subject: [PATCH 2/3] common/qat: move command line params to the device > struct >=20 > Command line parameters was moved to the device struct. >=20 > Signed-off-by: Arkadiusz Kusztal > --- > drivers/common/qat/qat_device.c | 54 ++++++++++++++++++-------------= - > ----- > drivers/common/qat/qat_device.h | 35 ++++++++++++------------ > drivers/compress/qat/qat_comp_pmd.c | 9 +++---- > drivers/compress/qat/qat_comp_pmd.h | 3 +-- > drivers/crypto/qat/qat_asym.c | 13 +++++---- > drivers/crypto/qat/qat_sym.c | 23 ++++++++-------- > 6 files changed, 66 insertions(+), 71 deletions(-) >=20 > diff --git a/drivers/common/qat/qat_device.c > b/drivers/common/qat/qat_device.c index 93aef9aeb1..d9604e666d > 100644 > --- a/drivers/common/qat/qat_device.c > +++ b/drivers/common/qat/qat_device.c > @@ -22,6 +22,16 @@ > diff --git a/drivers/common/qat/qat_device.h > b/drivers/common/qat/qat_device.h index 23d7f54b61..dcb5a42c89 > 100644 > --- a/drivers/common/qat/qat_device.h > +++ b/drivers/common/qat/qat_device.h > @@ -17,14 +17,21 @@ >=20 > #define QAT_DEV_NAME_MAX_LEN 64 >=20 > -#define QAT_LEGACY_CAPA "qat_legacy_capa" > +#define QAT_LEGACY_CAPA_NAME "qat_legacy_capa" > #define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold" > #define ASYM_ENQ_THRESHOLD_NAME "qat_asym_enq_threshold" > #define COMP_ENQ_THRESHOLD_NAME "qat_comp_enq_threshold" > #define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable" > -#define QAT_CMD_SLICE_MAP "qat_cmd_slice_disable" > -#define QAT_CMD_SLICE_MAP_POS 5 > -#define MAX_QP_THRESHOLD_SIZE 32 > +#define QAT_CMD_SLICE_MAP_NAME "qat_cmd_slice_disable" > +#define QAT_LEGACY_CAPA_POS 0 > +#define SYM_ENQ_THRESHOLD_POS 1 > +#define ASYM_ENQ_THRESHOLD_POS 2 > +#define COMP_ENQ_THRESHOLD_POS 3 > +#define SYM_CIPHER_CRC_ENABLE_POS 4 > +#define QAT_CMD_SLICE_MAP_POS 5 Small suggestion, maybe an enum could be used to group the above position m= acros together. Acked-by: Ciara Power