RE: [PATCH v5] test: add cryptodev crosscheck suite

["Power, Ciara" <ciara.power@intel.com>]

Hi Akhil, Volodymyr

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Thursday 16 March 2023 09:45
> To: Volodymyr Fialko <vfialko@marvell.com>; dev@dpdk.org; Fan Zhang
> <fanzhang.oss@gmail.com>; Power, Ciara <ciara.power@intel.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>; hemant.agrawal@nxp.com; Ji, Kai <kai.ji@intel.com>;
> Volodymyr Fialko <vfialko@marvell.com>
> Subject: RE: [PATCH v5] test: add cryptodev crosscheck suite
> 
> 
> > Subject: [PATCH v5] test: add cryptodev crosscheck suite
> >
> > Add a validation test suite that helps in verifying that the output
> > generated by two different cryptodevs match for a wide range of input
> > parameter combinations.
> >
> > Crypto autotest performs a comprehensive testing of the cryptodev but
> > since it performs verification by comparing against known vectors, the
> > extend to which various parameters (like packet size) can be tested is
> > limited. This test suite attempts to simulate various cases by running
> > same test case on different cryptodevs and compares the output
> > generated. The test suite relies on capabilities to determine the
> > combinations of tests to be attempted.
> >
> > A typical use case would be to compare outputs generated from a
> > standard driver such as openSSL PMD and a new cryptodev PMD. This test
> > suite is to compliment the testing coverage that crypto autotest provides.
> >
> > Currently supported symmetric xforms(cipher, auth, aead) without chaining.
> >
> > Example commands:
> > DPDK_TEST=cryptodev_crosscheck ./dpdk-test \
> > 	--vdev "crypto_openssl0" --vdev "crypto_openssl1"
> > DPDK_TEST=cryptodev_crosscheck ./dpdk-test \
> > 	-a <cryptodev> --vdev "crypto_openssl"
> >
> > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > ---
> > V2:
> > - Updated commit message.
> > V3:
> > - Removed usage of deprecated crypto strings API.
> > V4:
> > - Reworked cryptodev capabilities scan procedure
> > - Moved AAD and digest from rte_mbuf to separated memory
> > - Released allocated memory
> > V5:
> > - Fixed coding style issues
> Hi Ciara,
> 
> Can you check if this version works for you and ack if all good?
> 
> Regards,
> Akhil

Thanks for those fixes in v4 - the openssl issues I saw previously are fixed now.

When I try openssl/QAT or aesni_mb/QAT, the tests skip with no common capabilities.
I think this might be an error on QAT side, that capabilities aren't retrieved correctly maybe.
Needs further debugging on our side for that, but we have a bank holiday in Ireland tomorrow so it may be delayed.

Happy to ack this patch anyway, seeing as the tests look good for the other devices I tested.

Thanks,
Acked-by: Ciara Power <ciara.power@intel.com>