From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A832F41EB1; Thu, 16 Mar 2023 16:46:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 886BA40DF6; Thu, 16 Mar 2023 16:46:49 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id ABC0540DDC for ; Thu, 16 Mar 2023 16:46:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678981607; x=1710517607; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4l44JDcAIO56JhY3kBFhqUkzIRzduGAJn2hG/rLiyqw=; b=gDm1GgPCa1B/WbpRpVeMd5sh31QGANEsuxFLJllZL95Vea2i62m9RzAs rUpvyR6PIlaMOPUtDPPRuZCoYWfEciodHTLwDPJ1or5eze05SPd/Uopa7 U2A6P7QdSUBjGWDJRp0OudNJhYmeYfkb5LP6V25q8cQ+hsWwFN4ZLgN+h WlMToHqh9vnllokxJzqxo37BmuW/mZVWrw43BZ2Steu7SXvnvwnJeD0T5 21QRbCsAZ2X3gWw7TumXCRw7l3CKaKO0sul+PEPmdYnnespCjG6fz0ncr oa6aQiI5RypRJDjNon7JsGxBZYUTQIFXegtUI6fVKUc+R8XTvo1QVE+R7 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10651"; a="402917659" X-IronPort-AV: E=Sophos;i="5.98,265,1673942400"; d="scan'208";a="402917659" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2023 08:46:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10651"; a="803802032" X-IronPort-AV: E=Sophos;i="5.98,265,1673942400"; d="scan'208";a="803802032" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 16 Mar 2023 08:46:38 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 16 Mar 2023 08:46:37 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 16 Mar 2023 08:46:37 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 16 Mar 2023 08:46:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NlxxbXsoYOy6GSnYhtzV+FlU3MdvsT2rki0F3hQQwpf4w77wJZTQeg8QUdCd8TGq0MJpYmBm9S9YTbAfxpDXlPIaIGmkoPGkBSWo/Mzbbo2lmwo/+clheXGo9W40ScO9Xtv/L4zgPo36OeHJLbBEwPjq/PYiwrsI5Gf3/41fOxjCC+F2XA2QXqkqsEs0E+W67jurjUm1IgAb2GJQjJhiiKWFYt9KksS3hG+GNmUx7WCMi2Op0aGfUwIoe+AJH+VlHLUh42WXwREoueuyF8eSbDWWhHbAEefKHpfJ/vAcjpvPVCO9CQeX6kIFrJ2d0cDWX1Gxr1Du9cS+4LwQF6BkYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QJxlj6rX2x41R/xcmtbZGRXOl653MYU3MvZFP/87CQ0=; b=bG6FUgKmyIiCWnOpTIcsrNUEgz4KmlN1S6Isom8Qos9Yj9XxsnDVGL06OnmzlGbDD+Om8mo92xO97agXZ00aEv28tduXAKC8RGxZ+n6ZxCJ3pDldi/7bXbNAmrCnj9VpQd0O5/w+cCpuOeplC0Q4+kWjebgNUj/tojgqUtLUHQG7FCU2xlQ//4wfjTR8Hy1TQf7++iD6ZkB1glogHsV1SnB/MlhFzIEJ2cZB1ii8iUM2t0W5MufZgLP0eAb/wkNZNHzgpzPaGTmtFOuL8bGJPQwXQxUeLPN441z1Cce9MmTB+MwZSwSoDVnOYrdJxRU4bbTEbG76UV++We2TS5E0wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by PH8PR11MB8038.namprd11.prod.outlook.com (2603:10b6:510:25e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Thu, 16 Mar 2023 15:46:34 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::c93b:1b21:8d22:92d6]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::c93b:1b21:8d22:92d6%9]) with mapi id 15.20.6178.026; Thu, 16 Mar 2023 15:46:34 +0000 From: "Power, Ciara" To: Akhil Goyal , Volodymyr Fialko , "dev@dpdk.org" , Fan Zhang , "Ji, Kai" CC: Jerin Jacob Kollanukkaran , Anoob Joseph , "hemant.agrawal@nxp.com" , "Ji, Kai" , Volodymyr Fialko Subject: RE: [PATCH v5] test: add cryptodev crosscheck suite Thread-Topic: [PATCH v5] test: add cryptodev crosscheck suite Thread-Index: AQHZVnzcUXuaDwUPB0SBYbn0J1N4Ca79KtmAgABkE6A= Date: Thu, 16 Mar 2023 15:46:34 +0000 Message-ID: References: <20230314133251.3023193-1-vfialko@marvell.com> <20230314135609.3024256-1-vfialko@marvell.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|PH8PR11MB8038:EE_ x-ms-office365-filtering-correlation-id: 7bf45b6b-eef8-436d-d120-08db26359efc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: syvTo86SmEEvN2knB9zgVBnc0L8x74kFxCu8inVVSj0iF9GO8JQzo+ZhiNO2wEhz+9P/ufkP45PIou/mbL67GZQBjDNpkDvrCBBh+NqaLe+oe5NCBXInmynlz9V4vOF76z3LUgvXaoLj0YLtzyPFNEdawJGGUkqZl2q8zHW9k2QNDG8v3o5KGaJ7+FksvwpVVwaoXumjbd/xDbvItNYH/NT2LR2Fg+qUqY8r9Wxq2jZI2W2KCo1EwuWKNyVHXTJnMJD7KsdoM4yJp5GkzvnBKDNjPmRhKGlgw6yu5uTf9pJnKSVh9vUeVLZvO4ZzYGBLUtvp3YPTj8He8djL3w3Aa3o19VuNRkDiTL9IYg7iOTAK0QDPku2Y7BATyGaq/YFcMEgZFSPxapGinBvTRpKp0uX8dKeRXXzVaDJTeDrQa7GWfvbm4w7ywhA1SYptwmmkK8x1SJvgAWEGtXCfRQOdPjgykrvINwqKORFNvJGNrCQGy8+8D5qSl8sleMVX4wlKWfmmh/n2aMWAg1NL3wXZ33A2nJittf4UqfWu5Z6wJdOLjGrTolIpAJzDAY98Q11lDWJ4PrkcgqLAiWRCfYckqPQEv7gxQFEgux8eIuRe/sSysYMNL2K4tK48khd908h1DfAMzEpmDKYSkJt6b6vyIvc8jiz6Yscl3WuP6JTCrihxoq6SLJhnUBEEBcaLVOOX4Z7JixfPORSF+EUzAdqPEw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(136003)(396003)(376002)(346002)(366004)(451199018)(38070700005)(33656002)(55016003)(86362001)(122000001)(186003)(54906003)(38100700002)(82960400001)(8676002)(6636002)(478600001)(66476007)(52536014)(110136005)(66946007)(4326008)(66556008)(64756008)(8936002)(76116006)(66446008)(83380400001)(2906002)(6506007)(316002)(53546011)(26005)(71200400001)(9686003)(5660300002)(41300700001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V1KNFkIE176mPqU+kViwpaiUvImG8hK80Kk00HqYSbYe+ctQznZtQOYjICvB?= =?us-ascii?Q?TS5VSsXGwp5yozPL8VszmGYZU/yZiNuEFvxIozcF/JohjFScXS9RiZrVFEML?= =?us-ascii?Q?Oxb9yDmjZkXzbzKsb8GfgYXowQROpcG7umKIROE92ZB2aj4t4xvZHcxoDTZx?= =?us-ascii?Q?tVrKeigxkiEdaJfRg7FrbnRIffQXyzq7GR33UuT9iNn/6y+xFpBG6WEwlUVB?= =?us-ascii?Q?Ueje1gh8zS8dHMKFOcLBQe/yucjF1WnIsrdoCRppaVDof398CjvajW6BV7rw?= =?us-ascii?Q?DXjsML0v5CwUIwYQ2TQ4LZcJ5hudMG8nqJarBkKNSWNMmweuhZJcTeJ7ZhEi?= =?us-ascii?Q?kk4de0laijuxHFg1VETqirc1ODvr34LeCP+wvd8hYsyZ3z2TawTKXB/EV1pu?= =?us-ascii?Q?Z+TEum27qetyA+aUulDqpqurNdtbzIEeMxqY1ZpQySFghZmXhP+ploSJ3fuG?= =?us-ascii?Q?hnVQ/A1NxYLbAEMuGU8BNa8l7fvdoaKvaeZct4vAbahlmxy37oAWGTHmplfR?= =?us-ascii?Q?iYDLf4Rie7iYAYkoApQtNaQLfCNNh3t9JeGFD1ajUaXLCIOjfg49HIk8NCRa?= =?us-ascii?Q?UENAOwKZmTzYongJbl8UTHqHUivfI9zJ9sQhRoJm7eacvIlg4aRXwS3iwRuP?= =?us-ascii?Q?diJ77xW+CFWPjXqridQdz383ovzgLWx2HLq0KUtFRsnxEakq2O6lMARYhpQc?= =?us-ascii?Q?EJhO0XScvvRRvdSSp5/S1eBUDDN16aiTzRUO7ItaUm22eNCJhSyk+m05IcvV?= =?us-ascii?Q?5T19SbGCtpMbNDlpozr2k4CO5/qk74APKflnLUJa5ofq9OIXmDs/Ao4lMTWe?= =?us-ascii?Q?ZqE9SIH65b7N28EV6VCfZd/4KCd9QppU7ZGl9gv+JaoDDA9K4e18bDNaSMr1?= =?us-ascii?Q?dioEnxGLG/8Eg97JKAv6to/JFeeBD//2p/I7x5Vj0+vmJYQJgaMkhBZZZdE5?= =?us-ascii?Q?2XGcMjve9/ggEbKgQjjE7WFrJT0ndvuO6xmj7UgoUwGu8PYnYil54FTs3iMN?= =?us-ascii?Q?fOC6Ig8os3P0oRVSzN509sDm0rmYASM/57MDUQNfYVeu6F0+9WrPi9LAJErD?= =?us-ascii?Q?zw8f6793E/ugZXvfdxBqEQr6bgsNbvyNsqtLlfGwYzz23esRKeiWBsSFYQZ5?= =?us-ascii?Q?0cA3Ma8ACqEsDIZYT4uM1AxREUpzuo06Bb0qNMl9j6vbVI0EFIu+0nqB9Kzw?= =?us-ascii?Q?lKM1m+cMoPd9jw46Mr+w2e24fZEv9jIQ0o7YZdHGgd+IXys5Ff+SFszGdcQz?= =?us-ascii?Q?afs1HIdgHwwK6/dBQDcSC1sb+OdYCP/tMrMR4XbEu/h9LsBUnWn0xioWgTWL?= =?us-ascii?Q?0UYnxfegc2964wHoWCOacFGTLxrcWGUJgofTmfeuUCEBCCuEEnO8ov5YtRIK?= =?us-ascii?Q?/wDuPedGVdazPjPZdk0NfhlzOlAvE2dWyqtrdYInCeFCRlaxNgmprbdbXt/m?= =?us-ascii?Q?RZOMzNDr1nTMdN8ribik/RyyOoSFvPoILOmVj5if2NLAUGoFRwgiIgcKPCEc?= =?us-ascii?Q?BlVc47dN0s78Jcg4ctmJ2EfYeneA7Yh1MzHBvFfSXsH/0nyOtkWBQ+HqB8eH?= =?us-ascii?Q?mUWGGDdKi4tkH/EjgW913xFRCUO4p6HSdEmTOyEZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bf45b6b-eef8-436d-d120-08db26359efc X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2023 15:46:34.4923 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QGV+B8htvEQ17RtZfPVkukHUnMxhNqg6AzZ5+7GCAh9n0vznY/weRkJM5IKlxpJMcSd2hwRx18tpnrgrV6BD1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8038 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, Volodymyr > -----Original Message----- > From: Akhil Goyal > Sent: Thursday 16 March 2023 09:45 > To: Volodymyr Fialko ; dev@dpdk.org; Fan Zhang > ; Power, Ciara > Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > ; hemant.agrawal@nxp.com; Ji, Kai ; > Volodymyr Fialko > Subject: RE: [PATCH v5] test: add cryptodev crosscheck suite >=20 >=20 > > Subject: [PATCH v5] test: add cryptodev crosscheck suite > > > > Add a validation test suite that helps in verifying that the output > > generated by two different cryptodevs match for a wide range of input > > parameter combinations. > > > > Crypto autotest performs a comprehensive testing of the cryptodev but > > since it performs verification by comparing against known vectors, the > > extend to which various parameters (like packet size) can be tested is > > limited. This test suite attempts to simulate various cases by running > > same test case on different cryptodevs and compares the output > > generated. The test suite relies on capabilities to determine the > > combinations of tests to be attempted. > > > > A typical use case would be to compare outputs generated from a > > standard driver such as openSSL PMD and a new cryptodev PMD. This test > > suite is to compliment the testing coverage that crypto autotest provid= es. > > > > Currently supported symmetric xforms(cipher, auth, aead) without chaini= ng. > > > > Example commands: > > DPDK_TEST=3Dcryptodev_crosscheck ./dpdk-test \ > > --vdev "crypto_openssl0" --vdev "crypto_openssl1" > > DPDK_TEST=3Dcryptodev_crosscheck ./dpdk-test \ > > -a --vdev "crypto_openssl" > > > > Signed-off-by: Volodymyr Fialko > > --- > > V2: > > - Updated commit message. > > V3: > > - Removed usage of deprecated crypto strings API. > > V4: > > - Reworked cryptodev capabilities scan procedure > > - Moved AAD and digest from rte_mbuf to separated memory > > - Released allocated memory > > V5: > > - Fixed coding style issues > Hi Ciara, >=20 > Can you check if this version works for you and ack if all good? >=20 > Regards, > Akhil Thanks for those fixes in v4 - the openssl issues I saw previously are fixe= d now. When I try openssl/QAT or aesni_mb/QAT, the tests skip with no common capab= ilities. I think this might be an error on QAT side, that capabilities aren't retrie= ved correctly maybe. Needs further debugging on our side for that, but we have a bank holiday in= Ireland tomorrow so it may be delayed. Happy to ack this patch anyway, seeing as the tests look good for the other= devices I tested. Thanks, Acked-by: Ciara Power