From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78C1E43895; Thu, 11 Jan 2024 18:13:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 643D640691; Thu, 11 Jan 2024 18:13:35 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 07AED402AD for ; Thu, 11 Jan 2024 18:13:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704993214; x=1736529214; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gWHBz+aoAgUojC8XE0Ty9oLd+nzIRsc5RbIj3YrzOJE=; b=bi4fWZw7niNDfNWdXYekTOeHNFQL+6r+2Y3dxjzAQ10VAfUI02J8YHaZ Ac9wxQBvpuNeffv/XYTjSOem3C/4AQI4LerShUUaikQ2I+iMB0jCTOq/o lCAoSu3JyBS+GXdCZdXXviCXP4GLsG29P74w0RjzBv8gjQ3Vxn2bC8/AI LagsGj1NkFxdRPwXKyE6veXeXtBHWel8cy5BBPZpvd/XufuWpKdU+ctFg q6DUpOMldQjY0kP8M9iTF3t7mms/7yrTAYBod8bl7LTncj0T+DGAsbJ1M UleC1XXPFStGrchj0mCY7JisKTbXyFNISESIOWBnIw9uOCsFNVbmc1uv4 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10950"; a="12278415" X-IronPort-AV: E=Sophos;i="6.04,186,1695711600"; d="scan'208";a="12278415" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2024 09:13:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10950"; a="873091734" X-IronPort-AV: E=Sophos;i="6.04,186,1695711600"; d="scan'208";a="873091734" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Jan 2024 09:13:32 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 11 Jan 2024 09:13:32 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 11 Jan 2024 09:13:31 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 11 Jan 2024 09:13:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y0QPHOnAmArIYeUmG66EUumMX7ggmPrl54VzagqAmtkZ7UoeelJzZbdW79Zn2rrTv8m627LO1KSiHx9B9QFctOmLpbNy7lIpAop0fcRcbZ/fEf5jEo61m6JI0WSmR0XjQhiTboM0GgeytngO48nouILML941EgARsWuNhLq4cl1K7a8MtJETd5BVaJUHUmYZT+CY9XVSPns8mtaLvNQ+tV84+HjbcN4lMTGFdtkSe+iQlPrTxxBOlG1sVSrFfCKZNm0XLnMzs1olLdFzaI1k+bNCnBDVSe11PUCCi8dHhGqBY+TdE8sdw2oMU28vyOIZbaK2ed4jCUus0MH6R8l0eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gWHBz+aoAgUojC8XE0Ty9oLd+nzIRsc5RbIj3YrzOJE=; b=avJj2A4w2q1PLa0IVOjmphf4DZTjS9c1+1vMgTR2/X9qT9SzwymQnqhnstK94M2kDXuYwB2IiMUPQn1E+aMS7PB7IgKIrC3a9GOtC2NNlXiJ8pSnIZT1X2XYRqjuCfNRAFHOZDpSqn5j/Hk6CXDVRl6rGQ+8mF1D7OrBdfKEtOmyiBKvByVWum7iHhRv8JWzoRxupigrjfKngLSYiSqsMWCN5bQdm8er/Y9s9dn9SZ7BM/99ng9xc7W2sw3U6uclQHBrS4s0DZfzz3vlEImxNC/KrmUYlrTus+I9tFQ1Z1h3Lq7cgDDI+4j0pFNNhsHwEwj7DyXha5uZYi1n6VaFiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by IA1PR11MB7679.namprd11.prod.outlook.com (2603:10b6:208:3f1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Thu, 11 Jan 2024 17:13:29 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::8a06:eadf:e98b:23ad]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::8a06:eadf:e98b:23ad%2]) with mapi id 15.20.7181.015; Thu, 11 Jan 2024 17:13:29 +0000 From: "Power, Ciara" To: Jie Hai , "dev@dpdk.org" , "Wiles, Keith" , "Richardson, Bruce" CC: "lihuisong@huawei.com" , "fengchengwen@huawei.com" Subject: RE: [PATCH v2 14/22] telemetry: replace strtok with reentrant version Thread-Topic: [PATCH v2 14/22] telemetry: replace strtok with reentrant version Thread-Index: AQHaFtc2laf261J100an3A+PZkI667DVNSwA Date: Thu, 11 Jan 2024 17:13:29 +0000 Message-ID: References: <20231113104550.2138654-1-haijie1@huawei.com> <20231114084133.3573959-1-haijie1@huawei.com> <20231114084133.3573959-15-haijie1@huawei.com> In-Reply-To: <20231114084133.3573959-15-haijie1@huawei.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|IA1PR11MB7679:EE_ x-ms-office365-filtering-correlation-id: ab1026d1-ab2d-41c0-378d-08dc12c8a1b4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9J+ddE1ofQXH2S6J0ghY91qnTAxKoxzMkhdm0H+2vyKrZu9wPjsEI8l2qZl4vJeGJfzivOkqbFklz5vCIK2Hkyyrplgf3J9nPRkKq13WI3LdXH9ucfajjzO3t9kksAF1XBOBmD0w/ohf6c9An16boXW93kXdEiDVsiH+X+XwcaP9zr9je8v3TGE5k+uwT9myM4YednyHLf4jnuU2p28z599v6nSBbwfWtawGRrnF2+YRe5MbveA7afZTY8vOySnwexDwswz6LwEmOasYQjO+eTxSVUbxibxCzN8IN4wW3Gw0IocdolJD78JWJsmBKpeeJ4RmO+Ja5IHM3EbBNXG+mbsZbKT5sKmiWf59vCOgvAmr9jFu/5AoLD/BX2+QCEY/5QTBZ9G3ukVdKfZwANNW9+Jj8PkwMjX/2NIC7IcWBKJQu5EDnP+9C0qkdRrdOZq2UYaji+LKmB3PPZ2tJHuzTa4TLqWk/JVSIG3+5jFjytK4ykdIO/H/Z2HsQbgH54lVh0ZyLFGMXI+3srNcjuko91hEp72pJUQivfIx40orMPaZAefnjzyRBZMO0vaP9lB37FYB1RPiQTvSPrZOpRupq4csTmop+ldM7P4T/xFHtc60fiywau8qtyWRMVBf90Xq x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(39860400002)(136003)(396003)(366004)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(55016003)(2906002)(4744005)(5660300002)(38070700009)(41300700001)(8936002)(316002)(110136005)(66946007)(6636002)(66446008)(64756008)(52536014)(54906003)(33656002)(71200400001)(8676002)(6506007)(9686003)(478600001)(86362001)(53546011)(76116006)(26005)(7696005)(66476007)(122000001)(66556008)(82960400001)(4326008)(38100700002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EpK76agSt+0l2whDa67CFodOm60Ad2KDY3to5wG5B0rHr7F8jIih7sLkt4zw?= =?us-ascii?Q?7sQ18UGQ/FVqsLEBzJ0BuSDNJnG+bQaN1tgA4lDNJCnAWKkHBBmkYN0jk/9G?= =?us-ascii?Q?y2Vu7pOwRy4aKeST1fNkKepO+nrGvQ7E63LoGSLCH0xQyhmiDG3aiu6ASE3R?= =?us-ascii?Q?AwW+DkKmWQm3zUbZQcgkBcYXNnVX8/EaTBZrt6zOUe3jcZIkYP/JY2l6jEeD?= =?us-ascii?Q?3a5+VCuBc0oleX78D3n47TE2ZZmaGuEe8OO2f4m90ZZ8E9o//roQ3r1JveLN?= =?us-ascii?Q?QjV+FP7L4yK4TBxf6C+uhzNzDPZyF5Nb2OzJrVJMgV/NelWZsNClbA7pFOpu?= =?us-ascii?Q?CdFOf2CwmbYc58jNdGWkdUz+h76ucblEuUXBstqUpurJTHFXHoLuspttLfQV?= =?us-ascii?Q?UWa3XbXKJ20AlJ9R7Zg8i/V+ki7rmkMLbDlrDwrw0348y9dEvHz3SZJSCqBr?= =?us-ascii?Q?4gqjI+YMnxJzFjPBqkrGUJ7150TNcKLHzYVJn/gE+VbbH0nEFXv2CkPua7C3?= =?us-ascii?Q?4mfm6/xeD2kgXP60Vgby79TYjY1WbiglJJD9U/cB86uEMv0U8nd3v0W+nPrm?= =?us-ascii?Q?24+5aSUJzHp45fKZJuXC47a+LweSsDmYW9caTWHEUWnEJwJpc0pCnfHxb7K3?= =?us-ascii?Q?kU0wzNmhl9ZrDx9vTig9+/5Wx3zu7PI/UhtfHIYd9yuuWpicv2qONNu/LPUv?= =?us-ascii?Q?V6xdfp8px8+gqKP/GSIR2/bmTxKwzhQX3saTjgKLKbc/C1prWrjcVsHe/BR3?= =?us-ascii?Q?4eXCs4XOQyzDNjSSjqY/tloU7QSIkQn6pd+cyyoBmIQHPNQ2AS+tmO+eKDep?= =?us-ascii?Q?B7J7KKA1+RaQHrz0BxSkr+7nFk/7HkkdjtiNRRJDBz7WGtTQXekTpxWQeH7A?= =?us-ascii?Q?4DbTNnIihb9CYNerVnAQ8hQnY3vSClCDzkKQVUunIuHoK2tYU4BNnDzvIRJi?= =?us-ascii?Q?DqNIpzq2gSefB3hotlIzS+Pk8uXgMvMFsdlADMRYE0cYQZwmslO/6OMD4mbt?= =?us-ascii?Q?l60a5W7AojTr11KxZw4ZmbhJkZUaYUEQt6hmpo3KXK04y2xEYinwW78C7CFS?= =?us-ascii?Q?BegJw3Z5ja8oVBsyMRwneZ6L85XA81GxQnjgsaF3qgmSp7a4sep7NQT1OlU6?= =?us-ascii?Q?/u1GCbhSe+d2bBLT141mUcnWVTY65D9MlcSPwJzG9XfhCmuvyPNLmpbcN8xA?= =?us-ascii?Q?vef2HUiXETXE/XzMuOXEOVUdMcWeWEBrky2lY0ynvFeha9AEHHd6jrxG97Vo?= =?us-ascii?Q?cQSxgdNstnKMUpTFyuRv5IJnau1pt46h4SL73ufLpsHTDkto3hYYb3fL/nNY?= =?us-ascii?Q?dQ6t3pnSfupONZbhTJcJ3+gFDaOOvIXBacq3lLI0J7wGEF+7RwGkj87Tj6Ua?= =?us-ascii?Q?Gsl36BoLeZMmH5+as/KP7PnWxE6b1BTLXwn0HuXGsFWer+xh7oKKHYZSa1g+?= =?us-ascii?Q?3mp+y6afmJFiH538eq8DisqU/CQAn20e8kOkluc2NpW4rGJFvc4nRPo+bbOR?= =?us-ascii?Q?hrztan9Trja07JdTVQDhvgtt1chljZo55l6NOVebuAShb97aMDFw6fyvT/jA?= =?us-ascii?Q?LqUb8d2EN7VHpY0yj/iaI7cYwvCUQrP2/hCbg0MQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab1026d1-ab2d-41c0-378d-08dc12c8a1b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2024 17:13:29.5095 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p2ubnukH8+ArEq8HKXids0cLDORnfS1LE6uT2d2e+pyllY/omeM+W9uymXlhP1A27CXwvFHBzcIy/zOmEywNIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7679 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jie Hai > Sent: Tuesday, November 14, 2023 8:41 AM > To: dev@dpdk.org; Power, Ciara ; Wiles, Keith > ; Richardson, Bruce > Cc: haijie1@huawei.com; lihuisong@huawei.com; > fengchengwen@huawei.com > Subject: [PATCH v2 14/22] telemetry: replace strtok with reentrant versio= n >=20 > Multiple threads calling the same function may cause condition race issue= s, > which often leads to abnormal behavior and can cause more serious > vulnerabilities such as abnormal termination, denial of service, and > compromised data integrity. >=20 > The strtok() is non-reentrant, it is better to replace it with a reentran= t version. >=20 > Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jie Hai > Acked-by: Chengwen Feng > --- Acked-by: Ciara Power