From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DAE443895; Thu, 11 Jan 2024 18:12:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28714402AD; Thu, 11 Jan 2024 18:12:18 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id 0B2CA40269 for ; Thu, 11 Jan 2024 18:12:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704993137; x=1736529137; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DVpzY8bMcIYTEljcHf5m5lUIwRGYWS2JT4ss0fU2As0=; b=aoY5ZNQ/qhvkXD6GnDE0b3h3cbxxtFvLWO79doeJfuTfTDGMaqwZRcXC y9OTy46m7rzF7vqseTF8J10q+7X4/sywAYflJ5ahjbxG4Ke+rOoBtAoVn 3EZLD8tfenrV8+3J2FriIywjB90DWSSGtFTIpGNlgzECtKQ5XFuuKF46n 2+WG35IkRzr1GwPthEbxmzWm/t3PojdaNzceB8SeAOyi9QEdwRDzHytfb myoRj5rQyAIKRqukuU4Fye6ooBtTZwUUAcF070GusSaZ5fQl/CI734guy S1lbrBk7/z/tNrmhGFpeJpS/yPr9KT8+1Wei7oQjr/iHiHW+eOwXVNKZK g==; X-IronPort-AV: E=McAfee;i="6600,9927,10950"; a="12404021" X-IronPort-AV: E=Sophos;i="6.04,186,1695711600"; d="scan'208";a="12404021" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2024 09:10:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10950"; a="775696505" X-IronPort-AV: E=Sophos;i="6.04,186,1695711600"; d="scan'208";a="775696505" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Jan 2024 09:10:06 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 11 Jan 2024 09:10:03 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 11 Jan 2024 09:10:03 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 11 Jan 2024 09:10:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T6fbbAGDi7hebvJ5YPRLs4MfrqWNdZaXdDFnin5mw8gFZaaP9LLCuDRcv3AR62YLL6FmDIVIHItQn0zji2hhQbh9+244JjZrDR9MAhwOWH65fKaJ0fAV4CJ3I5QarPGaTr3VTcMioLIVWYHAM3PqHcvnCHnr9530pKlpjG3ota+sBga7NZ4kld9rtQi//hOwwz6mqxsNqNHJMtpMg5IbqVF27/x/qMWOaOFSmDt3DVa1ahjQeQESIpDCLCnu4y78NRCrB3aqNHukWr2cZg/ambbHTH86QxTtRqrCjTgEHSXqbJpnqcvu+bIXLlvWYHTp3cU14Y1bjz7h+Ol88yzdnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DVpzY8bMcIYTEljcHf5m5lUIwRGYWS2JT4ss0fU2As0=; b=G+6Mk57D0y7C7MT995DJB60BC3WIHYOHIbhNhUlXWXBssXGTOL031Q36qS5BrYdlLRHw+QGKhyPYQFY01A6jsaboLwOwqJsp5f6gCY9HmsRsoFBuEQPGFepyui84kpbEqeNIV5nr/xEmkF2c06eF45gl7CU9xahWxzvahYyadXjX8YekTcDzedAuYXJwlhhCqGekq+qwlz1y9HcWjj0h+4EvftvBHaHeB9PapQ3VV9rgJHuekgbs0o+WsWWyg21ScQDIAYyUPycTJN5wO/A6ZngVpddUHolrRHZvDaLOLz43xzv5XDZwm+ahJjudMsP7Znc6jcv3lBKRSDCQQy1C1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by IA1PR11MB7679.namprd11.prod.outlook.com (2603:10b6:208:3f1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Thu, 11 Jan 2024 17:10:01 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::8a06:eadf:e98b:23ad]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::8a06:eadf:e98b:23ad%2]) with mapi id 15.20.7181.015; Thu, 11 Jan 2024 17:10:01 +0000 From: "Power, Ciara" To: Jie Hai , "dev@dpdk.org" , "Sergio Gonzalez Monroy" , "De Lara Guarch, Pablo" , Piotr Azarewicz , "Kobylinski, Michal" , "Mrozowicz, SlawomirX" , "Kerlin, Marcin" , "Doherty, Declan" CC: "lihuisong@huawei.com" , "fengchengwen@huawei.com" Subject: RE: [PATCH v2 04/22] app/crypto-perf: replace strtok with reentrant version Thread-Topic: [PATCH v2 04/22] app/crypto-perf: replace strtok with reentrant version Thread-Index: AQHaFtc1Cx+mgYmIQkKd7E5p3d8JErDVNCLA Date: Thu, 11 Jan 2024 17:10:01 +0000 Message-ID: References: <20231113104550.2138654-1-haijie1@huawei.com> <20231114084133.3573959-1-haijie1@huawei.com> <20231114084133.3573959-5-haijie1@huawei.com> In-Reply-To: <20231114084133.3573959-5-haijie1@huawei.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|IA1PR11MB7679:EE_ x-ms-office365-filtering-correlation-id: 6521c25f-472b-489b-1afd-08dc12c8259f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yDlI7ZsPNlnk0Pbh+HZuWXcz9hwFkwqsu3w1FvHjMZA5O8uTsxAmpe2/ovJh1XlGHQo7X9fnDKDbOmR+qAMij712LvrCa9i6LR9ghPd7SR7CZpoaKT3LYGrZQ6eE9sDUSn+1ugNXlHd3zUZEci8NuemaEfHRhlIMjThAvdpwb9AuioOrUoZVGLLpFKlIolEC4ixvtqjmFwDDlnYgd2mwH9BRo8PoozL31AvRzTH2iioOynXlC6kQBGWi1T1BkdHUhmRhPMkLr9Cv0P8Dh+qoqNZ6PV721HHrMusofRQjE3I3irn6wqjPogLcECf0CzzlcwveOwQIPf50QyD+Uam1geDFAHV5CNwv8IO5GOO5psgW3v4xakdg1WZzGZqM9gUbzVd065AMS2Kl5eBRTqR3xD94U6M6/WkuG1sGn+wx+UtbGsXzRlPftSEoNKOKaIX5SKrTfT+K5dFQj0RHn7px8vyl0T2vd0xncOpOpt5Gg5ExmOcU6vhypgHTCa8duCmFoobMzCE5Rh3YOoR3IwXprc7vi+Pw6HH6VTsMNqRorStai1smIkBqfhp6shfKU3Q9STXs6rsCppTooRsn1V7sW9sKl9BrIPfKAt7GZFoWjsDdw2TKk2QprhpKsP0OEob0PZADbm3OZmErJEmirtXakg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(39860400002)(136003)(396003)(366004)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(55016003)(2906002)(5660300002)(38070700009)(41300700001)(921011)(8936002)(316002)(110136005)(66946007)(6636002)(66446008)(64756008)(52536014)(54906003)(33656002)(71200400001)(8676002)(6506007)(9686003)(478600001)(86362001)(53546011)(76116006)(26005)(7696005)(66476007)(122000001)(66556008)(82960400001)(4326008)(38100700002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HX9judhydUWwDpk5KdDBzVVFu0HLr0ws6GhQ3ZTJdWWTvWvrvbPUE68flDIK?= =?us-ascii?Q?wvRBXGDw/RxaXC7mYY2IIoibDzq/d5UbU3y3vcuflPYPBpt3aatDAWt2GZk2?= =?us-ascii?Q?Ye0LhGEFdYeh0JxYQtpWycJnzmox+L6EWCxNNUj4VFJOkBd04fnhJ0+8p+uS?= =?us-ascii?Q?1Fj8h6KQtk0vddcRRZpYnmfgFfmWpyihpSTGoA69vtwUgZ4e1HLIVl+4SWks?= =?us-ascii?Q?tqkBwAeXbEjK3zpsuZq/5alUqMUviocjIcbd9LrZVLPkftV44f6aLDJLYTsZ?= =?us-ascii?Q?GhlnZeI3Ken5fxugXJ5wOzftLORWE2jabhOcXbRDlzY3TFR3Dlxl6gQzsGqP?= =?us-ascii?Q?rFlnfzR5eO0G6J4imp2KyoP/5Y1dfQNuQMbGwleWb88/96Pz7F53E+WZFcpI?= =?us-ascii?Q?IAy3HZrInKGWPcAe8Fs2Gnwf/EyyFWCnsjmykx7G6rjOBedzuZx2uWJx1gG7?= =?us-ascii?Q?GI+077g5OKhMWfTQgHgHVel73IiqtQqbWK9PjnhdqKrh8PEwJ0R3NfWDCvG1?= =?us-ascii?Q?+OR8xs/wYepfYmRoZ6O79AhYa6elVvuXD7JNGlfA9V7JxlEWzMuoPj6Fpdzt?= =?us-ascii?Q?gIwWjEQzUjP/fE0zrwbPEQYZzbGjTdfRBVAeSMXyOlT61KjhDBRbZJhUhplw?= =?us-ascii?Q?vh1YkBGkW9MdadHQ4FO2hWwcAawmNKOuTSGn9MD8Fn6knJYrKc2xQdilzgcf?= =?us-ascii?Q?VHpewQG2PrCF2Siw0zW/RSIWxagSSuFeqMNxAV+UZe8lmx2sdGYFCGIFTmZA?= =?us-ascii?Q?hmgyjmuZhUkblIsfk7+suo77Ka9A7Oe5i4RueI0Tn/1hNUctYyJ8rMbOud3R?= =?us-ascii?Q?xIV6f1R5PtpsIw96ZUoS5Jk0vUbtpXdRoHszQ1tDaD3UNdkRLATFNZnzhYPK?= =?us-ascii?Q?blOlWlnxTeqeOZuAZ/De13h+nEIeaLS/t/890C7r1Ac491eb0HaD2qlFeiZt?= =?us-ascii?Q?amg/PVs5/CJBWiaXGS/NAfQGBhGV87+WCwZAAo0KpGJQcQNc6WQUyVrLyu5V?= =?us-ascii?Q?6LL2H07etDW2voPjJ71ieN2BzXXaZ499dPBt5PQxDlOZ3Y+hl0PvJ0frgUfc?= =?us-ascii?Q?znIdaWyxNqRKAcdXmnazRi0RIVZNCZqVjTiZETQ4Ld1ekmR59ald24pXdjaj?= =?us-ascii?Q?h1J/KuLzVhhX0VNf+ZQYB8d3x5HFfRBRf0LS4NuaIujLeiVfObRErNCcw3YZ?= =?us-ascii?Q?kvvD5pfrrX8IBAxIRq7NCCETkwn4XyMBkud6BTahySZ4O5uTUpBwpDPT0iR/?= =?us-ascii?Q?XoGKcDfa8yjU7+OFmzyJoGp2yB5t//t64XAnr23hm4foUcLlpIfIOFg0/j/t?= =?us-ascii?Q?Ynwe98WcUeSVOrLS5xtEbBCIm47UB0ZMX0qPCXhK30jezR/Erw8Ev3yBXQJU?= =?us-ascii?Q?zVRmi4k1ouI9zjy75AvtW5h4eL5kLg8b/Aa97zKO2WwsQqNErcAdtDuVZMhW?= =?us-ascii?Q?eDioVBIr8MWQxH5krH+d8wDw6eT5EyIUubpNgZbPyN7wofnBqF2XwYuoUW5x?= =?us-ascii?Q?Ar9Dcdpi/wfoPOtvO3sRx8okiM/WCKA9oHepjqtrpks7C+WB4HV/kMipvP41?= =?us-ascii?Q?kG1SSbwwwvwYD+vsvvIePpurfG8t5TVpuSjUjAKu?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6521c25f-472b-489b-1afd-08dc12c8259f X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2024 17:10:01.3204 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q/jkHJmpUhEaHHtYJ5XKJ/Cz8Eag5JDBuwNCfDBrstPibIP3smYtvvE2DO+iu6zRYxbok7UbQTsSrWmVDLItCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7679 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Jie Hai, > -----Original Message----- > From: Jie Hai > Sent: Tuesday, November 14, 2023 8:41 AM > To: dev@dpdk.org; Power, Ciara ; Sergio Gonzalez > Monroy ; De Lara Guarch, Pablo > ; Piotr Azarewicz > ; Kobylinski, Michal > ; Mrozowicz, SlawomirX > ; Kerlin, Marcin = ; > Doherty, Declan > Cc: haijie1@huawei.com; lihuisong@huawei.com; > fengchengwen@huawei.com > Subject: [PATCH v2 04/22] app/crypto-perf: replace strtok with reentrant > version >=20 > Multiple threads calling the same function may cause condition race issue= s, > which often leads to abnormal behavior and can cause more serious > vulnerabilities such as abnormal termination, denial of service, and > compromised data integrity. >=20 > The strtok() is non-reentrant, it is better to replace it with a reentran= t version. >=20 > Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test > application") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jie Hai > Acked-by: Chengwen Feng Acked-by: Ciara Power