From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBCB042537; Thu, 7 Sep 2023 17:26:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B806D402D2; Thu, 7 Sep 2023 17:26:18 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 3E2A64026C for ; Thu, 7 Sep 2023 17:26:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694100377; x=1725636377; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jgLDjiFSVrI5a//xERmTdW2wm3tA0UtX7jLxlCSs4O0=; b=UlliTtZZqtVSchJ7ewqVQoVESaIIJ6v1MulGr22i8DGOHRMiP0wOadS/ +FQzEaC4KGRP0wONT7HT9wBoVjACVwSFafjWqDfiRbBKXgFMxoUdep5NU YRCzxKY6LqSkZ9uzD5h87u1UYKP7c72S63rGLgPfnRJ8bNuvDG5yHHWKp vUvAkDV7cu5gJvH+XmVRKz54XD4HXS225zU1nPoHQoVSOESdJ2LbbXkUY L2eJQ6e7S8o1Eek8HGmF6RitwIYOJWtWPTtD3EG5J4pAUOewFYb8/4dcf bACO06ME+mcnxL2Yo+7+cIoT239Q0a1tQlF0bNkNh8u7g+R3KG/al6/TW Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="376292440" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="376292440" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 08:25:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="988811552" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="988811552" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Sep 2023 08:25:30 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 7 Sep 2023 08:25:30 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 7 Sep 2023 08:25:29 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 7 Sep 2023 08:25:29 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 7 Sep 2023 08:25:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FRWErJV1oxknHSWKQIDWGOj0PyUnTk1clZ+guhbEiO2rC9bwPgxSascOe3bSeGig0WSYNhchzStto8zOkadUlkoaSafqjNwSlSuCJ+9YQbCnZezCGK5IF6IDpYkjjtItNJxkFU/4FyY7YOl/q+K1Kf2n+aozJmZ8/fwsjXLKIi82IqodRbiiOYubMSD95A6lGhKal+WW2TwjlpTG/89QsJnwPBoyX/khOfMBG9jSx+Drj6m4NujKfE01jo2AyOOKzWBcsO37beRlHyrgC5Id/ZEiBTzohwF1ZaX0Uma5YOQPOzOec4SUCTUTAoktIlwn1u+z/NXG7LbJ380Qj9gr7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SEEtK+4piq5Ej+cqtc42MFBRGmYBV99zdEHiCuVfYdU=; b=bzerYH7irawpInSIwVtJtWOUSfH6bER+dcXAkIbrTvjc3hz3H35wBvIq9UN9Ltr40zLho7b2dme0wb+wPZufMNktsafGZl2CDDhx6tUiDY047QbdiELhdUw5K2tR4ZnJlGKhyg/pi7uJkgz5poQY93DUqM8+zk9PYKoilNI//2z67nL9xWaf2j4mtz4cls/MNjjF7CYyCB+EJ2XEW3DxxVe8O/ecaXP1CiQtCwxwY7iH0LKSr+8Ja4OuqTI+x0yN5XUzApTrQL8lmMcyQZIiHoKOFwLXVlS2iK+6pNJ7Ezl7hnhdX+4kNjRbpR56uBoaUOovk80QcKqKgmbRwwlD4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7639.namprd11.prod.outlook.com (2603:10b6:806:32a::14) by LV2PR11MB5998.namprd11.prod.outlook.com (2603:10b6:408:17e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.32; Thu, 7 Sep 2023 15:25:26 +0000 Received: from SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::4986:f7d2:4c49:b31b]) by SN7PR11MB7639.namprd11.prod.outlook.com ([fe80::4986:f7d2:4c49:b31b%6]) with mapi id 15.20.6745.035; Thu, 7 Sep 2023 15:25:26 +0000 From: "Power, Ciara" To: "Dooley, Brian" , Akhil Goyal , Fan Zhang , "Ji, Kai" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "Dooley, Brian" Subject: RE: [PATCH v6 1/2] crypto/ipsec_mb: add digest encrypted feature Thread-Topic: [PATCH v6 1/2] crypto/ipsec_mb: add digest encrypted feature Thread-Index: AQHZ4XXXcg2KUWxpQUyBBRumGDP2e7APe5KQ Date: Thu, 7 Sep 2023 15:25:26 +0000 Message-ID: References: <20230905161507.1561889-1-brian.dooley@intel.com> <20230907102614.2269913-1-brian.dooley@intel.com> <20230907102614.2269913-2-brian.dooley@intel.com> In-Reply-To: <20230907102614.2269913-2-brian.dooley@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7639:EE_|LV2PR11MB5998:EE_ x-ms-office365-filtering-correlation-id: a603eeee-c736-4b44-0c48-08dbafb6a948 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MC2sqmLXhXRkxHGGkxeX883mjg8xPDzKQY02FgehoB3xNaLpFvWN+9/SojIUqFD9SP4untAzMVEDQWMs3fD21CY0y8l0+18YB1PeejqiwN5ACSNR5yN1Q1KkeIsfkDrHecSmnt4D5ntgu8Fu9TGnGC9N/Qaz1HAWQlSklE1NVTj8TjmASvcrQfdtdcoFb/bwgrFpd9sGDowr+noJgG/zdDbrkpDVfgIENuLELd9m9u9jOx2l3OX8942EQr5WNd5k3TeM4uiZECUjOVPjdHglO275Wsg8z1PXzUyYf8OpUQLQOfsk4Q2cBs9pmR8v0nNlzOFZ5FsFEr5E8pcfCExskk6BnQ0DcNg+J9pNVnsq1hg1ndczPvNuvxli+JFymHDFYKQQZxCgLk0Kz7rcSNzsBTOVT0m0iR3RsKFSeJYmSek9njXnM9ntx/qKVk2GVSDRC0gSPcnSrqSgxt/V8sc8HZwl5NvdeCwonSip0PA7G0VxMahUfSAqQKWG09GZuAwtRBWaXJ75/t6FezKhSGokbl1mmpcciMTI6Y/18QhkSc/MHNscR0cWSQHPcYgLSA9ETfeN3XsEbKNG4NZBoMbJEyBOVUflxyvsA2X0WCOuvlZv+HSL+/9/Jekwx7MpU3ke x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(366004)(346002)(39860400002)(136003)(1800799009)(186009)(451199024)(107886003)(41300700001)(71200400001)(53546011)(7696005)(122000001)(478600001)(6506007)(26005)(82960400001)(9686003)(38070700005)(38100700002)(83380400001)(55016003)(66476007)(64756008)(6636002)(110136005)(66946007)(66446008)(2906002)(33656002)(316002)(76116006)(86362001)(66556008)(54906003)(52536014)(8936002)(5660300002)(8676002)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e8WOydV99zQjjAkYB35xQBAskiRAcrSx3bzvu1nu3/WynnceBG+Egyjqnyup?= =?us-ascii?Q?eWmJ86shVBoMqw7K5Nj5yeqrULeq12KAQPmG3SvDNbvA80p3rZktXDFAcdLq?= =?us-ascii?Q?sFUs2QTbRYnRbjeFkKqzfQgeGNWmm3WYSy3kRj1f5MmCB7+ZMXUtQKFOkPN1?= =?us-ascii?Q?ZuD+CagWhDUEjPOM9t6nTJNPaKkCQRGra0iMFHJSkBxFlPB314mNN9ITEeik?= =?us-ascii?Q?hk/i9EI4qVDDzyd0BoxjSwcrA3RHxRgiaHkWIXwWyU3Uh3DTpmGoR0/pNnX+?= =?us-ascii?Q?VfKbYmfkuBevCVmUDCB5mcaKVZsqbsRgJHG+4ZnadlatebLfLJlsMYkBWBoJ?= =?us-ascii?Q?d8AwDT1r5zQiHoKB2HmLtx51SoKNAwuslo/DXkOvwS/yrx3xXyAKEGRFmrnB?= =?us-ascii?Q?Y3LUp0gUmuOb+6TnVZF2AKeuHIw0Luez2KwpBwj8MMe8AnqviH++JJ3j5KOK?= =?us-ascii?Q?B3fLoEEuakbc6r+yCKJSM8yMa13EryR8xDVj7YM0QjWlK2IfHPU3+rFiuzMc?= =?us-ascii?Q?VNW3I9PxXGyLBBoNNQUk5FEqxlIWk7cyffOK1IQzjKvkhqsUfYDkQz7ytc5r?= =?us-ascii?Q?gLNXSDWjcQCriL4Ry/it0Z6gpWm3AD5yRxjeI+/bRK14mCD52AfARY9XxZk/?= =?us-ascii?Q?cqsJ3LxCO2nmfRgfAvy80XWM4oElhQD4sEOpZqfH+w3MGxlctARo9K5y4vCh?= =?us-ascii?Q?1DfJIDrakCJaXNLSX3LPSFLcXyWuQ3Jr2wnBa6TflUYq8vgzAlASemqvvqk3?= =?us-ascii?Q?4cPshLxpXWd/CF5KBlVaobY+twIrajTbezsg4AsWVNvx0LJ04cUvB0ftkJZS?= =?us-ascii?Q?t49n1iLdWNOQHcHCEvIOe7fetDQ4uk7bveFbSfWapWY+ImpQZkItr8vpyTbl?= =?us-ascii?Q?bIGVzBPtcLGr/WfnPIaCC70JmizoT/P/ZncSyY8ijE9E7Wusevkt99yK84p/?= =?us-ascii?Q?z9cDE5mys8HF5+9fEOnKtZVMk6d5foc7VjePXsaTe1MaBUGF2hQ8hL7l1gmo?= =?us-ascii?Q?2Zt9oj0VWhljgdCE1wBr922Ry1zfL6JVWnFYzgkV1PWjx7RLXIcu9CvnP5LU?= =?us-ascii?Q?qDfrG3SC9C6oyq0/BMzstiGtCuV5mu0Iam+3OMQjElYIi2HXzAfQnfCEEENl?= =?us-ascii?Q?eANtZz6xECcYqc+CeiSkIkSD9z08/E5Jmbijw8vFFV4AV6U6lALMAoNnQ7IR?= =?us-ascii?Q?XmdAo90Zjaf0WObarannQXfV6laq/tDByxob0UQhKxbzmm5yW62CDkpDHyrp?= =?us-ascii?Q?qGu/UWPwuMDhMsHXqvICmS3rIbBQFS2C1GnTEkE9favCxZ8LJZ+TbW3pIzq1?= =?us-ascii?Q?6hmHAElzZjHW5kHo2O8Yi6xEtAqHxpQeMbYKj5eZCUAZJSbmF1XDS59Gsd2F?= =?us-ascii?Q?qGZB0F4vtcCp7MX+e+JsiDLY4SOTsHgLQBZwJLr7iFPyJy7OrdHZ/M9YvKUU?= =?us-ascii?Q?8TKZ7U0qGEpPp7JLsYos2RpbRwBdcg5/3LYpUqFO06Ko/8IWLgbC/fCMOkyf?= =?us-ascii?Q?2vg0zyP3mG+iidXtyfjyuaI2/AmOgx7yjo9p/48hyw9LN8adMNFiB22UvCWO?= =?us-ascii?Q?XCiAwxMmPhxbZ3HyVkgX49AqSlAyHADYV56fEFEH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a603eeee-c736-4b44-0c48-08dbafb6a948 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2023 15:25:26.1860 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jZdRe5tA/5kE9xyF/kDVR6CsdkkuTY1AV+5kQEdbm2xRMPB+sRt7jhbpGjwCW1VqD3Fh0xqW7Jrc7by5aOWksw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB5998 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Brian, > -----Original Message----- > From: Brian Dooley > Sent: Thursday, September 7, 2023 11:26 AM > To: Akhil Goyal ; Fan Zhang ; > Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Dooley, Brian > Subject: [PATCH v6 1/2] crypto/ipsec_mb: add digest encrypted feature >=20 > AESNI_MB PMD does not support Digest Encrypted. This patch adds a check > and support for this feature. >=20 > Signed-off-by: Brian Dooley > --- > v2: > Fixed CHECKPATCH warning > v3: > Add Digest encrypted support to docs > v4: > Add comments and small refactor > v5: > Fix checkpatch warnings > v6: > Add skipping tests for synchronous crypto > --- > app/test/test_cryptodev.c | 6 ++ > doc/guides/cryptodevs/features/aesni_mb.ini | 1 + > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 109 > +++++++++++++++++++- > 3 files changed, 111 insertions(+), 5 deletions(-) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index > 956268bfcd..70f6b7ece1 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -6394,6 +6394,9 @@ test_zuc_auth_cipher(const struct > wireless_test_data *tdata, > tdata->digest.len) < 0) > return TEST_SKIPPED; >=20 > + if (gbl_action_type =3D=3D RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO) > + return TEST_SKIPPED; > + > rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info); >=20 > uint64_t feat_flags =3D dev_info.feature_flags; @@ -7829,6 +7832,9 > @@ test_mixed_auth_cipher(const struct mixed_cipher_auth_test_data > *tdata, > if (global_api_test_type =3D=3D CRYPTODEV_RAW_API_TEST) > return TEST_SKIPPED; >=20 > + if (gbl_action_type =3D=3D RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO) > + return TEST_SKIPPED; > + > rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info); >=20 Small thing, I think the above fixes should be in their own fix patch. Code changes look good to me. Can keep my ack on v7 with the fixes split ou= t. Acked-by: Ciara Power