From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04EB642609; Tue, 19 Sep 2023 14:20:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0877402BF; Tue, 19 Sep 2023 14:19:59 +0200 (CEST) Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2026.outbound.protection.outlook.com [40.92.98.26]) by mails.dpdk.org (Postfix) with ESMTP id 89A6E40276 for ; Tue, 19 Sep 2023 14:19:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l3OdSnGckVoQI3Mg92S0WkK+Tf+5GvRRWt0LZ4jlaQvH+j+ph8PpWRPvozsqNfo/oUiE6c+J+doZfSgc173WwAD8dP1WRptww8tYSB5ERSIZwOzuJbX6UUqUOzQbdfHR7CQaeZFKUuc0wBnAZy3Z+JS2k2dyQk12/9sYFCiyTVQ6DKGlCI38uoP3rtClcC3Ig4+il0w2Um6/ircNFLKM63BdhKRuU3SsiUN5Phe4WV5nahdsm4sY0ClESQltdceJql+SdcPCV3KhVeHlqZfcrSYbX7Ka6rnHblyvvJAtG90M3/A0XvSgOODShLzvGwZIw+LCSlIcmv1wQA7aFn+w+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n3+PP+qtQaaqov/HKfG3owB2UHCVvWPy882vaoamuNA=; b=JOlkbNAX18jJucUmql2O2hgPuXNk7V2BIt0PwZcGlHfD/aFeattJXInofzr32upvTaGMAo8Au6C3FT56dL0rhBte1D5NsUHF/KAnFOYgWkICYQgzjY+yFX1rViiloov/BKjo6+Axe660QdSbkZWTZ0KiorFQ6JtkOnZRP3DQ8Xa1lf1/EOdH9V+LXzw4333E+XcAvoli1LkA7FGPvdUiMiGvg2PnKRurU+dbxRQDjoxLML35c2kcFvt3ehzHHpekuC3C6RtFihBzpnGpA9bLObDJ6nEdN+/hkToOxGDcyT7JheMSzGP14xBRWENhAxFrucXJJ2hXDgqdV6fCA8bV0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n3+PP+qtQaaqov/HKfG3owB2UHCVvWPy882vaoamuNA=; b=HEzFNI5WkyvK7B2QsciKT8zTqupCMH4MjCcjvX00K422r3/47aM46LVEiVX81pY00QxE89UdX5Z5FX9EHdokuHsTukWs8AxLPXs3ZhfKiCD4fiXTtR6OAxnFkLvNwJR4n8CWwqtpL/B02efobA3P9PxDLJjEybRNySU3Ob178xKEaWZMbyLSd2/w2fx6mpCH7XP6S0jqUXaBVkWDcToDBRlqCTAhunBVnFQe9nnH/4ON/e5RNF8sCvZGYpXA4gPjpRdXsd1/n8fOeFHrZ8qilHGfa5rG/X2G9FrpUi04qAFI2ZHqgsxh1MbM07CpMBGEUyMrnaPbgoYMtGklkMgtRw== Received: from TYAP286MB0300.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:8039::14) by TYWP286MB3786.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:400::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.16; Tue, 19 Sep 2023 12:19:56 +0000 Received: from TYAP286MB0300.JPNP286.PROD.OUTLOOK.COM ([fe80::3898:d1b2:e70:4b5e]) by TYAP286MB0300.JPNP286.PROD.OUTLOOK.COM ([fe80::3898:d1b2:e70:4b5e%6]) with mapi id 15.20.6813.014; Tue, 19 Sep 2023 12:19:56 +0000 Message-ID: Date: Tue, 19 Sep 2023 20:19:50 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] build: fix list_dir_globs failure in MSYS2 To: Bruce Richardson Cc: dev@dpdk.org References: From: Ric Li In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TMN: [ilyKsXxwnxP6BUeByyATfheS+JzMFqkd] X-ClientProxiedBy: SG2PR04CA0173.apcprd04.prod.outlook.com (2603:1096:4::35) To TYAP286MB0300.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:8039::14) X-Microsoft-Original-Message-ID: <53d014cd-456d-46f5-8b37-c889de9b81ea@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYAP286MB0300:EE_|TYWP286MB3786:EE_ X-MS-Office365-Filtering-Correlation-Id: 9afef2d4-c6ac-4291-cfd4-08dbb90abbbc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cBtyY//y/qDRUuWrK4Gk+uOySZzbGt55N0BtLs4chxWRhp2ZpJN2Otxj00RIRIksBmQI+nG5JRJMEqUdMonI8XkBBd3atSJsEionrZkZp5Fdy50sSIcjeFuVYybC4D+J4XNyPi1ZUwKfSwr7jeVAB1nDGKEkUpiz54CuhpVXUei4OemnL4WP3S4vycZthIY0kdkGCD+yHE9f8eWCCu3UHDVLFyewpe+/mjlrQ43X4X9x/twKbk6jIK5VsCpqQwr8LDZFTGwBkAccRi0YPC1VeyPQxsIbwoSBP6dx+Wmw9Cdp/0AI/Iqp+cH+omMc2YLqKbtqV9GjDJwkv+O9p23KeYwc0ormRdZfgOxrHXyxamjAHOFVG6/YDhXRxpyFkr7zyaYWdG6p0twPO0puX2ROUzavNnBtVwZQJxTweuJ01YTKjgX6hjDLM1ulDhgsQs6RvrD3EPTe0j75xk1Bv8LxIsH2GOR61gq5ioZqh0o6jnkOkqZ7iJ5j//MxhIcRPU3RFcJP7lwJT4cwwn+u2DbOLJlkkpmpXqXk3lO3hYowYdUFVVB7F7Z5cNllOSQVxqQ5kBOF1VGURpbxjufF6cQk9JS6T78opnRV/UK12+VYqLY= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkFoSy8zb1JQektTbUpJNUQzYnFUcWdSTmE1MTc5dnhtY2Q3bmdFSGhBeWxw?= =?utf-8?B?VjVzOXAxV3FNM0d6Q3pDR0JVNC80T2g1MmNXS1p4Nm9taHcrTWNlTFdFVnVi?= =?utf-8?B?TU9QOUhSUEg1WVVHM0VOK21kR0lZRlFpY0NLYzBqY2N4QkpWTmZNMmxPNTZK?= =?utf-8?B?dVhZMU5uVGw5L3ZvV1cxaUt0dW8rTHpibkxnOFd3WEhXNlNqaTc1bnVKaFhq?= =?utf-8?B?UVJ1RlFnTkhFS3J4aWxaazVQbDlOQk8yb3VvR1pzSXp0bTl0YWI5Q0E2SmR3?= =?utf-8?B?L2g4NzB4aFp0T05zOU1NUW1yUC90WS9DNkdIczMwQXNCTnc0V3hkMy9aME4w?= =?utf-8?B?ZVh2dFhXTDFib3ZlcFprU282aUtPRUVESTNhMzhlbmJJT1Y5alAvYll0amY0?= =?utf-8?B?TEVSZkpaWTdQQS9vM0pFOVBzL1VIWVdYcHU2aEpOL2c3bG0yUVJ4Y1BNbGpC?= =?utf-8?B?ZFlRNDF2K245cWdxVzlNcWpjakhjcjFHM0EreEpJZzEyWklVSjI3c0lSaXhG?= =?utf-8?B?UFpmVjZ3cjNRMENsT1h4bWVXSmdjN3hJcUtxeUl3YlhXZ1VRK2FNanE2cVAv?= =?utf-8?B?dUE2VGFhTVR0TUltcWFGaEdQOU9xc0xRdEhSdDR5dGxXcjFyaTJQN01UdWZK?= =?utf-8?B?bzNxZUxoT3NUK2hubFRCU3Z2Nzc4Qkx2WnJKNU1tN0hKaHhQeERTU2IzU2FK?= =?utf-8?B?VjlwcFBqQlNaQklCRXV1dk5MYWt4WlU5MjJ1cWY3Qk84OW85bG5VYnFCL1Z6?= =?utf-8?B?RC9CQXpoMytpZFJDZlBUNnBKaENxelEyZktHTUpXeXUzdlhNdWNZQ0pCM2lI?= =?utf-8?B?cDFDTDdtQjdXTTdMczlRSUlERmY2YWVMeEpNdWhreHAwaGQwamxTakJMWkg5?= =?utf-8?B?RHBUOXZ4SjdEV1BFNldNS1F3S2ExN285RVAxMWVUdGR3cllxenZBVDM3Y0pJ?= =?utf-8?B?ZStSWWxJd2swT04yUjQ2V0NRYStReFpLZzNyNTZoOFBuZEdMa1lFZnVzWkVp?= =?utf-8?B?NEo0YUhxN25FTm1DQ1dXQUFxZ2NHbGkzTndNMWNPajNraUFHTHFqMkpocUZC?= =?utf-8?B?MFVISE5oQm5TQ0o0RmdtSjV0MU1WZEVscFlKeEpvODNCYi95a0VvOTZDYnN0?= =?utf-8?B?QnR0bmVmYlU1NksxMU82eldnT2xDY2dvbkg5NldUa0twdkNUd1FuN2kyOFR4?= =?utf-8?B?NjgwT3VVajJ2UThNakZHS2hlTnVzYm5YQkxvQ3g2UzJWNzdlaXVVU3kvNWJv?= =?utf-8?B?b0hCWUxsMXN2bHM2WWtiYTJsZHBDd3hGTm5Hb2Y0U0ZpS1JGUUdsQjdOSzZu?= =?utf-8?B?TDg5ODdxbERWZ20yVU1FWW1HaVNBSEoxa052bGlabFlGellqZlJUSUNUc2Vt?= =?utf-8?B?S0Y0a1RGMzljcUxBelpGZXVrNFlMNGY2L2J1ZDJMbnl1dWhyQnpMYWZjc2hV?= =?utf-8?B?dTNweWZ0ODVHUERYdGVCWnowQWtMV3RaZDA0Rlc0czNhbzRoaWtPODREeUw1?= =?utf-8?B?VHQ5NDZSaldUdU5GakJKV3BkZ1lIeDE0V2t4ZEhsRkNTYnJLOW5HTU5LOGxa?= =?utf-8?B?WVlWYnliYUltTlpNKzl5T3JPU2xlVVhtVUFKQk1QWDZRR0VPc1BrZll0TGZo?= =?utf-8?B?d0dhWlhFYmdyNEcyblRvNll1UklNMWc9PQ==?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9afef2d4-c6ac-4291-cfd4-08dbb90abbbc X-MS-Exchange-CrossTenant-AuthSource: TYAP286MB0300.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2023 12:19:56.2365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB3786 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/9/19 16:12, Bruce Richardson wrote: > On Sat, Sep 16, 2023 at 09:15:19PM +0800, Ric Li wrote: >> When running 'meson build' in MSYS2, >> "list-dir-globs.py * failed with status 1". >> >> Signed-off-by: Ric Li >> --- >> app/meson.build | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/app/meson.build b/app/meson.build >> index e4bf5c531c..73e5138301 100644 >> --- a/app/meson.build >> +++ b/app/meson.build >> @@ -11,7 +11,7 @@ disable_apps = run_command(list_dir_globs, disable_apps, check: true).stdout().s >> enable_apps = ',' + get_option('enable_apps') >> enable_apps = run_command(list_dir_globs, enable_apps, check: true).stdout().split() >> if enable_apps.length() == 0 >> - enable_apps = run_command(list_dir_globs, '*', check: true).stdout().split() >> + enable_apps = run_command(list_dir_globs, '*/', check: true).stdout().split() >> endif >> > > Do we know more about why this particular failure is happening with MSYS2? > Can you try running the script manually to see what the specific python > error is, and if we can make the script more robust generally? > Running the script manually showed nothing but the Usage log. The arguments here are not accepted by this python script. MSYS2 does mention some command line parsing issues, see: https://www.msys2.org/wiki/Porting/ "Windows programs parse the command line themselves, it isn't parsed for them by the calling process, as on Linux. This means that if wildcards (glob patterns) are to be accepted by the program, it has to be able to expand them somehow." > In terms of the fix, I actually think we should not be using a glob here at > all. Since we already have the list of apps present in the file, I think > that we should move the app list to the top of the file and then change the > code to be: > > if enable_apps.length() == 0 > enable_apps = apps > endif > > This sidesteps any issues with globbing, and also makes the code a bit > faster as we don't have to shell-out to a python script. > > /Bruce That sounds reasonable. I'll test it and provide an update to the patch. Thanks, Ric