On 05.03.2025, 19:03, "David Marchand" <david.marchand@redhat.com> wrote:

On Thu, Feb 20, 2025 at 11:06 PM Serhii Iliushyk <sil-plv@napatech.com> wrote:
> diff --git a/drivers/net/ntnic/nthw/core/include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h b/drivers/net/ntnic/nthw/core/include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h
> new file mode 100644
> index 0000000000..f87828fcfe
> --- /dev/null
> +++ b/drivers/net/ntnic/nthw/core/include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h
> @@ -0,0 +1,425 @@
> +/*
> + * Si5332-GM2 Rev D Configuration Register Export Header File
> + *
> + * This file represents a series of Skyworks Si5332-GM2 Rev D
> + * register writes that can be performed to load a single configuration
> + * on a device. It was created by a Skyworks ClockBuilder Pro
> + * export tool.
> + *

This file is missing a SPDX tag.
Please send a fix or we will have to revert this change.

The filename also looks strange, as it does not follow some kind of
implicit convention (when I compare to other files in this driver).
Could it be renamed?


--
David Marchand

Hi David,

We will add the SDPX to the current file. Thanks for noticing it.

The clock profiles are named according to our internal documentation on the PCB (board) design - the "Uxx" is actually the component number on the board design - the versioning ensures that we can support multiple versions of the clock profile for different PCB revisions.

Is it suitable for you to change the name of the file to all lowercase and remove dashes:

NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h ---> nt400d13_u62_si5332_gm2_revd_1_v5_registers.h

BR,

Serhii