* [dpdk-dev] [PATCH] app/crypto-perf: fix return status detection
@ 2019-06-14 20:56 Tomasz Jozwiak
2019-07-01 11:36 ` Akhil Goyal
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Jozwiak @ 2019-06-14 20:56 UTC (permalink / raw)
To: dev, fiona.trahe, tjozwiakgm, pablo.de.lara.guarch, stable
Currently, there's no return status check from lcore's jobs.
In case of fail - crypto-perf tool returns success anyway.
This patch adds such a detection and returns proper status at the end.
Fixes: ce8af1a4398d ("app/crypto-perf: wait for cores launched by app")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Jozwiak <tjozwiakgm@gmail.com>
---
app/test-crypto-perf/main.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index 4247f6a..ad72d7e 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -664,9 +664,12 @@ main(int argc, char **argv)
if (i == total_nb_qps)
break;
- rte_eal_wait_lcore(lcore_id);
+ ret |= rte_eal_wait_lcore(lcore_id);
i++;
}
+
+ if (ret != EXIT_SUCCESS)
+ goto err;
} else {
/* Get next size from range or list */
@@ -691,10 +694,13 @@ main(int argc, char **argv)
if (i == total_nb_qps)
break;
- rte_eal_wait_lcore(lcore_id);
+ ret |= rte_eal_wait_lcore(lcore_id);
i++;
}
+ if (ret != EXIT_SUCCESS)
+ goto err;
+
/* Get next size from range or list */
if (opts.inc_buffer_size != 0)
opts.test_buffer_size += opts.inc_buffer_size;
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] app/crypto-perf: fix return status detection
2019-06-14 20:56 [dpdk-dev] [PATCH] app/crypto-perf: fix return status detection Tomasz Jozwiak
@ 2019-07-01 11:36 ` Akhil Goyal
0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2019-07-01 11:36 UTC (permalink / raw)
To: Tomasz Jozwiak, dev, fiona.trahe, pablo.de.lara.guarch, stable
>
> Currently, there's no return status check from lcore's jobs.
> In case of fail - crypto-perf tool returns success anyway.
> This patch adds such a detection and returns proper status at the end.
>
> Fixes: ce8af1a4398d ("app/crypto-perf: wait for cores launched by app")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tomasz Jozwiak <tjozwiakgm@gmail.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-01 11:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 20:56 [dpdk-dev] [PATCH] app/crypto-perf: fix return status detection Tomasz Jozwiak
2019-07-01 11:36 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).