From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71D1BA2E1B for ; Wed, 4 Sep 2019 12:14:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D9631ED6A; Wed, 4 Sep 2019 12:14:19 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10040.outbound.protection.outlook.com [40.107.1.40]) by dpdk.org (Postfix) with ESMTP id C2A841EC0E for ; Wed, 4 Sep 2019 12:14:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kkS1kECXcOEcGSgb2TGpayxf8/YZirlFp4xYHlT0FVDOOdMm8pcJ4jnKyjH4DJq7vqdE13m02Rx8sju8kmD+WVyeIGxVivVX9nuy86UaG/j6JixEnBa3ic6xomGvmO0Ocg/6OZzlk1Knyj36Q687uEG6p3C+xqmcdijUO7GLguuTwSVp2+n9MY6EvlWsp/4BJW41qFzK7GhCe57PEp1qwUTE3kITyAzCKDUniJG90jmI77T5B3E5djg5ccMoxjSAuj7Ac3hwu6TzQ1AwvqYBWVq5SzHzTTDkea36ybcogB2IzhTWAYaPbhGs4uO0FsE8bT9yTti8mfhs4wLGNRk4gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yXpwyJGe3qQwDaEJd1it7Lj6g0iPcSgq27lBh3k0u7M=; b=IeaRYowMDIlu1e1Ro5y91/TKP5h9b8Bvd14FXPRv8PrmYApinKps+9u2L8KS63XTMM+ZweB6N3avl3MT1P0mL0c/Q9K5zbElWHmTMwkmO74kkMF2UT2slPegxXfHB+fazBJuxBagq5nuBpkjYcC72PG4QiHhGa36sYDbxWBi/XPOf2wAJr1NCD65vBcPrWUxqoKH1fLRfzBe19V8BPpwoWAtBKoOJhxbjTBFDoxhBQer6uUd9adk9ywmVpaNTVkdP+Zb6wX5GJIMMjBRrE8gl8405YDnyCg0T7LNyw3I8eGu5+vUjA5bt90Hu7T2cddlLpBTDOlePNmIVusmgbl1tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yXpwyJGe3qQwDaEJd1it7Lj6g0iPcSgq27lBh3k0u7M=; b=Lna6eyTiwKI10Ye+2JiXdmWrsZDl4flV623d8s3MkBBd+Kjyl25/ziaw5mWlp+knzkRCx/xl9TTbr9OCP/O4GdQLH9TIi1aaEm5dhyWlONubiXXydJ9pkSBtcbMRLluJUBxdB5C7tzhDanRCzxI1jPw5BLl3GJFnpRvQs/Y97yc= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6608.eurprd04.prod.outlook.com (20.179.235.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.19; Wed, 4 Sep 2019 10:14:16 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7092:d719:df0b:2b70]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7092:d719:df0b:2b70%7]) with mapi id 15.20.2220.021; Wed, 4 Sep 2019 10:14:16 +0000 From: Akhil Goyal To: "michaelsh@marvell.com" , "marko.kovacevic@intel.com" CC: "dev@dpdk.org" , "lironh@marvell.com" Thread-Topic: [dpdk-dev] [PATCH 00/12] FIPS improvements Thread-Index: AQHVW+/tFRrYsR5vKkKKLrDGwa6Ew6cbVPeA Date: Wed, 4 Sep 2019 10:14:16 +0000 Message-ID: References: <20190826094120.22590-1-michaelsh@marvell.com> In-Reply-To: <20190826094120.22590-1-michaelsh@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ba63d96-6b60-44c9-01c7-08d73120a4c5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6608; x-ms-traffictypediagnostic: VE1PR04MB6608: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0150F3F97D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(376002)(396003)(136003)(39860400002)(189003)(199004)(476003)(102836004)(3846002)(6436002)(55016002)(99286004)(256004)(25786009)(14444005)(446003)(6246003)(2501003)(86362001)(6116002)(9686003)(11346002)(76116006)(53936002)(486006)(4326008)(66446008)(64756008)(66556008)(66476007)(71190400001)(71200400001)(44832011)(66946007)(52536014)(5660300002)(14454004)(74316002)(7696005)(305945005)(186003)(6506007)(33656002)(54906003)(110136005)(2906002)(81156014)(7736002)(8676002)(81166006)(478600001)(229853002)(66066001)(316002)(76176011)(26005)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6608; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: O4P/yZqG2z9H/kAxFj9IuZc4otoGIsiBd4qKRRrrNeMZJvFS4ZNk0z0TOO4kIYk5dBkfGpymMqPAnrAtRHskiQtW8hxADur0AH5AJe+qWcFcGBaqQn1jPJ00sq3be7C4XNCpTqP//3yTEVzdQsIdIUchKNbJLjwM3mv6CDUkzPmVukLNrhK1wPPSJjk3yLA7kjGisKrf2PT04mowglTIgvNCq3ptW+KLVaKBlGNdoSdXB/adNJSuZTccgKL6RAn7N7keqrLcF85xZVuQx7OTV1bF8fBJTyzf7kvd6l83CNkO3X4Li7+nEEU/CSk2m1wiZUySb1RhGM+6S5oAYyryeJjXTwsiCzXFHMRr2fCcW5VevB4d/jVroFjT0l0rFQ6o2tJPRgpZF9LURAbkJu4AQcMjng6kh5nppZ64CBrnNYE= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ba63d96-6b60-44c9-01c7-08d73120a4c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2019 10:14:16.7504 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RCldSS/ZBammPxn9IuyFAwIG/1vf/j3psKPCQw7vEiT3dfxSQCVihKBgf9G00ZvuHEddjGMEwPeNGzAx69xBDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6608 Subject: Re: [dpdk-dev] [PATCH 00/12] FIPS improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Michael, Please try to improve descriptions and patch titles as per the suggestions = given below. There are many patches which are fixes. Are the eligible for backport to st= able branches? The support which is getting added, is it eligible for documentation update= for the application. -Akhil >=20 > Added support for ECB mode in TDES and AES. > Fixed some bugs in TDES and AES-GCM. >=20 > Michael Shamis (12): > examples/fips: added support for SHA algorithm in FIPS tests examples/fips_validation: support SHA > examples/fips: added support for TDES ECB mode in FIPS tests examples/fips_validation: support TDES ECB > examples/fips: added support AES ECB mode in FIPS tests examples/fips_validation: support AES ECB > examples/fips: fix bad return code in fips_test_parse_header() examples/fips_validation: fix bad return value Can be a separate patch from this set. Also send to stable. > examples/fips: AES-GCM vectors will use aead structure examples/fips_validation: use AEAD based structs for AES-GCM rather it is a fix and should be sent to stable and the title would be=20 examples/fips_validation: fix structs used for AES-GCM > examples/fips: set initial IV in AES-GCM if configured only salt value examples/fips_validation: initialize IV for AES-GCM > examples/fips: keep digest after crypto text examples/fips_validation: move digest after cipher text > examples/fips: AES-GCM decryption vectors fix examples/fips_validation: fix AES-GCM decryption vector Add fixes line and cc stable. Can be a separate patchset for fixes. > examples/fips: fix KEY and PT output prints for TDES mode Does not have a patch description and title does not look to justify the pa= tch. > examples/fips: supported IV, PT and CT init for TDES ECB mode Again there is no patch description and title is pretty long. Try to make i= t short. > examples/fips: algorithm definition by folder if it's not in file examples/fips_validation: improve algo parsing logic update description text to elaborate the need for this logic > examples/fips: erroneous overwrite of PLAINTEXT after DECRYPT examples/fips_validation: fix plain text overwrite send to stable and add fixes line. >=20 > examples/fips_validation/fips_validation.c | 92 ++++++-- > examples/fips_validation/fips_validation.h | 7 + > .../fips_validation/fips_validation_aes.c | 1 + > .../fips_validation/fips_validation_gcm.c | 39 +++- > .../fips_validation/fips_validation_tdes.c | 7 + > examples/fips_validation/main.c | 204 +++++++++++++++--- > 6 files changed, 301 insertions(+), 49 deletions(-) >=20 > -- > 2.23.0