From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DCE2A0613 for ; Fri, 27 Sep 2019 17:06:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 97C9B1B9BF; Fri, 27 Sep 2019 17:06:37 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130070.outbound.protection.outlook.com [40.107.13.70]) by dpdk.org (Postfix) with ESMTP id DFF5C1B994 for ; Fri, 27 Sep 2019 17:06:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/vE0pP3SiNLZnmS9O3MdeGQDCcH1a8U08v9Y1bGsb+G3oHINM7fP8/Qhi5lx9GcdYRxqKF7CfqZ6r9yIh+EqIWFrBq2hrw/Y0aQtmNy/5sC8AGHCE7Nt/koaYn2j6czN0H2AhFRrFtNsTg8xt/v4qPjc7MRdcYmb36bSJXNI3gRNj86RhlR0YZ+Ur+FiYIryatQFiGRdJXkY+LCHCBMwwyWjOUGaFFO9W+XeNgpVGjAOaeh6N0K9f4AJKtP255lCOdld2NTN3B1fxHtHZwNbv/01OWzeglXg2WH24w7dhgDwGyzdYb+AWVnsHtkduXLtEQF9y+iEa6f+FGOv2sl0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QU/2h0JxxYIWnoTg+N6p4l60Z2wXiBR+D3nf+0Ypgv0=; b=fo1ZwXggca3bPw6srR81kf6g/VfpPlgI+M9r7Odx1ivr34b4HTaQeWJSV4VglKtH2QqUUTIFdTxAYfCEsyrxv62cpNmbfNT1VrZ/xF84VA85usleqgsrZGcbhQIm1IQeNoTJCitB5pO8pw275ZVrGaku02KWDrl+13eDolq/3QJDLt++VeEqW7InSswxUB/Sx+Ob4dTW9vbibYgD9vq/fAaOT4eyunX8mxEwu+MqutBudVGLPeupeW3YzmyvHp7CWCUU3F+AboejajmKAV2GQeLBtXcf82PsHBF8LzrTajLru0QUTjz6ZwceS0lrB35nvsqm1JrgaKL9rYpPpfuj7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QU/2h0JxxYIWnoTg+N6p4l60Z2wXiBR+D3nf+0Ypgv0=; b=EXKxRMbEPd7ZkDLEbuSMeolgyuSltyzwn5MQQOkTKllOGgxZ/iWYvOFfzs8YI4VOhvFbNNx5B/NTkhTZBXFQEd1427g4Ut3noeJx5wzUxH47i9WIoBkuG7e54sfr+0cp/dIfPfArx8nQlaY7u5U6A+ukoYXfv/eDeSkW6a4gevs= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6479.eurprd04.prod.outlook.com (20.179.232.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.15; Fri, 27 Sep 2019 15:06:34 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee%5]) with mapi id 15.20.2305.017; Fri, 27 Sep 2019 15:06:34 +0000 From: Akhil Goyal To: Anoob Joseph , "konstantin.ananyev@intel.com" , Radu Nicolau CC: Hemant Agrawal , Vakul Garg , "dev@dpdk.org" , Narayana Prasad Raju Athreya , Jerin Jacob Kollanukkaran Thread-Topic: [PATCH 03/20] security: add hfn override option in PDCP Thread-Index: AQHVYYpseP6pmf4jjUCiA+OhwNw9yqczOdFQgAjmBwCAA6XNEA== Date: Fri, 27 Sep 2019 15:06:34 +0000 Message-ID: References: <20190902121734.926-1-akhil.goyal@nxp.com> <20190902121734.926-4-akhil.goyal@nxp.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d69d37ae-8612-49f4-dd33-08d7435c49b0 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VE1PR04MB6479:|VE1PR04MB6479: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0173C6D4D5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(396003)(376002)(366004)(39860400002)(189003)(199004)(3846002)(6116002)(5660300002)(99286004)(256004)(9686003)(52536014)(7696005)(4326008)(229853002)(55016002)(6436002)(76176011)(6506007)(186003)(33656002)(110136005)(66066001)(102836004)(54906003)(2906002)(7736002)(14454004)(66476007)(66446008)(76116006)(64756008)(66556008)(86362001)(8936002)(81166006)(81156014)(8676002)(6246003)(14444005)(71200400001)(305945005)(11346002)(44832011)(71190400001)(74316002)(478600001)(486006)(26005)(2501003)(66946007)(446003)(476003)(25786009)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6479; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SnxIF4ffsWflPV1ORTgyEkOpJLHXoGrZAgBaVyBf3O/Y8vWI0F5Bnbj6JDxtfGkQbAj50YCzocGzUllMrnmP4rK+Nijua3tXyUoZyDdYDQvCTH8TmsjtBZBlD3U7CktLkqzNPK0Qu+4U5+VqVzrVecajKo+g0G51vjP2WGHSDkLKsL17+FJaHzvg2u7jqCrNRuWyTgunyJBZBGmIymzFtetG/bEUiiH28YZ6fNC/+X2qMHqbY09TaZ0GVki5PP6B9+MQ6XUMDzGZwYaIqiBlb+Q9UeMB9zPgQcNah4BEA94S//WF0BZt0f67ZmODLvLhWOV4nsIPM26aJGr/JfOAkzMzHt/rqMarGVMxLtzVuVGxKQfR9SgOz18CSYWQ5W1vQrga9h+HqVQzvtYoFKDgCceqS04Lmh29MRhJ2EEJys4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d69d37ae-8612-49f4-dd33-08d7435c49b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2019 15:06:34.7185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H6Hmnnv6NDQwXsWExK6kwVOOShRZViuFbHADTx1RVRGSn7hT/7F8WKTRC5z5DvwpldrpRRGAhbRkGecHEob4ZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6479 Subject: Re: [dpdk-dev] [PATCH 03/20] security: add hfn override option in PDCP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, Thanks for review. > > > @@ -270,6 +270,8 @@ struct rte_security_pdcp_xform { > > > uint32_t hfn; > > > /** HFN Threshold for key renegotiation */ > > > uint32_t hfn_threshold; > > > + /** Enable per packet HFN override */ > > > + uint32_t hfn_ovrd; >=20 > [Anoob] I think you should document the fact that IV field will be used f= or HFN. > Your patch description accurately describes the procedure but the above > comment fails to capture it. Also I would suggest renaming "hfn_ovrd" to > something else to make it obvious that IV field is being used. Something = like, > use_iv_for_hfn or something. Will add comments here. /** HFN can be given as a per packet value also. * As we do not have IV in case of PDCP, and HFN is * used to generate IV. IV field can be used to get the * per packet HFN while enq/deq. * If hfn_ovrd field is set, user is expected to set the * per packet HFN in place of IV. PMDs will extract the HFN * and perform operations accordingly. */ But using a different name may not be useful. Here we want to specify that HFN can be overridden from the per packet value. Now the usage is explained in the comments. I believe hfn_ovrd is enough to explain the intent. Though not a very strong opinion on this. Will send the v2 shortly. >=20 > Otherwise, I don't see any issues with the approach. >=20 > > > }; > > > > > > /** > > > -- > > > 2.17.1