DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"fiona.trahe@intel.com" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/5] Add session-less, RSA, RSA-CRT to QAT
Date: Tue, 15 Oct 2019 10:22:48 +0000	[thread overview]
Message-ID: <VE1PR04MB66391AF8E1FA1B7471443035E6930@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191011100339.12912-1-arkadiuszx.kusztal@intel.com>

Hi Arek,
> 
> This patchset adds session-less option, RSA algorithm, RSA-CRT algorithm
> to Intel QuickAssist Technology PMD.
> 
> This patchset depends on the
> [v5] cryptodev: extend api of asymmetric crypto by session-less [1]
> 
> [1]
> http://patchwork.dpdk.org/patch/60882/
> 
Could you please rebase this patch so that compilation can be tested by CI.
The dependent patch is merged.
Also please update the patch titles as below.

@fiona.trahe@intel.com: could you please review this series and provide Ack

> v2:
> - fixed alg size problem in crt
> - fixed rsa capabilities
> - added rsa test cases
> 
> Arek Kusztal (5):
>   crypto/qat: add sessionless implementation to asym pmd
crypto/qat: support asymmetric sessionless ops

>   crypto/qat: add rsa implementation to asym pmd
crypto/qat: support RSA
>   crypto/qat: add rsa crt implementation to asym pmd
crypto/qat: support RSA CRT
>   test/crypto: add sessionless to asymmetric mod exp
test/crypto: support sessionless in asymmetric cases
>   test/crypto: add rsa tests to qat
test/crypto: add RSA cases in QAT

Also please add more meaningful patch description.

> 
>  app/test/test_cryptodev_asym.c                     | 182 ++++--
>  app/test/test_cryptodev_rsa_test_vectors.h         | 213 +++++++
>  doc/guides/cryptodevs/features/qat.ini             |   4 +
>  doc/guides/rel_notes/release_19_11.rst             |   8 +
>  .../qat/qat_adf/qat_pke_functionality_arrays.h     |  27 +
>  drivers/crypto/qat/qat_asym.c                      | 616 ++++++++++++++++-----
>  drivers/crypto/qat/qat_asym.h                      |  29 +-
>  drivers/crypto/qat/qat_asym_capabilities.h         |  21 +
>  drivers/crypto/qat/qat_asym_pmd.c                  |   5 +-
>  9 files changed, 925 insertions(+), 180 deletions(-)
> 
> --
> 2.1.0


  parent reply	other threads:[~2019-10-15 10:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 10:03 Arek Kusztal
2019-10-11 10:03 ` [dpdk-dev] [PATCH v2 1/5] crypto/qat: add sessionless implementation to asym pmd Arek Kusztal
2019-10-11 10:03 ` [dpdk-dev] [PATCH v2 2/5] crypto/qat: add rsa " Arek Kusztal
2019-10-11 10:03 ` [dpdk-dev] [PATCH v2 3/5] crypto/qat: add rsa crt " Arek Kusztal
2019-10-11 10:03 ` [dpdk-dev] [PATCH v2 4/5] test/crypto: add sessionless to asymmetric mod exp Arek Kusztal
2019-10-11 10:03 ` [dpdk-dev] [PATCH v2 5/5] test/crypto: add rsa tests to qat Arek Kusztal
2019-10-15 10:22 ` Akhil Goyal [this message]
2019-10-17  9:27   ` [dpdk-dev] [PATCH v2 0/5] Add session-less, RSA, RSA-CRT to QAT Trahe, Fiona
2019-10-21 10:47     ` Trahe, Fiona

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR04MB66391AF8E1FA1B7471443035E6930@VE1PR04MB6639.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).