From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B52C8A0487 for ; Tue, 30 Jul 2019 09:20:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3BAD34F2; Tue, 30 Jul 2019 09:20:07 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60071.outbound.protection.outlook.com [40.107.6.71]) by dpdk.org (Postfix) with ESMTP id 12882276C for ; Tue, 30 Jul 2019 09:20:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KKDJV5PiVTa3Wr6Nu5xZ8Pd0uzo889tZ1pd3dR176QYfViENZWAR1B0IytHHBDTAz+YBDQQmBITNndti+XoieBhr0+KA3E/j7pLsPSp1vxh7arFzLnpBHxk7vuzs4SY/RQBe6PLI2ji9JBpnZC5OKonrAoa1iNJ23wG1TCXS24qqgMMzt87vI7r345AInnjZRQMb7tY0fu/egW8lFISWdvJhupkGqa68aABrWBkY03T2Zy7TgKuIaEocDVG1qLha/mAIk6jxEPXp7n427DOBHBJN+tH+rhXSO++lb7ewdhJlZsHlwTZ6ShsFHJOLpdEb4W/EQS6tHUGNZ8BZ8C7W8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z3Kjxh0W+t6oYiptIBXOdN0ihuRQgBP+DtognbFECYs=; b=NcvaQsKVYn0dIAZyc+JNymnUVBOMFlC+pYemXYnPL+Nin4UXvr6iqGwjeVsHdpVgepbAjeWYFEp7OXOkr8Sda44vs2v2Io+PsRfL7R8OjY56+QyLZCZWucKn+gs8JhIVPWWW+nWIQVccswxP6FULgkPsJU2VkIRS1HnoOlmyvbqABDucB3hP+N//bWQLJ9vy3Et51H1UwujErgCgp/D6Qv9WcA/TWHb8g9wIZBzh8KjIZQrRAOtK6qTpPf6LALOwZnx+LVvU8tz1pbDgSGD2cod/Lkpk4iaybvqRQXaOaps8qqQlVNt6Gjykj6Fl8U0rUPZWKov9kLNmHDF2JN2icQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=nxp.com;dmarc=pass action=none header.from=nxp.com;dkim=pass header.d=nxp.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z3Kjxh0W+t6oYiptIBXOdN0ihuRQgBP+DtognbFECYs=; b=NskcWfqkMBf5ZJ4Rbd1AblMq6yXy7K/DxPs2Fbdz8Gx5BGmsrhuafaxjoonKNWqSyDWoXfqmSo8l4szvDXJ33KX/5sRSClg86UDC0yEfCGSXcLOVfjOFNdgcq706B2wtwab+cN3pB7/KgTJclkwyVAR/8q3IBDrOqD4OY2jNKsY= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6430.eurprd04.prod.outlook.com (20.179.232.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.14; Tue, 30 Jul 2019 07:20:05 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::964:4ddc:346b:e2ec]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::964:4ddc:346b:e2ec%7]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 07:20:05 +0000 From: Akhil Goyal To: Thomas Monjalon CC: Bernard Iremonger , "dev@dpdk.org" , Anoob Joseph , "konstantin.ananyev@intel.com" , Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya Thread-Topic: [dpdk-dev] [EXT] [PATCH] doc: deprecate legacy code path in ipsec-secgw Thread-Index: AQHVRitzwTpsrZhZLECEWe3JhP6PuqbiqGgwgAAWsgCAAAED4A== Date: Tue, 30 Jul 2019 07:20:05 +0000 Message-ID: References: <1562835937-24141-1-git-send-email-bernard.iremonger@intel.com> <3165113.5OK8ffLHOj@xps> <17016159.n4PeLHrF3L@xps> In-Reply-To: <17016159.n4PeLHrF3L@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 945d1608-3570-42f5-30c0-08d714be5886 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VE1PR04MB6430; x-ms-traffictypediagnostic: VE1PR04MB6430: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0114FF88F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(366004)(39860400002)(376002)(396003)(189003)(199004)(26005)(229853002)(486006)(5660300002)(476003)(446003)(86362001)(186003)(305945005)(99286004)(53936002)(52536014)(478600001)(6436002)(14444005)(74316002)(256004)(44832011)(55016002)(316002)(6916009)(54906003)(81166006)(2906002)(8676002)(6116002)(25786009)(11346002)(71190400001)(71200400001)(66066001)(81156014)(6506007)(33656002)(102836004)(66556008)(66946007)(64756008)(7736002)(66446008)(9686003)(76176011)(76116006)(66476007)(4326008)(6246003)(14454004)(3846002)(7696005)(8936002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6430; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: W5xDNi88urnIbKXk+5PdSAC+JNROohdX41GP6MWkFhDgRvOSEhCH4ajI/gvPyJeU82t3ijKZke23J7QLwa2OjzIIfS/78jJN37ZDaeP0YJ1JXSiu+Hw1Zks2l3YQd31brcBBZk71RyECFnJzm+JcI7v9OQHVVYjH9GPE48gXr9y6Q2QjHRz5NZxybVg8oAIXat7SYhyLR4FeNHmu+UacBV1fEgu+47n/VvR2uo9CYu3cRhys+zk5d/XUWPtKw2zRChdtqECu7h8Vsxx7bWiC9TOahdPqJXaN41a3U27xHOtcp7dZTEu8pJ24n82th0xbcodEKIiYQFg8WqPxoBJ6xecAKK/sg4VCo2Ov6H632ATzrPpzeUNK/iYKmeir9mAGAcwyjozVFzBi4wvyduie3b5CrBOGFsHqSlbfxMyIlno= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 945d1608-3570-42f5-30c0-08d714be5886 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 07:20:05.6736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6430 Subject: Re: [dpdk-dev] [EXT] [PATCH] doc: deprecate legacy code path in ipsec-secgw X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 30/07/2019 07:55, Akhil Goyal: > > > > > > > > > > > All the functionality of the legacy code path in now available = in the > > > librte_ipsec > > > > > > library. It is planned to deprecate the legacy code path in the= 19.11 > release > > > and > > > > > > remove the legacy code path in the 20.02 release. > > > > > > > > > > > > Signed-off-by: Bernard Iremonger > > > > > > Acked-by: Konstantin Ananyev > > > > > > Acked-by: Fan Zhang > > > > > > Acked-by: Akhil Goyal > > > > > > --- > > > > > > doc/guides/rel_notes/deprecation.rst | 5 +++++ > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > Acked-by: Anoob Joseph > > > > > > > > Applied to dpdk-next-crypto > > > > > > Why do we have a deprecation notice for some code path in an example? > > > The deprecation notices are for the API. > > > > > > I think you can drop the legacy code in 19.11, > > > and I don't merge this patch in master. > > > > > > > We are planning to remove the original code and replace it with IPSec l= ibrary > APIs which are still experimental. With this change there won't be any ex= ample > of the legacy ipsec code path. Applications over DPDK take ipsec-secgw as= an > example and IPSec is a major use case for customers. There may also be > performance differences in the two code paths. Atleast on NXP platforms I= saw > 5-7% drop when the patches were originally submitted. Not sure what is th= e > current state. > > I feel it is worth notifying the users that the original codepath is ge= tting > deprecated, so that they can plan to move to new IPSec APIs. >=20 > The deprecation notice is not the right place for a change in an example. > What change is there in IPsec API? In which release? >=20 IPSec lib was introduced in 1902 release and a few enhancements are done th= ereafter. Previously all IPSec related stuff was done in the application, now we have= IPSec Lib which perform similar work. There are changes both in datapath as well as control= path. User need to adapt to the recent changes, as we may no longer support/maint= ain the datapath/control path which was done previously and there may be some conflict. If deprecation notice is not the right place, then where should it be notif= ied before actually making the change.