From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C5DFA2EDB for ; Mon, 30 Sep 2019 22:21:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 707F41BEB6; Mon, 30 Sep 2019 22:21:34 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130044.outbound.protection.outlook.com [40.107.13.44]) by dpdk.org (Postfix) with ESMTP id DD5271BE86; Mon, 30 Sep 2019 22:21:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IjbfKJyl10l4t4adtS8yi0iaAoWHIQ8QIqXOq4MLlIIif7a2M6UM+ZNwgXlkaOggleu1syJ2GIesgZxPtVlwCpbUXtEsxceuH+pWn64LQzAOG9qMojypLgfMo96k9NhOBqekXEiPbj63BlT443gzU/GTa/kJg590dkf5JGOYzcCJ+Rxd4pc0gXaRqxW6J2GTnSE2wMN8icGlQqQJxV7lTSiGVhLa8lUkPTjPs63Lnfj6pmUZcH8FrfNCbqz7vlS1zzyTu1W1bm2ApEfMwEw4QbQPdRQ22rEfBYRDlglMVZWPTREuEvvhOoClUVNf3zdjWx02DEH/H8swSjoeXup3RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rerXPuu4eVBQDQjOP5Nq9R63BlT+uY4wSup4dtOfnnk=; b=od/EnNs0feBEFmyix06l5kuqmWriHUt+EXR9VdX4lZDdBWdwRyX2pICXSCb7V1IHHlY4QFNIjC47yq1sE+kSpQZX0k/ITiK6d36pm18iw89v3mxffv+wkptbF7xvp13oapoYwyFKdusyipGBApPq9GYfCoy68yaGCmNgEjtkXuivWtJy+XDX7SDNjNO7BfUfKC+IkzDKjAVRNuxvedM5D7D+vzDHGxbSGa7stOan49DRMFyrbD7UqEzuQINjWxkKBXGxyE21x/kq26IRStINGOMPsVJfsRiD5FrdHuijdIfTDnGPJvR3u7Zr+RBNGPpf8ryIZk+4NmEDyhXb2GyqYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rerXPuu4eVBQDQjOP5Nq9R63BlT+uY4wSup4dtOfnnk=; b=g+zvC2hQs2+3JJsNdAHdZ3V7khIdKjXQQFFqV5nL9l9C6U8UpUXVlu9MJ6DAm2LKXkB9lkw0phW23rc6zyKTF7lNj/KkRw6H4RsazJg68AHXr4dR4ribb+n8k/P8VinN4qdWBJGNtQKFzFY+t8sOQkMjtF6rv1LesKg3oPJtzXU= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6526.eurprd04.prod.outlook.com (20.179.233.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.15; Mon, 30 Sep 2019 20:21:32 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee%5]) with mapi id 15.20.2305.017; Mon, 30 Sep 2019 20:21:32 +0000 From: Akhil Goyal To: Chaitanya Babu Talluri , "dev@dpdk.org" CC: "reshma.pattan@intel.com" , "jananeex.m.parthasarathy@intel.com" , "marko.kovacevic@intel.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/fips_validation: fix null pointer dereferences Thread-Index: AQHVc2r/gxqDB5ru4U6lvqsTM8AykqdEskrw Date: Mon, 30 Sep 2019 20:21:31 +0000 Message-ID: References: <1569393094-26761-1-git-send-email-tallurix.chaitanya.babu@intel.com> In-Reply-To: <1569393094-26761-1-git-send-email-tallurix.chaitanya.babu@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [106.201.14.141] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8197c77-a058-4215-bc94-08d745e3c88f x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VE1PR04MB6526: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 01762B0D64 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(4636009)(39860400002)(136003)(376002)(346002)(366004)(396003)(189003)(199004)(64756008)(71190400001)(66476007)(66946007)(8936002)(305945005)(74316002)(316002)(486006)(66556008)(55016002)(66446008)(81166006)(81156014)(6246003)(476003)(256004)(54906003)(44832011)(102836004)(9686003)(76116006)(110136005)(86362001)(7736002)(6436002)(71200400001)(478600001)(52536014)(76176011)(5660300002)(2906002)(6116002)(446003)(2501003)(66066001)(55236004)(11346002)(4326008)(229853002)(186003)(6506007)(25786009)(99286004)(3846002)(26005)(33656002)(4744005)(14454004)(7696005)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6526; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TZboOv0UEsRyeWixnEA/ngHZNrlVvSm6gFZqmZtsVN6NAikeG4zASbPSViZJ2s/ex5smsnffjeIvzOZoInXPp7hAcXtdRV7fwA60R6eAet7x4zeACpJAeHoDBHyJVwuQ3B+qmkyJhixy6KbFLHz9ratjT/rP675THtjW5vkpPQc89/sATpAY69LDu7nIq1+trP2QGzBvQjgFNJkAzWNyD8Cdg/zMs7ocVj6Qv9kWeQBzZfjO1t75hhpWfJa0sXeWWeBaLEGtY+hMG6EJcNGLIaDf1MurxQlkCSRy43OYricS9k1X8AlnmpTIEzrTy6kg0Tmb6kFWevFyaxvJQVS05o1BIjehZEaxTdfTZlgnQmJpIxVHbU7CAmutpf7RIYYp+tnvMmZ8iCyV2Vn8SkE4Fy6wSi/GIuED5ezwrEgWPlY= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8197c77-a058-4215-bc94-08d745e3c88f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2019 20:21:31.9511 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6zKBPtT52F09foxVDT6WsZG8sL+jA37JLmQX/Uk1Y4j1UgqImttlB7W9+3UacTVltBmFqK+R3IpPrjUeZZZlBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6526 Subject: Re: [dpdk-dev] [PATCH] examples/fips_validation: fix null pointer dereferences X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > One issue caught by Coverity 343408 > *deref_parm: Directly dereferencing parameter val->val. >=20 > In writeback_tdes_hex_str(), tmp_val is initialised to null. > tmp_val.val is updated only if keys are found. > If keys are not found,it doesn't fails but continues > to invoke writeback_hex_str(),where val->val is accessed > without null check. >=20 > The fix is to return the error, > if keys are not found in writeback_tdes_hex_str(). >=20 > Coverity issue: 343408 > Fixes: 527cbf3d5e ("examples/fips_validation: support TDES parsing") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chaitanya Babu Talluri > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.