From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95F83A053B; Thu, 6 Feb 2020 15:54:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00DD31C11F; Thu, 6 Feb 2020 15:54:37 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60050.outbound.protection.outlook.com [40.107.6.50]) by dpdk.org (Postfix) with ESMTP id 5B6B81C11D for ; Thu, 6 Feb 2020 15:54:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fJZcOSQ96bXfrJTJA8b9k5PMKPGw4plw3iHFoWJ7ShbJCWhFfghAhSKSP1z2QLoeLi6CZS4SC2YXGNDgFrE4DYzQNLFOUxLtiGCVKCXHargoZdWpfqRZKdrH/dluhme18GmjYuaj3Z4lFm/Mf/e2JziD9BF5asoC+HpsQoZSSg1C9BBVuM7gu8/rTJGEr/92mp+m+6ThKHibf82oV/azUK05QlCNf3XMbqhSUPP0G12SCAFCju0tlPjN1T8224PKfi/wDDpxchx4XpCWOAEMTYxF5PDDXwaMBvtps/wPvgjeAnPURMHL/RzDCQbf9o8dYlhDhmjUwTSvSqj/gOyI2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mmZp9UC2kMalZXQ4WYMymEkdEbvqQdkyDci3WCfsHKg=; b=ZqyJKN2oPI994WQ0PioifuVsyeIHrlG2miMHBuZ1yBZcY30nuojGD6TYBs7rXgJaYDUzdEIygv3efybZWBE+iglxZIitdE+WWCsZkiCKg+3wc2XnRMOioqAeOqkD/7kTE9hrMDPxsw7jtkmgAkeBBhnZqPyE+pt5dQJOGIWVj0IQi0pbN8iaCLVNMYBW5XkK6vcdQ1goc5oEmdUw9QlpdJdagWrQn1LiJfFtioU9qh8WR4fGzCJd1HY9AcF2Bb3xksIh52jQ/LlY1TpLHTZuSq+qX/XD2XPg0iUd3cX5+hyyMWA9tEWO/f2x3nRG8hpe4rNvHQE2sePrSngQqS44dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mmZp9UC2kMalZXQ4WYMymEkdEbvqQdkyDci3WCfsHKg=; b=kcBDSijOnRZ/CLL7oJ+X9KsF0FVRsPZ9RVnlmqThCA0n6WB/xdS0+0eWmXbGLHa8l2IeW3xM721nfXrkXKNbjuh251rzrNazscYs5guIn/RzxD2F8m7DKsYE4fsInsgRqVy87Mcsmn1LdMyZ6DoOe+4aBxEz0nQO76+jqQWjk6E= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6734.eurprd04.prod.outlook.com (20.179.234.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Thu, 6 Feb 2020 14:54:35 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1%7]) with mapi id 15.20.2707.023; Thu, 6 Feb 2020 14:54:35 +0000 From: Akhil Goyal To: Bruce Richardson , Thierry Herbelot CC: "dev@dpdk.org" , Anoob Joseph Thread-Topic: [dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY Thread-Index: AQHV3PLcF8gGpFKTO0S/GMzG+Q+9CqgOOVGAgAAFtpA= Date: Thu, 6 Feb 2020 14:54:35 +0000 Message-ID: References: <20200206142749.GA777@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200206142749.GA777@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [64.157.242.222] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5045bd93-608f-4ad9-945e-08d7ab147b88 x-ms-traffictypediagnostic: VE1PR04MB6734: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0305463112 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(366004)(376002)(346002)(136003)(199004)(189003)(8936002)(33656002)(81166006)(81156014)(8676002)(4326008)(2906002)(52536014)(316002)(66476007)(5660300002)(71200400001)(86362001)(54906003)(76116006)(64756008)(110136005)(66946007)(66446008)(66556008)(26005)(44832011)(186003)(7696005)(55016002)(6506007)(9686003)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6734; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ldayrNgMRuU1MqBV08JVfvUhd5PH5RLMmNCWAOGVP5hn35b77kJNHqjS2PLFlfqtO1pepp1YRSAddbb+Jq3KRM+37ZzvkcmMgQCNUW8vLBMwuDNjgvJnynkNW/KSy2ZcNjAmAKxr8AgaCWGdX0yuriUusGNoQMlC2QQZt4EXpHSMH2ccJMLoXapYReR3/FoFRZmb8StedmYMVTD8hHzUFa4ubLDqDOeanTUcoy51GET9RmVACWLwwkEnolSHNVAhJItaThCJddlcWz+eKYlxyy998in5RN6acGP+ha+xSxkqlJNOCcCiNq5wfyRTNngPkha1dEA7oUWulZf8vhIR56qMbyu1Va+Vqlqm+mU0jg7wtNL/reSku7fdcM4Vjk8dxAHwsEF8j/Pmq1rtKOhQ+hiQXVy//Tz4q/HllGscCRvrbOUhcv0fUxlNZSZqUL/J x-ms-exchange-antispam-messagedata: I7lHaJPbS8dwRdjpcyZufUSDEFo8H45WDoveL3hP9yhjfFbs2pNZcePEFqAhZe6yn5N8QYIa/ccrYqKsplss7aG36HbO9PC4I8H2WmsOwj+YF2slD6fwCgkTBoOjJYZsAgicvnsZOwsuoFDjjnsgmQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5045bd93-608f-4ad9-945e-08d7ab147b88 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2020 14:54:35.5289 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kAxfVP6GaSzLIgYYiELHijuHL/9VK16UICwOzmB8NJ9gM8V2d5OPD1EzNKye8RPuOOVwuncK7oVRxQ3XT9+XXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6734 Subject: Re: [dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce/Thierry, > On Thu, Feb 06, 2020 at 02:39:28PM +0100, Thierry Herbelot wrote: > > Hello, > > > > When RTE_LIBRTE_SECURITY is disabled, compilation fails for octeontx2 (= on > an > > Intel machine): > > > > git clone git://dpdk.org/dpdk > > cd dpdk > > make config T=3Dx86_64-native-linux-gcc > > cd build > > vi .config > > =3D> disable RTE_LIBRTE_IPSEC and RTE_LIBRTE_SECURITY > > make > > ... > > =3D=3D Build drivers/net/octeontx2 > > CC otx2_rx.o > > In file included from .../dpdk/drivers/net/octeontx2/otx2_ethdev_sec.h:= 10, > > from .../dpdk/drivers/net/octeontx2/otx2_rx.h:11, > > from .../dpdk/drivers/net/octeontx2/otx2_ethdev.h:24, > > from .../dpdk/drivers/net/octeontx2/otx2_rx.c:7: > > .../dpdk/drivers/crypto/octeontx2/otx2_ipsec_fp.h:9:10: fatal error: > > rte_security.h: No such file or directory > > #include > > ^~~~~~~~~~~~~~~~ > > compilation terminated. > > > > This seems cause by f44e7163775537 ('net/octeontx2: add security sessio= n > > operations'). > > > Disabling parts of the build, particularly libraries, is always likely to > cause other build failures. I'm not sure we should, or even need to, > support the disabling of arbitrary libs in DPDK. >=20 This was followed in the past when rte_security was experimental And we made sure that compilation should work even after disabling the Lib. Now since the lib has been removed with the experimental tag, shall we Follow the same in future as well. It depends on the community and the user= s Of the code. If there is a valid use case, we can continue test compilation= without Rte_security. -Akhil=20