From: Akhil Goyal <akhil.goyal@nxp.com> To: Marcin Smoczynski <marcinx.smoczynski@intel.com>, "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>, "roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>, "declan.doherty@intel.com" <declan.doherty@intel.com>, "radu.nicolau@intel.com" <radu.nicolau@intel.com>, "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v6 0/8] Introduce CPU crypto mode Date: Wed, 5 Feb 2020 15:03:02 +0000 Message-ID: <VE1PR04MB663939F70FF936369E2CCC33E6020@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200204131258.17632-1-marcinx.smoczynski@intel.com> > Originally both SW and HW crypto PMDs use rte_crypot_op based API to > process the crypto workload asynchronously. This way provides uniformity > to both PMD types, but also introduce unnecessary performance penalty to > SW PMDs that have to "simulate" HW async behavior (crypto-ops > enqueue/dequeue, HW addresses computations, storing/dereferencing user > provided data (mbuf) for each crypto-op, etc). > > The aim is to introduce a new optional API for SW crypto-devices > to perform crypto processing in a synchronous manner. > > v3 to v4 changes: > - add feature discovery in the ipsec example application when > using cpu-crypto > - add gmac in aesni-gcm > - add tests for aesni-gcm/cpu crypto mode > - add documentation: pg and rel notes > - remove xform flags as no longer needed > - add some extra API comments > - remove compilation error from v3 > > v4 to v5 changes: > - fixed build error for arm64 (missing header include) > - update licensing information > > v5 to v6 changes: > - unit tests integrated in the current test application for cryptodev > - iova fix > - moved mbuf to sgl helper function to crypo sym header > > Marcin Smoczynski (8): > cryptodev: introduce cpu crypto support API > crypto/aesni_gcm: cpu crypto support > security: add cpu crypto action type > test/crypto: add cpu crypto mode to tests > ipsec: introduce support for cpu crypto mode > examples/ipsec-secgw: cpu crypto support > examples/ipsec-secgw: cpu crypto testing > doc: add release notes for cpu crypto Series applied to dpdk-next-crypto Last patch is split and merged in relevant patches Following patch is dropped while merging due to merge conflict. Please send it again, we will merge in RC3 "test/crypto: add cpu crypto mode to tests" > > app/test/test_cryptodev.c | 161 ++++++++++++- > doc/guides/cryptodevs/aesni_gcm.rst | 7 +- > doc/guides/cryptodevs/features/aesni_gcm.ini | 1 + > doc/guides/cryptodevs/features/default.ini | 1 + > doc/guides/prog_guide/cryptodev_lib.rst | 33 ++- > doc/guides/prog_guide/ipsec_lib.rst | 10 +- > doc/guides/prog_guide/rte_security.rst | 15 +- > doc/guides/rel_notes/release_20_02.rst | 7 + > drivers/crypto/aesni_gcm/aesni_gcm_ops.h | 11 +- > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 222 +++++++++++++++++- > drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 4 +- > .../crypto/aesni_gcm/aesni_gcm_pmd_private.h | 13 +- > examples/ipsec-secgw/ipsec.c | 25 +- > examples/ipsec-secgw/ipsec_process.c | 136 +++++++---- > examples/ipsec-secgw/sa.c | 30 ++- > examples/ipsec-secgw/test/common_defs.sh | 21 ++ > examples/ipsec-secgw/test/linux_test4.sh | 11 +- > examples/ipsec-secgw/test/linux_test6.sh | 11 +- > .../test/trs_3descbc_sha1_common_defs.sh | 8 +- > .../test/trs_aescbc_sha1_common_defs.sh | 8 +- > .../test/trs_aesctr_sha1_common_defs.sh | 8 +- > .../test/tun_3descbc_sha1_common_defs.sh | 8 +- > .../test/tun_aescbc_sha1_common_defs.sh | 8 +- > .../test/tun_aesctr_sha1_common_defs.sh | 8 +- > lib/librte_cryptodev/rte_crypto_sym.h | 128 +++++++++- > lib/librte_cryptodev/rte_cryptodev.c | 35 ++- > lib/librte_cryptodev/rte_cryptodev.h | 22 +- > lib/librte_cryptodev/rte_cryptodev_pmd.h | 21 +- > .../rte_cryptodev_version.map | 1 + > lib/librte_ipsec/esp_inb.c | 156 ++++++++++-- > lib/librte_ipsec/esp_outb.c | 136 ++++++++++- > lib/librte_ipsec/misc.h | 73 +++++- > lib/librte_ipsec/rte_ipsec.h | 20 +- > lib/librte_ipsec/sa.c | 114 +++++++-- > lib/librte_ipsec/sa.h | 19 +- > lib/librte_ipsec/ses.c | 5 +- > lib/librte_security/rte_security.h | 8 +- > 37 files changed, 1311 insertions(+), 194 deletions(-) > > -- > 2.17.1
prev parent reply other threads:[~2020-02-05 15:03 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-15 18:28 [dpdk-dev] [PATCH v3 0/6] " Marcin Smoczynski 2020-01-15 18:28 ` [dpdk-dev] [PATCH v3 1/6] cryptodev: introduce cpu crypto support API Marcin Smoczynski 2020-01-15 23:20 ` Ananyev, Konstantin 2020-01-16 10:11 ` Zhang, Roy Fan 2020-01-15 18:28 ` [dpdk-dev] [PATCH v3 2/6] crypto/aesni_gcm: cpu crypto support Marcin Smoczynski 2020-01-15 23:16 ` Ananyev, Konstantin 2020-01-16 10:00 ` Zhang, Roy Fan 2020-01-21 13:53 ` De Lara Guarch, Pablo 2020-01-21 14:29 ` Ananyev, Konstantin 2020-01-21 14:51 ` De Lara Guarch, Pablo 2020-01-21 15:23 ` Ananyev, Konstantin 2020-01-21 22:33 ` De Lara Guarch, Pablo 2020-01-22 12:43 ` Ananyev, Konstantin 2020-01-15 18:28 ` [dpdk-dev] [PATCH v3 3/6] security: add cpu crypto action type Marcin Smoczynski 2020-01-15 22:49 ` Ananyev, Konstantin 2020-01-16 10:01 ` Zhang, Roy Fan 2020-01-15 18:28 ` [dpdk-dev] [PATCH v3 4/6] ipsec: introduce support for cpu crypto mode Marcin Smoczynski 2020-01-16 10:53 ` Zhang, Roy Fan 2020-01-16 10:53 ` Zhang, Roy Fan 2020-01-15 18:28 ` [dpdk-dev] [PATCH v3 5/6] examples/ipsec-secgw: cpu crypto support Marcin Smoczynski 2020-01-16 10:54 ` Zhang, Roy Fan 2020-01-15 18:28 ` [dpdk-dev] [PATCH v3 6/6] examples/ipsec-secgw: cpu crypto testing Marcin Smoczynski 2020-01-16 10:54 ` Zhang, Roy Fan 2020-01-28 3:16 ` [dpdk-dev] [PATCH v4 0/8] Introduce CPU crypto mode Marcin Smoczynski 2020-01-28 3:16 ` [dpdk-dev] [PATCH v4 1/8] cryptodev: introduce cpu crypto support API Marcin Smoczynski 2020-01-28 3:16 ` [dpdk-dev] [PATCH v4 2/8] crypto/aesni_gcm: cpu crypto support Marcin Smoczynski 2020-01-28 10:49 ` De Lara Guarch, Pablo 2020-01-28 3:16 ` [dpdk-dev] [PATCH v4 3/8] test/crypto: add CPU crypto tests Marcin Smoczynski 2020-01-28 9:31 ` De Lara Guarch, Pablo 2020-01-28 10:51 ` De Lara Guarch, Pablo 2020-01-28 3:16 ` [dpdk-dev] [PATCH v4 4/8] security: add cpu crypto action type Marcin Smoczynski 2020-01-28 11:00 ` Ananyev, Konstantin 2020-01-28 3:16 ` [dpdk-dev] [PATCH v4 5/8] ipsec: introduce support for cpu crypto mode Marcin Smoczynski 2020-01-28 3:16 ` [dpdk-dev] [PATCH v4 6/8] examples/ipsec-secgw: cpu crypto support Marcin Smoczynski 2020-01-28 3:16 ` [dpdk-dev] [PATCH v4 7/8] examples/ipsec-secgw: cpu crypto testing Marcin Smoczynski 2020-01-28 3:16 ` [dpdk-dev] [PATCH v4 8/8] doc: add cpu crypto related documentation Marcin Smoczynski 2020-01-28 14:22 ` [dpdk-dev] [PATCH v5 0/8] Introduce CPU crypto mode Marcin Smoczynski 2020-01-28 14:22 ` [dpdk-dev] [PATCH v5 1/8] cryptodev: introduce cpu crypto support API Marcin Smoczynski 2020-01-31 14:30 ` Akhil Goyal 2020-01-28 14:22 ` [dpdk-dev] [PATCH v5 2/8] crypto/aesni_gcm: cpu crypto support Marcin Smoczynski 2020-01-28 16:39 ` Ananyev, Konstantin 2020-01-31 14:33 ` Akhil Goyal 2020-01-28 14:22 ` [dpdk-dev] [PATCH v5 3/8] test/crypto: add CPU crypto tests Marcin Smoczynski 2020-01-31 14:37 ` Akhil Goyal 2020-01-28 14:22 ` [dpdk-dev] [PATCH v5 4/8] security: add cpu crypto action type Marcin Smoczynski 2020-01-31 14:26 ` Akhil Goyal 2020-02-04 10:36 ` Akhil Goyal 2020-02-04 10:43 ` Ananyev, Konstantin 2020-01-28 14:22 ` [dpdk-dev] [PATCH v5 5/8] ipsec: introduce support for cpu crypto mode Marcin Smoczynski 2020-01-28 16:37 ` Ananyev, Konstantin 2020-01-28 14:22 ` [dpdk-dev] [PATCH v5 6/8] examples/ipsec-secgw: cpu crypto support Marcin Smoczynski 2020-01-28 14:22 ` [dpdk-dev] [PATCH v5 7/8] examples/ipsec-secgw: cpu crypto testing Marcin Smoczynski 2020-01-28 14:22 ` [dpdk-dev] [PATCH v5 8/8] doc: add cpu crypto related documentation Marcin Smoczynski 2020-01-31 14:43 ` Akhil Goyal 2020-02-04 13:12 ` [dpdk-dev] [PATCH v6 0/8] Introduce CPU crypto mode Marcin Smoczynski 2020-02-04 13:12 ` [dpdk-dev] [PATCH v6 1/8] cryptodev: introduce cpu crypto support API Marcin Smoczynski 2020-02-05 14:57 ` Akhil Goyal 2020-02-06 0:48 ` Thomas Monjalon 2020-02-06 12:36 ` [dpdk-dev] [PATCH] cryptodev: fix missing doxygen comment Marcin Smoczynski 2020-02-06 12:43 ` Ananyev, Konstantin 2020-02-12 13:15 ` Akhil Goyal 2020-02-04 13:12 ` [dpdk-dev] [PATCH v6 2/8] crypto/aesni_gcm: cpu crypto support Marcin Smoczynski 2020-02-04 13:12 ` [dpdk-dev] [PATCH v6 3/8] security: add cpu crypto action type Marcin Smoczynski 2020-02-05 14:58 ` Akhil Goyal 2020-02-04 13:12 ` [dpdk-dev] [PATCH v6 4/8] test/crypto: add cpu crypto mode to tests Marcin Smoczynski 2020-02-05 14:59 ` Akhil Goyal 2020-02-07 14:28 ` [dpdk-dev] [PATCH] test/crypto: add cpu crypto mode tests Marcin Smoczynski 2020-02-07 17:04 ` Ananyev, Konstantin 2020-02-13 9:14 ` Akhil Goyal 2020-02-13 9:29 ` Akhil Goyal 2020-02-04 13:12 ` [dpdk-dev] [PATCH v6 5/8] ipsec: introduce support for cpu crypto mode Marcin Smoczynski 2020-02-05 14:59 ` Akhil Goyal 2020-02-04 13:12 ` [dpdk-dev] [PATCH v6 6/8] examples/ipsec-secgw: cpu crypto support Marcin Smoczynski 2020-02-05 15:00 ` Akhil Goyal 2020-02-04 13:12 ` [dpdk-dev] [PATCH v6 7/8] examples/ipsec-secgw: cpu crypto testing Marcin Smoczynski 2020-02-04 13:12 ` [dpdk-dev] [PATCH v6 8/8] doc: add release notes for cpu crypto Marcin Smoczynski 2020-02-05 15:03 ` Akhil Goyal [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VE1PR04MB663939F70FF936369E2CCC33E6020@VE1PR04MB6639.eurprd04.prod.outlook.com \ --to=akhil.goyal@nxp.com \ --cc=declan.doherty@intel.com \ --cc=dev@dpdk.org \ --cc=konstantin.ananyev@intel.com \ --cc=marcinx.smoczynski@intel.com \ --cc=pablo.de.lara.guarch@intel.com \ --cc=radu.nicolau@intel.com \ --cc=roy.fan.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git