DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] test/compress: clarify out-of-space error messages
@ 2019-07-05 17:19 Fiona Trahe
       [not found] ` <522B1A062D56224ABC0C6BDBCD64D9D32F3E58A8@irsmsx105.ger.corp.intel.com>
  0 siblings, 1 reply; 3+ messages in thread
From: Fiona Trahe @ 2019-07-05 17:19 UTC (permalink / raw)
  To: dev; +Cc: akhil.goyal, fiona.trahe

Use ERR rather than INFO to warn that it's a negative test else
the errors are seen but the warning to expect them isn't.
Also add comment to make it easier to follow code.

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 app/test/test_compressdev.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index cf78775..65889c2 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -1870,7 +1870,7 @@ struct test_data_params {
 	uint16_t i;
 	const struct rte_compressdev_capabilities *capab;
 
-	RTE_LOG(INFO, USER1, "This is a negative test errors are expected\n");
+	RTE_LOG(ERR, USER1, "This is a negative test errors are expected\n");
 
 	capab = rte_compressdev_capability_get(0, RTE_COMP_ALGO_DEFLATE);
 	TEST_ASSERT(capab != NULL, "Failed to retrieve device capabilities");
@@ -1901,7 +1901,7 @@ struct test_data_params {
 		RTE_COMP_OP_STATELESS,
 		LB_BOTH,
 		ZLIB_DECOMPRESS,
-		1,
+		1,  /* run out-of-space test */
 		0
 	};
 	/* Compress with compressdev, decompress with Zlib */
-- 
1.7.0.7


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test/compress: clarify out-of-space error messages
       [not found] ` <522B1A062D56224ABC0C6BDBCD64D9D32F3E58A8@irsmsx105.ger.corp.intel.com>
@ 2019-07-18 12:39   ` Dybkowski, AdamX
  2019-07-18 15:24     ` Akhil Goyal
  0 siblings, 1 reply; 3+ messages in thread
From: Dybkowski, AdamX @ 2019-07-18 12:39 UTC (permalink / raw)
  To: Trahe, Fiona, 'dev@dpdk.org'; +Cc: 'akhil.goyal@nxp.com'

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fiona Trahe
> Sent: Friday, 5 July, 2019 19:19
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: [dpdk-dev] [PATCH] test/compress: clarify out-of-space error 
> messages
> 
> Use ERR rather than INFO to warn that it's a negative test else the 
> errors are seen but the warning to expect them isn't.
> Also add comment to make it easier to follow code.
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---

Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test/compress: clarify out-of-space error messages
  2019-07-18 12:39   ` Dybkowski, AdamX
@ 2019-07-18 15:24     ` Akhil Goyal
  0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2019-07-18 15:24 UTC (permalink / raw)
  To: Dybkowski, AdamX, Trahe, Fiona, 'dev@dpdk.org'



> >
> > Use ERR rather than INFO to warn that it's a negative test else the
> > errors are seen but the warning to expect them isn't.
> > Also add comment to make it easier to follow code.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> > ---
> 
> Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>

Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-18 15:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-05 17:19 [dpdk-dev] [PATCH] test/compress: clarify out-of-space error messages Fiona Trahe
     [not found] ` <522B1A062D56224ABC0C6BDBCD64D9D32F3E58A8@irsmsx105.ger.corp.intel.com>
2019-07-18 12:39   ` Dybkowski, AdamX
2019-07-18 15:24     ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).