From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58ADBA046B for ; Thu, 25 Jul 2019 13:42:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 946CD1C309; Thu, 25 Jul 2019 13:42:35 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140049.outbound.protection.outlook.com [40.107.14.49]) by dpdk.org (Postfix) with ESMTP id 870271C306 for ; Thu, 25 Jul 2019 13:42:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XqgCOq25SyYWDI2JHNtGsoySBIkwwfp9QuOWddwan+FAiK1pIrWCw/C8eimrHK43JJHo+A3LNpIxr8EddBetCrSyagc/ZZpgJ/+iO6n7o0BOXp2wZgqZPgZnI6y2bu3MuAeLYY/Pd7DgWL6+wmvxc2UM36H8U7RiEwptz0K9oCid8Fh+aLZVBKCHt5fC9zhfcQpBjd1IUxAMe8/1AAE8EJY55Jeen0pO2e4VKAAevN5uQZh6tuwj5QQVw5upuWe4QiS7IyCVM7x5gJfbL0SEnSEsWwEn+0R2sUKZvsDOkqHoIwsLIl4pnXUSEhFiwADlJjxWv/rdzPOvc+rLbRiZVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qhmgNO1dpGzIn2iiV3hymufpn24cFqY0E66pah6oYUA=; b=cMkl/gibzK4MzNtWaN317Y47URqFdVfERK1/dhbgQ4cTyQtJnzuFWEuEaq3agfcZQDGtK1UtSE3DIsLeU3Wa+LPzb/eF+xqjR2MZtQ5FPUq3JNhFO8LHla/zAJ4nV0gL16wdPVgzN72HkAp3QH/4C3aiX3PHVRI8mik9hs+tm6uBC6LMni/CKP4x7QtoDFRKgLsZbNcbfBaiiniE4MXjWndejPajDMjyPy/me+rWj3WGCjU4X76Fo/B3QqczepQmwxrFxNUFALU5iSl22i8DoQaXEOaIN1vzdwUQke6FqX2TDlnYHxvt57q5NLFIbsGPzEHNrYU8Xszc6fHXFZdr6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=nxp.com;dmarc=pass action=none header.from=nxp.com;dkim=pass header.d=nxp.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qhmgNO1dpGzIn2iiV3hymufpn24cFqY0E66pah6oYUA=; b=CntidcVLB2KID40FG1QJWasbXec5Ph9+AzcVieKlS6JtjrcKr6so0S+l+tXO+uAWqYO3tQqgKTz0AOWYeznyq1Rcxmln/5k6hvDn7abhcWNj7XvDJwA5zdLcQp9r0OurhK030U2y9nGJD84nPsStyVOAU7JrmOdUUqGJ5hQIENE= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6543.eurprd04.prod.outlook.com (20.179.234.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Thu, 25 Jul 2019 11:42:33 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::d546:8474:f63a:5d22]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::d546:8474:f63a:5d22%6]) with mapi id 15.20.2094.013; Thu, 25 Jul 2019 11:42:33 +0000 From: Akhil Goyal To: Shally Verma , Anoob Joseph , Ayuj Verma CC: "arkadiuszx.kusztal@intel.com" , Sunila Sahu , Kanaka Durga Kotamarthy , "dev@dpdk.org" , Fiona Trahe Thread-Topic: [PATCH v1 0/2] declare crypto asym xform immutable Thread-Index: AQHVQf0Uq6n1MCNYAkafRcdHeP7+s6bZdlWAgAFE6YCAABJ3AIAAFSsAgABPWXCAAAPYgIAAAHAg Date: Thu, 25 Jul 2019 11:42:33 +0000 Message-ID: References: <1563958317-480-1-git-send-email-ayverma@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.0.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cb94f222-96da-469a-586f-08d710f52ee0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6543; x-ms-traffictypediagnostic: VE1PR04MB6543: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(39860400002)(346002)(366004)(136003)(396003)(189003)(199004)(66066001)(2906002)(102836004)(14454004)(76116006)(55016002)(86362001)(99286004)(71190400001)(26005)(8936002)(71200400001)(6246003)(7696005)(66946007)(76176011)(6506007)(66556008)(66446008)(6436002)(68736007)(64756008)(66476007)(81166006)(54906003)(8676002)(305945005)(110136005)(9686003)(6306002)(229853002)(186003)(316002)(44832011)(25786009)(81156014)(486006)(476003)(74316002)(4326008)(446003)(966005)(53936002)(11346002)(478600001)(5660300002)(52536014)(14444005)(256004)(3846002)(33656002)(6116002)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6543; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ensiofKHAvLP9k8L4O1mokfJK73D25zheeTZAjAjV9+jebgbEi2ekdlrbNAOWFJU2h8+b5tU/QGvrpDrgow20FETusF1RZarlr/9r0wo0U9Coe5cUFchv5mJI7oqTVJeKADrTKTHI0XYuygDPN/5gK1y3tnb7n9BuaJURYspoNux3/JD8DluVQ4t+mbHOYtX8iuHQIcJHOvxj0LpImoy0cfL3ZkoRaNCft4LAVy4sq1O6UM7/uwLZ8JjlBAINIXWAo9EeK0/r5Tm6qSExP6LxrMxdsXN25yvqBsdwaZojEpdmT3SH8XKbtWZKN523mevv///KATqb46X+CXMhDu0J2NaiOVpddzIXcwRbSj23gYETIcY9V2LJTJ0zVm2qDk7H5EGx7eXZseO20/RaSvVI6SN5hFhVPLwVhxUZfcXGXI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb94f222-96da-469a-586f-08d710f52ee0 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2019 11:42:33.4052 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6543 Subject: Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Akhil >=20 > > > > Hi Anoob/Shally > > > > > > > > > > Hi Ayuj, > > > > > > > > I believe there are couple of issues with this patch. > > > > > > > > Are these experimental APIs? I believe they were made stable this > > > > release and I'm not sure if it is a right practice to edit an API > > > > without deprecation notice after it is made stable. Especially now > > > > that RC2 is done. @Akhil, what is your take on this? > > > > [Shally] These are experimental still, hence no deprecation notice. > > > > We checked about it with Fiona, Akhil before. > > > > > > [Anoob] In the patch, the edited APIs doesn't have experimental tag. = I > > > leave it to Akhil's judgement on this. > > > > > The API is experimental. Check the .map file. > > > > But these kind of patches cannot go in 1908 release, as we have already > > tagged it for RC2. > > We need to defer this change for 19.11 release. > > > [Shally] Well. Cant do anything if we have missed deadline here. Right no= w its up > for feedback. > Meanwhile if we get any agreement and window gets open for nearest releas= e, > then please consider it. library changes cannot go beyond RC2 unless it is a fix for some issue. >=20 > > One more issue that I see in this patch. QAT also uses these APIs, so i= t shall > > also be modified along with openssl. > > > [Shally] We assume QAT changes will be done by QAT maintainer, once they > review and approve this change. >=20 Patch 1/2 will break the compilation for QAT and openssl. All changes should be part of a single patch (both for QAT and openssl). If somebody is modifying the common code, then it should not atleast break = the compilation. Check the following commit. http://git.dpdk.org/next/dpdk-next-crypto/commit/?id=3D186b14d6850654eb84a8= ae9ea29b736f0ba5e093 -Akhil