From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6743FA0487 for ; Tue, 30 Jul 2019 10:48:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B394E1BF64; Tue, 30 Jul 2019 10:48:28 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80051.outbound.protection.outlook.com [40.107.8.51]) by dpdk.org (Postfix) with ESMTP id BDCE61BEC5 for ; Tue, 30 Jul 2019 10:48:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DQQ8AEZWXRurS/VKQsCIMuGDcEVs85JXpGx+WA21RqC6rejZ7orn7UzmGAC20NS9Qriff/LtQtmc2yiRrsthpwPeQHANM38igZTheWDZXnydw9qj6r8bDmR/obe02V2Sx3Aj3ZSr7tni82/x2Y20QLXyFc0IzxvlThc3kOAGBbt+IQQoSCMyKRUOBfttMO1SKfH1YNGQYMFoBHGkJHev/7Czdv88jrY/RA29XSoFI+vlLB/DgmO0SUNP9w/WnA2rv40UCdeTm0i0LVD9xm4AR2L9EKXUoUGzRA/e59K/0IX2toMt9DkHnOfQF3i9+F28GVJnJmon4FvjJVRyXl6ajw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MbbHp5BqXHy9jfkxQlqgO1JziREl2docZ2u8zSy6C5M=; b=DYY38UYkP+rIwyf6k+L++IbBwkS+EY2GP2/ntW1F6jocLXM9ODq9JjxBVVacwNC9pYdPeyqZOwHyUdTSpYZHjErjfyS8YL29Wr974waWsSTwap4aNpmpg9HwsUppobuGDd68OnJSamc3y2yuZiCUY5Fg5G8doYxKeq5N+qfJ3Gt6ceX+bBG60O6w1WpFTaGggboZ8KLMD0sTi5hFu9dW131O7K8Jvz0gr2em6N3d6Ada+FZI/CJGu0KU806EN9Sbs2ZQKZBaN2CGngzIDW2lFVMmyAWTjvAS/M+LGYBMtTfKIc4jxnoFrcJjGqmGODVxUmoM5Gbh/8XSrijIp1mDNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=nxp.com;dmarc=pass action=none header.from=nxp.com;dkim=pass header.d=nxp.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MbbHp5BqXHy9jfkxQlqgO1JziREl2docZ2u8zSy6C5M=; b=n34r7w2Dyp5VJ3AaWvOU3L3jiBTCOagbcoVVnWOQwwdblz1ArpdrkhsHHTXZfxA0l8g1DH0yngUku/TxymdGRwYpeUXKHUdiOcFJk52GOQnWukC/HTSSlCvu+BSr/eYXI02/8kpYdne98bCZOz60lRHAy9q4X7h+DG4dABVwEcg= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6351.eurprd04.prod.outlook.com (10.255.118.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.13; Tue, 30 Jul 2019 08:48:26 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::964:4ddc:346b:e2ec]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::964:4ddc:346b:e2ec%7]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 08:48:26 +0000 From: Akhil Goyal To: Thomas Monjalon CC: Bernard Iremonger , "dev@dpdk.org" , Anoob Joseph , "konstantin.ananyev@intel.com" , Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya Thread-Topic: [dpdk-dev] [EXT] [PATCH] doc: deprecate legacy code path in ipsec-secgw Thread-Index: AQHVRitzwTpsrZhZLECEWe3JhP6PuqbiqGgwgAAWsgCAAAED4IAAC4QAgAAOSbA= Date: Tue, 30 Jul 2019 08:48:26 +0000 Message-ID: References: <1562835937-24141-1-git-send-email-bernard.iremonger@intel.com> <17016159.n4PeLHrF3L@xps> <2417926.RaMoeEf8dU@xps> In-Reply-To: <2417926.RaMoeEf8dU@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4ad31873-6379-406e-c135-08d714caafce x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6351; x-ms-traffictypediagnostic: VE1PR04MB6351: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0114FF88F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(136003)(346002)(376002)(39860400002)(189003)(199004)(66446008)(66556008)(7736002)(316002)(76176011)(6436002)(6116002)(3846002)(7696005)(99286004)(5660300002)(6916009)(81166006)(54906003)(9686003)(86362001)(55016002)(8676002)(26005)(81156014)(68736007)(52536014)(102836004)(186003)(6506007)(8936002)(53936002)(25786009)(71190400001)(256004)(446003)(71200400001)(6246003)(66066001)(486006)(74316002)(14444005)(44832011)(305945005)(14454004)(478600001)(33656002)(64756008)(11346002)(4326008)(66476007)(76116006)(66946007)(2906002)(476003)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6351; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ZWpXZ5dwu6HxWU+6pnGU4JN3/hLZWTbrW5pzvw/MN1q5+PiabE/VmYoHF3k/Fv49C1rvQbzVYmZsEZBZM6o13/M2+p3PD3oM7c95omrXJmoR6Oyfe61c8VYSV0cMYE87BAywfaMO+fbsOiW8kdC82Nv3MdMA/lYVdWxiCLVJYhPL1Gk4idrAMqx6szmRpWmKlXDUbSw69aiPhHSlnQFvRShydLHxmn2l54iKtwWZlkB7CvAV/hUXdocOFm/QXRQ1gvzYOdgfatm9pnw5uiMcdgNRSLiiRJaqinAGDyyAqsr46+Ctf0yKp2XbsZct5y2CBe8Tvw0z9UDGqN02fE7Lm7MSmeCMYROmicZAE298bP61tz7Yy5VW2fCv/Wc7SEP5HwYWqbYlkTCKW4ngebd0gGaomqgajrAJD3gGoUhKBic= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ad31873-6379-406e-c135-08d714caafce X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 08:48:26.1386 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6351 Subject: Re: [dpdk-dev] [EXT] [PATCH] doc: deprecate legacy code path in ipsec-secgw X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 30/07/2019 09:20, Akhil Goyal: > > > 30/07/2019 07:55, Akhil Goyal: > > > > > > > > All the functionality of the legacy code path in now availa= ble > > > > > > > > in the librte_ipsec library. > > > > > > > > It is planned to deprecate the legacy code path in the 19.1= 1 > > > > > > > > release and remove the legacy code path in the 20.02 releas= e. > > > > > > > > > > > > > > > > Signed-off-by: Bernard Iremonger > > > > > > > > Acked-by: Konstantin Ananyev > > > > > > > > Acked-by: Fan Zhang > > > > > > > > Acked-by: Akhil Goyal > > > > > > > > --- > > > > > > > > doc/guides/rel_notes/deprecation.rst | 5 +++++ > > > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > > > > > Acked-by: Anoob Joseph > > > > > > > > > > > > Applied to dpdk-next-crypto > > > > > > > > > > Why do we have a deprecation notice for some code path in an exam= ple? > > > > > The deprecation notices are for the API. > > > > > > > > > > I think you can drop the legacy code in 19.11, > > > > > and I don't merge this patch in master. > > > > > > > > We are planning to remove the original code and replace it with IPS= ec > > > > library APIs which are still experimental. > > > > With this change there won't be any example of the legacy ipsec cod= e path. >=20 > That's good to drop old code. > If someone still wants to look at it, it is in old releases. >=20 > > > > Applications over DPDK take ipsec-secgw as an example and IPSec > > > > is a major use case for customers. There may also be performance > > > > differences in the two code paths. Atleast on NXP platforms I saw > > > > 5-7% drop when the patches were originally submitted. > > > > Not sure what is the current state. >=20 > That's a different issue you need to solve in the library. >=20 > > > > I feel it is worth notifying the users that the original codepath i= s > > > > getting deprecated, so that they can plan to move to new IPSec APIs= . >=20 > I hope they already planned to move when they saw the new library. >=20 > > > The deprecation notice is not the right place for a change in an exam= ple. > > > What change is there in IPsec API? In which release? > > > > IPSec lib was introduced in 1902 release and a few enhancements are don= e > thereafter. > > Previously all IPSec related stuff was done in the application, now we = have > IPSec Lib which > > perform similar work. There are changes both in datapath as well as con= trol > path. > > User need to adapt to the recent changes, as we may no longer > support/maintain the datapath/control > > path which was done previously and there may be some conflict. >=20 > So the real DPDK change is to have a new library in 19.02. >=20 > > If deprecation notice is not the right place, > > then where should it be notified before actually making the change. >=20 > It has already been notified in "New Features" of 19.02 > that there is an IPsec library. What do you want to notify more? > Again, the example is not supposed to be a real application. > If you want to maintain an IPsec application with better quality rules, > I suggest to start a new git repository for it. >=20 OK got your point, but in that case, I would say, legacy code shall not be = removed Until we have the ipsec lib as experimental. User should have both the code paths as long as we have ipsec library exper= imental.