From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EA15EA0471 for ; Thu, 20 Jun 2019 14:27:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8DCDF1D398; Thu, 20 Jun 2019 14:27:20 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60068.outbound.protection.outlook.com [40.107.6.68]) by dpdk.org (Postfix) with ESMTP id E42D41D374 for ; Thu, 20 Jun 2019 14:27:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qJDufNNVN3NZVQzxhcbaswfd4L3OcKQ0Uh/Y46bFAW8=; b=sULBWjXBgRRYxL3YF4NbQ663++QOjYQaA1IhNoUvBzWbNAnccqcmwVhu37J9lYu2WW+2kvw4gT5gWrCl8EB2rnb4bwFLPMVwrLdhZk0KkfFJlDcjvl7NW9i4/Ud8zKcXIrnTnBuiofa4SOZWA6XJVOBxJnCB/JGfYMb8af2E/Gg= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6672.eurprd04.prod.outlook.com (20.179.235.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.12; Thu, 20 Jun 2019 12:27:18 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.1987.014; Thu, 20 Jun 2019 12:27:18 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "Kovacevic, Marko" , "dev@dpdk.org" CC: "Zhang, Roy Fan" Thread-Topic: [PATCH v1] lib/ipsec: add support for header construction Thread-Index: AQHVDMoSdEZ5UIeZT0+nVo7RGL0NkKZypaMAgDIHJyA= Date: Thu, 20 Jun 2019 12:27:17 +0000 Message-ID: References: <20190517160319.2468-1-marko.kovacevic@intel.com> <2601191342CEEE43887BDE71AB9772580161635D40@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772580161635D40@irsmsx105.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c34cb3bc-f5aa-41f7-3750-08d6f57aa28c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6672; x-ms-traffictypediagnostic: VE1PR04MB6672: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0074BBE012 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(366004)(39860400002)(396003)(376002)(189003)(199004)(76176011)(7736002)(26005)(6436002)(55016002)(305945005)(6116002)(14444005)(256004)(99286004)(5660300002)(66476007)(3846002)(476003)(66556008)(74316002)(4326008)(486006)(81156014)(102836004)(446003)(9686003)(14454004)(229853002)(11346002)(6506007)(2501003)(8676002)(478600001)(2906002)(76116006)(73956011)(7696005)(52536014)(44832011)(25786009)(66066001)(66446008)(81166006)(8936002)(66946007)(186003)(110136005)(68736007)(64756008)(53936002)(33656002)(71190400001)(71200400001)(6246003)(86362001)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6672; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: psw+1OskQgYlD/XCbtcyupVYgrlLO7x76d6K3Q8sx4cfaJBjZbQogAbJeHHw1earYdG/eBRtIta/QYljmi+EPpVh78Li4r3/BfAjUfxcBs1calHZvJSb0j7S9l+XCGPpt6bDOPf6bPnrL+Ny6yi46rXlobRQdjc4TvqetBt7FB48IipziyMq0oA/YRhIWFOK8imEmG47fjcSr3mXHSG6FXMlnLNZ2yIBRb9TUYqJKsJpwYzE8f0V0ndHwJcsEPVJtEUedLC/DpN+g1Rkbh8SLx4VSH7eV8eS4RtnNbjQQDQtyZPPyThnkRsRBXnUz+GBmYDrg9K+PIDT3QYVy4jgNFvhHL60Mebg3hgRHjfungMT+lWyHvVJOdqfK7Lcl6wEx9Dg+d3Pcs6kpPC3W8w0u9+cLuwZ6hwiOhqXizAW6nI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c34cb3bc-f5aa-41f7-3750-08d6f57aa28c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2019 12:27:18.0357 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6672 Subject: Re: [dpdk-dev] [PATCH v1] lib/ipsec: add support for header construction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Marko, Could you please address to the comments from Konstantin? We have an RC1 da= te coming. Thanks, Akhil > Hi, >=20 > > > > Add support for RFC 4301(5.1.2) to update of > > Type of service field and Traffic class field > > bits inside ipv4/ipv6 packets for outbound cases > > and inbound cases which deals with the update of > > the DSCP/ENC bits inside each of the fields. > > > > Signed-off-by: Marko Kovacevic > > --- > > examples/ipsec-secgw/sa.c | 2 + > > lib/librte_ipsec/esp_inb.c | 14 ++++- > > lib/librte_ipsec/esp_outb.c | 4 +- > > lib/librte_ipsec/iph.h | 119 +++++++++++++++++++++++++++++= ++++++- > - > > lib/librte_ipsec/rte_ipsec_sa.h | 25 ++++++++ > > lib/librte_ipsec/sa.c | 17 ++++++ > > lib/librte_ipsec/sa.h | 2 + > > lib/librte_net/rte_ip.h | 8 +++ > > lib/librte_security/rte_security.h | 9 +++ > > 9 files changed, 191 insertions(+), 9 deletions(-) >=20 > Looks good in general, some generic comments: > - I think it is better to split the patch into few sub-pathces: > One for rte_security, second for rte_net, third - rte_ipsec, forth - > examples/ipsec-secgw > - Would be good to add support for other options too (ttl, etc.) > - Would be good to add new test-case for it into examples/ipsec-secgw/tes= t/ >=20 > Plus few nits in the code below. > Konstantin >=20