* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option
2019-07-18 14:21 [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option taox.zhu
@ 2019-07-18 9:39 ` Iremonger, Bernard
2019-07-18 10:58 ` Ananyev, Konstantin
0 siblings, 1 reply; 4+ messages in thread
From: Iremonger, Bernard @ 2019-07-18 9:39 UTC (permalink / raw)
To: Zhu, TaoX, Nicolau, Radu, akhil.goyal; +Cc: dev, Zhu, TaoX
Hi Tao
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> taox.zhu@intel.com
> Sent: Thursday, July 18, 2019 3:22 PM
> To: Nicolau, Radu <radu.nicolau@intel.com>; akhil.goyal@nxp.com
> Cc: dev@dpdk.org; Zhu, TaoX <taox.zhu@intel.com>
> Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu
> parse option
>
> From: Zhu Tao <taox.zhu@intel.com>
>
> This patch add parameter --mtu parse key and enumeration value.
>
> Signed-off-by: Zhu Tao <taox.zhu@intel.com>
> ---
> examples/ipsec-secgw/ipsec-secgw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-
> secgw/ipsec-secgw.c
> index b1ecbb975..05fffa967 100644
> --- a/examples/ipsec-secgw/ipsec-secgw.c
> +++ b/examples/ipsec-secgw/ipsec-secgw.c
> @@ -159,6 +159,7 @@ static const struct option lgopts[] = {
> {CMD_LINE_OPT_RX_OFFLOAD, 1, 0,
> CMD_LINE_OPT_RX_OFFLOAD_NUM},
> {CMD_LINE_OPT_TX_OFFLOAD, 1, 0,
> CMD_LINE_OPT_TX_OFFLOAD_NUM},
> {CMD_LINE_OPT_REASSEMBLE, 1, 0,
> CMD_LINE_OPT_REASSEMBLE_NUM},
> + {CMD_LINE_OPT_MTU, 1, 0, CMD_LINE_OPT_MTU_NUM},
> {NULL, 0, 0, 0}
> };
>
> --
> 2.17.1
This patch looks like a fix, if so it should have a fixes line and Cc: stable@dpdk.org if it is to be back ported.
Also
./devtools/check-git-log.sh -1
Wrong headline lowercase:
examples/ipsec-secgw: add parameter --mtu parse option
Regards,
Bernard.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option
2019-07-18 9:39 ` Iremonger, Bernard
@ 2019-07-18 10:58 ` Ananyev, Konstantin
2019-07-18 15:21 ` Akhil Goyal
0 siblings, 1 reply; 4+ messages in thread
From: Ananyev, Konstantin @ 2019-07-18 10:58 UTC (permalink / raw)
To: Iremonger, Bernard, Zhu, TaoX, Nicolau, Radu, akhil.goyal; +Cc: dev, Zhu, TaoX
Hi guys,
>
> Hi Tao
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> > taox.zhu@intel.com
> > Sent: Thursday, July 18, 2019 3:22 PM
> > To: Nicolau, Radu <radu.nicolau@intel.com>; akhil.goyal@nxp.com
> > Cc: dev@dpdk.org; Zhu, TaoX <taox.zhu@intel.com>
> > Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu
> > parse option
> >
> > From: Zhu Tao <taox.zhu@intel.com>
> >
> > This patch add parameter --mtu parse key and enumeration value.
> >
> > Signed-off-by: Zhu Tao <taox.zhu@intel.com>
> > ---
> > examples/ipsec-secgw/ipsec-secgw.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-
> > secgw/ipsec-secgw.c
> > index b1ecbb975..05fffa967 100644
> > --- a/examples/ipsec-secgw/ipsec-secgw.c
> > +++ b/examples/ipsec-secgw/ipsec-secgw.c
> > @@ -159,6 +159,7 @@ static const struct option lgopts[] = {
> > {CMD_LINE_OPT_RX_OFFLOAD, 1, 0,
> > CMD_LINE_OPT_RX_OFFLOAD_NUM},
> > {CMD_LINE_OPT_TX_OFFLOAD, 1, 0,
> > CMD_LINE_OPT_TX_OFFLOAD_NUM},
> > {CMD_LINE_OPT_REASSEMBLE, 1, 0,
> > CMD_LINE_OPT_REASSEMBLE_NUM},
> > + {CMD_LINE_OPT_MTU, 1, 0, CMD_LINE_OPT_MTU_NUM},
> > {NULL, 0, 0, 0}
> > };
> >
> > --
> > 2.17.1
Thanks for fixing it for me, don't know where I lost that line.
>
> This patch looks like a fix, if so it should have a fixes line and Cc: stable@dpdk.org if it is to be back ported.
I am agree with Bernard about fixes line, though no need to CC stable,
as this bug was introduced in 19.08 timeframe.
>
> Also
> ./devtools/check-git-log.sh -1
> Wrong headline lowercase:
> examples/ipsec-secgw: add parameter --mtu parse option
>
Apart from the nits mentioned above:
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Tested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option
@ 2019-07-18 14:21 taox.zhu
2019-07-18 9:39 ` Iremonger, Bernard
0 siblings, 1 reply; 4+ messages in thread
From: taox.zhu @ 2019-07-18 14:21 UTC (permalink / raw)
To: radu.nicolau, akhil.goyal; +Cc: dev, Zhu Tao
From: Zhu Tao <taox.zhu@intel.com>
This patch add parameter --mtu parse key and enumeration value.
Signed-off-by: Zhu Tao <taox.zhu@intel.com>
---
examples/ipsec-secgw/ipsec-secgw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index b1ecbb975..05fffa967 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -159,6 +159,7 @@ static const struct option lgopts[] = {
{CMD_LINE_OPT_RX_OFFLOAD, 1, 0, CMD_LINE_OPT_RX_OFFLOAD_NUM},
{CMD_LINE_OPT_TX_OFFLOAD, 1, 0, CMD_LINE_OPT_TX_OFFLOAD_NUM},
{CMD_LINE_OPT_REASSEMBLE, 1, 0, CMD_LINE_OPT_REASSEMBLE_NUM},
+ {CMD_LINE_OPT_MTU, 1, 0, CMD_LINE_OPT_MTU_NUM},
{NULL, 0, 0, 0}
};
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option
2019-07-18 10:58 ` Ananyev, Konstantin
@ 2019-07-18 15:21 ` Akhil Goyal
0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2019-07-18 15:21 UTC (permalink / raw)
To: Ananyev, Konstantin, Iremonger, Bernard, Zhu, TaoX, Nicolau, Radu
Cc: dev, Zhu, TaoX
>
>
> Hi guys,
>
> >
> > Hi Tao
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> > > taox.zhu@intel.com
> > > Sent: Thursday, July 18, 2019 3:22 PM
> > > To: Nicolau, Radu <radu.nicolau@intel.com>; akhil.goyal@nxp.com
> > > Cc: dev@dpdk.org; Zhu, TaoX <taox.zhu@intel.com>
> > > Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu
> > > parse option
> > >
> > > From: Zhu Tao <taox.zhu@intel.com>
> > >
> > > This patch add parameter --mtu parse key and enumeration value.
> > >
> > > Signed-off-by: Zhu Tao <taox.zhu@intel.com>
> > > ---
> > > examples/ipsec-secgw/ipsec-secgw.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-
> > > secgw/ipsec-secgw.c
> > > index b1ecbb975..05fffa967 100644
> > > --- a/examples/ipsec-secgw/ipsec-secgw.c
> > > +++ b/examples/ipsec-secgw/ipsec-secgw.c
> > > @@ -159,6 +159,7 @@ static const struct option lgopts[] = {
> > > {CMD_LINE_OPT_RX_OFFLOAD, 1, 0,
> > > CMD_LINE_OPT_RX_OFFLOAD_NUM},
> > > {CMD_LINE_OPT_TX_OFFLOAD, 1, 0,
> > > CMD_LINE_OPT_TX_OFFLOAD_NUM},
> > > {CMD_LINE_OPT_REASSEMBLE, 1, 0,
> > > CMD_LINE_OPT_REASSEMBLE_NUM},
> > > + {CMD_LINE_OPT_MTU, 1, 0, CMD_LINE_OPT_MTU_NUM},
> > > {NULL, 0, 0, 0}
> > > };
> > >
> > > --
> > > 2.17.1
>
> Thanks for fixing it for me, don't know where I lost that line.
>
> >
> > This patch looks like a fix, if so it should have a fixes line and Cc:
> stable@dpdk.org if it is to be back ported.
>
> I am agree with Bernard about fixes line, though no need to CC stable,
> as this bug was introduced in 19.08 timeframe.
>
> >
> > Also
> > ./devtools/check-git-log.sh -1
> > Wrong headline lowercase:
> > examples/ipsec-secgw: add parameter --mtu parse option
> >
>
> Apart from the nits mentioned above:
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Tested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Changed the subject and added fixes line
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-18 15:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 14:21 [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option taox.zhu
2019-07-18 9:39 ` Iremonger, Bernard
2019-07-18 10:58 ` Ananyev, Konstantin
2019-07-18 15:21 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).