DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Somalapuram, Amaranath" <Amaranath.Somalapuram@amd.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 2/6] crypto/ccp: max queue pair and max burst	sizes changes
Date: Tue, 22 Oct 2019 06:07:00 +0000	[thread overview]
Message-ID: <VE1PR04MB6639997FB931550CCF3A1092E6680@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CY4PR1201MB24714E63E83AB749CCBDF475F8680@CY4PR1201MB2471.namprd12.prod.outlook.com>



> 
> We can reproduce this issue in l2fwd by changing MAX_PKT_BURST 32 to 256
> 
> 
Description should have appropriate information explaining what the issue is and
What is done in the patch to fix the issue.

> 
> Title should be: crypto/ccp: update max qp and burst size.
> 
> >
> > From: Amaranath Somalapuram <asomalap@amd.com>
> >
> > issue occurred during VPP testing, crash's issue in VPP when ccp used.
> > vpp max burst size is 256, and minimum queue pair required is 3.
> 
> Please explain the issue appropriately in the description.
> Does that mean, without VPP, this issue cannot be reproduced.
> 
> Add a fixes line with the commit which introduces this issue.
> 
> 
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> > ---
> >  drivers/crypto/ccp/ccp_pmd_private.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/crypto/ccp/ccp_pmd_private.h
> > b/drivers/crypto/ccp/ccp_pmd_private.h
> > index 7f2979e89..781050c31 100644
> > --- a/drivers/crypto/ccp/ccp_pmd_private.h
> > +++ b/drivers/crypto/ccp/ccp_pmd_private.h
> > @@ -31,9 +31,9 @@
> >  #endif
> >
> >  /**< Maximum queue pairs supported by CCP PMD */
> > -#define CCP_PMD_MAX_QUEUE_PAIRS      1
> > +#define CCP_PMD_MAX_QUEUE_PAIRS      8
> >  #define CCP_NB_MAX_DESCRIPTORS 1024
> > -#define CCP_MAX_BURST 64
> > +#define CCP_MAX_BURST 256
> >
> >  #include "ccp_dev.h"
> >
> > --
> > 2.17.1


      reply	other threads:[~2019-10-22  6:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15  7:01 asomalap
2019-10-15 10:58 ` Akhil Goyal
2019-10-22  5:21   ` Somalapuram, Amaranath
2019-10-22  6:07     ` Akhil Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR04MB6639997FB931550CCF3A1092E6680@VE1PR04MB6639.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=Amaranath.Somalapuram@amd.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).