From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8C08A0535; Tue, 4 Feb 2020 16:22:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 858111C206; Tue, 4 Feb 2020 16:22:57 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80057.outbound.protection.outlook.com [40.107.8.57]) by dpdk.org (Postfix) with ESMTP id B96C61C1F6 for <dev@dpdk.org>; Tue, 4 Feb 2020 16:22:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i2Wba9EYj7VAA/YHZMKbtOGtT/gId2gdZuifXjOYSSV0UAa6o4PfFrixvrrHGQOrkgmklaOOaMFzi+Mq6NE7h8cYCjtVkJUZPaQkTJnxR3YzlD6ruIZpBTQD0neei0IQnEf83/dKCafNF+/BIzCyg7Q+lpYF83A/+DUPrks+G6FxuMmnL9nmKpZpHdnAyW2EDbpQSrNKz9I/Ric6tsVINaIRGOYQcjCwK20kt6y7foxok61SnQkiYu4dPZPvwFEPlBk+vb9r1VSNv5734W70TMIi2Tz4P611PH7dqw1nsVqXCtQUkZEPxXELCLyuFcEUYJg/vsIqmD+5i1Br8133iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YYg/Sy1+yCr3tZ2ToAXo/XeVCygQ0xsFDRCm0fW9q5A=; b=KsCwcI7uaq1WwV0NzT3w+uvrd1yDoc4hpmED8D3XHB6Vvx8fF1h+nMYg8MMzLppz4wniwYJOhPo7v8w8VSGTz+awx12d0RcDj+qfCsoiMLlZPiWjZ1yOuHTdxDfwVQ/wKJumRnuXr3IRJD2w+NJcgJSEymVJT14bUIOMvXqzVtPilkC6kt+swT72r/fa/Xd0nfWTkjNmQQy29cJ1hC06M5buACDCioblAwzaWWAm1GBEBAw4JiPUz66A1UmASO6fgSvB5l7q/ZfJZocmdrLGdK+h9SjTmSIMRYZ2FIKwLaYxwdl5NAqqlxnEuZVHSY9YoZkZ95ZbzfUTLUbLjAJ/1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YYg/Sy1+yCr3tZ2ToAXo/XeVCygQ0xsFDRCm0fW9q5A=; b=eYS+PomnhBNlio54E5Z1WQJ+DjBgSx+Dhe/OupMUXClsS9RLJk+AodnK/k25Kgp4yI/q6bRHqeB1QuRTmUJDdLoRx9lk990vvgbGQtX1FohfEh6pO05thJ/IDcmMfr/EuwTd4Qx/GK5S7Tgpx8BUp0xJR1rebZqZhmBxPDqYKBE= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6542.eurprd04.prod.outlook.com (20.179.234.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.27; Tue, 4 Feb 2020 15:22:56 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1%7]) with mapi id 15.20.2686.031; Tue, 4 Feb 2020 15:22:56 +0000 From: Akhil Goyal <akhil.goyal@nxp.com> To: Anoob Joseph <anoobj@marvell.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com> CC: "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [PATCH v5 0/6] integrate librte_ipsec SAD into ipsec-secgw Thread-Index: AQHV1q1F4w2RqjI6IE6VioTYQWMILKgEvOsAgAW4AgCAALuGIA== Date: Tue, 4 Feb 2020 15:22:56 +0000 Message-ID: <VE1PR04MB66399DA806FDD79782BB437BE6030@VE1PR04MB6639.eurprd04.prod.outlook.com> References: <1579012036-326214-1-git-send-email-vladimir.medvedkin@intel.com> <1580306768-110555-1-git-send-email-vladimir.medvedkin@intel.com> <VE1PR04MB6639AD8915827B12A4477615E6070@VE1PR04MB6639.eurprd04.prod.outlook.com> <MN2PR18MB2877AF14CB5BFD7238EFA718DF030@MN2PR18MB2877.namprd18.prod.outlook.com> In-Reply-To: <MN2PR18MB2877AF14CB5BFD7238EFA718DF030@MN2PR18MB2877.namprd18.prod.outlook.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 024d77d9-d436-44a5-a2d7-08d7a9861c4e x-ms-traffictypediagnostic: VE1PR04MB6542: x-microsoft-antispam-prvs: <VE1PR04MB654261E94C7A6B121070D792E6030@VE1PR04MB6542.eurprd04.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:1169; x-forefront-prvs: 03030B9493 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(376002)(396003)(346002)(136003)(199004)(189003)(6506007)(2906002)(26005)(186003)(44832011)(52536014)(110136005)(54906003)(76116006)(66476007)(316002)(86362001)(66946007)(66446008)(64756008)(66556008)(33656002)(9686003)(55016002)(4326008)(8936002)(71200400001)(7696005)(81156014)(8676002)(81166006)(478600001)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6542; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zsZW7H376sACqYOjn/hKugJ+P6XV4SE02EsBoTQd3u5Q/tA1nXy0j3j/Q7tm8IfdONG42F0k8CkpHKZWzImpwKGxEy/iH4JGcpqLeXHKAB9dbgZeRcwD83hxDKE1KVqKVuPv8eRz1DWqLJU8Pat40znmIrEoKl++KDibEIcokNa6MRsbYsSY6lTlScjPA7OHWt90OI1muGeBx6s/elMEl7bqOu/iiFDpZeSmyWgwZXYlZjKBCb6C6WDmYf9UNus+Xn8R09lTb/ahvCkRk8a52EHLdk3YE7l987/RPrvHsCX9MO034iXPY39kETh11SwvzKNh+xWjcp2cJjr1ZhWwZUOEVfxE2fyp5/98KBu0VrqHX5VtAdAQ//9IpR27dbFEnumf3I9P5WITCWT83d86w94MyZYTqG2muLe8664r+JIzvvwcLqjJPf++Ky4CXXHQ x-ms-exchange-antispam-messagedata: IEY4utsbl/NbCnzxoEnstHg8deRYuneqNtpfThXehyA2erlXbgR+3Qh8aEbWA1S8hX5E+SyqL0TMePpn8STnE7uTgIJNnlCblop0nJ2coEYE3mS22MGuXJyYxUfKdyydlFBzaVv6nhWm11G4SXFZUw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 024d77d9-d436-44a5-a2d7-08d7a9861c4e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2020 15:22:56.0902 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W4triKXzVlOn6opvA1YDuId0EXEPO8MuWb9Ca4is+kzdYPKvyLuhKTlZ/V8CsOQ9ic2RihLccwAHmdUaQeuGmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6542 Subject: Re: [dpdk-dev] [PATCH v5 0/6] integrate librte_ipsec SAD into ipsec-secgw X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> >=20 > Hi Akhil, >=20 > > > > > > This series integrates SA database (SAD) capabilities from ipsec libr= ary. > > > The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. > > > Also patch series removes hardcoded limitation for maximum number of > > > SA's and SP's. > > > According to our measurements, after this series of patches, > > > ipsec-secgw performance drops by about 0-2%. > > > > > > v5: > > > - introduce SAD cache to solve performance degradation > > > - ipsec_sad_add() returns an error if the key is present > > > > > > v4: > > > - put tunnel SA's into SAD with SPI_ONLY type for performance reason > > > > > > v3: > > > - parse SA and SP into sorted array instead of linked list > > > > > > v2: > > > - get rid of maximum sp limitation > > > > > > Vladimir Medvedkin (6): > > > ipsec: move ipsec sad name length into .h > > > examples/ipsec-secgw: implement inbound SAD > > > examples/ipsec-secgw: integrate inbound SAD > > > examples/ipsec-secgw: get rid of maximum sa limitation > > > examples/ipsec-secgw: get rid of maximum sp limitation > > > examples/ipsec-secgw: add SAD cache > > > > > > examples/ipsec-secgw/Makefile | 1 + > > > examples/ipsec-secgw/ipsec-secgw.c | 34 +++++- > > > examples/ipsec-secgw/ipsec.h | 12 +- > > > examples/ipsec-secgw/meson.build | 2 +- > > > examples/ipsec-secgw/parser.c | 4 + > > > examples/ipsec-secgw/parser.h | 9 ++ > > > examples/ipsec-secgw/sa.c | 238 +++++++++++++++++++++------= ----- > > ----- > > > examples/ipsec-secgw/sad.c | 149 +++++++++++++++++++++++ > > > examples/ipsec-secgw/sad.h | 168 ++++++++++++++++++++++++++ > > > examples/ipsec-secgw/sp4.c | 114 +++++++++++++----- > > > examples/ipsec-secgw/sp6.c | 112 ++++++++++++----- > > > lib/librte_ipsec/ipsec_sad.c | 20 ++-- > > > lib/librte_ipsec/rte_ipsec_sad.h | 2 + > > > 13 files changed, 686 insertions(+), 179 deletions(-) create mode > > > 100644 examples/ipsec-secgw/sad.c create mode 100644 > > > examples/ipsec-secgw/sad.h > > > > > > > Series > > Acked-by: Akhil Goyal <akhil.goyal@nxp.com> > > > > Hi Anoob, > > > > Do you have any comments on this set. I do not see degradation on this > > patchset now. >=20 > [Anoob] The perf degradation is negligible on our platform as well. I don= 't have > any issue with the patch set. >=20 > Series > Acked-by: Anoob Joseph <anoobj@marvell.com> Applied to dpdk-next-crypto Thanks.