Re: [dpdk-dev] [PATCH v3 2/8] cryptodev: add digest encrypted feature flag

[Akhil Goyal <akhil.goyal@nxp.com>]

> >
> > Some PMDs can only support digest being
> > encrypted separately in auth-cipher operations.
> > Thus it is required to add feature flag in PMD to reflect if it does support
> > digest-appended
> > both: digest generation with encryption and decryption with digest
> > verification.
> > This patch also adds information about new feature flag to the release
> > notes.
> >
> > Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
> 
> Looks good. Just one comment below:
> 
> > +++ b/doc/guides/rel_notes/release_19_08.rst
> > @@ -169,6 +169,9 @@ API Changes
> >    structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> >    ``rte_crypto_aead_xform``) have been changed to ``const uint8_t *data``.
> >
> > +* cryptodev: ``RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED`` feature flag
> > +  has been introduced.
> 
> I don't think you need to add anything here, as you are extending the feature
> flags,
> not changing any, so there is no API breakage.
> 
> Apart from this comment:
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Removed changes in the release notes, as suggested by Pablo.

Series Applied to dpdk-next-crypto

Thanks.