From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32570A0487 for ; Fri, 5 Jul 2019 09:10:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C70531B96B; Fri, 5 Jul 2019 09:10:57 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10072.outbound.protection.outlook.com [40.107.1.72]) by dpdk.org (Postfix) with ESMTP id 169CC1B965 for ; Fri, 5 Jul 2019 09:10:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p08fgbUdk2flE8ta4hI4Jx9OdbSM/fWQTgtcmAFN7HM=; b=kE3y8abiYyT35LSJmpO5EljSYhJTPtBBjKglTT4TtOZ7jeS6pcHx83GFxZ92s491rPFNyPk+Z1zlGn42/PAJf94sPpXvV0I55RUuqev6YdMGO9rFQh0zBPDcVN2AE2QlxY+JkAOZS7zgxDBUYnMSzhqaLItHbuYbjulGXi0ETgI= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6368.eurprd04.prod.outlook.com (10.255.118.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Fri, 5 Jul 2019 07:10:53 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.2052.010; Fri, 5 Jul 2019 07:10:53 +0000 From: Akhil Goyal To: "De Lara Guarch, Pablo" , "Nowak, DamianX" , "dev@dpdk.org" CC: "Trahe, Fiona" , "Kusztal, ArkadiuszX" , "Nowak, DamianX" Thread-Topic: [dpdk-dev] [PATCH v3 2/8] cryptodev: add digest encrypted feature flag Thread-Index: AQHVMbpZXEFzAyS0M0OExu6yZLwqiqa7ndYw Date: Fri, 5 Jul 2019 07:10:53 +0000 Message-ID: References: <20190607100608.16212-1-damianx.nowak@intel.com> <20190703111558.11552-1-damianx.nowak@intel.com> <20190703111558.11552-3-damianx.nowak@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 86435540-aa06-4449-007e-08d70117eb47 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6368; x-ms-traffictypediagnostic: VE1PR04MB6368: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 008960E8EC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(39860400002)(396003)(366004)(376002)(18543002)(189003)(199004)(305945005)(81156014)(81166006)(110136005)(54906003)(11346002)(74316002)(486006)(446003)(4326008)(6436002)(229853002)(25786009)(73956011)(2501003)(44832011)(316002)(66946007)(76116006)(8936002)(66476007)(64756008)(55016002)(7736002)(66556008)(86362001)(6246003)(14454004)(476003)(53936002)(9686003)(66446008)(66066001)(14444005)(71200400001)(71190400001)(52536014)(256004)(2906002)(478600001)(7696005)(5660300002)(68736007)(6506007)(186003)(76176011)(102836004)(6116002)(26005)(33656002)(3846002)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6368; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: JaWMCqwpvXuFU0PEIdIQFfS31VZXM2cyWCSO9QKd7Yx0OFq4Rm+FjvZVnOw3KloLxHIL8AcHrmwbcF2bK6ZyFAcfTL0FpX++YDwAtZ2GZKRbzKCNolsXb/7Vc6qNR1uTB7y+u4UHj7SuND0z24gnu8ZFCcb6GM+I4vcWxJVwOrUqOxQPiO/AofOAvQ3ovEMs5qGZhdgSkSPvHQQL5rEr6dLUR1PgfcoMtomyJNMrqiWcPGkIbtzlLj835ZLlmtEEeBIfjdekRvX63SSghwqqiWZDx+zvUNIqsOAeGK5pAURxGStFDxAPzarS35yqvlxLFg9rCaEc69s0gC3CtXBMg6tAyAvpCUHImP3rd7wj0Mb0fHnlGIy8r+88nqdlaP/wje5QWQi1C3T6lgddUFOdrhf1bRHIo1vqVLmGk2uSj0M= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86435540-aa06-4449-007e-08d70117eb47 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2019 07:10:53.8939 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6368 Subject: Re: [dpdk-dev] [PATCH v3 2/8] cryptodev: add digest encrypted feature flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > Some PMDs can only support digest being > > encrypted separately in auth-cipher operations. > > Thus it is required to add feature flag in PMD to reflect if it does su= pport > > digest-appended > > both: digest generation with encryption and decryption with digest > > verification. > > This patch also adds information about new feature flag to the release > > notes. > > > > Signed-off-by: Damian Nowak >=20 > Looks good. Just one comment below: >=20 > > +++ b/doc/guides/rel_notes/release_19_08.rst > > @@ -169,6 +169,9 @@ API Changes > > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, a= nd > > ``rte_crypto_aead_xform``) have been changed to ``const uint8_t *dat= a``. > > > > +* cryptodev: ``RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED`` feature flag > > + has been introduced. >=20 > I don't think you need to add anything here, as you are extending the fea= ture > flags, > not changing any, so there is no API breakage. >=20 > Apart from this comment: >=20 > Acked-by: Pablo de Lara Removed changes in the release notes, as suggested by Pablo. Series Applied to dpdk-next-crypto Thanks.