From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E336A058E; Thu, 26 Mar 2020 06:27:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49C4B1C028; Thu, 26 Mar 2020 06:27:34 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60063.outbound.protection.outlook.com [40.107.6.63]) by dpdk.org (Postfix) with ESMTP id 916621BFC3 for ; Thu, 26 Mar 2020 06:27:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dib6I7Mf5ifQL7RAKVvYHJjRIOdDYkcHIzsnh5MdrV52TUE7JiZjtIIKrtq8iPclgR7UYDCKwLMFgJC777vZQV6vqS1ohjacmBlJWlMye5pUNOpa3kLH+esMjplUnLDTxyHguyhReRSa7XsnRDCdOKEefNOe/xZx7Sp+33asKxwpq4GY8qaHyEsf7dJ0WToA8x1itKRhcvAmxAqET9RUP9QSAkcVTqmoVsKxzPSF4u7lDMKE9M7t7f8kiNPXRxbT0A92GSj01+wqptnRPjMr/Q+4G3g4p8QskufyaGbQlo/hB/HDt7nwcIJpz9lzQ6UYVvJcw0O5mjSF7VqtJTw21A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iQzecjoSVRE7xGSwn6txYK4vtA6AKQ36/67Etn3aGV4=; b=Rpetx39Ks8WAgg5suxwMMmS29ut+bs/1EM9WOz5HhJm70Wyxi38PA46Emu2kI29AwILh21W0HR8kNUJb3eYdxVEMMnNpvDl5rlaSu85tCQOQxMvi3ap4u7+AcClWNEDKAvaUG2FcZoGQszTXbnKS0Ylwkuypxx/c069iKfJoQYB9rTmUggBHTKdCeN2Q864XqaD1uMf61A2eUVJga4y8jZarCxUkiKsqHuNp0kcpggsqfVTL7weA1m2ZLxKew1fX7GaB/6VVqtU6sRD1HBHZULheSO9h1G8HPOSpM3dsdsPnvJOc1PDZiPHBPgK9klqS8IBRv4xH2/OQCAmvmWoozA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iQzecjoSVRE7xGSwn6txYK4vtA6AKQ36/67Etn3aGV4=; b=YdKr3YOkuWuxIvsvSnXEFtauUuIDXZ8PsWiRBJlA7eFoEHVuZVhpBIxYovKYll/ElbjhofLqG7/NVhX4Xk8LrwtFTb4XhpkDvZL2jkY3B/GYBjBr4Yi0BLiZL5LxVg67GUd30tLhfYzDThsDj2jZkPMUlqxCA97VgJxms7dE4hM= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6703.eurprd04.prod.outlook.com (10.255.118.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.18; Thu, 26 Mar 2020 05:27:31 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::8060:a35c:4858:c490]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::8060:a35c:4858:c490%7]) with mapi id 15.20.2835.023; Thu, 26 Mar 2020 05:27:31 +0000 From: Akhil Goyal To: "Chautru, Nicolas" , "thomas@monjalon.net" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC Thread-Index: AQHV8lZ1p2pW+1OVvESmAOKscJ4nBKhZhlBwgADO2gCAACPbAA== Date: Thu, 26 Mar 2020 05:27:30 +0000 Message-ID: References: <1582778348-113547-15-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-1-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-13-git-send-email-nicolas.chautru@intel.com> <1183128033837D43A851F70F33ED5C576EFD27B4@FMSMSX109.amr.corp.intel.com> In-Reply-To: <1183128033837D43A851F70F33ED5C576EFD27B4@FMSMSX109.amr.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [45.118.166.93] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 51d240bf-cd42-4c65-1326-08d7d14661b6 x-ms-traffictypediagnostic: VE1PR04MB6703: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0354B4BED2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(376002)(396003)(39850400004)(346002)(86362001)(66946007)(6506007)(55016002)(64756008)(66476007)(9686003)(8936002)(66446008)(66556008)(81166006)(8676002)(76116006)(7696005)(81156014)(5660300002)(186003)(2906002)(110136005)(4326008)(316002)(33656002)(478600001)(52536014)(71200400001)(26005)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6703; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UoBy1ZEubRWmRXj1i8svsSOBbbRJxPXu+uvVGEt+wL3wDg7ZW5AIM4t8GFnINLMhB4DgrO50KVm90V32R8wHYPns2OJBqedBB9y73S8EtLQTD++NQ98IWjC5/d+qS0VFWQNoTAIoZqtfMnaZLpLbYNe0HkrAnDxcewLFeF75DS8IxEJVx0HO4W/TRC6CtTeGKrGknXecHTmyh76b2OYG6e4XtlZs0mbhxCoeKS5cC1zyqoODuSPmX/ld+LsXg/b9CYi+E9/gnHRO3qD3MzddUC6Ju9c3V9twFHv8nC0c8OQrPWGEgZP4AhlslxndKmzWSrmHu50OHuzEYiAM3f+OAA5Z9lq5MzfArIwt/zv+chIDaBQpnSZDgehrHGEkwowdF8zKLVBs+YPdilkEOHt/GukFjqPfYUw1W+hQGGMhdbCKClhayZ0MwUHanSmtIUI7 x-ms-exchange-antispam-messagedata: /V2c94m4DtO2TDfuCiUbKY0dNRHBz1suGnGp0fjy5jQ88ahFIMnUnEMGJaxMg+7eIhEiUvw8LKTAbKASEFxKCf96MxBwDgSUPRw779zFjuoRtvNGb23QPd1v22lpWwMwgTAXUcIoupiQojIVnmNrnQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51d240bf-cd42-4c65-1326-08d7d14661b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2020 05:27:31.2423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4fhYMav2uRJ0qJ8qXNkOdFZyGYsGvWS5EMnQbFgOA3nlx36VZj4oZyM65r0aKzdo2U4xN7U0Gg63MgvNQyqVvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6703 Subject: Re: [dpdk-dev] [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > From: Akhil Goyal > >> > >> From: Nic Chautru > >> > >> Supports for FEC 5G PMD Driver on FPGA card PAC N3000 > >> > >> Signed-off-by: Nic Chautru > >> --- > > > >I cannot review this patch. This patch should be a separate series. > >This should be split into logical parts as a new PMD is submitted for re= view. > > >=20 > I will push this PMD in a new serie and keep existing serie for the rest. > Note that this new PMD has quite a lot of similarity with the fpga_lte_fe= c PMD, > no quite created incrementally from scratch. > Still I can create an after-the-fact split : one patchset with empty PMD = for build > purpose then a couple of patchsets for the ldpc processing operations and > configuration. > Would that be helpful and sufficient? Please split the patch as other new PMD are submitted. >=20 > > I can see that all the MACROS, enums, structures are defined in the .c = file > which Is not correct. Please move the relevant code in .h files and split= the > whole patch Along with documentation. >=20 > This is following the exact same structure as the existing fpga_lte_fec P= MD. Still > makes sense to change it as suggested. >=20 Yes, even the previous drivers should be updated. Header file code should b= e in header files.