From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8530DA0513; Wed, 15 Jan 2020 16:48:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 521CC1BFA3; Wed, 15 Jan 2020 16:48:41 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061.outbound.protection.outlook.com [40.107.22.61]) by dpdk.org (Postfix) with ESMTP id 3162B1BF99 for ; Wed, 15 Jan 2020 16:48:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UobNwC3xW/smcTcICFxuPxxLR31x5CFsh973gb0HI7V6TG+AnVkeX50DHe2YoYQEL1GbP6oqPl3MOGxOedKMrLp29z0zp8xS+ZSxF7I6/CyaygxMt5h4HZ7ZP/DMD3x6r3y0PMP558yUUs12fDiPUaILvqJGxCDR4W1FPUkZGijgib7AMAPXXE5XQFh9fcUKftr+QF973G7IgrHZQH8NNoK0aEaqj6DnLvRGqroM3/YUxTEBt0oIsAWXR8choc5w7N/0ADVTYx/Yaqd7tjIjD9+vWYc417c9VNpz2r/4atHcdRN5IO4Lxw6kFn2gtjNegIIPsyIEtqvwtLlKHmvozw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FLg3+7H5SjowPilYOLO1fppSJ/9vv3ysgvBrb8ItX6s=; b=ItolnIURf3eyBbp7CJJ2sbbATDzvsCfrNLLWDMWASZ8ApYUteekctkqL9X5w/iL8ka8xxoXJQ5a4geIf6R9BLCuGSERgT1h2V9zBLckuCPzJVZZZaz1ivkrzIJGqCZtGf6EROT0pQroV++23FA0Tm1Bv81wZu1rdWw/aBYJffOVs134v8aCETwZqwETxBc06sjP9RkR4iHTyDJQqKlJq7MWhMI1zCdbMNbUDW/YMvPaMnq3BOgCgnoGmq0E6K58DTgVuAYADhx8enmkBTGOcL42usN9oukNdM5TZNqWztSKKVcD1Sio1qy4ojsou1WmPN52comVkvZqCC/T9SXXypQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FLg3+7H5SjowPilYOLO1fppSJ/9vv3ysgvBrb8ItX6s=; b=h9CA0rojKfqLmOgnbDnNYK11xkBiYMPMsDqoT3ddNpJ6SetrwP/xJUhCO8C8ZzXiQgvhsLEoHcovhZ1txyOYSNy/nTzMCN1TzxwNhgePlqlmkxWtfZmIQgcbHLDyfGw96jSnhhD+ykVS9W07yUkv10ivF77gpbOiSdCPaT4P96U= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6591.eurprd04.prod.outlook.com (20.179.234.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.10; Wed, 15 Jan 2020 15:48:39 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1%7]) with mapi id 15.20.2644.015; Wed, 15 Jan 2020 15:48:39 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "fiona.trahe@intel.com" , "declan.doherty@intel.com" Thread-Topic: [PATCH v5 0/4] Add dual threading in QAT PMD Thread-Index: AQHVy7CXyQgZgzfmDUWgBeWR/GbQSqfr3wlA Date: Wed, 15 Jan 2020 15:48:39 +0000 Message-ID: References: <20200115143211.6176-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20200115143211.6176-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.66] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a206d6f2-02c2-4526-dd07-08d799d263e2 x-ms-traffictypediagnostic: VE1PR04MB6591: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 02830F0362 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(199004)(189003)(4326008)(86362001)(2906002)(5660300002)(8676002)(478600001)(81166006)(71200400001)(8936002)(9686003)(81156014)(55016002)(66476007)(66946007)(44832011)(76116006)(7696005)(66556008)(66446008)(26005)(64756008)(186003)(54906003)(6506007)(110136005)(33656002)(316002)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6591; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4M939G2FkJfnheOP4WgEQcbJ1IS3JolD0wuw/O6fG1FqPL+53j1O/Z+gl+PJjl6H7AKvqyW/3btHbNAxAk49Y2888wzJAq2jiQPbvyf6dx+vMzRae3vjqxnsr8uAGJV11yvGVqTOqaklDShc9Vq9yoFUg64fAS/aAYVgTvD/lh7ZbJIa1bCZECTTORGOR5tbRDV4eWyFSOjF2NsTJTOqEDSzEuCyi+penNttRRevFTZz6ppPojz5Z5DnTTFFKEnUpgmZOoPiZIHeqKaS3sirxJOOHR9JV1Fk6oJT+dsBq+14KRn49smMvS0hw5MgW9S1f5SHEuWHnQm4ocvKYTByMzdprOwtUcaDpz/zV8b8Ck0Mgdnz3lrzSsreqf0Wa3uV/llRiD7WpzN+om4GxZStXiaVZVU75J/pNrubhQMh68rdMERFdQ6WIkN7864eGhT0 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a206d6f2-02c2-4526-dd07-08d799d263e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2020 15:48:39.3169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0pV1zGebraeUvffNCQ+hm0+Nb9j+Sp3ov91JxboKZfRKoaBRw+rF2jj4cvjw5BqgTgA/upKoDpufSflxbl3SDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6591 Subject: Re: [dpdk-dev] [PATCH v5 0/4] Add dual threading in QAT PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Remove the limitation whereby enqueue and dequeue must be > done in same thread. > The inflight calculation is reworked to be thread-safe for 2 > threads - note this is not general multi-thread support, i.e > all enqueues to a qp must still be done in one thread and > all dequeues must be done in one thread, but enqueues and > dequeues may be in separate threads. > As the tail-coalescing feature is not > threadsafe it is removed first. > Additional option added is to set minumum enqueue burst > threshold which may help to reduce MMIO write occurances. >=20 > v5: > - sent all patches in one patchset > v4: > - fixed checkpatch issues in 4th patch > v3: > - added minimum threshold option > v2: > - clarified wording in docs >=20 > Arek Kusztal (1): > crypto/qat: add minimum enq threshold to qat pmd >=20 > Fiona Trahe (3): > common/qat: remove tail write coalescing feature > common/qat: move max inflights param into qp > common/qat: add dual thread support >=20 > doc/guides/compressdevs/qat_comp.rst | 5 +- > doc/guides/cryptodevs/qat.rst | 28 +++++++++- > drivers/common/qat/qat_common.c | 3 ++ > drivers/common/qat/qat_common.h | 3 ++ > drivers/common/qat/qat_device.c | 99 > +++++++++++++++++++++++++++++++----- > drivers/common/qat/qat_device.h | 22 ++++++-- > drivers/common/qat/qat_qp.c | 86 +++++++++++++++++-------------= - > drivers/common/qat/qat_qp.h | 14 +++-- > drivers/compress/qat/qat_comp_pmd.c | 14 ++++- > drivers/compress/qat/qat_comp_pmd.h | 4 +- > drivers/crypto/qat/qat_asym_pmd.c | 14 ++++- > drivers/crypto/qat/qat_asym_pmd.h | 4 +- > drivers/crypto/qat/qat_sym_pmd.c | 14 ++++- > drivers/crypto/qat/qat_sym_pmd.h | 4 +- > 14 files changed, 243 insertions(+), 71 deletions(-) >=20 Series Applied to dpdk-next-crypto Thanks