From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 190B6A046B for ; Wed, 26 Jun 2019 09:35:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90DED5B34; Wed, 26 Jun 2019 09:35:10 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60089.outbound.protection.outlook.com [40.107.6.89]) by dpdk.org (Postfix) with ESMTP id 8397A5B34 for ; Wed, 26 Jun 2019 09:35:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iWxH+ZhDoDj2sHbrfnv3M9yg8pkTAbhFlN4N9bVmr+4=; b=ZOgnAoE+d6G0laaaqql79hS06/Pugeto4c3KRK6d0l+//XSPBpJyxORZWYI1EristHSAKZHbJs7z0vMlYL/BA4YJw0Vwv2Fo43yCtrZHqa0mrK3XOuCocgbhpcGBs9eWUyM6jDUMmimdUF6Eudt1yMfju0aymPxhHwUE+hClMWY= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6382.eurprd04.prod.outlook.com (20.179.232.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Wed, 26 Jun 2019 07:35:08 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.2008.014; Wed, 26 Jun 2019 07:35:08 +0000 From: Akhil Goyal To: Konstantin Ananyev , "dev@dpdk.org" Thread-Topic: [PATCH] ipsec: packet with null encryption can cause a segfault Thread-Index: AQHVK4OSN9gVLvFzPEeXMY56Z4Log6atjCFg Date: Wed, 26 Jun 2019 07:35:08 +0000 Message-ID: References: <20190625182644.8401-1-konstantin.ananyev@intel.com> In-Reply-To: <20190625182644.8401-1-konstantin.ananyev@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dcbf770f-025e-4fd3-bdd5-08d6fa08d091 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6382; x-ms-traffictypediagnostic: VE1PR04MB6382: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:608; x-forefront-prvs: 00808B16F3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(136003)(346002)(39860400002)(396003)(199004)(189003)(81166006)(14454004)(6246003)(74316002)(33656002)(229853002)(4744005)(256004)(7736002)(6436002)(53936002)(52536014)(7696005)(2501003)(66556008)(66446008)(8676002)(8936002)(64756008)(110136005)(66476007)(81156014)(76116006)(99286004)(66946007)(73956011)(76176011)(6506007)(186003)(5660300002)(476003)(66066001)(102836004)(26005)(305945005)(316002)(9686003)(55016002)(11346002)(446003)(71190400001)(71200400001)(2906002)(3846002)(478600001)(6116002)(86362001)(68736007)(486006)(25786009)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6382; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: T3JnCWg51b1pF7w3eIgDMVo4VB9fC/9wMKHjklK7kz8vCiSqzma2Av5jM+UtsgIeZzdQak2YHvSd/5CqmZnJ7Svu54GKX0ZR7QOaZxMFUvcvXK+CGLj8Wa/59wbjAFFBCUKN/77YVBA0iWges46tsDP8t1/H/fjhI0El1aaIstKQWBgWeTbxNbVNBEapiyE1SHdMxl3oWHHOSGMGlUqN1/JPvgAhDwszEi7Znc7wTPYnxt/WVR84O0xg+XEYbwvuo/Hk7+5TZCOoLS7GZVm1LFod5XHJLF/YNkmGuulWwXu/S+bTjQ+MZDLbeeM7zdZFqtiB96zqsJIV2HcfS2bKMdwNRFXB7Rdw9Jhvi1wVCnlT7vXb9TeZDFgPIgFb2x+pxukPbO3FgnCGzvGXE2Bd+eI8l9dpOG5nZrews4NuXGM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcbf770f-025e-4fd3-bdd5-08d6fa08d091 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2019 07:35:08.3849 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6382 Subject: Re: [dpdk-dev] [PATCH] ipsec: packet with null encryption can cause a segfault X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > mbuf_get_seg_ofs() doesn't handle the case when requested offset > equals to packet length. Though it is a valid situation for > algorithms with no ICV data (IPsec with null encryption as an example). >=20 > Fixes: 12a0423236a9 ("ipsec: support multi-segment packets") >=20 > Signed-off-by: Konstantin Ananyev > --- Applied. Squashed with the original commit. Thanks.