* Re: [dpdk-dev] [PATCH v1 0/2] add tests for RSA key type CRT
@ 2019-07-16 12:04 Shally Verma
2019-07-18 15:35 ` Akhil Goyal
0 siblings, 1 reply; 5+ messages in thread
From: Shally Verma @ 2019-07-16 12:04 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, Ayuj Verma, akhil.goyal
Cc: Anoob Joseph, Trahe, Fiona, Sunila Sahu, dev,
Kanaka Durga Kotamarthy, Zhang, Roy Fan
Sent from Workspace ONE Boxer
On 12-Jul-2019 6:45 PM, "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com> wrote:
>
> In future we could unify tests even more (i.e. passing padding type as a param, or even information if it is encryption or signature generation) like Fan once done with blockcipher.
>
> > -----Original Message-----
> > From: Ayuj Verma [mailto:ayverma@marvell.com]
> > Sent: Thursday, July 11, 2019 3:23 PM
> > To: akhil.goyal@nxp.com
> > Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Trahe, Fiona
> > <fiona.trahe@intel.com>; shallyv@marvell.com; ssahu@marvell.com;
> > kkotamarthy@marvell.com; anoobj@marvell.com; dev@dpdk.org; Ayuj
> > Verma <ayverma@marvell.com>
> > Subject: [PATCH v1 0/2] add tests for RSA key type CRT
> >
> > This patch series add new RSA CRT key based test cases, improve code
> > organization and also rebase it to latest changes.
> > It covers following changes:
> >
> > * Add crt key based rsa sign/verify, enc/decrypt test cases
> > * Move common code of enqueue/dequeue into separate function
> > * Configure device with ff_disable set
> >
> > Ayuj Verma (2):
> > test/crypto: move rsa enqueue/dequeue into separate functions
> > test/crypto: add tests for RSA key type CRT
> >
> > app/test/test_cryptodev_asym.c | 460 +++++++++++++++++------------
> > app/test/test_cryptodev_rsa_test_vectors.h | 93 ++++++
> > 2 files changed, 363 insertions(+), 190 deletions(-)
> >
> > --
> > 1.8.3.1
>
> Series-acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>
Series-acked-by: Shally Verma <shallyv@marvell.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v1 0/2] add tests for RSA key type CRT
2019-07-16 12:04 [dpdk-dev] [PATCH v1 0/2] add tests for RSA key type CRT Shally Verma
@ 2019-07-18 15:35 ` Akhil Goyal
0 siblings, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2019-07-18 15:35 UTC (permalink / raw)
To: Shally Verma, Kusztal, ArkadiuszX, Ayuj Verma
Cc: Anoob Joseph, Trahe, Fiona, Sunila Sahu, dev,
Kanaka Durga Kotamarthy, Zhang, Roy Fan
Sent from Workspace ONE Boxer
On 12-Jul-2019 6:45 PM, "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com<mailto:arkadiuszx.kusztal@intel.com>> wrote:
>
> In future we could unify tests even more (i.e. passing padding type as a param, or even information if it is encryption or signature generation) like Fan once done with blockcipher.
>
> > -----Original Message-----
> > From: Ayuj Verma [mailto:ayverma@marvell.com]
> > Sent: Thursday, July 11, 2019 3:23 PM
> > To: akhil.goyal@nxp.com<mailto:akhil.goyal@nxp.com>
> > Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com<mailto:arkadiuszx.kusztal@intel.com>>; Trahe, Fiona
> > <fiona.trahe@intel.com<mailto:fiona.trahe@intel.com>>; shallyv@marvell.com<mailto:shallyv@marvell.com>; ssahu@marvell.com<mailto:ssahu@marvell.com>;
> > kkotamarthy@marvell.com<mailto:kkotamarthy@marvell.com>; anoobj@marvell.com<mailto:anoobj@marvell.com>; dev@dpdk.org<mailto:dev@dpdk.org>; Ayuj
> > Verma <ayverma@marvell.com<mailto:ayverma@marvell.com>>
> > Subject: [PATCH v1 0/2] add tests for RSA key type CRT
> >
> > This patch series add new RSA CRT key based test cases, improve code
> > organization and also rebase it to latest changes.
> > It covers following changes:
> >
> > * Add crt key based rsa sign/verify, enc/decrypt test cases
> > * Move common code of enqueue/dequeue into separate function
> > * Configure device with ff_disable set
> >
> > Ayuj Verma (2):
> > test/crypto: move rsa enqueue/dequeue into separate functions
> > test/crypto: add tests for RSA key type CRT
> >
> > app/test/test_cryptodev_asym.c | 460 +++++++++++++++++------------
> > app/test/test_cryptodev_rsa_test_vectors.h | 93 ++++++
> > 2 files changed, 363 insertions(+), 190 deletions(-)
> >
> > --
> > 1.8.3.1
>
> Series-acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com<mailto:arkadiuszx.kusztal@intel.com>>
>
Series-acked-by: Shally Verma <shallyv@marvell.com<mailto:shallyv@marvell.com>>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v1 0/2] add tests for RSA key type CRT
@ 2019-07-15 10:05 Shally Verma
0 siblings, 0 replies; 5+ messages in thread
From: Shally Verma @ 2019-07-15 10:05 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, Ayuj Verma, akhil.goyal
Cc: Anoob Joseph, Trahe, Fiona, Sunila Sahu, dev,
Kanaka Durga Kotamarthy, Zhang, Roy Fan
Thanks Arek. Response inline.
Sent from Workspace ONE Boxer
On 12-Jul-2019 6:45 PM, "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com> wrote:
>
> In future we could unify tests even more (i.e. passing padding type as a param, or even information if it is encryption or signature generation) like Fan once done with blockcipher.
I will take a look at that but isn't test suite preferable otherwise? Means keeping it less interactive in nature? Else command line args will be different combinations of padding type, modulus length, crt/non-crt, op type ..is it okay to make it this way?
Thanks
Shally
>
> > -----Original Message-----
> > From: Ayuj Verma [mailto:ayverma@marvell.com]
> > Sent: Thursday, July 11, 2019 3:23 PM
> > To: akhil.goyal@nxp.com
> > Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Trahe, Fiona
> > <fiona.trahe@intel.com>; shallyv@marvell.com; ssahu@marvell.com;
> > kkotamarthy@marvell.com; anoobj@marvell.com; dev@dpdk.org; Ayuj
> > Verma <ayverma@marvell.com>
> > Subject: [PATCH v1 0/2] add tests for RSA key type CRT
> >
> > This patch series add new RSA CRT key based test cases, improve code
> > organization and also rebase it to latest changes.
> > It covers following changes:
> >
> > * Add crt key based rsa sign/verify, enc/decrypt test cases
> > * Move common code of enqueue/dequeue into separate function
> > * Configure device with ff_disable set
> >
> > Ayuj Verma (2):
> > test/crypto: move rsa enqueue/dequeue into separate functions
> > test/crypto: add tests for RSA key type CRT
> >
> > app/test/test_cryptodev_asym.c | 460 +++++++++++++++++------------
> > app/test/test_cryptodev_rsa_test_vectors.h | 93 ++++++
> > 2 files changed, 363 insertions(+), 190 deletions(-)
> >
> > --
> > 1.8.3.1
>
> Series-acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v1 0/2] add tests for RSA key type CRT
2019-07-11 13:22 Ayuj Verma
@ 2019-07-12 13:15 ` Kusztal, ArkadiuszX
0 siblings, 0 replies; 5+ messages in thread
From: Kusztal, ArkadiuszX @ 2019-07-12 13:15 UTC (permalink / raw)
To: Ayuj Verma, akhil.goyal
Cc: Trahe, Fiona, shallyv, ssahu, kkotamarthy, anoobj, dev, Zhang, Roy Fan
In future we could unify tests even more (i.e. passing padding type as a param, or even information if it is encryption or signature generation) like Fan once done with blockcipher.
> -----Original Message-----
> From: Ayuj Verma [mailto:ayverma@marvell.com]
> Sent: Thursday, July 11, 2019 3:23 PM
> To: akhil.goyal@nxp.com
> Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; shallyv@marvell.com; ssahu@marvell.com;
> kkotamarthy@marvell.com; anoobj@marvell.com; dev@dpdk.org; Ayuj
> Verma <ayverma@marvell.com>
> Subject: [PATCH v1 0/2] add tests for RSA key type CRT
>
> This patch series add new RSA CRT key based test cases, improve code
> organization and also rebase it to latest changes.
> It covers following changes:
>
> * Add crt key based rsa sign/verify, enc/decrypt test cases
> * Move common code of enqueue/dequeue into separate function
> * Configure device with ff_disable set
>
> Ayuj Verma (2):
> test/crypto: move rsa enqueue/dequeue into separate functions
> test/crypto: add tests for RSA key type CRT
>
> app/test/test_cryptodev_asym.c | 460 +++++++++++++++++------------
> app/test/test_cryptodev_rsa_test_vectors.h | 93 ++++++
> 2 files changed, 363 insertions(+), 190 deletions(-)
>
> --
> 1.8.3.1
Series-acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v1 0/2] add tests for RSA key type CRT
@ 2019-07-11 13:22 Ayuj Verma
2019-07-12 13:15 ` Kusztal, ArkadiuszX
0 siblings, 1 reply; 5+ messages in thread
From: Ayuj Verma @ 2019-07-11 13:22 UTC (permalink / raw)
To: akhil.goyal
Cc: arkadiuszx.kusztal, fiona.trahe, shallyv, ssahu, kkotamarthy,
anoobj, dev, Ayuj Verma
This patch series add new RSA CRT key based test cases,
improve code organization and also rebase it to latest changes.
It covers following changes:
* Add crt key based rsa sign/verify, enc/decrypt test cases
* Move common code of enqueue/dequeue into separate function
* Configure device with ff_disable set
Ayuj Verma (2):
test/crypto: move rsa enqueue/dequeue into separate functions
test/crypto: add tests for RSA key type CRT
app/test/test_cryptodev_asym.c | 460 +++++++++++++++++------------
app/test/test_cryptodev_rsa_test_vectors.h | 93 ++++++
2 files changed, 363 insertions(+), 190 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-18 15:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 12:04 [dpdk-dev] [PATCH v1 0/2] add tests for RSA key type CRT Shally Verma
2019-07-18 15:35 ` Akhil Goyal
-- strict thread matches above, loose matches on Subject: below --
2019-07-15 10:05 Shally Verma
2019-07-11 13:22 Ayuj Verma
2019-07-12 13:15 ` Kusztal, ArkadiuszX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).